| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b5013bc3-16b6-de69-d89f-f8102e1e2f02 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DC66:139A69:12E3E6B:1A3EEF5:696A91F9 |
| html-safe-nonce | dc6dfadb21334376ad0118f507f94aa7bdc047a19b3f14134778224a7b58360b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzY2OjEzOUE2OToxMkUzRTZCOjFBM0VFRjU6Njk2QTkxRjkiLCJ2aXNpdG9yX2lkIjoiNDY0NTQzMTQzMjIxMTc2MzcwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 5dc76ab6823b175f70d8136f85664566884a586e7d53d45de58f6de1b8430c53 |
| hovercard-subject-tag | pull_request:809128949 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/41299/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e34b224407467c68c1ea19247deb39695ddb21ab9be3364df4ac9761b6411c79/nodejs/node/pull/41299 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e34b224407467c68c1ea19247deb39695ddb21ab9be3364df4ac9761b6411c79/nodejs/node/pull/41299 |
| og:image:alt | Refs: #33864 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | aduh95 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 31496a13b80a2f6ad77d6c617ee2255a3545b539 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/41299#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41299 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41299 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/41299 |
| Reload | https://github.com/nodejs/node/pull/41299 |
| Reload | https://github.com/nodejs/node/pull/41299 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/41299 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/41299 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/41299#issue-comment-box |
| aduh95 | https://github.com/aduh95 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| aduh95:pr-guide-main | https://github.com/aduh95/node/tree/pr-guide-main |
|
doc: make pull-request guide default branch agnostic
| https://github.com/nodejs/node/pull/41299#top |
| aduh95 | https://github.com/aduh95 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| aduh95:pr-guide-main | https://github.com/aduh95/node/tree/pr-guide-main |
|
Conversation
11
| https://github.com/nodejs/node/pull/41299 |
|
Commits
3
| https://github.com/nodejs/node/pull/41299/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/41299/checks |
|
Files changed
| https://github.com/nodejs/node/pull/41299/files |
| Please reload this page | https://github.com/nodejs/node/pull/41299 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Dec 23, 2021 | https://github.com/nodejs/node/pull/41299#issue-1087675667 |
| #33864 | https://github.com/nodejs/node/issues/33864 |
| Please reload this page | https://github.com/nodejs/node/pull/41299 |
|
| https://github.com/aduh95 |
| doc: make pull-request guide default branch agnostic | https://github.com/nodejs/node/pull/41299/commits/a674c6f65fc83b1806fb9bea22da924e262ffce7 |
| a674c6f | https://github.com/nodejs/node/pull/41299/commits/a674c6f65fc83b1806fb9bea22da924e262ffce7 |
| nodejs#33864 | https://github.com/nodejs/node/issues/33864 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 23, 2021 | https://github.com/nodejs/node/pull/41299#issuecomment-1000273364 |
| Please reload this page | https://github.com/nodejs/node/pull/41299 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Dec 23, 2021 | https://github.com/nodejs/node/pull/41299#event-5809698665 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Dec 23, 2021
| https://github.com/nodejs/node/pull/41299#pullrequestreview-839548380 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/41299/files/a674c6f65fc83b1806fb9bea22da924e262ffce7 |
| doc/guides/contributing/pull-requests.md | https://github.com/nodejs/node/pull/41299/files/a674c6f65fc83b1806fb9bea22da924e262ffce7#diff-b989d7ccc0bd9a756a048f0255df3bd9444a63f8cb667e4b7b2a9575da1800a0 |
| Trott | https://github.com/Trott |
| Dec 23, 2021 | https://github.com/nodejs/node/pull/41299#discussion_r774720339 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://user-images.githubusercontent.com/718899/147277809-34491eed-74a6-4ec6-ba50-d6912470bc1b.png |
| Please reload this page | https://github.com/nodejs/node/pull/41299 |
| aduh95 | https://github.com/aduh95 |
| Dec 23, 2021 | https://github.com/nodejs/node/pull/41299#discussion_r774736286 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/41299 |
| Trott | https://github.com/Trott |
| Dec 23, 2021 | https://github.com/nodejs/node/pull/41299#discussion_r774810201 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/41299 |
| aduh95 | https://github.com/aduh95 |
| Dec 25, 2021 | https://github.com/nodejs/node/pull/41299#discussion_r775092063 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/41299 |
| Trott | https://github.com/Trott |
| Dec 25, 2021 | https://github.com/nodejs/node/pull/41299#discussion_r775094893 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/41299 |
| Trott | https://github.com/Trott |
| Dec 25, 2021 | https://github.com/nodejs/node/pull/41299#discussion_r775094969 |
| Please reload this page | https://github.com/nodejs/node/pull/41299 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/41299 |
| aduh95 | https://github.com/aduh95 |
| Dec 25, 2021 | https://github.com/nodejs/node/pull/41299#discussion_r775125916 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/41299 |
| Trott | https://github.com/Trott |
| Dec 25, 2021 | https://github.com/nodejs/node/pull/41299#discussion_r775148400 |
| Please reload this page | https://github.com/nodejs/node/pull/41299 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/github/linguist | https://github.com/github/linguist |
| https://github.com/github/linguist/blob/master/lib/linguist/languages.yml | https://github.com/github/linguist/blob/master/lib/linguist/languages.yml |
| They say they use Linguist for detection | https://docs.github.com/en/github/writing-on-github/working-with-advanced-formatting/creating-and-highlighting-code-blocks#syntax-highlighting |
| Please reload this page | https://github.com/nodejs/node/pull/41299 |
|
| https://github.com/aduh95 |
| Use text instead of sh | https://github.com/nodejs/node/pull/41299/commits/adb7ed361cd5339652cf03bab9b207978845ed9f |
| adb7ed3 | https://github.com/nodejs/node/pull/41299/commits/adb7ed361cd5339652cf03bab9b207978845ed9f |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Dec 26, 2021
| https://github.com/nodejs/node/pull/41299#pullrequestreview-840110585 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/41299/files/adb7ed361cd5339652cf03bab9b207978845ed9f |
| doc/guides/contributing/pull-requests.md | https://github.com/nodejs/node/pull/41299/files/adb7ed361cd5339652cf03bab9b207978845ed9f#diff-b989d7ccc0bd9a756a048f0255df3bd9444a63f8cb667e4b7b2a9575da1800a0 |
| Please reload this page | https://github.com/nodejs/node/pull/41299 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Dec 26, 2021
| https://github.com/nodejs/node/pull/41299#pullrequestreview-840110592 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/41299/files/adb7ed361cd5339652cf03bab9b207978845ed9f |
|
| https://github.com/aduh95 |
|
| https://github.com/Trott |
| Update doc/guides/contributing/pull-requests.md | https://github.com/nodejs/node/pull/41299/commits/bace3a8a90a3d25ca969eaef4113025c3225c9af |
| bace3a8 | https://github.com/nodejs/node/pull/41299/commits/bace3a8a90a3d25ca969eaef4113025c3225c9af |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
commit-queue-squash
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash |
| Dec 26, 2021 | https://github.com/nodejs/node/pull/41299#event-5815919376 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| c5ac0c6 | https://github.com/nodejs/node/commit/c5ac0c67d92727bc76c226ff47d5d9050dfbfedb |
| Dec 31, 2021 | https://github.com/nodejs/node/pull/41299#event-5829376440 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| December 31, 2021 00:07 | https://github.com/nodejs/node/pull/41299#event-5829376538 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Dec 31, 2021 | https://github.com/nodejs/node/pull/41299#issuecomment-1003218176 |
| c5ac0c6 | https://github.com/nodejs/node/commit/c5ac0c67d92727bc76c226ff47d5d9050dfbfedb |
| Please reload this page | https://github.com/nodejs/node/pull/41299 |
| targos | https://github.com/targos |
|
Jan 14, 2022
| https://github.com/nodejs/node/pull/41299#ref-commit-ffe17a8 |
|
| https://github.com/aduh95 |
|
| https://github.com/targos |
| doc: make pull-request guide default branch agnostic | https://github.com/nodejs/node/commit/ffe17a84f2df26fb33a5705b37aac7e8e9ab355b |
| ffe17a8 | https://github.com/nodejs/node/commit/ffe17a84f2df26fb33a5705b37aac7e8e9ab355b |
| #33864 | https://github.com/nodejs/node/issues/33864 |
| #41299 | https://github.com/nodejs/node/pull/41299 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jan 16, 2022
| https://github.com/nodejs/node/pull/41299#ref-pullrequest-1105064450 |
|
v17.4.0 release proposal
#41557
| https://github.com/nodejs/node/pull/41557 |
| danielleadams | https://github.com/danielleadams |
|
Jan 31, 2022
| https://github.com/nodejs/node/pull/41299#ref-commit-0208568 |
|
| https://github.com/aduh95 |
|
| https://github.com/danielleadams |
| doc: make pull-request guide default branch agnostic | https://github.com/nodejs/node/commit/0208568136b9ba4fff0026d54e3f851e6a1676d0 |
| 0208568 | https://github.com/nodejs/node/commit/0208568136b9ba4fff0026d54e3f851e6a1676d0 |
| #33864 | https://github.com/nodejs/node/issues/33864 |
| #41299 | https://github.com/nodejs/node/pull/41299 |
| Linkgoron | https://github.com/Linkgoron |
|
Jan 31, 2022
| https://github.com/nodejs/node/pull/41299#ref-commit-3f61465 |
|
| https://github.com/aduh95 |
|
| https://github.com/Linkgoron |
| doc: make pull-request guide default branch agnostic | https://github.com/Linkgoron/node/commit/3f61465df2f6cd9e7a71b6a6629875d1e0124177 |
| 3f61465 | https://github.com/Linkgoron/node/commit/3f61465df2f6cd9e7a71b6a6629875d1e0124177 |
| nodejs#33864 | https://github.com/nodejs/node/issues/33864 |
| nodejs#41299 | https://github.com/nodejs/node/pull/41299 |
| danielleadams | https://github.com/danielleadams |
|
Feb 1, 2022
| https://github.com/nodejs/node/pull/41299#ref-commit-46c38eb |
|
| https://github.com/aduh95 |
|
| https://github.com/danielleadams |
| doc: make pull-request guide default branch agnostic | https://github.com/nodejs/node/commit/46c38eb5fc774d27c654b57d9a527dddcb3616b6 |
| 46c38eb | https://github.com/nodejs/node/commit/46c38eb5fc774d27c654b57d9a527dddcb3616b6 |
| #33864 | https://github.com/nodejs/node/issues/33864 |
| #41299 | https://github.com/nodejs/node/pull/41299 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
Feb 1, 2022
| https://github.com/nodejs/node/pull/41299#ref-pullrequest-1120258873 |
|
v16.14.0 proposal
#41804
| https://github.com/nodejs/node/pull/41804 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41299 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/41299/files/adb7ed361cd5339652cf03bab9b207978845ed9f |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
commit-queue-squash
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Please reload this page | https://github.com/nodejs/node/pull/41299 |
|
| https://github.com/aduh95 |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |