René's URL Explorer Experiment


Title: stream: manual destroy ServerResponse on pipeline by RafaelGSS · Pull Request #41137 · nodejs/node · GitHub

Open Graph Title: stream: manual destroy ServerResponse on pipeline by RafaelGSS · Pull Request #41137 · nodejs/node

X Title: stream: manual destroy ServerResponse on pipeline by RafaelGSS · Pull Request #41137 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Change the behavior to not destroy the ServerResponse stream on stream.pipeline when an error happens. Address: #26311 I feel that #38262 was a similar issue that was solved differently, however, ...

X Description: Change the behavior to not destroy the ServerResponse stream on stream.pipeline when an error happens. Address: #26311 I feel that #38262 was a similar issue that was solved differently, however, ...

Opengraph URL: https://github.com/nodejs/node/pull/41137

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a66594fe-0b87-4f59-7fcd-f776faa8485b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE2BA:2568D:129822D:18C08A6:6AED5C26
html-safe-nonce9fc5fc5d12f1293e4365fbf2cbd540c5bcf9fb9bc7bd7a202f78208719e4f0bb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMkJBOjI1NjhEOjEyOTgyMkQ6MThDMDhBNjo2QUVENUMyNiIsInZpc2l0b3JfaWQiOiI5MDE0MDY4MzU2NjQ1MjE1MjcxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3c693350eb7b51d2cb7dce380513a35c5cee365f60463b552399392905b086ad
hovercard-subject-tagpull_request:800070141
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/41137/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/efecd19daaa00f0d511f787f2bc94129eac22c91352469efa792d756e851eed9/nodejs/node/pull/41137
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/efecd19daaa00f0d511f787f2bc94129eac22c91352469efa792d756e851eed9/nodejs/node/pull/41137
og:image:altChange the behavior to not destroy the ServerResponse stream on stream.pipeline when an error happens. Address: #26311 I feel that #38262 was a similar issue that was solved differently, however, ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameRafaelGSS
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/41137#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41137
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41137
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/41137
Reloadhttps://github.com/nodejs/node/pull/41137
Reloadhttps://github.com/nodejs/node/pull/41137
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests662 (662)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
RafaelGSShttps://github.com/RafaelGSS
nodejs:masterhttps://github.com/nodejs/node/tree/master
RafaelGSS:fix/pipeline-incoming-request-destroyhttps://github.com/RafaelGSS/node/tree/fix/pipeline-incoming-request-destroy
Conversationhttps://github.com/nodejs/node/pull/41137
Commits1 (1)https://github.com/nodejs/node/pull/41137/commits
Checkshttps://github.com/nodejs/node/pull/41137/checks
Files changedhttps://github.com/nodejs/node/pull/41137/files
stream: manual destroy ServerResponse on pipelinehttps://github.com/nodejs/node/pull/41137#top
RafaelGSShttps://github.com/RafaelGSS
nodejs:masterhttps://github.com/nodejs/node/tree/master
RafaelGSS:fix/pipeline-incoming-request-destroyhttps://github.com/RafaelGSS/node/tree/fix/pipeline-incoming-request-destroy
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Dec 10, 2021https://github.com/nodejs/node/pull/41137#issue-1077026459
Please reload this pagehttps://github.com/nodejs/node/pull/41137
#26311https://github.com/nodejs/node/issues/26311
#38262https://github.com/nodejs/node/issues/38262
Please reload this pagehttps://github.com/nodejs/node/pull/41137
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Dec 10, 2021https://github.com/nodejs/node/pull/41137#event-5748872124
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
force-pushedhttps://github.com/nodejs/node/compare/6ef08bd40dbe56f0ef174846d064efd16a03958c..e13d9eff255e5b599c328dc1453255fad49fd122
6ef08bdhttps://github.com/nodejs/node/commit/6ef08bd40dbe56f0ef174846d064efd16a03958c
e13d9efhttps://github.com/nodejs/node/commit/e13d9eff255e5b599c328dc1453255fad49fd122
Compare https://github.com/nodejs/node/compare/6ef08bd40dbe56f0ef174846d064efd16a03958c..e13d9eff255e5b599c328dc1453255fad49fd122
December 10, 2021 16:35https://github.com/nodejs/node/pull/41137#event-5748881714
https://github.com/RafaelGSS
stream: manual destroy IncomingRequest on pipelinehttps://github.com/nodejs/node/pull/41137/commits/0a819b92fbd34bf93cf428809f232040e5b3ae52
0a819b9https://github.com/nodejs/node/pull/41137/commits/0a819b92fbd34bf93cf428809f232040e5b3ae52
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
force-pushedhttps://github.com/nodejs/node/compare/e13d9eff255e5b599c328dc1453255fad49fd122..0a819b92fbd34bf93cf428809f232040e5b3ae52
e13d9efhttps://github.com/nodejs/node/commit/e13d9eff255e5b599c328dc1453255fad49fd122
0a819b9https://github.com/nodejs/node/commit/0a819b92fbd34bf93cf428809f232040e5b3ae52
Compare https://github.com/nodejs/node/compare/e13d9eff255e5b599c328dc1453255fad49fd122..0a819b92fbd34bf93cf428809f232040e5b3ae52
December 10, 2021 17:55https://github.com/nodejs/node/pull/41137#event-5749298157
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 10, 2021https://github.com/nodejs/node/pull/41137#issuecomment-991254009
Please reload this pagehttps://github.com/nodejs/node/pull/41137
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 10, 2021https://github.com/nodejs/node/pull/41137#issuecomment-991254467
#26311https://github.com/nodejs/node/issues/26311
Please reload this pagehttps://github.com/nodejs/node/pull/41137
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 10, 2021https://github.com/nodejs/node/pull/41137#issuecomment-991256039
Please reload this pagehttps://github.com/nodejs/node/pull/41137
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Dec 10, 2021https://github.com/nodejs/node/pull/41137#issuecomment-991261484
#34133https://github.com/nodejs/node/pull/34133
Please reload this pagehttps://github.com/nodejs/node/pull/41137
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Dec 10, 2021https://github.com/nodejs/node/pull/41137#event-5749881897
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 10, 2021 https://github.com/nodejs/node/pull/41137#pullrequestreview-829286431
View reviewed changes https://github.com/nodejs/node/pull/41137/files/0a819b92fbd34bf93cf428809f232040e5b3ae52
ronaghttps://github.com/ronag
https://github.com/nodejs/node/pull/41137#pullrequestreview-829286431
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/41137
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Dec 10, 2021https://github.com/nodejs/node/pull/41137#issuecomment-991270472
@ronaghttps://github.com/ronag
#34133https://github.com/nodejs/node/pull/34133
Please reload this pagehttps://github.com/nodejs/node/pull/41137
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Dec 10, 2021https://github.com/nodejs/node/pull/41137#issuecomment-991271644
Please reload this pagehttps://github.com/nodejs/node/pull/41137
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Jan 31, 2022https://github.com/nodejs/node/pull/41137#issuecomment-1025690392
Please reload this pagehttps://github.com/nodejs/node/pull/41137
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/41137
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 31, 2022https://github.com/nodejs/node/pull/41137#issuecomment-1025697924
Please reload this pagehttps://github.com/nodejs/node/pull/41137
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Jan 31, 2022 https://github.com/nodejs/node/pull/41137#ref-pullrequest-1119845913
doc: add steam pipelining note on Http usage #41796 https://github.com/nodejs/node/pull/41796
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Jan 31, 2022https://github.com/nodejs/node/pull/41137#issuecomment-1026130981
#41796https://github.com/nodejs/node/pull/41796
Please reload this pagehttps://github.com/nodejs/node/pull/41137
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Jan 31, 2022https://github.com/nodejs/node/pull/41137#event-5983361790
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41137
https://github.com/ronag
ronag https://github.com/ronag
https://github.com/nodejs/node/pull/41137/files/0a819b92fbd34bf93cf428809f232040e5b3ae52
Please reload this pagehttps://github.com/nodejs/node/pull/41137
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/41137
https://github.com/RafaelGSS
https://github.com/ronag
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.