| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d3bb622c-dcce-7a67-e407-b32173dbe737 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CA5A:531C6:4B3535:6A7BCC:696A0C97 |
| html-safe-nonce | 9cd594355419fcda9c77f41fa9d413aa802e6dc0c297c6cfcf93fae6db9ac0ef |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTVBOjUzMUM2OjRCMzUzNTo2QTdCQ0M6Njk2QTBDOTciLCJ2aXNpdG9yX2lkIjoiODYyMTY1MTYyNTg3NDQyNzAzMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7a62de94787a9259a79fddfc666d4bea0df10b6bc41d4e33f643331403c21871 |
| hovercard-subject-tag | pull_request:790611932 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/41014/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ed75e9bfaae0ff5e92c8836417a0c585c9206c72ba855813b43bdb088536bb58/nodejs/node/pull/41014 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ed75e9bfaae0ff5e92c8836417a0c585c9206c72ba855813b43bdb088536bb58/nodejs/node/pull/41014 |
| og:image:alt | The socket property of the IncomingMessage object is nulled on the
server after calling message.destroy() and on the client after a
request completes and the socket is kept alive.
Fixes: #41011 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | lpinca |
| hostname | github.com |
| expected-hostname | github.com |
| None | 699227a00bbb7fe1eec276d2ae1c3a93068bc5ba483bd9dc4b2a27a8f4f2f595 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7266b2d935baa1c6474b16dd9feaa5ca30607261 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/41014#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41014 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41014 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/41014 |
| Reload | https://github.com/nodejs/node/pull/41014 |
| Reload | https://github.com/nodejs/node/pull/41014 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/41014 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/41014 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/41014#issue-comment-box |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| lpinca:fix/issue-41011 | https://github.com/lpinca/node/tree/fix/issue-41011 |
|
doc: specify that message.socket can be nulled
| https://github.com/nodejs/node/pull/41014#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| lpinca:fix/issue-41011 | https://github.com/lpinca/node/tree/fix/issue-41011 |
|
Conversation
2
| https://github.com/nodejs/node/pull/41014 |
|
Commits
1
| https://github.com/nodejs/node/pull/41014/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/41014/checks |
|
Files changed
| https://github.com/nodejs/node/pull/41014/files |
| Please reload this page | https://github.com/nodejs/node/pull/41014 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Nov 29, 2021 | https://github.com/nodejs/node/pull/41014#issue-1065961266 |
| #41011 | https://github.com/nodejs/node/issues/41011 |
| Please reload this page | https://github.com/nodejs/node/pull/41014 |
|
| https://github.com/lpinca |
| doc: specify that message.socket can be nulled | https://github.com/nodejs/node/pull/41014/commits/a516edc5e781ad3b1df1bd47b56ae86d146aef6a |
| a516edc | https://github.com/nodejs/node/pull/41014/commits/a516edc5e781ad3b1df1bd47b56ae86d146aef6a |
| nodejs#41011 | https://github.com/nodejs/node/issues/41011 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
| Nov 29, 2021 | https://github.com/nodejs/node/pull/41014#event-5684471565 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Nov 29, 2021
| https://github.com/nodejs/node/pull/41014#pullrequestreview-817717982 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/41014/files/a516edc5e781ad3b1df1bd47b56ae86d146aef6a |
| doc/api/http.md | https://github.com/nodejs/node/pull/41014/files/a516edc5e781ad3b1df1bd47b56ae86d146aef6a#diff-d692ac4524379ec6a1201165e8ff8d3267c8130e07014e8221ebf7e6f80c6641 |
| lpinca | https://github.com/lpinca |
| Nov 29, 2021 | https://github.com/nodejs/node/pull/41014#discussion_r758303275 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/41014 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Nov 29, 2021
| https://github.com/nodejs/node/pull/41014#pullrequestreview-817918280 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/41014/files/a516edc5e781ad3b1df1bd47b56ae86d146aef6a |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Nov 29, 2021
| https://github.com/nodejs/node/pull/41014#pullrequestreview-817952290 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/41014/files/a516edc5e781ad3b1df1bd47b56ae86d146aef6a |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Dec 1, 2021 | https://github.com/nodejs/node/pull/41014#event-5701393241 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Dec 1, 2021 | https://github.com/nodejs/node/pull/41014#event-5701420294 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| 255b1db | https://github.com/nodejs/node/commit/255b1db9320df7b2e17a248ba4ab659d3f25853d |
| Dec 1, 2021 | https://github.com/nodejs/node/pull/41014#event-5701420557 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 1, 2021 | https://github.com/nodejs/node/pull/41014#issuecomment-983998232 |
| 255b1db | https://github.com/nodejs/node/commit/255b1db9320df7b2e17a248ba4ab659d3f25853d |
| Please reload this page | https://github.com/nodejs/node/pull/41014 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| December 1, 2021 19:48 | https://github.com/nodejs/node/pull/41014#event-5701423564 |
| danielleadams | https://github.com/danielleadams |
|
Dec 13, 2021
| https://github.com/nodejs/node/pull/41014#ref-commit-c6c0c90 |
|
| https://github.com/lpinca |
|
| https://github.com/danielleadams |
| doc: specify that message.socket can be nulled | https://github.com/nodejs/node/commit/c6c0c90cfbc6a07561dc606aadfdd881ca3c7db4 |
| c6c0c90 | https://github.com/nodejs/node/commit/c6c0c90cfbc6a07561dc606aadfdd881ca3c7db4 |
| #41011 | https://github.com/nodejs/node/issues/41011 |
| #41014 | https://github.com/nodejs/node/pull/41014 |
| danielleadams | https://github.com/danielleadams |
|
Dec 14, 2021
| https://github.com/nodejs/node/pull/41014#ref-commit-681edbe |
|
| https://github.com/lpinca |
|
| https://github.com/danielleadams |
| doc: specify that message.socket can be nulled | https://github.com/nodejs/node/commit/681edbe75f3d8c695b0ed1f403021164ec69d46a |
| 681edbe | https://github.com/nodejs/node/commit/681edbe75f3d8c695b0ed1f403021164ec69d46a |
| #41011 | https://github.com/nodejs/node/issues/41011 |
| #41014 | https://github.com/nodejs/node/pull/41014 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
Dec 14, 2021
| https://github.com/nodejs/node/pull/41014#ref-pullrequest-1079701516 |
|
v17.3.0 release proposal
#41167
| https://github.com/nodejs/node/pull/41167 |
| danielleadams | https://github.com/danielleadams |
|
Jan 31, 2022
| https://github.com/nodejs/node/pull/41014#ref-commit-348c100 |
|
| https://github.com/lpinca |
|
| https://github.com/danielleadams |
| doc: specify that message.socket can be nulled | https://github.com/nodejs/node/commit/348c1000383bcddd060fd9c5a2ba1b44b4fb14b3 |
| 348c100 | https://github.com/nodejs/node/commit/348c1000383bcddd060fd9c5a2ba1b44b4fb14b3 |
| #41011 | https://github.com/nodejs/node/issues/41011 |
| #41014 | https://github.com/nodejs/node/pull/41014 |
| Linkgoron | https://github.com/Linkgoron |
|
Jan 31, 2022
| https://github.com/nodejs/node/pull/41014#ref-commit-ede4151 |
|
| https://github.com/lpinca |
|
| https://github.com/Linkgoron |
| doc: specify that message.socket can be nulled | https://github.com/Linkgoron/node/commit/ede4151e5c6e78a5e099c62bea5f39f358016653 |
| ede4151 | https://github.com/Linkgoron/node/commit/ede4151e5c6e78a5e099c62bea5f39f358016653 |
| nodejs#41011 | https://github.com/nodejs/node/issues/41011 |
| nodejs#41014 | https://github.com/nodejs/node/pull/41014 |
| danielleadams | https://github.com/danielleadams |
|
Feb 1, 2022
| https://github.com/nodejs/node/pull/41014#ref-commit-c52ce19 |
|
| https://github.com/lpinca |
|
| https://github.com/danielleadams |
| doc: specify that message.socket can be nulled | https://github.com/nodejs/node/commit/c52ce19c80bf6b1b7b38423d81d0a5f957d1ed26 |
| c52ce19 | https://github.com/nodejs/node/commit/c52ce19c80bf6b1b7b38423d81d0a5f957d1ed26 |
| #41011 | https://github.com/nodejs/node/issues/41011 |
| #41014 | https://github.com/nodejs/node/pull/41014 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
Feb 1, 2022
| https://github.com/nodejs/node/pull/41014#ref-pullrequest-1120258873 |
|
v16.14.0 proposal
#41804
| https://github.com/nodejs/node/pull/41804 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41014 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/41014/files/a516edc5e781ad3b1df1bd47b56ae86d146aef6a |
|
| https://github.com/ronag |
|
ronag
| https://github.com/ronag |
|
| https://github.com/nodejs/node/pull/41014/files/a516edc5e781ad3b1df1bd47b56ae86d146aef6a |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
|
IncomingMessage docs incorrect
| https://github.com/nodejs/node/issues/41011 |
| Please reload this page | https://github.com/nodejs/node/pull/41014 |
|
| https://github.com/lpinca |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/jasnell |
|
| https://github.com/ronag |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |