René's URL Explorer Experiment


Title: assert: use stricter stack frame detection in .ifError() by BridgeAR · Pull Request #41006 · nodejs/node · GitHub

Open Graph Title: assert: use stricter stack frame detection in .ifError() by BridgeAR · Pull Request #41006 · nodejs/node

X Title: assert: use stricter stack frame detection in .ifError() by BridgeAR · Pull Request #41006 · nodejs/node

Description: This makes sure arbitrary stack traces are not handled as stack frames. Signed-off-by: Ruben Bridgewater ruben@bridgewater.de

Open Graph Description: This makes sure arbitrary stack traces are not handled as stack frames. Signed-off-by: Ruben Bridgewater ruben@bridgewater.de

X Description: This makes sure arbitrary stack traces are not handled as stack frames. Signed-off-by: Ruben Bridgewater ruben@bridgewater.de

Mail addresses
ruben@bridgewater.de

Opengraph URL: https://github.com/nodejs/node/pull/41006

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:76f933b9-6f26-484c-b3b4-30f67278e414
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA73C:7E3A0:5CAAB1:830BF7:696A0F3C
html-safe-nonce23ac5da760ef419253457a9c3917acf8c606eed65ffb540cd4c2ca4129b552d2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzNDOjdFM0EwOjVDQUFCMTo4MzBCRjc6Njk2QTBGM0MiLCJ2aXNpdG9yX2lkIjoiMjk2NTQxMTQ1MzQ3NzcxOTg2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac30c3ba948ada89e45c43c35e153c7953bc20b46f258a56bf91e4766168907c02
hovercard-subject-tagpull_request:790153116
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/41006/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/fa68380346069ee2910943b544976c504c862effa1cbf678d637175679a90673/nodejs/node/pull/41006
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fa68380346069ee2910943b544976c504c862effa1cbf678d637175679a90673/nodejs/node/pull/41006
og:image:altThis makes sure arbitrary stack traces are not handled as stack frames. Signed-off-by: Ruben Bridgewater ruben@bridgewater.de
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBridgeAR
hostnamegithub.com
expected-hostnamegithub.com
None699227a00bbb7fe1eec276d2ae1c3a93068bc5ba483bd9dc4b2a27a8f4f2f595
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7266b2d935baa1c6474b16dd9feaa5ca30607261
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/41006#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41006
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41006
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/41006
Reloadhttps://github.com/nodejs/node/pull/41006
Reloadhttps://github.com/nodejs/node/pull/41006
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/41006
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 698 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/41006
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/41006#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:stricter-stack-frame-detectionhttps://github.com/BridgeAR/node/tree/stricter-stack-frame-detection
assert: use stricter stack frame detection in .ifError() https://github.com/nodejs/node/pull/41006#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:stricter-stack-frame-detectionhttps://github.com/BridgeAR/node/tree/stricter-stack-frame-detection
Conversation 10 https://github.com/nodejs/node/pull/41006
Commits 1 https://github.com/nodejs/node/pull/41006/commits
Checks 0 https://github.com/nodejs/node/pull/41006/checks
Files changed https://github.com/nodejs/node/pull/41006/files
Please reload this pagehttps://github.com/nodejs/node/pull/41006
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Nov 28, 2021https://github.com/nodejs/node/pull/41006#issue-1065408056
Please reload this pagehttps://github.com/nodejs/node/pull/41006
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
assert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Nov 28, 2021https://github.com/nodejs/node/pull/41006#event-5681470130
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 28, 2021 https://github.com/nodejs/node/pull/41006#pullrequestreview-817247453
View reviewed changes https://github.com/nodejs/node/pull/41006/files
lib/assert.jshttps://github.com/nodejs/node/pull/41006/files#diff-4354d778aaf56c7c9558812b2f108f001388ef2a6ae846dda4e08f16a5edb20f
Please reload this pagehttps://github.com/nodejs/node/pull/41006
https://github.com/BridgeAR
assert: use stricter stack frame detection in .ifError()https://github.com/nodejs/node/pull/41006/commits/55445c1e0ef85023f31bc20f87d92b51fe17776c
55445c1https://github.com/nodejs/node/pull/41006/commits/55445c1e0ef85023f31bc20f87d92b51fe17776c
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
force-pushedhttps://github.com/nodejs/node/compare/134fd8942631000766545d84a05b3b43f58b64f3..55445c1e0ef85023f31bc20f87d92b51fe17776c
134fd89https://github.com/nodejs/node/commit/134fd8942631000766545d84a05b3b43f58b64f3
55445c1https://github.com/nodejs/node/commit/55445c1e0ef85023f31bc20f87d92b51fe17776c
Compare https://github.com/nodejs/node/compare/134fd8942631000766545d84a05b3b43f58b64f3..55445c1e0ef85023f31bc20f87d92b51fe17776c
November 28, 2021 19:14https://github.com/nodejs/node/pull/41006#event-5681486280
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 28, 2021https://github.com/nodejs/node/pull/41006#event-5681678356
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 28, 2021https://github.com/nodejs/node/pull/41006#event-5681681588
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41006
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41006
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 29, 2021https://github.com/nodejs/node/pull/41006#issuecomment-981973059
https://ci.nodejs.org/job/node-test-pull-request/41210/https://ci.nodejs.org/job/node-test-pull-request/41210/
Please reload this pagehttps://github.com/nodejs/node/pull/41006
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 30, 2021https://github.com/nodejs/node/pull/41006#issuecomment-982184332
https://ci.nodejs.org/job/node-test-pull-request/41218/https://ci.nodejs.org/job/node-test-pull-request/41218/
Please reload this pagehttps://github.com/nodejs/node/pull/41006
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 30, 2021https://github.com/nodejs/node/pull/41006#issuecomment-982515149
https://ci.nodejs.org/job/node-test-pull-request/41224/https://ci.nodejs.org/job/node-test-pull-request/41224/
Please reload this pagehttps://github.com/nodejs/node/pull/41006
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 30, 2021 https://github.com/nodejs/node/pull/41006#pullrequestreview-819146559
View reviewed changes https://github.com/nodejs/node/pull/41006/files/55445c1e0ef85023f31bc20f87d92b51fe17776c
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 30, 2021https://github.com/nodejs/node/pull/41006#event-5692630898
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 1, 2021https://github.com/nodejs/node/pull/41006#issuecomment-983163525
https://ci.nodejs.org/job/node-test-pull-request/41245/https://ci.nodejs.org/job/node-test-pull-request/41245/
Please reload this pagehttps://github.com/nodejs/node/pull/41006
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Dec 1, 2021https://github.com/nodejs/node/pull/41006#event-5695765245
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Dec 1, 2021https://github.com/nodejs/node/pull/41006#event-5695809817
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 1, 2021https://github.com/nodejs/node/pull/41006#issuecomment-983205858
https://github.com/nodejs/node/actions/runs/1523758566https://github.com/nodejs/node/actions/runs/1523758566
Please reload this pagehttps://github.com/nodejs/node/pull/41006
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
Dec 1, 2021https://github.com/nodejs/node/pull/41006#event-5695825289
CI Reliability 2021-12-03 nodejs/reliability#133 https://github.com/nodejs/reliability/issues/133
CI Reliability 2021-12-04 nodejs/reliability#134 https://github.com/nodejs/reliability/issues/134
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Dec 6, 2021https://github.com/nodejs/node/pull/41006#event-5722201710
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Dec 6, 2021https://github.com/nodejs/node/pull/41006#event-5722242506
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
414bc7bhttps://github.com/nodejs/node/commit/414bc7bec1080ef611aeb666a832b118fe0b9bfa
Dec 6, 2021https://github.com/nodejs/node/pull/41006#event-5722243028
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 6, 2021https://github.com/nodejs/node/pull/41006#issuecomment-987001366
414bc7bhttps://github.com/nodejs/node/commit/414bc7bec1080ef611aeb666a832b118fe0b9bfa
Please reload this pagehttps://github.com/nodejs/node/pull/41006
danielleadamshttps://github.com/danielleadams
Dec 13, 2021 https://github.com/nodejs/node/pull/41006#ref-commit-d4aa97d
https://github.com/BridgeAR
https://github.com/danielleadams
assert: use stricter stack frame detection in .ifError()https://github.com/nodejs/node/commit/d4aa97df9e49b1c9053ad474912733dd3f7d08ed
d4aa97dhttps://github.com/nodejs/node/commit/d4aa97df9e49b1c9053ad474912733dd3f7d08ed
#41006https://github.com/nodejs/node/pull/41006
danielleadamshttps://github.com/danielleadams
Dec 14, 2021 https://github.com/nodejs/node/pull/41006#ref-commit-a7dfa43
https://github.com/BridgeAR
https://github.com/danielleadams
assert: use stricter stack frame detection in .ifError()https://github.com/nodejs/node/commit/a7dfa43dc7f9d101e45fbc796f3fc6138726d2c9
a7dfa43https://github.com/nodejs/node/commit/a7dfa43dc7f9d101e45fbc796f3fc6138726d2c9
#41006https://github.com/nodejs/node/pull/41006
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
Dec 14, 2021 https://github.com/nodejs/node/pull/41006#ref-pullrequest-1079701516
v17.3.0 release proposal #41167 https://github.com/nodejs/node/pull/41167
danielleadamshttps://github.com/danielleadams
Jan 31, 2022 https://github.com/nodejs/node/pull/41006#ref-commit-45cd06b
https://github.com/BridgeAR
https://github.com/danielleadams
assert: use stricter stack frame detection in .ifError()https://github.com/nodejs/node/commit/45cd06b8ab69e6d50a798a5d46379b931cc6d396
45cd06bhttps://github.com/nodejs/node/commit/45cd06b8ab69e6d50a798a5d46379b931cc6d396
#41006https://github.com/nodejs/node/pull/41006
danielleadamshttps://github.com/danielleadams
Jan 31, 2022 https://github.com/nodejs/node/pull/41006#ref-commit-e07a334
https://github.com/BridgeAR
https://github.com/danielleadams
assert: use stricter stack frame detection in .ifError()https://github.com/nodejs/node/commit/e07a33487e0677b05febcd73b663ab8f023d1bc9
e07a334https://github.com/nodejs/node/commit/e07a33487e0677b05febcd73b663ab8f023d1bc9
#41006https://github.com/nodejs/node/pull/41006
Linkgoronhttps://github.com/Linkgoron
Jan 31, 2022 https://github.com/nodejs/node/pull/41006#ref-commit-33e7edb
https://github.com/BridgeAR
https://github.com/Linkgoron
assert: use stricter stack frame detection in .ifError()https://github.com/Linkgoron/node/commit/33e7edbc37e6ec69da79ce95ed01ce58c74e191a
33e7edbhttps://github.com/Linkgoron/node/commit/33e7edbc37e6ec69da79ce95ed01ce58c74e191a
nodejs#41006https://github.com/nodejs/node/pull/41006
danielleadamshttps://github.com/danielleadams
Feb 1, 2022 https://github.com/nodejs/node/pull/41006#ref-commit-2d471e4
https://github.com/BridgeAR
https://github.com/danielleadams
assert: use stricter stack frame detection in .ifError()https://github.com/nodejs/node/commit/2d471e47a0953f862280b2efa1f288b15ccd023d
2d471e4https://github.com/nodejs/node/commit/2d471e47a0953f862280b2efa1f288b15ccd023d
#41006https://github.com/nodejs/node/pull/41006
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
Feb 1, 2022 https://github.com/nodejs/node/pull/41006#ref-pullrequest-1120258873
v16.14.0 proposal #41804 https://github.com/nodejs/node/pull/41804
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41006
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/41006/files/134fd8942631000766545d84a05b3b43f58b64f3
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/41006/files/55445c1e0ef85023f31bc20f87d92b51fe17776c
assert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/41006
https://github.com/BridgeAR
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/aduh95
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.