René's URL Explorer Experiment


Title: net: activate setNoDelay by default by voxpelli · Pull Request #40778 · nodejs/node · GitHub

Open Graph Title: net: activate setNoDelay by default by voxpelli · Pull Request #40778 · nodejs/node

X Title: net: activate setNoDelay by default by voxpelli · Pull Request #40778 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes #34185 This is kind of a draft and is eg. lacking tests as I don't know how to test this (partly because it interacts deeply with the OS) and the fact that the current setup isn't tes...

X Description: Fixes #34185 This is kind of a draft and is eg. lacking tests as I don't know how to test this (partly because it interacts deeply with the OS) and the fact that the current setup isn&#...

Opengraph URL: https://github.com/nodejs/node/pull/40778

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4d20dce0-35a3-1846-830e-803bf0747e8c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB6FC:2C0692:429420:59A537:6A4D9EBE
html-safe-nonce53311009df3f2bed17951ceabce725e4b472ececeeebd4a608eff61ca43e4ec8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNkZDOjJDMDY5Mjo0Mjk0MjA6NTlBNTM3OjZBNEQ5RUJFIiwidmlzaXRvcl9pZCI6Ijg0NzY2Njc2MTMxNzQxNDQ3MDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf5de2858d2356cd68aaefb4cb2fd5a4d22d20ca2ce332e65ee39ffb1b1aa4718
hovercard-subject-tagpull_request:777810792
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/40778/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/93e48126c87aa8f1c0bb90c60ad2502d50fedfdef1e36908bb9b41169c4e016b/nodejs/node/pull/40778
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/93e48126c87aa8f1c0bb90c60ad2502d50fedfdef1e36908bb9b41169c4e016b/nodejs/node/pull/40778
og:image:altFixes #34185 This is kind of a draft and is eg. lacking tests as I don't know how to test this (partly because it interacts deeply with the OS) and the fact that the current setup isn't tes...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevoxpelli
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7f13faa65cccc9b729d674da83335d5dcfdfd193
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/40778#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F40778
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F40778
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/40778
Reloadhttps://github.com/nodejs/node/pull/40778
Reloadhttps://github.com/nodejs/node/pull/40778
Please reload this pagehttps://github.com/nodejs/node/pull/40778
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/40778
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
voxpellihttps://github.com/voxpelli
nodejs:masterhttps://github.com/nodejs/node/tree/master
Conversationhttps://github.com/nodejs/node/pull/40778
Commits3 (3)https://github.com/nodejs/node/pull/40778/commits
Checkshttps://github.com/nodejs/node/pull/40778/checks
Files changedhttps://github.com/nodejs/node/pull/40778/files
net: activate setNoDelay by defaulthttps://github.com/nodejs/node/pull/40778#top
voxpellihttps://github.com/voxpelli
nodejs:masterhttps://github.com/nodejs/node/tree/master
https://github.com/voxpelli
voxpellihttps://github.com/voxpelli
Nov 10, 2021https://github.com/nodejs/node/pull/40778#issue-1050082604
Please reload this pagehttps://github.com/nodejs/node/pull/40778
#34185https://github.com/nodejs/node/issues/34185
#34185https://github.com/nodejs/node/issues/34185
Please reload this pagehttps://github.com/nodejs/node/pull/40778
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
Nov 10, 2021https://github.com/nodejs/node/pull/40778#event-5598626314
https://github.com/voxpelli
voxpellihttps://github.com/voxpelli
Nov 10, 2021 https://github.com/nodejs/node/pull/40778#ref-issue-650695151
Follow curl: Enable setNoDelay() / TCP_NODELAY by default on HTTP(S) 1.x #34185 https://github.com/nodejs/node/issues/34185
https://github.com/voxpelli
net: activate setNoDelay by defaulthttps://github.com/nodejs/node/pull/40778/commits/5bdcf577a38bf5c80640260da3e38c47168d12f7
5bdcf57https://github.com/nodejs/node/pull/40778/commits/5bdcf577a38bf5c80640260da3e38c47168d12f7
#34185https://github.com/nodejs/node/issues/34185
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Nov 11, 2021https://github.com/nodejs/node/pull/40778#issuecomment-966201332
Please reload this pagehttps://github.com/nodejs/node/pull/40778
https://github.com/mcollina
mcollinahttps://github.com/mcollina
notable-change https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
baking-for-lts https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abaking-for-lts
Nov 11, 2021https://github.com/nodejs/node/pull/40778#event-5603051545
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Nov 11, 2021https://github.com/nodejs/node/pull/40778#issuecomment-966201862
Please reload this pagehttps://github.com/nodejs/node/pull/40778
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 12, 2021https://github.com/nodejs/node/pull/40778#issuecomment-966958998
https://ci.nodejs.org/job/node-test-pull-request/40849/https://ci.nodejs.org/job/node-test-pull-request/40849/
Please reload this pagehttps://github.com/nodejs/node/pull/40778
https://github.com/nodejs
nodejshttps://github.com/nodejs
Nov 12, 2021https://github.com/nodejs/node/pull/40778#event-5608938629
https://github.com/nodejs
nodejshttps://github.com/nodejs
Nov 12, 2021https://github.com/nodejs/node/pull/40778#event-5608938999
voxpellihttps://github.com/voxpelli
November 12, 2021 17:39https://github.com/nodejs/node/pull/40778#commits-pushed-b23fc17
https://github.com/voxpelli
net: remove failing setNoDelay testhttps://github.com/nodejs/node/pull/40778/commits/b23fc174e19208e78e021456a182d9ed2122aab0
b23fc17https://github.com/nodejs/node/pull/40778/commits/b23fc174e19208e78e021456a182d9ed2122aab0
https://github.com/voxpelli
net: adapt setNoDelay tests to new defaulthttps://github.com/nodejs/node/pull/40778/commits/df4595e2c3b83c065753abfbac3653f11bedfd4d
df4595ehttps://github.com/nodejs/node/pull/40778/commits/df4595e2c3b83c065753abfbac3653f11bedfd4d
https://github.com/voxpelli
voxpellihttps://github.com/voxpelli
Nov 12, 2021https://github.com/nodejs/node/pull/40778#issuecomment-967262228
Please reload this pagehttps://github.com/nodejs/node/pull/40778
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Nov 12, 2021https://github.com/nodejs/node/pull/40778#issuecomment-967294854
Please reload this pagehttps://github.com/nodejs/node/pull/40778
https://github.com/voxpelli
voxpellihttps://github.com/voxpelli
Nov 12, 2021https://github.com/nodejs/node/pull/40778#issuecomment-967300918
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/40778
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 13, 2021 https://github.com/nodejs/node/pull/40778#ref-issue-1052488126
CI Reliability 2021-11-13 nodejs/reliability#116 https://github.com/nodejs/reliability/issues/116
https://github.com/lpinca
lpincahttps://github.com/lpinca
Nov 13, 2021https://github.com/nodejs/node/pull/40778#issuecomment-967793425
Please reload this pagehttps://github.com/nodejs/node/pull/40778
node/lib/_http_client.jshttps://github.com/nodejs/node/blob/9cd30894f6e708475ec56cea63eb8c960df779a4/lib/_http_client.js#L757
9cd3089https://github.com/nodejs/node/commit/9cd30894f6e708475ec56cea63eb8c960df779a4
Please reload this pagehttps://github.com/nodejs/node/pull/40778
CI Reliability 2021-11-14 nodejs/reliability#117 https://github.com/nodejs/reliability/issues/117
CI Reliability 2021-11-15 nodejs/reliability#118 https://github.com/nodejs/reliability/issues/118
CI Reliability 2021-11-16 nodejs/reliability#119 https://github.com/nodejs/reliability/issues/119
https://github.com/voxpelli
voxpellihttps://github.com/voxpelli
Nov 16, 2021https://github.com/nodejs/node/pull/40778#issuecomment-970493688
Please reload this pagehttps://github.com/nodejs/node/pull/40778
https://github.com/lpinca
lpincahttps://github.com/lpinca
Nov 16, 2021https://github.com/nodejs/node/pull/40778#issuecomment-970514794
Please reload this pagehttps://github.com/nodejs/node/pull/40778
https://github.com/voxpelli
voxpellihttps://github.com/voxpelli
Nov 16, 2021https://github.com/nodejs/node/pull/40778#issuecomment-970518020
#31539https://github.com/nodejs/node/pull/31539
Please reload this pagehttps://github.com/nodejs/node/pull/40778
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 17, 2021 https://github.com/nodejs/node/pull/40778#ref-issue-1055559883
CI Reliability 2021-11-17 nodejs/reliability#120 https://github.com/nodejs/reliability/issues/120
https://github.com/voxpelli
voxpellihttps://github.com/voxpelli
Mar 22, 2022https://github.com/nodejs/node/pull/40778#issuecomment-1074937005
#34185https://github.com/nodejs/node/issues/34185
#42163https://github.com/nodejs/node/pull/42163
Please reload this pagehttps://github.com/nodejs/node/pull/40778
https://github.com/voxpelli
voxpellihttps://github.com/voxpelli
Mar 22, 2022https://github.com/nodejs/node/pull/40778#event-6282054362
https://github.com/voxpelli
voxpellihttps://github.com/voxpelli
April 8, 2022 12:03https://github.com/nodejs/node/pull/40778#event-6395948534
https://github.com/targos
targoshttps://github.com/targos
baking-for-lts https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abaking-for-lts
Sep 16, 2022https://github.com/nodejs/node/pull/40778#event-7401962454
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F40778
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
notable-change https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Follow curl: Enable setNoDelay() / TCP_NODELAY by default on HTTP(S) 1.x https://github.com/nodejs/node/issues/34185
Please reload this pagehttps://github.com/nodejs/node/pull/40778
https://github.com/voxpelli
https://github.com/mcollina
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/lpinca
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.