| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6b3f762d-8423-f42e-d5e5-651b2834ceed |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C558:11D37A:ADC777:F4C7EC:696A1DD2 |
| html-safe-nonce | 7445a43b0ba1fe5f5a1e6b82068043dfcb7bb641e1c2ecae6fef689b4974dd7a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTU4OjExRDM3QTpBREM3Nzc6RjRDN0VDOjY5NkExREQyIiwidmlzaXRvcl9pZCI6Ijg0ODM0MTc3Mjk3OTA1MTY2OTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ec5b8f50cee300ba3393fb9bfdf092e06ec4d8fcecfa3e8dd9ee7bdba0af1650 |
| hovercard-subject-tag | pull_request:771745566 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/40704/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/40fa8813c13413f6898cb1b24a12e09275cc1398b698235fdfbb31937ce3be52/nodejs/node/pull/40704 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/40fa8813c13413f6898cb1b24a12e09275cc1398b698235fdfbb31937ce3be52/nodejs/node/pull/40704 |
| og:image:alt | In example of implementing a writable stream with extending on Writable add explicit declaration of 'fd' (file descriptor) variable with null value.
It will make this example more similar t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Gena888 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 014f3d193f36b7d393f88ca22d06fbacd370800b40a547c1ea67291e02dc8ea3 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d515f6f09fa57a93bf90355cb894eb84ca4f458f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/40704#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F40704 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F40704 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/40704 |
| Reload | https://github.com/nodejs/node/pull/40704 |
| Reload | https://github.com/nodejs/node/pull/40704 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/40704 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
698
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/40704 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/40704#issue-comment-box |
| Gena888 | https://github.com/Gena888 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
feat: add explicit declaration of fd with null val
| https://github.com/nodejs/node/pull/40704#top |
| Gena888 | https://github.com/Gena888 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
Conversation
9
| https://github.com/nodejs/node/pull/40704 |
|
Commits
1
| https://github.com/nodejs/node/pull/40704/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/40704/checks |
|
Files changed
| https://github.com/nodejs/node/pull/40704/files |
| Please reload this page | https://github.com/nodejs/node/pull/40704 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Gena888 |
| Gena888 | https://github.com/Gena888 |
| Nov 2, 2021 | https://github.com/nodejs/node/pull/40704#issue-1042705969 |
| https://user-images.githubusercontent.com/74081058/139927470-ac02885f-4708-411a-bfc8-01815b819682.png |
| Please reload this page | https://github.com/nodejs/node/pull/40704 |
|
| https://github.com/Gena888 |
| feat: add explicit declaration of fd with null val | https://github.com/nodejs/node/pull/40704/commits/3aaa09e4a8ba993a902d36e11fdbbdb17941c493 |
| 3aaa09e | https://github.com/nodejs/node/pull/40704/commits/3aaa09e4a8ba993a902d36e11fdbbdb17941c493 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Nov 2, 2021 | https://github.com/nodejs/node/pull/40704#event-5557659682 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| ronag | https://github.com/ronag |
| November 3, 2021 13:13 | https://github.com/nodejs/node/pull/40704#event-5561807322 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Nov 3, 2021
| https://github.com/nodejs/node/pull/40704#pullrequestreview-796519518 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/40704/files/3aaa09e4a8ba993a902d36e11fdbbdb17941c493 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Nov 3, 2021 | https://github.com/nodejs/node/pull/40704#issuecomment-959050687 |
| @Gena888 | https://github.com/Gena888 |
| node/doc/api/stream.md | https://github.com/nodejs/node/blob/2e2a6fecd9b1aaffcb932fcc415439f359c84fdd/doc/api/stream.md#L2908-L2912 |
| 2e2a6fe | https://github.com/nodejs/node/commit/2e2a6fecd9b1aaffcb932fcc415439f359c84fdd |
| Please reload this page | https://github.com/nodejs/node/pull/40704 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Nov 3, 2021 | https://github.com/nodejs/node/pull/40704#issuecomment-959051630 |
| Please reload this page | https://github.com/nodejs/node/pull/40704 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Nov 3, 2021
| https://github.com/nodejs/node/pull/40704#pullrequestreview-796568561 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/40704/files/3aaa09e4a8ba993a902d36e11fdbbdb17941c493 |
| doc/api/stream.md | https://github.com/nodejs/node/pull/40704/files/3aaa09e4a8ba993a902d36e11fdbbdb17941c493#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| mcollina | https://github.com/mcollina |
| Nov 3, 2021 | https://github.com/nodejs/node/pull/40704#discussion_r741955981 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/40704 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Nov 3, 2021
| https://github.com/nodejs/node/pull/40704#pullrequestreview-797054761 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/40704/files/3aaa09e4a8ba993a902d36e11fdbbdb17941c493 |
| https://github.com/JungMinu |
| JungMinu | https://github.com/JungMinu |
|
Nov 9, 2021
| https://github.com/nodejs/node/pull/40704#pullrequestreview-800835161 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/40704/files/3aaa09e4a8ba993a902d36e11fdbbdb17941c493 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Nov 9, 2021 | https://github.com/nodejs/node/pull/40704#issuecomment-963904268 |
| Please reload this page | https://github.com/nodejs/node/pull/40704 |
| https://github.com/Gena888 |
| Gena888 | https://github.com/Gena888 |
| Nov 9, 2021 | https://github.com/nodejs/node/pull/40704#issuecomment-963905543 |
| Please reload this page | https://github.com/nodejs/node/pull/40704 |
| Please reload this page | https://github.com/nodejs/node/pull/40704 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Nov 9, 2021 | https://github.com/nodejs/node/pull/40704#issuecomment-963906260 |
| Please reload this page | https://github.com/nodejs/node/pull/40704 |
| https://github.com/Gena888 |
| Gena888 | https://github.com/Gena888 |
| Nov 9, 2021 | https://github.com/nodejs/node/pull/40704#issuecomment-964247521 |
| Please reload this page | https://github.com/nodejs/node/pull/40704 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Nov 13, 2021
| https://github.com/nodejs/node/pull/40704#pullrequestreview-805385310 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/40704/files/3aaa09e4a8ba993a902d36e11fdbbdb17941c493 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Dec 4, 2021
| https://github.com/nodejs/node/pull/40704#pullrequestreview-823282021 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/40704/files/3aaa09e4a8ba993a902d36e11fdbbdb17941c493 |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/40704#pullrequestreview-823282021 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/40704 |
| mcollina | https://github.com/mcollina |
|
Dec 4, 2021
| https://github.com/nodejs/node/pull/40704#ref-commit-069d2bd |
|
| https://github.com/Gena888 |
|
| https://github.com/mcollina |
| doc: add explicit declaration of fd with null val | https://github.com/nodejs/node/commit/069d2bd2507b62d819b590df859e0db79fb7996f |
| 069d2bd | https://github.com/nodejs/node/commit/069d2bd2507b62d819b590df859e0db79fb7996f |
| #40704 | https://github.com/nodejs/node/pull/40704 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Dec 4, 2021 | https://github.com/nodejs/node/pull/40704#issuecomment-986054289 |
| 069d2bd | https://github.com/nodejs/node/commit/069d2bd2507b62d819b590df859e0db79fb7996f |
| Please reload this page | https://github.com/nodejs/node/pull/40704 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Dec 4, 2021 | https://github.com/nodejs/node/pull/40704#event-5715819472 |
| danielleadams | https://github.com/danielleadams |
|
Dec 13, 2021
| https://github.com/nodejs/node/pull/40704#ref-commit-cd68bb0 |
|
| https://github.com/Gena888 |
|
| https://github.com/danielleadams |
| doc: add explicit declaration of fd with null val | https://github.com/nodejs/node/commit/cd68bb0ba3a970102810fc08a8ebebce2ddf3874 |
| cd68bb0 | https://github.com/nodejs/node/commit/cd68bb0ba3a970102810fc08a8ebebce2ddf3874 |
| #40704 | https://github.com/nodejs/node/pull/40704 |
| danielleadams | https://github.com/danielleadams |
|
Dec 14, 2021
| https://github.com/nodejs/node/pull/40704#ref-commit-94d0911 |
|
| https://github.com/Gena888 |
|
| https://github.com/danielleadams |
| doc: add explicit declaration of fd with null val | https://github.com/nodejs/node/commit/94d09113a21e96aaab86f577d4e0e815dfd70c64 |
| 94d0911 | https://github.com/nodejs/node/commit/94d09113a21e96aaab86f577d4e0e815dfd70c64 |
| #40704 | https://github.com/nodejs/node/pull/40704 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
Dec 14, 2021
| https://github.com/nodejs/node/pull/40704#ref-pullrequest-1079701516 |
|
v17.3.0 release proposal
#41167
| https://github.com/nodejs/node/pull/41167 |
| danielleadams | https://github.com/danielleadams |
|
Jan 31, 2022
| https://github.com/nodejs/node/pull/40704#ref-commit-93666d3 |
|
| https://github.com/Gena888 |
|
| https://github.com/danielleadams |
| doc: add explicit declaration of fd with null val | https://github.com/nodejs/node/commit/93666d30f09ac94bc420c49f3da9fc822f883306 |
| 93666d3 | https://github.com/nodejs/node/commit/93666d30f09ac94bc420c49f3da9fc822f883306 |
| #40704 | https://github.com/nodejs/node/pull/40704 |
| danielleadams | https://github.com/danielleadams |
|
Jan 31, 2022
| https://github.com/nodejs/node/pull/40704#ref-commit-d9331e4 |
|
| https://github.com/Gena888 |
|
| https://github.com/danielleadams |
| doc: add explicit declaration of fd with null val | https://github.com/nodejs/node/commit/d9331e474b4e6ba29db1693ac011b806fe941209 |
| d9331e4 | https://github.com/nodejs/node/commit/d9331e474b4e6ba29db1693ac011b806fe941209 |
| #40704 | https://github.com/nodejs/node/pull/40704 |
| Linkgoron | https://github.com/Linkgoron |
|
Jan 31, 2022
| https://github.com/nodejs/node/pull/40704#ref-commit-cc35aaa |
|
| https://github.com/Gena888 |
|
| https://github.com/Linkgoron |
| doc: add explicit declaration of fd with null val | https://github.com/Linkgoron/node/commit/cc35aaac830d9a1c7b4a900a4079687f33a635ae |
| cc35aaa | https://github.com/Linkgoron/node/commit/cc35aaac830d9a1c7b4a900a4079687f33a635ae |
| nodejs#40704 | https://github.com/nodejs/node/pull/40704 |
| danielleadams | https://github.com/danielleadams |
|
Feb 1, 2022
| https://github.com/nodejs/node/pull/40704#ref-commit-6a9db2e |
|
| https://github.com/Gena888 |
|
| https://github.com/danielleadams |
| doc: add explicit declaration of fd with null val | https://github.com/nodejs/node/commit/6a9db2ebdb2af2655328e2c9e24a02486994baff |
| 6a9db2e | https://github.com/nodejs/node/commit/6a9db2ebdb2af2655328e2c9e24a02486994baff |
| #40704 | https://github.com/nodejs/node/pull/40704 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
Feb 1, 2022
| https://github.com/nodejs/node/pull/40704#ref-pullrequest-1120258873 |
|
v16.14.0 proposal
#41804
| https://github.com/nodejs/node/pull/41804 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F40704 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/40704/files/3aaa09e4a8ba993a902d36e11fdbbdb17941c493 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/40704/files/3aaa09e4a8ba993a902d36e11fdbbdb17941c493 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/40704/files/3aaa09e4a8ba993a902d36e11fdbbdb17941c493 |
|
| https://github.com/tniessen |
|
tniessen
| https://github.com/tniessen |
|
| https://github.com/nodejs/node/pull/40704/files/3aaa09e4a8ba993a902d36e11fdbbdb17941c493 |
|
| https://github.com/JungMinu |
|
JungMinu
| https://github.com/JungMinu |
|
| https://github.com/nodejs/node/pull/40704/files/3aaa09e4a8ba993a902d36e11fdbbdb17941c493 |
|
| https://github.com/ronag |
|
ronag
| https://github.com/ronag |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Please reload this page | https://github.com/nodejs/node/pull/40704 |
|
| https://github.com/Gena888 |
|
| https://github.com/tniessen |
|
| https://github.com/mcollina |
|
| https://github.com/jasnell |
|
| https://github.com/lpinca |
|
| https://github.com/JungMinu |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |