René's URL Explorer Experiment


Title: lib: make validateAbortSignal stricter by VoltrexKeyva · Pull Request #40657 · nodejs/node · GitHub

Open Graph Title: lib: make validateAbortSignal stricter by VoltrexKeyva · Pull Request #40657 · nodejs/node

X Title: lib: make validateAbortSignal stricter by VoltrexKeyva · Pull Request #40657 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: We should not force-check if the passed signal is NOT undefined and then proceed to check whether the value is an abort signal or not as the validator won't throw an error if the value is undef...

X Description: We should not force-check if the passed signal is NOT undefined and then proceed to check whether the value is an abort signal or not as the validator won't throw an error if the value is u...

Opengraph URL: https://github.com/nodejs/node/pull/40657

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:25b3d284-f9e9-c69b-1250-0c5ceb8e2b1f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDCE4:276C72:5EE596:7DDC30:6A52FE09
html-safe-nonce17e19c588d5fa378efdc230a59d189159d2ace26c9eafdea4202e777cdd62d17
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0U0OjI3NkM3Mjo1RUU1OTY6N0REQzMwOjZBNTJGRTA5IiwidmlzaXRvcl9pZCI6IjQ4MjAwMjU3MjI1NzQ5Mjk0MTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd17463c9b12edd4a44e990fc147ea04ebab538c6a7aa3ee2c4a6f41e644d43a6
hovercard-subject-tagpull_request:769340847
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/40657/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6a1d0a5d9e1cb1b5deb387e551278ced3221e011f876fe2dc43ae917b1e7cb50/nodejs/node/pull/40657
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6a1d0a5d9e1cb1b5deb387e551278ced3221e011f876fe2dc43ae917b1e7cb50/nodejs/node/pull/40657
og:image:altWe should not force-check if the passed signal is NOT undefined and then proceed to check whether the value is an abort signal or not as the validator won't throw an error if the value is undef...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameVoltrexKeyva
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/40657#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F40657
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F40657
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/40657
Reloadhttps://github.com/nodejs/node/pull/40657
Reloadhttps://github.com/nodejs/node/pull/40657
Please reload this pagehttps://github.com/nodejs/node/pull/40657
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/40657
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.2k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 997 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
VoltrexKeyvahttps://github.com/VoltrexKeyva
nodejs:masterhttps://github.com/nodejs/node/tree/master
VoltrexKeyva:make-validator-stricterhttps://github.com/VoltrexKeyva/node/tree/make-validator-stricter
Conversationhttps://github.com/nodejs/node/pull/40657
Commits1 (1)https://github.com/nodejs/node/pull/40657/commits
Checkshttps://github.com/nodejs/node/pull/40657/checks
Files changedhttps://github.com/nodejs/node/pull/40657/files
lib: make validateAbortSignal stricterhttps://github.com/nodejs/node/pull/40657#top
VoltrexKeyvahttps://github.com/VoltrexKeyva
nodejs:masterhttps://github.com/nodejs/node/tree/master
VoltrexKeyva:make-validator-stricterhttps://github.com/VoltrexKeyva/node/tree/make-validator-stricter
https://github.com/VoltrexKeyva
VoltrexKeyvahttps://github.com/VoltrexKeyva
Oct 29, 2021https://github.com/nodejs/node/pull/40657#issue-1039684604
Please reload this pagehttps://github.com/nodejs/node/pull/40657
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Oct 29, 2021https://github.com/nodejs/node/pull/40657#event-5541334084
https://github.com/targos
targoshttps://github.com/targos
Oct 29, 2021https://github.com/nodejs/node/pull/40657#issuecomment-954845936
Please reload this pagehttps://github.com/nodejs/node/pull/40657
https://github.com/targos
targoshttps://github.com/targos
Oct 29, 2021 https://github.com/nodejs/node/pull/40657#pullrequestreview-793199473
View reviewed changes https://github.com/nodejs/node/pull/40657/files
lib/internal/validators.jshttps://github.com/nodejs/node/pull/40657/files#diff-84047e9de2de28fd3ae796466cebdbae912d724504cb1b44c4f45b3517c1fa5f
Please reload this pagehttps://github.com/nodejs/node/pull/40657
https://github.com/VoltrexKeyva
VoltrexKeyvahttps://github.com/VoltrexKeyva
force-pushedhttps://github.com/nodejs/node/compare/cce3af9e94b0fac626f88dfa7529aaa973a0679a..4d0912781a080eed60c90afb14767dcd96713e61
cce3af9https://github.com/nodejs/node/commit/cce3af9e94b0fac626f88dfa7529aaa973a0679a
4d09127https://github.com/nodejs/node/commit/4d0912781a080eed60c90afb14767dcd96713e61
Compare https://github.com/nodejs/node/compare/cce3af9e94b0fac626f88dfa7529aaa973a0679a..4d0912781a080eed60c90afb14767dcd96713e61
October 29, 2021 20:49https://github.com/nodejs/node/pull/40657#event-5542747236
https://github.com/Linkgoron
Linkgoronhttps://github.com/Linkgoron
Oct 29, 2021https://github.com/nodejs/node/pull/40657#issuecomment-955089452
Please reload this pagehttps://github.com/nodejs/node/pull/40657
Please reload this pagehttps://github.com/nodejs/node/pull/40657
https://github.com/VoltrexKeyva
VoltrexKeyvahttps://github.com/VoltrexKeyva
Oct 29, 2021https://github.com/nodejs/node/pull/40657#issuecomment-955090923
Please reload this pagehttps://github.com/nodejs/node/pull/40657
https://github.com/Linkgoron
Linkgoronhttps://github.com/Linkgoron
Oct 29, 2021https://github.com/nodejs/node/pull/40657#issuecomment-955093349
Please reload this pagehttps://github.com/nodejs/node/pull/40657
Please reload this pagehttps://github.com/nodejs/node/pull/40657
https://github.com/VoltrexKeyva
VoltrexKeyvahttps://github.com/VoltrexKeyva
Oct 29, 2021https://github.com/nodejs/node/pull/40657#issuecomment-955096797
node/lib/internal/streams/add-abort-signal.jshttps://github.com/nodejs/node/blob/e937662dec4adc6ac1cd65afd4cbda79703d5ecc/lib/internal/streams/add-abort-signal.js#L14-L19
e937662https://github.com/nodejs/node/commit/e937662dec4adc6ac1cd65afd4cbda79703d5ecc
Please reload this pagehttps://github.com/nodejs/node/pull/40657
https://github.com/Linkgoron
Linkgoronhttps://github.com/Linkgoron
Oct 29, 2021https://github.com/nodejs/node/pull/40657#issuecomment-955098278
Please reload this pagehttps://github.com/nodejs/node/pull/40657
node/lib/internal/streams/add-abort-signal.jshttps://github.com/nodejs/node/blob/e937662dec4adc6ac1cd65afd4cbda79703d5ecc/lib/internal/streams/add-abort-signal.js#L14-L19
e937662https://github.com/nodejs/node/commit/e937662dec4adc6ac1cd65afd4cbda79703d5ecc
#36061 (comment)https://github.com/nodejs/node/pull/36061#discussion_r533718029
Please reload this pagehttps://github.com/nodejs/node/pull/40657
https://github.com/VoltrexKeyva
VoltrexKeyvahttps://github.com/VoltrexKeyva
Oct 29, 2021https://github.com/nodejs/node/pull/40657#issuecomment-955099628
Please reload this pagehttps://github.com/nodejs/node/pull/40657
node/lib/internal/streams/add-abort-signal.jshttps://github.com/nodejs/node/blob/e937662dec4adc6ac1cd65afd4cbda79703d5ecc/lib/internal/streams/add-abort-signal.js#L14-L19
e937662https://github.com/nodejs/node/commit/e937662dec4adc6ac1cd65afd4cbda79703d5ecc
#36061 (comment)https://github.com/nodejs/node/pull/36061#discussion_r533718029
Please reload this pagehttps://github.com/nodejs/node/pull/40657
https://github.com/VoltrexKeyva
VoltrexKeyvahttps://github.com/VoltrexKeyva
force-pushedhttps://github.com/nodejs/node/compare/26cd6071797b92885064cc572bdf6893d53a3317..77a1d3a7c21ebd1c2a6c01679300ba57a0682b50
26cd607https://github.com/nodejs/node/commit/26cd6071797b92885064cc572bdf6893d53a3317
77a1d3ahttps://github.com/nodejs/node/commit/77a1d3a7c21ebd1c2a6c01679300ba57a0682b50
Compare https://github.com/nodejs/node/compare/26cd6071797b92885064cc572bdf6893d53a3317..77a1d3a7c21ebd1c2a6c01679300ba57a0682b50
October 30, 2021 14:21https://github.com/nodejs/node/pull/40657#event-5543965034
https://github.com/VoltrexKeyva
lib: make validateAbortSignal stricterhttps://github.com/nodejs/node/pull/40657/commits/0cf699933317fc75f032552c258a68a5e7de7a56
0cf6999https://github.com/nodejs/node/pull/40657/commits/0cf699933317fc75f032552c258a68a5e7de7a56
https://github.com/VoltrexKeyva
VoltrexKeyvahttps://github.com/VoltrexKeyva
force-pushedhttps://github.com/nodejs/node/compare/77a1d3a7c21ebd1c2a6c01679300ba57a0682b50..0cf699933317fc75f032552c258a68a5e7de7a56
77a1d3ahttps://github.com/nodejs/node/commit/77a1d3a7c21ebd1c2a6c01679300ba57a0682b50
0cf6999https://github.com/nodejs/node/commit/0cf699933317fc75f032552c258a68a5e7de7a56
Compare https://github.com/nodejs/node/compare/77a1d3a7c21ebd1c2a6c01679300ba57a0682b50..0cf699933317fc75f032552c258a68a5e7de7a56
October 30, 2021 17:00https://github.com/nodejs/node/pull/40657#event-5544147679
https://github.com/VoltrexKeyva
VoltrexKeyvahttps://github.com/VoltrexKeyva
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 30, 2021https://github.com/nodejs/node/pull/40657#event-5544326575
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 30, 2021https://github.com/nodejs/node/pull/40657#event-5544328130
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 30, 2021https://github.com/nodejs/node/pull/40657#issuecomment-955588880
https://ci.nodejs.org/job/node-test-pull-request/40583/https://ci.nodejs.org/job/node-test-pull-request/40583/
Please reload this pagehttps://github.com/nodejs/node/pull/40657
CI Reliability 2021-10-31 nodejs/reliability#103 https://github.com/nodejs/reliability/issues/103
CI Reliability 2021-11-01 nodejs/reliability#104 https://github.com/nodejs/reliability/issues/104
CI Reliability 2021-11-02 nodejs/reliability#105 https://github.com/nodejs/reliability/issues/105
CI Reliability 2021-11-03 nodejs/reliability#106 https://github.com/nodejs/reliability/issues/106
https://github.com/VoltrexKeyva
VoltrexKeyvahttps://github.com/VoltrexKeyva
Apr 3, 2022https://github.com/nodejs/node/pull/40657#event-6358569001
https://github.com/VoltrexKeyva
VoltrexKeyvahttps://github.com/VoltrexKeyva
April 3, 2022 17:36https://github.com/nodejs/node/pull/40657#event-6358569079
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F40657
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/40657/files/1a79c1c6756778c538044f1c983c378455d5b63d
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/40657
https://github.com/VoltrexKeyva
https://github.com/targos
https://github.com/Linkgoron
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.