| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:12466a34-5c4f-d6a7-3fd5-f18fdd19a1eb |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D074:1258EF:5DB1AB:79C8B8:6AED2A77 |
| html-safe-nonce | 43fe897d85e9e9f8e0d3a236245145931855c70cc980d29798da06ebc968f178 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDc0OjEyNThFRjo1REIxQUI6NzlDOEI4OjZBRUQyQTc3IiwidmlzaXRvcl9pZCI6IjEyNzUyNzM5NTM0NTM4Nzc4NzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 07df606c048d41255cbae849303d6e6a8ba7dcb257afb4690736fdac80e0a097 |
| hovercard-subject-tag | pull_request:769128614 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/40653/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5acc9f761bd845331637db1ba9e83fa1254f1303ca1411715be0fb461642ba2b/nodejs/node/pull/40653 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5acc9f761bd845331637db1ba9e83fa1254f1303ca1411715be0fb461642ba2b/nodejs/node/pull/40653 |
| og:image:alt | Otherwise it's impossible to read the remaining data... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ronag |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9d95365dda0576efe9b71f45807595e396bd0ca9286fba5367a05048e6ddf8f2 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 98b41fa4b5635ceb45a4c54320fced73817ff290 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/nodejs/node/pull/40653#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F40653 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F40653 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/40653 |
| Reload | https://github.com/nodejs/node/pull/40653 |
| Reload | https://github.com/nodejs/node/pull/40653 |
| nodejs | https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Code | https://github.com/nodejs/node |
| Issues656 (656) | https://github.com/nodejs/node/issues |
| Pull requests666 (666) | https://github.com/nodejs/node/pulls |
| Actions | https://github.com/nodejs/node/actions |
| Projects | https://github.com/nodejs/node/projects |
| Security and quality | https://github.com/nodejs/node/security |
| Insights | https://github.com/nodejs/node/pulse |
| https://github.com/nodejs/node |
| ronag | https://github.com/ronag |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| nxtedition:promise-pipeline-return | https://github.com/nxtedition/node/tree/promise-pipeline-return |
| Conversation | https://github.com/nodejs/node/pull/40653 |
| Commits1 (1) | https://github.com/nodejs/node/pull/40653/commits |
| Checks | https://github.com/nodejs/node/pull/40653/checks |
| Files changed | https://github.com/nodejs/node/pull/40653/files |
| stream: return readable stream on promisified pipeline | https://github.com/nodejs/node/pull/40653#top |
| ronag | https://github.com/ronag |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| nxtedition:promise-pipeline-return | https://github.com/nxtedition/node/tree/promise-pipeline-return |
|
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Oct 29, 2021 | https://github.com/nodejs/node/pull/40653#issue-1039437442 |
| Please reload this page | https://github.com/nodejs/node/pull/40653 |
| Please reload this page | https://github.com/nodejs/node/pull/40653 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| lpinca | https://github.com/lpinca |
| mcollina | https://github.com/mcollina |
| October 29, 2021 10:50 | https://github.com/nodejs/node/pull/40653#event-5539828015 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Oct 29, 2021 | https://github.com/nodejs/node/pull/40653#event-5539828746 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Oct 29, 2021 | https://github.com/nodejs/node/pull/40653#issuecomment-954645809 |
| Please reload this page | https://github.com/nodejs/node/pull/40653 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Oct 29, 2021 | https://github.com/nodejs/node/pull/40653#event-5539830797 |
|
| https://github.com/ronag |
| stream: return readable stream on promisified pipeline | https://github.com/nodejs/node/pull/40653/commits/088af2a0b88a1ff367a2b812fc83e4aea54940e2 |
| 088af2a | https://github.com/nodejs/node/pull/40653/commits/088af2a0b88a1ff367a2b812fc83e4aea54940e2 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/56ec619321ba6aa338646208175e5702ecf20f69..088af2a0b88a1ff367a2b812fc83e4aea54940e2 |
| 56ec619 | https://github.com/nodejs/node/commit/56ec619321ba6aa338646208175e5702ecf20f69 |
| 088af2a | https://github.com/nodejs/node/commit/088af2a0b88a1ff367a2b812fc83e4aea54940e2 |
|
Compare
| https://github.com/nodejs/node/compare/56ec619321ba6aa338646208175e5702ecf20f69..088af2a0b88a1ff367a2b812fc83e4aea54940e2 |
| October 29, 2021 10:51 | https://github.com/nodejs/node/pull/40653#event-5539832761 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
| Oct 29, 2021 | https://github.com/nodejs/node/pull/40653#event-5539834719 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Oct 29, 2021 | https://github.com/nodejs/node/pull/40653#issuecomment-954646592 |
| @mcollina | https://github.com/mcollina |
| Please reload this page | https://github.com/nodejs/node/pull/40653 |
| https://github.com/Mesteery |
| Mesteery | https://github.com/Mesteery |
|
Oct 29, 2021
| https://github.com/nodejs/node/pull/40653#pullrequestreview-792914217 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/40653/files/088af2a0b88a1ff367a2b812fc83e4aea54940e2 |
| test/parallel/test-stream-pipeline.js | https://github.com/nodejs/node/pull/40653/files/088af2a0b88a1ff367a2b812fc83e4aea54940e2#diff-a67241f46cd58ac94c8d56acb3b727310465bdf493535654f71bb384f8a80057 |
| Please reload this page | https://github.com/nodejs/node/pull/40653 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Oct 29, 2021
| https://github.com/nodejs/node/pull/40653#ref-pullrequest-1039464238 |
|
stream: pipeline should drain empty readable
#40654
| https://github.com/nodejs/node/pull/40654 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
| Oct 29, 2021 | https://github.com/nodejs/node/pull/40653#event-5539990151 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Oct 31, 2021
| https://github.com/nodejs/node/pull/40653#pullrequestreview-793757925 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/40653/files |
| lib/stream/promises.js | https://github.com/nodejs/node/pull/40653/files#diff-241fa22640048b6a147dec92f1ebf253043a1c4c342c7e52402112eb3c58f8fb |
| Please reload this page | https://github.com/nodejs/node/pull/40653 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Nov 1, 2021
| https://github.com/nodejs/node/pull/40653#ref-issue-1040920440 |
|
pipeline deadlock with readable tail?
#40685
| https://github.com/nodejs/node/issues/40685 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Nov 4, 2021 | https://github.com/nodejs/node/pull/40653#event-5571040020 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/aea84c28255585a735410f1482e13019eeafdd0e..088af2a0b88a1ff367a2b812fc83e4aea54940e2 |
| aea84c2 | https://github.com/nodejs/node/commit/aea84c28255585a735410f1482e13019eeafdd0e |
| 088af2a | https://github.com/nodejs/node/commit/088af2a0b88a1ff367a2b812fc83e4aea54940e2 |
|
Compare
| https://github.com/nodejs/node/compare/aea84c28255585a735410f1482e13019eeafdd0e..088af2a0b88a1ff367a2b812fc83e4aea54940e2 |
| November 4, 2021 20:57 | https://github.com/nodejs/node/pull/40653#event-5571040038 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 4, 2021 | https://github.com/nodejs/node/pull/40653#event-5571055135 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 4, 2021 | https://github.com/nodejs/node/pull/40653#issuecomment-961418079 |
| https://ci.nodejs.org/job/node-test-pull-request/40715/ | https://ci.nodejs.org/job/node-test-pull-request/40715/ |
| Please reload this page | https://github.com/nodejs/node/pull/40653 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Nov 4, 2021
| https://github.com/nodejs/node/pull/40653#pullrequestreview-798276613 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/40653/files/088af2a0b88a1ff367a2b812fc83e4aea54940e2 |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/40653#pullrequestreview-798276613 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/40653 |
|
CI Reliability 2021-11-05
nodejs/reliability#108
| https://github.com/nodejs/reliability/issues/108 |
|
CI Reliability 2021-11-06
nodejs/reliability#109
| https://github.com/nodejs/reliability/issues/109 |
|
CI Reliability 2021-11-07
nodejs/reliability#110
| https://github.com/nodejs/reliability/issues/110 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Nov 7, 2021 | https://github.com/nodejs/node/pull/40653#event-5579414962 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Nov 7, 2021 | https://github.com/nodejs/node/pull/40653#issuecomment-962663240 |
| Please reload this page | https://github.com/nodejs/node/pull/40653 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Nov 8, 2021
| https://github.com/nodejs/node/pull/40653#ref-issue-1046886901 |
|
CI Reliability 2021-11-08
nodejs/reliability#111
| https://github.com/nodejs/reliability/issues/111 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Nov 8, 2021
| https://github.com/nodejs/node/pull/40653#ref-pullrequest-1010276440 |
|
esm: add support for JSON import assertion
#40250
| https://github.com/nodejs/node/pull/40250 |
|
CI Reliability 2021-11-09
nodejs/reliability#112
| https://github.com/nodejs/reliability/issues/112 |
|
CI Reliability 2021-11-10
nodejs/reliability#113
| https://github.com/nodejs/reliability/issues/113 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F40653 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/40653/files/aea84c28255585a735410f1482e13019eeafdd0e |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/40653/files/088af2a0b88a1ff367a2b812fc83e4aea54940e2 |
|
| https://github.com/Mesteery |
|
Mesteery
| https://github.com/Mesteery |
|
| https://github.com/nodejs/node/pull/40653/files/088af2a0b88a1ff367a2b812fc83e4aea54940e2 |
| Please reload this page | https://github.com/nodejs/node/pull/40653 |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Please reload this page | https://github.com/nodejs/node/pull/40653 |
|
| https://github.com/ronag |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mcollina |
|
| https://github.com/lpinca |
|
| https://github.com/Mesteery |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |