René's URL Explorer Experiment


Title: module: add a condition to if in case of a bug. by iam-frankqiu · Pull Request #40549 · nodejs/node · GitHub

Open Graph Title: module: add a condition to if in case of a bug. by iam-frankqiu · Pull Request #40549 · nodejs/node

X Title: module: add a condition to if in case of a bug. by iam-frankqiu · Pull Request #40549 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: If the extension does not belong to the legacyExtensionFormatMap, It should throw an Error. I add it in case of a bug.

X Description: If the extension does not belong to the legacyExtensionFormatMap, It should throw an Error. I add it in case of a bug.

Opengraph URL: https://github.com/nodejs/node/pull/40549

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:67349539-5e0c-3c98-cd90-12df50037f0b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id982A:23BD59:446CA57:5A35F36:6992F3F6
html-safe-noncecaa03959df85ae6d77a4c876d0c508dee36b1ba3b04b7d39418a752a5c0c8041
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODJBOjIzQkQ1OTo0NDZDQTU3OjVBMzVGMzY6Njk5MkYzRjYiLCJ2aXNpdG9yX2lkIjoiNDg4MzUwNzI4OTExMjM3NjMxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9bd0bc80e2760b9fb2fb5794272cfb0a5ebb8c3fa9d452da5dd9f677ca2c2ab7
hovercard-subject-tagpull_request:763369077
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/40549/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ee2dcedb0f6abe11f9d8ed523db850f428fb11cbedeabe74ee1afed097b9ab15/nodejs/node/pull/40549
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ee2dcedb0f6abe11f9d8ed523db850f428fb11cbedeabe74ee1afed097b9ab15/nodejs/node/pull/40549
og:image:altIf the extension does not belong to the legacyExtensionFormatMap, It should throw an Error. I add it in case of a bug.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameiam-frankqiu
hostnamegithub.com
expected-hostnamegithub.com
None348cc0594c4976eb4050dc9547ecf65057ee89a2b7ed0652b983b9b539f57145
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasece72317238c729e85014e1d867fd30d09b7f94ba
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/40549#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F40549
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F40549
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/40549
Reloadhttps://github.com/nodejs/node/pull/40549
Reloadhttps://github.com/nodejs/node/pull/40549
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/40549
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 714 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
iam-frankqiuhttps://github.com/iam-frankqiu
nodejs:mainhttps://github.com/nodejs/node/tree/main
iam-frankqiu:refactor_get_formathttps://github.com/iam-frankqiu/node/tree/refactor_get_format
Conversationhttps://github.com/nodejs/node/pull/40549
Commits6 (6)https://github.com/nodejs/node/pull/40549/commits
Checkshttps://github.com/nodejs/node/pull/40549/checks
Files changedhttps://github.com/nodejs/node/pull/40549/files
module: add a condition to if in case of a bug.https://github.com/nodejs/node/pull/40549#top
iam-frankqiuhttps://github.com/iam-frankqiu
nodejs:mainhttps://github.com/nodejs/node/tree/main
iam-frankqiu:refactor_get_formathttps://github.com/iam-frankqiu/node/tree/refactor_get_format
https://github.com/iam-frankqiu
iam-frankqiuhttps://github.com/iam-frankqiu
Oct 21, 2021https://github.com/nodejs/node/pull/40549#issue-1032604863
Please reload this pagehttps://github.com/nodejs/node/pull/40549
Please reload this pagehttps://github.com/nodejs/node/pull/40549
iam-frankqiuhttps://github.com/iam-frankqiu
October 21, 2021 22:43https://github.com/nodejs/node/pull/40549#commits-pushed-5e7d26e
https://github.com/iam-frankqiu
module: refactor get_formathttps://github.com/nodejs/node/pull/40549/commits/5e7d26ec0035607bab9abf1247f5666764c1497a
5e7d26ehttps://github.com/nodejs/node/pull/40549/commits/5e7d26ec0035607bab9abf1247f5666764c1497a
https://github.com/iam-frankqiu
module: fix bughttps://github.com/nodejs/node/pull/40549/commits/c52be618e6be0fb91032b53a0feffed6220e7abc
c52be61https://github.com/nodejs/node/pull/40549/commits/c52be618e6be0fb91032b53a0feffed6220e7abc
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Oct 21, 2021https://github.com/nodejs/node/pull/40549#event-5499224930
https://github.com/iam-frankqiu
iam-frankqiuhttps://github.com/iam-frankqiu
GeoffreyBoothhttps://github.com/GeoffreyBooth
October 21, 2021 15:08https://github.com/nodejs/node/pull/40549#event-5499291194
https://github.com/Ayase-252
Ayase-252https://github.com/Ayase-252
Oct 21, 2021 https://github.com/nodejs/node/pull/40549#pullrequestreview-785861201
View reviewed changes https://github.com/nodejs/node/pull/40549/files/c52be618e6be0fb91032b53a0feffed6220e7abc
lib/internal/modules/esm/get_format.jshttps://github.com/nodejs/node/pull/40549/files/c52be618e6be0fb91032b53a0feffed6220e7abc#diff-06da79a2469f62bfb7c1fac61435050f80d8b93c3221026c02e423f38063d11f
Please reload this pagehttps://github.com/nodejs/node/pull/40549
lib/internal/modules/esm/get_format.jshttps://github.com/nodejs/node/pull/40549/files/c52be618e6be0fb91032b53a0feffed6220e7abc#diff-06da79a2469f62bfb7c1fac61435050f80d8b93c3221026c02e423f38063d11f
Please reload this pagehttps://github.com/nodejs/node/pull/40549
https://github.com/GeoffreyBooth
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F40549
https://github.com/iam-frankqiu
esm: add a condition to ifhttps://github.com/nodejs/node/pull/40549/commits/1d612d49ca127f2e1fd6179174aef83a3039f85d
1d612d4https://github.com/nodejs/node/pull/40549/commits/1d612d49ca127f2e1fd6179174aef83a3039f85d
https://github.com/iam-frankqiu
iam-frankqiuhttps://github.com/iam-frankqiu
Ayase-252https://github.com/Ayase-252
October 27, 2021 14:39https://github.com/nodejs/node/pull/40549#event-5527998979
https://github.com/iam-frankqiu
iam-frankqiuhttps://github.com/iam-frankqiu
Oct 27, 2021https://github.com/nodejs/node/pull/40549#event-5528005263
https://github.com/iam-frankqiu
iam-frankqiuhttps://github.com/iam-frankqiu
Oct 27, 2021https://github.com/nodejs/node/pull/40549#event-5528028095
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Oct 27, 2021https://github.com/nodejs/node/pull/40549#issuecomment-953140561
Please reload this pagehttps://github.com/nodejs/node/pull/40549
https://github.com/iam-frankqiu
iam-frankqiuhttps://github.com/iam-frankqiu
Oct 28, 2021https://github.com/nodejs/node/pull/40549#issuecomment-953785881
Please reload this pagehttps://github.com/nodejs/node/pull/40549
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Oct 28, 2021https://github.com/nodejs/node/pull/40549#issuecomment-954010876
Please reload this pagehttps://github.com/nodejs/node/pull/40549
https://github.com/iam-frankqiu
iam-frankqiuhttps://github.com/iam-frankqiu
Nov 1, 2021https://github.com/nodejs/node/pull/40549#issuecomment-956087429
Please reload this pagehttps://github.com/nodejs/node/pull/40549
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Nov 1, 2021https://github.com/nodejs/node/pull/40549#issuecomment-956433175
Please reload this pagehttps://github.com/nodejs/node/pull/40549
https://github.com/iam-frankqiu
module: add some testshttps://github.com/nodejs/node/pull/40549/commits/d781db949dd894ec80489d1790d603c75208ae6f
d781db9https://github.com/nodejs/node/pull/40549/commits/d781db949dd894ec80489d1790d603c75208ae6f
https://github.com/iam-frankqiu
iam-frankqiuhttps://github.com/iam-frankqiu
Nov 2, 2021https://github.com/nodejs/node/pull/40549#issuecomment-957146522
Please reload this pagehttps://github.com/nodejs/node/pull/40549
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Nov 2, 2021 https://github.com/nodejs/node/pull/40549#pullrequestreview-795378291
View reviewed changes https://github.com/nodejs/node/pull/40549/files/d781db949dd894ec80489d1790d603c75208ae6f
GeoffreyBoothhttps://github.com/GeoffreyBooth
https://github.com/nodejs/node/pull/40549#pullrequestreview-795378291
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/40549
https://github.com/iam-frankqiu
module: fix lint errhttps://github.com/nodejs/node/pull/40549/commits/e54325a39c74cf53fc972a850dafbe88028fcdcd
e54325ahttps://github.com/nodejs/node/pull/40549/commits/e54325a39c74cf53fc972a850dafbe88028fcdcd
https://github.com/iam-frankqiu
iam-frankqiuhttps://github.com/iam-frankqiu
Nov 3, 2021https://github.com/nodejs/node/pull/40549#issuecomment-958684970
#40549 (comment)https://github.com/nodejs/node/pull/40549#issue-1032604863
Please reload this pagehttps://github.com/nodejs/node/pull/40549
https://github.com/iam-frankqiu
iam-frankqiuhttps://github.com/iam-frankqiu
GeoffreyBoothhttps://github.com/GeoffreyBooth
November 3, 2021 06:33https://github.com/nodejs/node/pull/40549#event-5559788187
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Nov 3, 2021https://github.com/nodejs/node/pull/40549#issuecomment-959937882
Please reload this pagehttps://github.com/nodejs/node/pull/40549
https://github.com/iam-frankqiu
iam-frankqiuhttps://github.com/iam-frankqiu
Nov 27, 2021https://github.com/nodejs/node/pull/40549#issuecomment-980486551
Please reload this pagehttps://github.com/nodejs/node/pull/40549
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Nov 27, 2021https://github.com/nodejs/node/pull/40549#issuecomment-980493621
Please reload this pagehttps://github.com/nodejs/node/pull/40549
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 29, 2021 https://github.com/nodejs/node/pull/40549#pullrequestreview-817903470
View reviewed changes https://github.com/nodejs/node/pull/40549/files/e54325a39c74cf53fc972a850dafbe88028fcdcd
lib/internal/modules/esm/get_format.jshttps://github.com/nodejs/node/pull/40549/files/e54325a39c74cf53fc972a850dafbe88028fcdcd#diff-06da79a2469f62bfb7c1fac61435050f80d8b93c3221026c02e423f38063d11f
Please reload this pagehttps://github.com/nodejs/node/pull/40549
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 29, 2021 https://github.com/nodejs/node/pull/40549#pullrequestreview-817904397
View reviewed changes https://github.com/nodejs/node/pull/40549/files/e54325a39c74cf53fc972a850dafbe88028fcdcd
https://github.com/iam-frankqiu
module: fix lint errhttps://github.com/nodejs/node/pull/40549/commits/8d330e26714be59ce5ad767db2543a5f96eb5a41
8d330e2https://github.com/nodejs/node/pull/40549/commits/8d330e26714be59ce5ad767db2543a5f96eb5a41
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Nov 29, 2021 https://github.com/nodejs/node/pull/40549#pullrequestreview-817987634
View reviewed changes https://github.com/nodejs/node/pull/40549/files/8d330e26714be59ce5ad767db2543a5f96eb5a41
GeoffreyBoothhttps://github.com/GeoffreyBooth
https://github.com/nodejs/node/pull/40549#pullrequestreview-817987634
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/40549
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/2d76238f9184c9009bfa395848a120ac3e5b98e5..ca3ed363ffefa4819c1414aff7ffca34b53a7b95
2d76238https://github.com/nodejs/node/commit/2d76238f9184c9009bfa395848a120ac3e5b98e5
ca3ed36https://github.com/nodejs/node/commit/ca3ed363ffefa4819c1414aff7ffca34b53a7b95
Compare https://github.com/nodejs/node/compare/2d76238f9184c9009bfa395848a120ac3e5b98e5..ca3ed363ffefa4819c1414aff7ffca34b53a7b95
November 12, 2022 01:49https://github.com/nodejs/node/pull/40549#event-7795751520
https://github.com/aduh95
aduh95https://github.com/aduh95
Apr 22, 2023 https://github.com/nodejs/node/pull/40549#pullrequestreview-1396666811
View reviewed changes https://github.com/nodejs/node/pull/40549/files/8d330e26714be59ce5ad767db2543a5f96eb5a41
test/es-module/test-esm-get-format.jshttps://github.com/nodejs/node/pull/40549/files/8d330e26714be59ce5ad767db2543a5f96eb5a41#diff-85b05c0f32b427dfd395e9204d8e7fd865dc972c68557707fa191c6766f57f58
aduh95https://github.com/aduh95
Apr 22, 2023https://github.com/nodejs/node/pull/40549#discussion_r1174363553
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/40549
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F40549
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/40549/files/8d330e26714be59ce5ad767db2543a5f96eb5a41
https://github.com/GeoffreyBooth
GeoffreyBooth https://github.com/GeoffreyBooth
https://github.com/nodejs/node/pull/40549/files/8d330e26714be59ce5ad767db2543a5f96eb5a41
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/40549/files/e54325a39c74cf53fc972a850dafbe88028fcdcd
https://github.com/Ayase-252
Ayase-252 https://github.com/Ayase-252
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/40549
https://github.com/iam-frankqiu
https://github.com/GeoffreyBooth
https://github.com/jasnell
https://github.com/Ayase-252
https://github.com/aduh95
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.