René's URL Explorer Experiment


Title: doc: clarify that ObjectWrap requires manual cleanup on shutdown by Flarna · Pull Request #40074 · nodejs/node · GitHub

Open Graph Title: doc: clarify that ObjectWrap requires manual cleanup on shutdown by Flarna · Pull Request #40074 · nodejs/node

X Title: doc: clarify that ObjectWrap requires manual cleanup on shutdown by Flarna · Pull Request #40074 · nodejs/node

Description: Clarify that ObjectWrap instances are not destroyed on process or worker shutdown and require manual destruction to avoid resource leaks. fixes: #38816

Open Graph Description: Clarify that ObjectWrap instances are not destroyed on process or worker shutdown and require manual destruction to avoid resource leaks. fixes: #38816

X Description: Clarify that ObjectWrap instances are not destroyed on process or worker shutdown and require manual destruction to avoid resource leaks. fixes: #38816

Opengraph URL: https://github.com/nodejs/node/pull/40074

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5017f7d5-44e2-af33-b3cc-5b2043401f76
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBBAC:920F1:9BBBEB:DDFF1A:696A5CD7
html-safe-nonce43a12c698926c3e0791b0ab736976f0123acbbd7a3c1b893b55146aace840153
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQkFDOjkyMEYxOjlCQkJFQjpEREZGMUE6Njk2QTVDRDciLCJ2aXNpdG9yX2lkIjoiNDgyNjI0NTk1NjE5MDc1NjA1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc881715685caa5a21d1e5878f0bc639cbe4ae2d04783c7d68f9560f4a0dba76e
hovercard-subject-tagpull_request:731670419
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/40074/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0d7c2af29af07615679e72696dacc4ca6ab67535daa15be59986b378bfd48e8c/nodejs/node/pull/40074
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0d7c2af29af07615679e72696dacc4ca6ab67535daa15be59986b378bfd48e8c/nodejs/node/pull/40074
og:image:altClarify that ObjectWrap instances are not destroyed on process or worker shutdown and require manual destruction to avoid resource leaks. fixes: #38816
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameFlarna
hostnamegithub.com
expected-hostnamegithub.com
None3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release63c426b30d262aba269ef14c40e3c817b384cd61
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/40074#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F40074
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F40074
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/40074
Reloadhttps://github.com/nodejs/node/pull/40074
Reloadhttps://github.com/nodejs/node/pull/40074
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/40074
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 695 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/40074
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/40074#issue-comment-box
Flarnahttps://github.com/Flarna
nodejs:masterhttps://github.com/nodejs/node/tree/master
Flarna:doc-objectwraphttps://github.com/Flarna/node/tree/doc-objectwrap
doc: clarify that ObjectWrap requires manual cleanup on shutdown https://github.com/nodejs/node/pull/40074#top
Flarnahttps://github.com/Flarna
nodejs:masterhttps://github.com/nodejs/node/tree/master
Flarna:doc-objectwraphttps://github.com/Flarna/node/tree/doc-objectwrap
Conversation 5 https://github.com/nodejs/node/pull/40074
Commits 2 https://github.com/nodejs/node/pull/40074/commits
Checks 0 https://github.com/nodejs/node/pull/40074/checks
Files changed https://github.com/nodejs/node/pull/40074/files
Please reload this pagehttps://github.com/nodejs/node/pull/40074
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/Flarna
Flarnahttps://github.com/Flarna
Sep 10, 2021https://github.com/nodejs/node/pull/40074#issue-993492958
Please reload this pagehttps://github.com/nodejs/node/pull/40074
#38816https://github.com/nodejs/node/issues/38816
Please reload this pagehttps://github.com/nodejs/node/pull/40074
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
addons https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aaddons
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
Sep 10, 2021https://github.com/nodejs/node/pull/40074#event-5285979472
https://github.com/Flarna
Flarnahttps://github.com/Flarna
force-pushedhttps://github.com/nodejs/node/compare/eb1e2c84c2c9ebe722b14c70f5a4954e499a65e4..618e642bc34d2bfb5570943ac620763505860994
eb1e2c8https://github.com/nodejs/node/commit/eb1e2c84c2c9ebe722b14c70f5a4954e499a65e4
618e642https://github.com/nodejs/node/commit/618e642bc34d2bfb5570943ac620763505860994
Compare https://github.com/nodejs/node/compare/eb1e2c84c2c9ebe722b14c70f5a4954e499a65e4..618e642bc34d2bfb5570943ac620763505860994
September 10, 2021 18:51https://github.com/nodejs/node/pull/40074#event-5286041684
https://github.com/Flarna
Flarnahttps://github.com/Flarna
Sep 10, 2021https://github.com/nodejs/node/pull/40074#event-5286054912
https://github.com/Flarna
doc: clarify that ObjectWrap requires manual cleanup on shutdownhttps://github.com/nodejs/node/pull/40074/commits/3146ba1b8492d5ca5a69fa2e4192133165a2275f
3146ba1https://github.com/nodejs/node/pull/40074/commits/3146ba1b8492d5ca5a69fa2e4192133165a2275f
https://github.com/Flarna
Flarnahttps://github.com/Flarna
force-pushedhttps://github.com/nodejs/node/compare/618e642bc34d2bfb5570943ac620763505860994..3146ba1b8492d5ca5a69fa2e4192133165a2275f
618e642https://github.com/nodejs/node/commit/618e642bc34d2bfb5570943ac620763505860994
3146ba1https://github.com/nodejs/node/commit/3146ba1b8492d5ca5a69fa2e4192133165a2275f
Compare https://github.com/nodejs/node/compare/618e642bc34d2bfb5570943ac620763505860994..3146ba1b8492d5ca5a69fa2e4192133165a2275f
September 10, 2021 19:32https://github.com/nodejs/node/pull/40074#event-5286214619
https://github.com/lpinca
lpincahttps://github.com/lpinca
Sep 10, 2021 https://github.com/nodejs/node/pull/40074#pullrequestreview-751735540
View reviewed changes https://github.com/nodejs/node/pull/40074/files/3146ba1b8492d5ca5a69fa2e4192133165a2275f
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Sep 11, 2021 https://github.com/nodejs/node/pull/40074#pullrequestreview-751879485
View reviewed changes https://github.com/nodejs/node/pull/40074/files/3146ba1b8492d5ca5a69fa2e4192133165a2275f
doc/api/addons.mdhttps://github.com/nodejs/node/pull/40074/files/3146ba1b8492d5ca5a69fa2e4192133165a2275f#diff-b69022a2f4c4470619fe1ef734ae88813c5e5f3d5603da7452bdd300b6d27579
Please reload this pagehttps://github.com/nodejs/node/pull/40074
https://github.com/Flarna
fixup! doc: clarify that ObjectWrap requires manual cleanup on shutdownhttps://github.com/nodejs/node/pull/40074/commits/8ed33ec57578688c6de132034f4eb4b290bd0a27
8ed33echttps://github.com/nodejs/node/pull/40074/commits/8ed33ec57578688c6de132034f4eb4b290bd0a27
https://github.com/Flarna
Flarnahttps://github.com/Flarna
force-pushedhttps://github.com/nodejs/node/compare/ff8d9d32394b026fd3505c0eb9a38062beb42b8e..8ed33ec57578688c6de132034f4eb4b290bd0a27
ff8d9d3https://github.com/nodejs/node/commit/ff8d9d32394b026fd3505c0eb9a38062beb42b8e
8ed33echttps://github.com/nodejs/node/commit/8ed33ec57578688c6de132034f4eb4b290bd0a27
Compare https://github.com/nodejs/node/compare/ff8d9d32394b026fd3505c0eb9a38062beb42b8e..8ed33ec57578688c6de132034f4eb4b290bd0a27
September 11, 2021 18:33https://github.com/nodejs/node/pull/40074#event-5287829441
https://github.com/Flarna
Flarnahttps://github.com/Flarna
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Sep 11, 2021https://github.com/nodejs/node/pull/40074#event-5287850012
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Sep 14, 2021 https://github.com/nodejs/node/pull/40074#pullrequestreview-754097664
View reviewed changes https://github.com/nodejs/node/pull/40074/files/8ed33ec57578688c6de132034f4eb4b290bd0a27
doc/api/addons.mdhttps://github.com/nodejs/node/pull/40074/files/8ed33ec57578688c6de132034f4eb4b290bd0a27#diff-b69022a2f4c4470619fe1ef734ae88813c5e5f3d5603da7452bdd300b6d27579
Please reload this pagehttps://github.com/nodejs/node/pull/40074
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 15, 2021 https://github.com/nodejs/node/pull/40074#pullrequestreview-755239752
View reviewed changes https://github.com/nodejs/node/pull/40074/files/8ed33ec57578688c6de132034f4eb4b290bd0a27
https://github.com/Flarna
Flarnahttps://github.com/Flarna
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 15, 2021https://github.com/nodejs/node/pull/40074#event-5306631295
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 15, 2021https://github.com/nodejs/node/pull/40074#event-5306648463
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 15, 2021https://github.com/nodejs/node/pull/40074#issuecomment-920102704
8468bdb...7b4e6d4https://github.com/nodejs/node/compare/8468bdbefce8c8a5f93d9181c1b4aec62c583194...7b4e6d4772e635670d70433b93f719ab31783598
Please reload this pagehttps://github.com/nodejs/node/pull/40074
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 15, 2021https://github.com/nodejs/node/pull/40074#event-5306649172
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 15, 2021 https://github.com/nodejs/node/pull/40074#ref-commit-7b4e6d4
https://github.com/Flarna
https://github.com/nodejs-github-bot
doc: clarify that ObjectWrap requires manual cleanup on shutdownhttps://github.com/nodejs/node/commit/7b4e6d4772e635670d70433b93f719ab31783598
7b4e6d4https://github.com/nodejs/node/commit/7b4e6d4772e635670d70433b93f719ab31783598
#40074https://github.com/nodejs/node/pull/40074
#38816https://github.com/nodejs/node/issues/38816
https://github.com/Flarna
Flarnahttps://github.com/Flarna
September 15, 2021 15:08https://github.com/nodejs/node/pull/40074#event-5306682272
BethGriggshttps://github.com/BethGriggs
Sep 21, 2021 https://github.com/nodejs/node/pull/40074#ref-commit-16d903e
https://github.com/Flarna
https://github.com/BethGriggs
doc: clarify that ObjectWrap requires manual cleanup on shutdownhttps://github.com/nodejs/node/commit/16d903e56a56d8ee04d20e904d8bcaf0951ffe1e
16d903ehttps://github.com/nodejs/node/commit/16d903e56a56d8ee04d20e904d8bcaf0951ffe1e
#40074https://github.com/nodejs/node/pull/40074
#38816https://github.com/nodejs/node/issues/38816
BethGriggshttps://github.com/BethGriggs
Sep 21, 2021 https://github.com/nodejs/node/pull/40074#ref-commit-81cb14b
https://github.com/Flarna
https://github.com/BethGriggs
doc: clarify that ObjectWrap requires manual cleanup on shutdownhttps://github.com/nodejs/node/commit/81cb14bb589947e1e2e1de7459e549f7309734d4
81cb14bhttps://github.com/nodejs/node/commit/81cb14bb589947e1e2e1de7459e549f7309734d4
#40074https://github.com/nodejs/node/pull/40074
#38816https://github.com/nodejs/node/issues/38816
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Sep 21, 2021 https://github.com/nodejs/node/pull/40074#ref-pullrequest-1003497628
v16.10.0 proposal #40175 https://github.com/nodejs/node/pull/40175
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F40074
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/40074/files/8ed33ec57578688c6de132034f4eb4b290bd0a27
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/40074/files/8ed33ec57578688c6de132034f4eb4b290bd0a27
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/40074/files/3146ba1b8492d5ca5a69fa2e4192133165a2275f
https://github.com/mscdex
mscdex https://github.com/mscdex
https://github.com/nodejs/node/pull/40074/files/3146ba1b8492d5ca5a69fa2e4192133165a2275f
addons https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aaddons
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
memleak using worker and objects wrapping c++ instances https://github.com/nodejs/node/issues/38816
Please reload this pagehttps://github.com/nodejs/node/pull/40074
https://github.com/Flarna
https://github.com/mscdex
https://github.com/jasnell
https://github.com/lpinca
https://github.com/mhdawson
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.