| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6ff4c99c-5192-2ddf-1653-27d27fb4521c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8A0E:3856C7:BE04F:109EDC:696A3DDA |
| html-safe-nonce | aeecd7b205d79c27dd6cdf0a794bff9a7333ed5b7a6a7c461eaac00457c51622 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTBFOjM4NTZDNzpCRTA0RjoxMDlFREM6Njk2QTNEREEiLCJ2aXNpdG9yX2lkIjoiMjI4Mzg4MjQyNjU4NTk4ODU3MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ff5d0e88914985814e101f444b8165871bd3791731858fd758185888c06ce667 |
| hovercard-subject-tag | pull_request:731372132 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/40065/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/da7cbd373077ac47f79c54a6f3d5f5f5dd9c7b06704275e28979389ae24c25f6/nodejs/node/pull/40065 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/da7cbd373077ac47f79c54a6f3d5f5f5dd9c7b06704275e28979389ae24c25f6/nodejs/node/pull/40065 |
| og:image:alt | This has been flaky for a long time.
Refs: #38226 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | richardlau |
| hostname | github.com |
| expected-hostname | github.com |
| None | 321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 13581a31d51edf4a3aca179e10890a4d4f9b6d76 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/40065#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F40065 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F40065 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/40065 |
| Reload | https://github.com/nodejs/node/pull/40065 |
| Reload | https://github.com/nodejs/node/pull/40065 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/40065 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
694
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/40065 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/40065#issue-comment-box |
| richardlau | https://github.com/richardlau |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| richardlau:cryptotiming | https://github.com/richardlau/node-1/tree/cryptotiming |
|
test: mark test-crypto-timing-safe-equal-benchmarks flaky
| https://github.com/nodejs/node/pull/40065#top |
| richardlau | https://github.com/richardlau |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| richardlau:cryptotiming | https://github.com/richardlau/node-1/tree/cryptotiming |
|
Conversation
4
| https://github.com/nodejs/node/pull/40065 |
|
Commits
1
| https://github.com/nodejs/node/pull/40065/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/40065/checks |
|
Files changed
| https://github.com/nodejs/node/pull/40065/files |
| Please reload this page | https://github.com/nodejs/node/pull/40065 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Sep 10, 2021 | https://github.com/nodejs/node/pull/40065#issue-993140448 |
| #38226 | https://github.com/nodejs/node/issues/38226 |
| Please reload this page | https://github.com/nodejs/node/pull/40065 |
|
| https://github.com/richardlau |
| test: mark test-crypto-timing-safe-equal-benchmarks flaky | https://github.com/nodejs/node/pull/40065/commits/fbe6085297b25fd730608a2667fa89663b352d88 |
| fbe6085 | https://github.com/nodejs/node/pull/40065/commits/fbe6085297b25fd730608a2667fa89663b352d88 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 10, 2021 | https://github.com/nodejs/node/pull/40065#event-5283907121 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Sep 10, 2021 | https://github.com/nodejs/node/pull/40065#event-5283907315 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Sep 10, 2021
| https://github.com/nodejs/node/pull/40065#ref-issue-856965254 |
|
investigate flaky test-crypto-timing-safe-equal-benchmarks
#38226
| https://github.com/nodejs/node/issues/38226 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 10, 2021 | https://github.com/nodejs/node/pull/40065#event-5283936924 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 10, 2021 | https://github.com/nodejs/node/pull/40065#issuecomment-916832985 |
| https://ci.nodejs.org/job/node-test-pull-request/39898/ | https://ci.nodejs.org/job/node-test-pull-request/39898/ |
| Please reload this page | https://github.com/nodejs/node/pull/40065 |
| https://github.com/AshCripps |
| AshCripps | https://github.com/AshCripps |
|
Sep 10, 2021
| https://github.com/nodejs/node/pull/40065#pullrequestreview-751313514 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/40065/files/fbe6085297b25fd730608a2667fa89663b352d88 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Sep 10, 2021 | https://github.com/nodejs/node/pull/40065#issuecomment-916845927 |
| https://ci.nodejs.org/job/node-test-commit-linuxone/28795/nodes=rhel7-s390x/testReport/(root)/test/pummel_test_crypto_timing_safe_equal_benchmarks_/ | https://ci.nodejs.org/job/node-test-commit-linuxone/28795/nodes=rhel7-s390x/testReport/(root)/test/pummel_test_crypto_timing_safe_equal_benchmarks_/ |
| Please reload this page | https://github.com/nodejs/node/pull/40065 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Sep 10, 2021
| https://github.com/nodejs/node/pull/40065#pullrequestreview-751538974 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/40065/files/fbe6085297b25fd730608a2667fa89663b352d88 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Sep 10, 2021 | https://github.com/nodejs/node/pull/40065#event-5285188577 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Sep 10, 2021
| https://github.com/nodejs/node/pull/40065#pullrequestreview-751606650 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/40065/files/fbe6085297b25fd730608a2667fa89663b352d88 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Sep 10, 2021
| https://github.com/nodejs/node/pull/40065#pullrequestreview-751668413 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/40065/files/fbe6085297b25fd730608a2667fa89663b352d88 |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node/pull/40065#pullrequestreview-751668413 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/40065 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Sep 12, 2021
| https://github.com/nodejs/node/pull/40065#pullrequestreview-752146967 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/40065/files/fbe6085297b25fd730608a2667fa89663b352d88 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Sep 12, 2021 | https://github.com/nodejs/node/pull/40065#event-5289471636 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Sep 12, 2021 | https://github.com/nodejs/node/pull/40065#event-5289477157 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Sep 12, 2021 | https://github.com/nodejs/node/pull/40065#issuecomment-917687908 |
| Please reload this page | https://github.com/nodejs/node/pull/40065 |
| b6ac7e6 | https://github.com/nodejs/node/commit/b6ac7e6919b06ab604cc11c45f190b36c95c727f |
| Please reload this page | https://github.com/nodejs/node/pull/40065 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Sep 12, 2021 | https://github.com/nodejs/node/pull/40065#event-5289477316 |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
Sep 12, 2021
| https://github.com/nodejs/node/pull/40065#ref-commit-2e4fc8e |
|
| https://github.com/richardlau |
|
| https://github.com/nodejs-github-bot |
| test: mark test-crypto-timing-safe-equal-benchmarks flaky | https://github.com/nodejs/node/commit/2e4fc8ede7c3c251d7a911914c1a967efba2b56d |
| 2e4fc8e | https://github.com/nodejs/node/commit/2e4fc8ede7c3c251d7a911914c1a967efba2b56d |
| #40065 | https://github.com/nodejs/node/pull/40065 |
| #38226 | https://github.com/nodejs/node/issues/38226 |
| aduh95 | https://github.com/aduh95 |
|
Sep 12, 2021
| https://github.com/nodejs/node/pull/40065#ref-commit-b6ac7e6 |
|
| https://github.com/richardlau |
|
| https://github.com/aduh95 |
| test: mark test-crypto-timing-safe-equal-benchmarks flaky | https://github.com/nodejs/node/commit/b6ac7e6919b06ab604cc11c45f190b36c95c727f |
| b6ac7e6 | https://github.com/nodejs/node/commit/b6ac7e6919b06ab604cc11c45f190b36c95c727f |
| #40065 | https://github.com/nodejs/node/pull/40065 |
| #38226 | https://github.com/nodejs/node/issues/38226 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| September 12, 2021 19:34 | https://github.com/nodejs/node/pull/40065#event-5289526284 |
| BethGriggs | https://github.com/BethGriggs |
|
Sep 21, 2021
| https://github.com/nodejs/node/pull/40065#ref-commit-04efafd |
|
| https://github.com/richardlau |
|
| https://github.com/BethGriggs |
| test: mark test-crypto-timing-safe-equal-benchmarks flaky | https://github.com/nodejs/node/commit/04efafd8bc4a7302ae3af7d2e86476def687893e |
| 04efafd | https://github.com/nodejs/node/commit/04efafd8bc4a7302ae3af7d2e86476def687893e |
| #40065 | https://github.com/nodejs/node/pull/40065 |
| #38226 | https://github.com/nodejs/node/issues/38226 |
| BethGriggs | https://github.com/BethGriggs |
|
Sep 21, 2021
| https://github.com/nodejs/node/pull/40065#ref-commit-4367a61 |
|
| https://github.com/richardlau |
|
| https://github.com/BethGriggs |
| test: mark test-crypto-timing-safe-equal-benchmarks flaky | https://github.com/nodejs/node/commit/4367a61a9b0a9bfabdf25fb23204158ef6b5daa6 |
| 4367a61 | https://github.com/nodejs/node/commit/4367a61a9b0a9bfabdf25fb23204158ef6b5daa6 |
| #40065 | https://github.com/nodejs/node/pull/40065 |
| #38226 | https://github.com/nodejs/node/issues/38226 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Sep 21, 2021
| https://github.com/nodejs/node/pull/40065#ref-pullrequest-1003497628 |
|
v16.10.0 proposal
#40175
| https://github.com/nodejs/node/pull/40175 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F40065 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/40065/files/fbe6085297b25fd730608a2667fa89663b352d88 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/40065/files/fbe6085297b25fd730608a2667fa89663b352d88 |
|
| https://github.com/tniessen |
|
tniessen
| https://github.com/tniessen |
|
| https://github.com/nodejs/node/pull/40065/files/fbe6085297b25fd730608a2667fa89663b352d88 |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/40065/files/fbe6085297b25fd730608a2667fa89663b352d88 |
|
| https://github.com/AshCripps |
|
AshCripps
| https://github.com/AshCripps |
|
| https://github.com/nodejs/node/pull/40065/files/fbe6085297b25fd730608a2667fa89663b352d88 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/40065 |
|
| https://github.com/richardlau |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/jasnell |
|
| https://github.com/lpinca |
|
| https://github.com/tniessen |
|
| https://github.com/mhdawson |
|
| https://github.com/AshCripps |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |