| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4ae5bff1-f846-a5ba-4eb9-6a3eb0f486e4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AF0E:117B82:461963:6280D0:696A46DE |
| html-safe-nonce | 735a5ea4eddad31fdc09cc09770011969d6945557ef5fe2c889a4a3d795d6d20 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjBFOjExN0I4Mjo0NjE5NjM6NjI4MEQwOjY5NkE0NkRFIiwidmlzaXRvcl9pZCI6Ijg4MjYyNjQ2MTA4ODUyMjQxNTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 67a21617c9b5d96a623471d654a1b001cd352bd85bb7ebdd785fefb6279191a8 |
| hovercard-subject-tag | pull_request:723704379 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/39963/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5c195f946b8bc7401ca8513c67f65da90115b5ed59d98fe852b79c2a109f6c99/nodejs/node/pull/39963 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5c195f946b8bc7401ca8513c67f65da90115b5ed59d98fe852b79c2a109f6c99/nodejs/node/pull/39963 |
| og:image:alt | As a prerequisite for #39927 without any semverness, add missing "changes:" entries to the generateKeyPair(Sync) APIs.
Refs: #26774
Refs: #26960 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tniessen |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 63c426b30d262aba269ef14c40e3c817b384cd61 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/39963#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39963 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39963 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/39963 |
| Reload | https://github.com/nodejs/node/pull/39963 |
| Reload | https://github.com/nodejs/node/pull/39963 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/39963 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
694
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/39963 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/39963#issue-comment-box |
| tniessen | https://github.com/tniessen |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| tniessen:doc-missing-changes-generatekeypair | https://github.com/tniessen/node/tree/doc-missing-changes-generatekeypair |
|
doc: add missing changes to generateKeyPair(Sync)
| https://github.com/nodejs/node/pull/39963#top |
| tniessen | https://github.com/tniessen |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| tniessen:doc-missing-changes-generatekeypair | https://github.com/tniessen/node/tree/doc-missing-changes-generatekeypair |
|
Conversation
2
| https://github.com/nodejs/node/pull/39963 |
|
Commits
1
| https://github.com/nodejs/node/pull/39963/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/39963/checks |
|
Files changed
| https://github.com/nodejs/node/pull/39963/files |
| Please reload this page | https://github.com/nodejs/node/pull/39963 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Aug 31, 2021 | https://github.com/nodejs/node/pull/39963#issue-984248723 |
| #39927 | https://github.com/nodejs/node/pull/39927 |
| #26774 | https://github.com/nodejs/node/pull/26774 |
| #26960 | https://github.com/nodejs/node/pull/26960 |
| Please reload this page | https://github.com/nodejs/node/pull/39963 |
|
| https://github.com/tniessen |
| doc: add missing changes to generateKeyPair(Sync) | https://github.com/nodejs/node/pull/39963/commits/c519462e77eaa256bf1aa2f84d41e0dbce73f457 |
| c519462 | https://github.com/nodejs/node/pull/39963/commits/c519462e77eaa256bf1aa2f84d41e0dbce73f457 |
| nodejs#26774 | https://github.com/nodejs/node/pull/26774 |
| nodejs#26960 | https://github.com/nodejs/node/pull/26960 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| panva | https://github.com/panva |
| August 31, 2021 19:54 | https://github.com/nodejs/node/pull/39963#event-5234841619 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Aug 31, 2021 | https://github.com/nodejs/node/pull/39963#event-5234843230 |
| https://github.com/panva |
| panva | https://github.com/panva |
|
Aug 31, 2021
| https://github.com/nodejs/node/pull/39963#pullrequestreview-743139722 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/39963/files/c519462e77eaa256bf1aa2f84d41e0dbce73f457 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
| Aug 31, 2021 | https://github.com/nodejs/node/pull/39963#event-5234871989 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Aug 31, 2021 | https://github.com/nodejs/node/pull/39963#issuecomment-909574051 |
| @tniessen | https://github.com/tniessen |
| Please reload this page | https://github.com/nodejs/node/pull/39963 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Aug 31, 2021
| https://github.com/nodejs/node/pull/39963#pullrequestreview-743225558 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/39963/files/c519462e77eaa256bf1aa2f84d41e0dbce73f457 |
| panva | https://github.com/panva |
|
Sep 1, 2021
| https://github.com/nodejs/node/pull/39963#ref-commit-6155499 |
|
| https://github.com/tniessen |
|
| https://github.com/panva |
| doc: add missing changes to generateKeyPair(Sync) | https://github.com/nodejs/node/commit/6155499252199d12f1577c6e9321008e6cd9e89d |
| 6155499 | https://github.com/nodejs/node/commit/6155499252199d12f1577c6e9321008e6cd9e89d |
| #26774 | https://github.com/nodejs/node/pull/26774 |
| #26960 | https://github.com/nodejs/node/pull/26960 |
| #39963 | https://github.com/nodejs/node/pull/39963 |
| https://github.com/panva |
| panva | https://github.com/panva |
| Sep 1, 2021 | https://github.com/nodejs/node/pull/39963#issuecomment-909939726 |
| 6155499 | https://github.com/nodejs/node/commit/6155499252199d12f1577c6e9321008e6cd9e89d |
| Please reload this page | https://github.com/nodejs/node/pull/39963 |
| https://github.com/panva |
| panva | https://github.com/panva |
| Sep 1, 2021 | https://github.com/nodejs/node/pull/39963#event-5237062967 |
| targos | https://github.com/targos |
|
Sep 6, 2021
| https://github.com/nodejs/node/pull/39963#ref-commit-80e686d |
|
| https://github.com/tniessen |
|
| https://github.com/targos |
| doc: add missing changes to generateKeyPair(Sync) | https://github.com/nodejs/node/commit/80e686de807bb402aa4f890a7c4fcb60dc9ce2be |
| 80e686d | https://github.com/nodejs/node/commit/80e686de807bb402aa4f890a7c4fcb60dc9ce2be |
| #26774 | https://github.com/nodejs/node/pull/26774 |
| #26960 | https://github.com/nodejs/node/pull/26960 |
| #39963 | https://github.com/nodejs/node/pull/39963 |
| targos | https://github.com/targos |
|
Sep 6, 2021
| https://github.com/nodejs/node/pull/39963#ref-commit-fc01dd9 |
|
| https://github.com/tniessen |
|
| https://github.com/targos |
| doc: add missing changes to generateKeyPair(Sync) | https://github.com/nodejs/node/commit/fc01dd916e867c83dd92aa88e41407db4b3c8433 |
| fc01dd9 | https://github.com/nodejs/node/commit/fc01dd916e867c83dd92aa88e41407db4b3c8433 |
| #26774 | https://github.com/nodejs/node/pull/26774 |
| #26960 | https://github.com/nodejs/node/pull/26960 |
| #39963 | https://github.com/nodejs/node/pull/39963 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Sep 6, 2021
| https://github.com/nodejs/node/pull/39963#ref-pullrequest-988900582 |
|
v16.9.0 release proposal
#40011
| https://github.com/nodejs/node/pull/40011 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| October 7, 2021 16:42 | https://github.com/nodejs/node/pull/39963#event-5429817981 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39963 |
|
| https://github.com/panva |
|
panva
| https://github.com/panva |
|
| https://github.com/nodejs/node/pull/39963/files/c519462e77eaa256bf1aa2f84d41e0dbce73f457 |
|
| https://github.com/aduh95 |
|
aduh95
| https://github.com/aduh95 |
|
| https://github.com/nodejs/node/pull/39963/files/c519462e77eaa256bf1aa2f84d41e0dbce73f457 |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
| Please reload this page | https://github.com/nodejs/node/pull/39963 |
|
| https://github.com/tniessen |
|
| https://github.com/panva |
|
| https://github.com/aduh95 |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |