René's URL Explorer Experiment


Title: Fix: Invalid HTTP/2 origin set when servername is empty #39919 by Narasimha1997 · Pull Request #39934 · nodejs/node · GitHub

Open Graph Title: Fix: Invalid HTTP/2 origin set when servername is empty #39919 by Narasimha1997 · Pull Request #39934 · nodejs/node

X Title: Fix: Invalid HTTP/2 origin set when servername is empty #39919 by Narasimha1997 · Pull Request #39934 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: The bug posted by @szmarczak is because of not checking the truthy value of options.servername in line 3101 and 3102 of lib/internal/http2/core.js, instead the options.servername is strictly checke...

X Description: The bug posted by @szmarczak is because of not checking the truthy value of options.servername in line 3101 and 3102 of lib/internal/http2/core.js, instead the options.servername is strictly checke...

Opengraph URL: https://github.com/nodejs/node/pull/39934

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cdd521de-2baa-1e4b-4e9b-4f865a721046
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id97AE:EC2BF:FA0EC:16AB04:6A4DFB47
html-safe-nonce246eb14a24f57a54e2d280063cd4bb0a46c363e987695831f1cfc6f38f5502a8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5N0FFOkVDMkJGOkZBMEVDOjE2QUIwNDo2QTRERkI0NyIsInZpc2l0b3JfaWQiOiI4MDI5MTAyNjgyMDA5MzY5NDE1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6b3a188f829571e6d2e06e93c5260924825b4ea6067711896c9995933070354b
hovercard-subject-tagpull_request:721979569
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/39934/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/14e013ca5de16198797db6b22b7094a01000e70bb977a742c2655f86b8192d65/nodejs/node/pull/39934
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/14e013ca5de16198797db6b22b7094a01000e70bb977a742c2655f86b8192d65/nodejs/node/pull/39934
og:image:altThe bug posted by @szmarczak is because of not checking the truthy value of options.servername in line 3101 and 3102 of lib/internal/http2/core.js, instead the options.servername is strictly checke...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameNarasimha1997
hostnamegithub.com
expected-hostnamegithub.com
None5818716c93c6a2925b815402541a32814e43a7b1261c322b0c2df75224289566
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4314b1df11fa8a565684f3a72dc971e3785da365
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/39934#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39934
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39934
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/39934
Reloadhttps://github.com/nodejs/node/pull/39934
Reloadhttps://github.com/nodejs/node/pull/39934
Please reload this pagehttps://github.com/nodejs/node/pull/39934
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/39934
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Narasimha1997https://github.com/Narasimha1997
nodejs:mainhttps://github.com/nodejs/node/tree/main
Narasimha1997:fix-invalid-origin-sethttps://github.com/Narasimha1997/node/tree/fix-invalid-origin-set
Conversationhttps://github.com/nodejs/node/pull/39934
Commits1 (1)https://github.com/nodejs/node/pull/39934/commits
Checkshttps://github.com/nodejs/node/pull/39934/checks
Files changedhttps://github.com/nodejs/node/pull/39934/files
Fix: Invalid HTTP/2 origin set when servername is empty #39919https://github.com/nodejs/node/pull/39934#top
Narasimha1997https://github.com/Narasimha1997
nodejs:mainhttps://github.com/nodejs/node/tree/main
Narasimha1997:fix-invalid-origin-sethttps://github.com/Narasimha1997/node/tree/fix-invalid-origin-set
https://github.com/Narasimha1997
Narasimha1997https://github.com/Narasimha1997
Aug 29, 2021https://github.com/nodejs/node/pull/39934#issue-982140800
Please reload this pagehttps://github.com/nodejs/node/pull/39934
@szmarczakhttps://github.com/szmarczak
@szmarczakhttps://github.com/szmarczak
Please reload this pagehttps://github.com/nodejs/node/pull/39934
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Aug 29, 2021https://github.com/nodejs/node/pull/39934#event-5222904979
https://github.com/Narasimha1997
Narasimha1997https://github.com/Narasimha1997
Aug 29, 2021 https://github.com/nodejs/node/pull/39934#ref-issue-981637884
Invalid HTTP/2 origin set when servername is empty #39919 https://github.com/nodejs/node/issues/39919
https://github.com/Ayase-252
Ayase-252https://github.com/Ayase-252
Aug 29, 2021https://github.com/nodejs/node/pull/39934#issuecomment-907827420
Please reload this pagehttps://github.com/nodejs/node/pull/39934
https://github.com/Narasimha1997
Narasimha1997https://github.com/Narasimha1997
Aug 29, 2021https://github.com/nodejs/node/pull/39934#issuecomment-907829107
@Ayase-252https://github.com/Ayase-252
Please reload this pagehttps://github.com/nodejs/node/pull/39934
https://github.com/Narasimha1997
Narasimha1997https://github.com/Narasimha1997
Aug 29, 2021https://github.com/nodejs/node/pull/39934#issuecomment-907848262
@Ayase-252https://github.com/Ayase-252
Please reload this pagehttps://github.com/nodejs/node/pull/39934
https://github.com/szmarczak
szmarczakhttps://github.com/szmarczak
Aug 29, 2021https://github.com/nodejs/node/pull/39934#issuecomment-907869442
@Narasimha1997https://github.com/Narasimha1997
Please reload this pagehttps://github.com/nodejs/node/pull/39934
https://github.com/Mesteery
Mesteeryhttps://github.com/Mesteery
Aug 29, 2021https://github.com/nodejs/node/pull/39934#issuecomment-907872463
https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#naming-test-fileshttps://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#naming-test-files
Please reload this pagehttps://github.com/nodejs/node/pull/39934
https://github.com/Ayase-252
Ayase-252https://github.com/Ayase-252
Aug 30, 2021 https://github.com/nodejs/node/pull/39934#pullrequestreview-741189755
View reviewed changes https://github.com/nodejs/node/pull/39934/files
Ayase-252https://github.com/Ayase-252
https://github.com/nodejs/node/pull/39934#pullrequestreview-741189755
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/nodejs/node/blob/master/BUILDING.md#running-testshttps://github.com/nodejs/node/blob/master/BUILDING.md#running-tests
Please reload this pagehttps://github.com/nodejs/node/pull/39934
test/internet/test-http2-issue-39919.jshttps://github.com/nodejs/node/pull/39934/files#diff-1cb160b36479ed669dd9f57ab9b12927b36579e538960afb8e1138764d975ef9
Please reload this pagehttps://github.com/nodejs/node/pull/39934
test/internet/test-http2-issue-39919.jshttps://github.com/nodejs/node/pull/39934/files#diff-1cb160b36479ed669dd9f57ab9b12927b36579e538960afb8e1138764d975ef9
Please reload this pagehttps://github.com/nodejs/node/pull/39934
https://github.com/Narasimha1997
Narasimha1997https://github.com/Narasimha1997
Aug 30, 2021https://github.com/nodejs/node/pull/39934#issuecomment-907986421
Please reload this pagehttps://github.com/nodejs/node/pull/39934
@Mesteeryhttps://github.com/Mesteery
@szmarczakhttps://github.com/szmarczak
@Ayase-252https://github.com/Ayase-252
Please reload this pagehttps://github.com/nodejs/node/pull/39934
https://github.com/Ayase-252
Ayase-252https://github.com/Ayase-252
Aug 30, 2021https://github.com/nodejs/node/pull/39934#issuecomment-908012558
@Narasimha1997https://github.com/Narasimha1997
Please reload this pagehttps://github.com/nodejs/node/pull/39934
https://github.com/Narasimha1997
http2: set origin name correctly when servername is emptyhttps://github.com/nodejs/node/pull/39934/commits/c43b614cab9abca8a3a6449f7d025d5476749430
c43b614https://github.com/nodejs/node/pull/39934/commits/c43b614cab9abca8a3a6449f7d025d5476749430
nodejs#39919https://github.com/nodejs/node/issues/39919
https://github.com/Narasimha1997
Narasimha1997https://github.com/Narasimha1997
force-pushedhttps://github.com/nodejs/node/compare/74b149d9088a2fc793a9eb433ba5d7d0ca77caf8..c43b614cab9abca8a3a6449f7d025d5476749430
74b149dhttps://github.com/nodejs/node/commit/74b149d9088a2fc793a9eb433ba5d7d0ca77caf8
c43b614https://github.com/nodejs/node/commit/c43b614cab9abca8a3a6449f7d025d5476749430
Compare https://github.com/nodejs/node/compare/74b149d9088a2fc793a9eb433ba5d7d0ca77caf8..c43b614cab9abca8a3a6449f7d025d5476749430
August 30, 2021 11:12https://github.com/nodejs/node/pull/39934#event-5225572177
https://github.com/szmarczak
szmarczakhttps://github.com/szmarczak
Aug 30, 2021 https://github.com/nodejs/node/pull/39934#pullrequestreview-741591609
View reviewed changes https://github.com/nodejs/node/pull/39934/files/c43b614cab9abca8a3a6449f7d025d5476749430
lib/internal/http2/core.jshttps://github.com/nodejs/node/pull/39934/files/c43b614cab9abca8a3a6449f7d025d5476749430#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
Please reload this pagehttps://github.com/nodejs/node/pull/39934
https://github.com/Narasimha1997
Narasimha1997https://github.com/Narasimha1997
Aug 31, 2021https://github.com/nodejs/node/pull/39934#issuecomment-908842552
Please reload this pagehttps://github.com/nodejs/node/pull/39934
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 31, 2021 https://github.com/nodejs/node/pull/39934#pullrequestreview-743003832
View reviewed changes https://github.com/nodejs/node/pull/39934/files/c43b614cab9abca8a3a6449f7d025d5476749430
lib/internal/http2/core.jshttps://github.com/nodejs/node/pull/39934/files/c43b614cab9abca8a3a6449f7d025d5476749430#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
lpincahttps://github.com/lpinca
Aug 31, 2021https://github.com/nodejs/node/pull/39934#discussion_r699529426
Please reload this pagehttps://github.com/nodejs/node/pull/39934
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
the empty string is used to disable the SNI extensionhttps://github.com/nodejs/node/commit/98e9de7db930e505884ca8d0ca6588afbe43f127
Please reload this pagehttps://github.com/nodejs/node/pull/39934
Narasimha1997https://github.com/Narasimha1997
Sep 1, 2021https://github.com/nodejs/node/pull/39934#discussion_r699794502
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/39934
test/internet/test-http2-https-origin-string-correctness.jshttps://github.com/nodejs/node/pull/39934/files/c43b614cab9abca8a3a6449f7d025d5476749430#diff-a8bcc0e80c31088a05418a8058ad9cbd6934371f87fbbb6dfc27b8d13c9f2e8b
lpincahttps://github.com/lpinca
Aug 31, 2021https://github.com/nodejs/node/pull/39934#discussion_r699532587
Please reload this pagehttps://github.com/nodejs/node/pull/39934
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#39011https://github.com/nodejs/node/pull/39011
Please reload this pagehttps://github.com/nodejs/node/pull/39934
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Aug 31, 2021 https://github.com/nodejs/node/pull/39934#pullrequestreview-743225109
View reviewed changes https://github.com/nodejs/node/pull/39934/files/c43b614cab9abca8a3a6449f7d025d5476749430
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/39934#pullrequestreview-743225109
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/39934
ofirbarakhttps://github.com/ofirbarak
Apr 23, 2022 https://github.com/nodejs/node/pull/39934#ref-commit-90bb546
http2: set origin name correctly when servername is emptyhttps://github.com/ofirbarak/node/commit/90bb5461549590511cfe5d08295c27578b1bac71
90bb546https://github.com/ofirbarak/node/commit/90bb5461549590511cfe5d08295c27578b1bac71
nodejs#39919https://github.com/nodejs/node/issues/39919
nodejs#39934https://github.com/nodejs/node/pull/39934
https://github.com/ofirbarak
ofirbarakhttps://github.com/ofirbarak
Apr 23, 2022 https://github.com/nodejs/node/pull/39934#ref-pullrequest-1213296858
http2: set origin name correctly when servername is empty #42838 https://github.com/nodejs/node/pull/42838
ofirbarakhttps://github.com/ofirbarak
May 22, 2022 https://github.com/nodejs/node/pull/39934#ref-commit-10cb6da
http2: set origin name correctly when servername is emptyhttps://github.com/ofirbarak/node/commit/10cb6da2a1f91a70ffb1c957c487e1ae45d11d0d
10cb6dahttps://github.com/ofirbarak/node/commit/10cb6da2a1f91a70ffb1c957c487e1ae45d11d0d
nodejs#39919https://github.com/nodejs/node/issues/39919
nodejs#39934https://github.com/nodejs/node/pull/39934
nodejs-github-bothttps://github.com/nodejs-github-bot
May 25, 2022 https://github.com/nodejs/node/pull/39934#ref-commit-f9f22b4
https://github.com/ofirbarak
http2: set origin name correctly when servername is emptyhttps://github.com/nodejs/node/commit/f9f22b4b6978ccf6573f244a971f8f1e4fbe40ee
f9f22b4https://github.com/nodejs/node/commit/f9f22b4b6978ccf6573f244a971f8f1e4fbe40ee
#39919https://github.com/nodejs/node/issues/39919
#39934https://github.com/nodejs/node/pull/39934
#42838https://github.com/nodejs/node/pull/42838
benglhttps://github.com/bengl
May 30, 2022 https://github.com/nodejs/node/pull/39934#ref-commit-b187060
https://github.com/ofirbarak
https://github.com/bengl
http2: set origin name correctly when servername is emptyhttps://github.com/nodejs/node/commit/b187060f76fd33d8f36b8fb835a21a26a43fd9c1
b187060https://github.com/nodejs/node/commit/b187060f76fd33d8f36b8fb835a21a26a43fd9c1
#39919https://github.com/nodejs/node/issues/39919
#39934https://github.com/nodejs/node/pull/39934
#42838https://github.com/nodejs/node/pull/42838
danielleadamshttps://github.com/danielleadams
Jun 27, 2022 https://github.com/nodejs/node/pull/39934#ref-commit-a212dc9
https://github.com/ofirbarak
https://github.com/danielleadams
http2: set origin name correctly when servername is emptyhttps://github.com/nodejs/node/commit/a212dc924abaf547249f88ad1022c87f6f707845
a212dc9https://github.com/nodejs/node/commit/a212dc924abaf547249f88ad1022c87f6f707845
#39919https://github.com/nodejs/node/issues/39919
#39934https://github.com/nodejs/node/pull/39934
#42838https://github.com/nodejs/node/pull/42838
targoshttps://github.com/targos
Jul 12, 2022 https://github.com/nodejs/node/pull/39934#ref-commit-33fbf98
https://github.com/ofirbarak
https://github.com/targos
http2: set origin name correctly when servername is emptyhttps://github.com/nodejs/node/commit/33fbf986b5324b83994959bcf13328ea282101c9
33fbf98https://github.com/nodejs/node/commit/33fbf986b5324b83994959bcf13328ea282101c9
#39919https://github.com/nodejs/node/issues/39919
#39934https://github.com/nodejs/node/pull/39934
#42838https://github.com/nodejs/node/pull/42838
targoshttps://github.com/targos
Jul 31, 2022 https://github.com/nodejs/node/pull/39934#ref-commit-3674542
https://github.com/ofirbarak
https://github.com/targos
http2: set origin name correctly when servername is emptyhttps://github.com/nodejs/node/commit/367454205dcea63ff3ee5fbbc7274663f7024fc7
3674542https://github.com/nodejs/node/commit/367454205dcea63ff3ee5fbbc7274663f7024fc7
#39919https://github.com/nodejs/node/issues/39919
#39934https://github.com/nodejs/node/pull/39934
#42838https://github.com/nodejs/node/pull/42838
guangwonghttps://github.com/guangwong
Oct 10, 2022 https://github.com/nodejs/node/pull/39934#ref-commit-68826e6
https://github.com/ofirbarak
https://github.com/guangwong
http2: set origin name correctly when servername is emptyhttps://github.com/noslate-project/node/commit/68826e6dd792b8f2ee0b855187c27a4855e318d9
68826e6https://github.com/noslate-project/node/commit/68826e6dd792b8f2ee0b855187c27a4855e318d9
nodejs/node#39919https://github.com/nodejs/node/issues/39919
nodejs/node#39934https://github.com/nodejs/node/pull/39934
nodejs/node#42838https://github.com/nodejs/node/pull/42838
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/2d76238f9184c9009bfa395848a120ac3e5b98e5..ca3ed363ffefa4819c1414aff7ffca34b53a7b95
2d76238https://github.com/nodejs/node/commit/2d76238f9184c9009bfa395848a120ac3e5b98e5
ca3ed36https://github.com/nodejs/node/commit/ca3ed363ffefa4819c1414aff7ffca34b53a7b95
Compare https://github.com/nodejs/node/compare/2d76238f9184c9009bfa395848a120ac3e5b98e5..ca3ed363ffefa4819c1414aff7ffca34b53a7b95
November 12, 2022 01:49https://github.com/nodejs/node/pull/39934#event-7795751558
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39934
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/39934/files/c43b614cab9abca8a3a6449f7d025d5476749430
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/39934/files/c43b614cab9abca8a3a6449f7d025d5476749430
https://github.com/Ayase-252
Ayase-252 https://github.com/Ayase-252
https://github.com/nodejs/node/pull/39934/files/74b149d9088a2fc793a9eb433ba5d7d0ca77caf8
https://github.com/szmarczak
szmarczak https://github.com/szmarczak
https://github.com/nodejs/node/pull/39934/files/c43b614cab9abca8a3a6449f7d025d5476749430
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/39934
https://github.com/Narasimha1997
https://github.com/Ayase-252
https://github.com/szmarczak
https://github.com/Mesteery
https://github.com/mcollina
https://github.com/lpinca
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.