| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:242e3a45-c072-195d-d095-1b0c27f602c1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E374:3EE845:3E8D745:55D25D0:6A4F3AC3 |
| html-safe-nonce | eb3783b4dab0ef53bc04fb5ff75a4241aa6edded0178a57b1702a9e4edab73c4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzc0OjNFRTg0NTozRThENzQ1OjU1RDI1RDA6NkE0RjNBQzMiLCJ2aXNpdG9yX2lkIjoiOTEyMzc5NDM2NDM0MTg5MzgyNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | fd22d891fdb55ae2afd5e630f56892e5b310b2cbda03471e19faf01ff448b350 |
| hovercard-subject-tag | pull_request:697128091 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/39531/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e1f964b11f3393ef82bf525a271ca7d9a4ef82d58b6eb17aaf20b1db2363ed28/nodejs/node/pull/39531 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e1f964b11f3393ef82bf525a271ca7d9a4ef82d58b6eb17aaf20b1db2363ed28/nodejs/node/pull/39531 |
| og:image:alt | Reopening of #39421 to only land after two weeks on v16. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | guybedford |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/39531#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39531 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39531 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/39531 |
| Reload | https://github.com/nodejs/node/pull/39531 |
| Reload | https://github.com/nodejs/node/pull/39531 |
| Please reload this page | https://github.com/nodejs/node/pull/39531 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/39531 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
971
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| guybedford | https://github.com/guybedford |
| nodejs:v14.x-staging | https://github.com/nodejs/node/tree/v14.x-staging |
| guybedford:cjs-module-lexer-update-14 | https://github.com/guybedford/node/tree/cjs-module-lexer-update-14 |
| Conversation | https://github.com/nodejs/node/pull/39531 |
| Commits139 (139) | https://github.com/nodejs/node/pull/39531/commits |
| Checks | https://github.com/nodejs/node/pull/39531/checks |
| Files changed | https://github.com/nodejs/node/pull/39531/files |
| [v14 backport] deps: update to cjs-module-lexer@1.2.2 | https://github.com/nodejs/node/pull/39531#top |
| guybedford | https://github.com/guybedford |
| nodejs:v14.x-staging | https://github.com/nodejs/node/tree/v14.x-staging |
| guybedford:cjs-module-lexer-update-14 | https://github.com/guybedford/node/tree/cjs-module-lexer-update-14 |
|
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| Jul 26, 2021 | https://github.com/nodejs/node/pull/39531#issue-953020990 |
| #39421 | https://github.com/nodejs/node/pull/39421 |
| Please reload this page | https://github.com/nodejs/node/pull/39531 |
| addaleax | https://github.com/addaleax |
| July 5, 2021 17:01 | https://github.com/nodejs/node/pull/39531#commits-pushed-16dcd9c |
|
| https://github.com/addaleax |
|
| https://github.com/richardlau |
| src: add maybe versions of EmitExit and EmitBeforeExit | https://github.com/nodejs/node/pull/39531/commits/16dcd9c9a53d5e65c9d733d5b4f7f038eed0850c |
| 16dcd9c | https://github.com/nodejs/node/pull/39531/commits/16dcd9c9a53d5e65c9d733d5b4f7f038eed0850c |
| nodejs#35486 | https://github.com/nodejs/node/pull/35486 |
| nodejs#38786 | https://github.com/nodejs/node/pull/38786 |
|
| https://github.com/targos |
| deps: V8: backport 1b1eda0876aa | https://github.com/nodejs/node/pull/39531/commits/889ee04c206c3edbce07bfabe08d8a50b742c65e |
| 889ee04 | https://github.com/nodejs/node/pull/39531/commits/889ee04c206c3edbce07bfabe08d8a50b742c65e |
| https://chromium-review.googlesource.com/c/v8/v8/+/2454079 | https://chromium-review.googlesource.com/c/v8/v8/+/2454079 |
| v8/v8@1b1eda0 | https://github.com/v8/v8/commit/1b1eda0876aa20bc1dc71caa6baf3a52c0c1540d |
| nodejs#39244 | https://github.com/nodejs/node/pull/39244 |
| nodejs/build#2696 | https://github.com/nodejs/build/issues/2696 |
|
| https://github.com/targos |
| deps: V8: cherry-pick 92e6d3317082 | https://github.com/nodejs/node/pull/39531/commits/2b7a1267d3a97954b155b42f5763d98b8b8ab8c5 |
| 2b7a126 | https://github.com/nodejs/node/pull/39531/commits/2b7a1267d3a97954b155b42f5763d98b8b8ab8c5 |
| https://chromium-review.googlesource.com/c/v8/v8/+/2456988 | https://chromium-review.googlesource.com/c/v8/v8/+/2456988 |
| v8/v8@92e6d33 | https://github.com/v8/v8/commit/92e6d3317082e492ff11fd50a1f3481368f6cafc |
| nodejs#39244 | https://github.com/nodejs/node/pull/39244 |
| nodejs/build#2696 | https://github.com/nodejs/build/issues/2696 |
|
| https://github.com/targos |
| deps: V8: cherry-pick 7c182bd65f42 | https://github.com/nodejs/node/pull/39531/commits/b01bbdbfee894203a9ca7b612eb1f015bd1f0673 |
| b01bbdb | https://github.com/nodejs/node/pull/39531/commits/b01bbdbfee894203a9ca7b612eb1f015bd1f0673 |
| https://chromium-review.googlesource.com/c/v8/v8/+/2360909 | https://chromium-review.googlesource.com/c/v8/v8/+/2360909 |
| v8/v8@7c182bd | https://github.com/v8/v8/commit/7c182bd65f424db19dc3e3d9aca601030af30d7e |
| nodejs#39244 | https://github.com/nodejs/node/pull/39244 |
| nodejs/build#2696 | https://github.com/nodejs/build/issues/2696 |
|
| https://github.com/targos |
| deps: V8: cherry-pick 0b3a4ecf7083 | https://github.com/nodejs/node/pull/39531/commits/423352c9f47270b7f96ebb3b06445f4036833d4d |
| 423352c | https://github.com/nodejs/node/pull/39531/commits/423352c9f47270b7f96ebb3b06445f4036833d4d |
| https://chromium-review.googlesource.com/c/v8/v8/+/2391323 | https://chromium-review.googlesource.com/c/v8/v8/+/2391323 |
| v8/v8@0b3a4ec | https://github.com/v8/v8/commit/0b3a4ecf708334ff20dd5a978c3765e75675b40b |
| nodejs#39244 | https://github.com/nodejs/node/pull/39244 |
| nodejs/build#2696 | https://github.com/nodejs/build/issues/2696 |
|
| https://github.com/targos |
| deps: V8: cherry-pick 895949419186 | https://github.com/nodejs/node/pull/39531/commits/f8a8766b536da3206e9e5a43017754df6221d367 |
| f8a8766 | https://github.com/nodejs/node/pull/39531/commits/f8a8766b536da3206e9e5a43017754df6221d367 |
| https://chromium-review.googlesource.com/c/v8/v8/+/2366829 | https://chromium-review.googlesource.com/c/v8/v8/+/2366829 |
| v8/v8@8959494 | https://github.com/v8/v8/commit/8959494191869ff483927916f9f46eb419784f07 |
| nodejs#39244 | https://github.com/nodejs/node/pull/39244 |
| nodejs/build#2696 | https://github.com/nodejs/build/issues/2696 |
|
| https://github.com/targos |
| deps: V8: update build dependencies | https://github.com/nodejs/node/pull/39531/commits/752817c8211f4452ec7d801b5c9f15ca6ce91a69 |
| 752817c | https://github.com/nodejs/node/pull/39531/commits/752817c8211f4452ec7d801b5c9f15ca6ce91a69 |
| nodejs#39244 | https://github.com/nodejs/node/pull/39244 |
| nodejs/build#2696 | https://github.com/nodejs/build/issues/2696 |
|
| https://github.com/richardlau |
| deps: restore minimum ICU version to 65 | https://github.com/nodejs/node/pull/39531/commits/3543ed2f3c5d3bf6e36e8456539f2d25343d4a52 |
| 3543ed2 | https://github.com/nodejs/node/pull/39531/commits/3543ed2f3c5d3bf6e36e8456539f2d25343d4a52 |
| nodejs#34356 | https://github.com/nodejs/node/pull/34356 |
| v8/v8@611e412 | https://github.com/v8/v8/commit/611e412768a7bc87a20d0315635b0bf76a5bab46 |
| v8/v8@eeccede | https://github.com/v8/v8/commit/eeccedee1882f1f870b37d12978cd818934b375d |
| nodejs#39068 | https://github.com/nodejs/node/pull/39068 |
|
| https://github.com/thomasmichaelwallace |
|
| https://github.com/richardlau |
| deps: V8: cherry-pick 81181a8ad80a | https://github.com/nodejs/node/pull/39531/commits/848cf461b14fc3f2cd7d3ccc4ffc734f4ece9c58 |
| 848cf46 | https://github.com/nodejs/node/pull/39531/commits/848cf461b14fc3f2cd7d3ccc4ffc734f4ece9c58 |
| https://chromium-review.googlesource.com/c/v8/v8/+/2928181 | https://chromium-review.googlesource.com/c/v8/v8/+/2928181 |
| v8/v8@81181a8 | https://github.com/v8/v8/commit/81181a8 |
| nodejs#39187 | https://github.com/nodejs/node/pull/39187 |
| nodejs#37553 | https://github.com/nodejs/node/issues/37553 |
| v8/v8@81181a8 | https://github.com/v8/v8/commit/81181a8 |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
| debugger: move node-inspect to internal library | https://github.com/nodejs/node/pull/39531/commits/cde4de9ea06a10ed8b0b7d7ff53e3e752a7c429d |
| cde4de9 | https://github.com/nodejs/node/pull/39531/commits/cde4de9ea06a10ed8b0b7d7ff53e3e752a7c429d |
| https://github.com/nodejs/node/discussions/36481 | https://github.com/nodejs/node/discussions/36481 |
| nodejs#38161 | https://github.com/nodejs/node/pull/38161 |
| nodejs#38858 | https://github.com/nodejs/node/pull/38858 |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
| tools: remove node-inspect from license | https://github.com/nodejs/node/pull/39531/commits/890b82fb03c485825df01ac0b464907f00fe0c93 |
| 890b82f | https://github.com/nodejs/node/pull/39531/commits/890b82fb03c485825df01ac0b464907f00fe0c93 |
| nodejs#38161 | https://github.com/nodejs/node/pull/38161 |
| nodejs#38858 | https://github.com/nodejs/node/pull/38858 |
| https://github.com/nodejs/node/discussions/36481 | https://github.com/nodejs/node/discussions/36481 |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
| debugger: remove unused code | https://github.com/nodejs/node/pull/39531/commits/07ec5d394664aa621bc5ba5a51024baf202d7225 |
| 07ec5d3 | https://github.com/nodejs/node/pull/39531/commits/07ec5d394664aa621bc5ba5a51024baf202d7225 |
| nodejs#38161 | https://github.com/nodejs/node/pull/38161 |
| nodejs#38858 | https://github.com/nodejs/node/pull/38858 |
| https://github.com/nodejs/node/discussions/36481 | https://github.com/nodejs/node/discussions/36481 |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
| debugger: fix inspect restart on Windows | https://github.com/nodejs/node/pull/39531/commits/643a0926b46b9a8b6aa6b8930476b73252a927d4 |
| 643a092 | https://github.com/nodejs/node/pull/39531/commits/643a0926b46b9a8b6aa6b8930476b73252a927d4 |
| nodejs#37224 | https://github.com/nodejs/node/issues/37224 |
| nodejs#38161 | https://github.com/nodejs/node/pull/38161 |
| nodejs#38858 | https://github.com/nodejs/node/pull/38858 |
| https://github.com/nodejs/node/discussions/36481 | https://github.com/nodejs/node/discussions/36481 |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
| debugger: accommodate line chunking in Windows | https://github.com/nodejs/node/pull/39531/commits/cd591556420e974c39b37df44ca6b85c29eb9a37 |
| cd59155 | https://github.com/nodejs/node/pull/39531/commits/cd591556420e974c39b37df44ca6b85c29eb9a37 |
| nodejs#38161 | https://github.com/nodejs/node/pull/38161 |
| nodejs#38858 | https://github.com/nodejs/node/pull/38858 |
| https://github.com/nodejs/node/discussions/36481 | https://github.com/nodejs/node/discussions/36481 |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
| debugger: allow longer time to connect | https://github.com/nodejs/node/pull/39531/commits/3079315f806644c7ffc11573535fe1656b74944b |
| 3079315 | https://github.com/nodejs/node/pull/39531/commits/3079315f806644c7ffc11573535fe1656b74944b |
| nodejs#38161 | https://github.com/nodejs/node/pull/38161 |
| nodejs#38858 | https://github.com/nodejs/node/pull/38858 |
| https://github.com/nodejs/node/discussions/36481 | https://github.com/nodejs/node/discussions/36481 |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
| test: fix test-inspector-cli-address | https://github.com/nodejs/node/pull/39531/commits/cc2339ce7fde7043f6ec753ceae2241e2529b719 |
| cc2339c | https://github.com/nodejs/node/pull/39531/commits/cc2339ce7fde7043f6ec753ceae2241e2529b719 |
| nodejs#38161 | https://github.com/nodejs/node/pull/38161 |
| nodejs#38858 | https://github.com/nodejs/node/pull/38858 |
| https://github.com/nodejs/node/discussions/36481 | https://github.com/nodejs/node/discussions/36481 |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
| test,debugger: migrate node-inspect tests to core | https://github.com/nodejs/node/pull/39531/commits/edf14b53bd5e0d8e475866948024b3eaf12c2f08 |
| edf14b5 | https://github.com/nodejs/node/pull/39531/commits/edf14b53bd5e0d8e475866948024b3eaf12c2f08 |
| nodejs#38161 | https://github.com/nodejs/node/pull/38161 |
| nodejs#38858 | https://github.com/nodejs/node/pull/38858 |
| https://github.com/nodejs/node/discussions/36481 | https://github.com/nodejs/node/discussions/36481 |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
| debugger: replace internal use of deprecated API | https://github.com/nodejs/node/pull/39531/commits/c3b6ce3e222cf37fb19acf75e2121dbb18e4e230 |
| c3b6ce3 | https://github.com/nodejs/node/pull/39531/commits/c3b6ce3e222cf37fb19acf75e2121dbb18e4e230 |
| nodejs#38161 | https://github.com/nodejs/node/pull/38161 |
| nodejs#38858 | https://github.com/nodejs/node/pull/38858 |
| https://github.com/nodejs/node/discussions/36481 | https://github.com/nodejs/node/discussions/36481 |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
| test: fix comment typo | https://github.com/nodejs/node/pull/39531/commits/24b5e12d093b8bfa9ab1b1ed223567d9dfc846cb |
| 24b5e12 | https://github.com/nodejs/node/pull/39531/commits/24b5e12d093b8bfa9ab1b1ed223567d9dfc846cb |
| nodejs#38161 | https://github.com/nodejs/node/pull/38161 |
| nodejs#38858 | https://github.com/nodejs/node/pull/38858 |
| https://github.com/nodejs/node/discussions/36481 | https://github.com/nodejs/node/discussions/36481 |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
| debugger: fix race condition/deadlock on initialization | https://github.com/nodejs/node/pull/39531/commits/9c4d8ee2767a488b002da6c89eee36353b3d6f61 |
| 9c4d8ee | https://github.com/nodejs/node/pull/39531/commits/9c4d8ee2767a488b002da6c89eee36353b3d6f61 |
| nodejs#38161 | https://github.com/nodejs/node/pull/38161 |
| nodejs#38858 | https://github.com/nodejs/node/pull/38858 |
| https://github.com/nodejs/node/discussions/36481 | https://github.com/nodejs/node/discussions/36481 |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
| test: extend timeout on debugger tests for slower machines | https://github.com/nodejs/node/pull/39531/commits/562b5549b8a17f401b9956161ae6c30a6d8ddb62 |
| 562b554 | https://github.com/nodejs/node/pull/39531/commits/562b5549b8a17f401b9956161ae6c30a6d8ddb62 |
| nodejs#38161 | https://github.com/nodejs/node/pull/38161 |
| nodejs#38858 | https://github.com/nodejs/node/pull/38858 |
| https://github.com/nodejs/node/discussions/36481 | https://github.com/nodejs/node/discussions/36481 |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
| test: fix flaky inspector-cli tests when breakpionts are restored | https://github.com/nodejs/node/pull/39531/commits/7f2017d750befb7f642cf820e27df5a1430a5613 |
| 7f2017d | https://github.com/nodejs/node/pull/39531/commits/7f2017d750befb7f642cf820e27df5a1430a5613 |
| nodejs#38431 | https://github.com/nodejs/node/pull/38431 |
|
| https://github.com/fisker |
|
| https://github.com/richardlau |
| doc: update code examples for node:url module | https://github.com/nodejs/node/pull/39531/commits/793c527d094941a511fee33120906437bdd685bf |
| 793c527 | https://github.com/nodejs/node/pull/39531/commits/793c527d094941a511fee33120906437bdd685bf |
| nodejs#38645 | https://github.com/nodejs/node/pull/38645 |
|
| https://github.com/XadillaX |
|
| https://github.com/richardlau |
| src: replace autos in node_contextify.cc | https://github.com/nodejs/node/pull/39531/commits/c33e3818ed2199188652ee331375b86ce4f8b03a |
| c33e381 | https://github.com/nodejs/node/pull/39531/commits/c33e3818ed2199188652ee331375b86ce4f8b03a |
| nodejs#38644 | https://github.com/nodejs/node/pull/38644 |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/richardlau |
| test: give js-native-api tests consistent names | https://github.com/nodejs/node/pull/39531/commits/6fb9f79c49c0c89476b1919c8568ac4b27841d56 |
| 6fb9f79 | https://github.com/nodejs/node/pull/39531/commits/6fb9f79c49c0c89476b1919c8568ac4b27841d56 |
| nodejs#38692 | https://github.com/nodejs/node/pull/38692 |
|
| https://github.com/guybedford |
|
| https://github.com/richardlau |
| doc: document null target pattern | https://github.com/nodejs/node/pull/39531/commits/564114a09bcd81c835dbc740ea6cf0c61007a240 |
| 564114a | https://github.com/nodejs/node/pull/39531/commits/564114a09bcd81c835dbc740ea6cf0c61007a240 |
| nodejs#38724 | https://github.com/nodejs/node/pull/38724 |
|
| https://github.com/legendecas |
|
| https://github.com/richardlau |
| src: write named pipe info in diagnostic report | https://github.com/nodejs/node/pull/39531/commits/f9c7defe504f128a74cb982925f9bf7a5682182f |
| f9c7def | https://github.com/nodejs/node/pull/39531/commits/f9c7defe504f128a74cb982925f9bf7a5682182f |
| nodejs#38637 | https://github.com/nodejs/node/pull/38637 |
| nodejs#38625 | https://github.com/nodejs/node/issues/38625 |
|
| https://github.com/juanarbol |
|
| https://github.com/richardlau |
| src: remove commented code in node_file.cc | https://github.com/nodejs/node/pull/39531/commits/f50d45961e5c866a1f9a6ae72bf4bf4be1ce9251 |
| f50d459 | https://github.com/nodejs/node/pull/39531/commits/f50d45961e5c866a1f9a6ae72bf4bf4be1ce9251 |
| nodejs#38693 | https://github.com/nodejs/node/pull/38693 |
|
| https://github.com/RaisinTen |
|
| https://github.com/richardlau |
| src: use HandleScope in StreamReq::Done() | https://github.com/nodejs/node/pull/39531/commits/ee66cfca79932fe30eed66e7f8cda726753907a5 |
| ee66cfc | https://github.com/nodejs/node/pull/39531/commits/ee66cfca79932fe30eed66e7f8cda726753907a5 |
| nodejs#38707 | https://github.com/nodejs/node/issues/38707 |
| nodejs#38720 | https://github.com/nodejs/node/pull/38720 |
|
| https://github.com/VoltrexKeyva |
|
| https://github.com/richardlau |
| typings: add JSDoc typings for events | https://github.com/nodejs/node/pull/39531/commits/efeea113e6d4c8bf22f4a30cf3c8bea3ed8a9784 |
| efeea11 | https://github.com/nodejs/node/pull/39531/commits/efeea113e6d4c8bf22f4a30cf3c8bea3ed8a9784 |
| nodejs#38712 | https://github.com/nodejs/node/pull/38712 |
| aduh95 | https://github.com/aduh95 |
| July 21, 2021 06:40 | https://github.com/nodejs/node/pull/39531#commits-pushed-89b353d |
|
| https://github.com/aduh95 |
|
| https://github.com/richardlau |
| lib: add primordials.SafeArrayIterator | https://github.com/nodejs/node/pull/39531/commits/89b353de5750a2ee3cdc2e567c45ca2d6eb8dfe0 |
| 89b353d | https://github.com/nodejs/node/pull/39531/commits/89b353de5750a2ee3cdc2e567c45ca2d6eb8dfe0 |
| nodejs#36532 | https://github.com/nodejs/node/pull/36532 |
| nodejs#39446 | https://github.com/nodejs/node/pull/39446 |
|
| https://github.com/aduh95 |
|
| https://github.com/richardlau |
| Revert "debugger: rename internal library for clarity" | https://github.com/nodejs/node/pull/39531/commits/ba96c561fd5680b6e2880c88187636d1446e3d73 |
| ba96c56 | https://github.com/nodejs/node/pull/39531/commits/ba96c561fd5680b6e2880c88187636d1446e3d73 |
| d0c7ab0 | https://github.com/guybedford/node/commit/d0c7ab00f9fcbf6ba45c3f554fa75cf60ca1b2ce |
| nodejs#39446 | https://github.com/nodejs/node/pull/39446 |
|
| https://github.com/RafaelGSS |
|
| https://github.com/richardlau |
| debugger: add usage example for --port | https://github.com/nodejs/node/pull/39531/commits/99a4c16f827d6ec7c6f70a0ec3b3200ddd06e3c8 |
| 99a4c16 | https://github.com/nodejs/node/pull/39531/commits/99a4c16f827d6ec7c6f70a0ec3b3200ddd06e3c8 |
| nodejs#38400 | https://github.com/nodejs/node/pull/38400 |
| nodejs#39446 | https://github.com/nodejs/node/pull/39446 |
|
| https://github.com/aduh95 |
|
| https://github.com/richardlau |
| debugger: refactor internal/inspector/_inspect to use more primordials | https://github.com/nodejs/node/pull/39531/commits/01cde1491a40b3a1f3c6b2b0782e001f3c3dbaee |
| 01cde14 | https://github.com/nodejs/node/pull/39531/commits/01cde1491a40b3a1f3c6b2b0782e001f3c3dbaee |
| nodejs#38406 | https://github.com/nodejs/node/pull/38406 |
| nodejs#39446 | https://github.com/nodejs/node/pull/39446 |
|
| https://github.com/targos |
|
| https://github.com/richardlau |
| debugger: wait for V8 debugger to be enabled | https://github.com/nodejs/node/pull/39531/commits/36050af3299da2d8b571ac838a00ebea66fafcfa |
| 36050af | https://github.com/nodejs/node/pull/39531/commits/36050af3299da2d8b571ac838a00ebea66fafcfa |
| nodejs#38273 (comment) | https://github.com/nodejs/node/pull/38273#issuecomment-848438189 |
| nodejs#38811 | https://github.com/nodejs/node/pull/38811 |
| nodejs#39446 | https://github.com/nodejs/node/pull/39446 |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
| debugger: revise async iterator usage to comply with lint rules | https://github.com/nodejs/node/pull/39531/commits/992f5ff1db08971298b03b2de2347939778ea3a0 |
| 992f5ff | https://github.com/nodejs/node/pull/39531/commits/992f5ff1db08971298b03b2de2347939778ea3a0 |
| nodejs#38847 | https://github.com/nodejs/node/pull/38847 |
| nodejs#39446 | https://github.com/nodejs/node/pull/39446 |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
| debugger: reduce scope of eslint disable comment | https://github.com/nodejs/node/pull/39531/commits/d477e8054a81a960351544fa123155ed048caab8 |
| d477e80 | https://github.com/nodejs/node/pull/39531/commits/d477e8054a81a960351544fa123155ed048caab8 |
| nodejs#38946 | https://github.com/nodejs/node/pull/38946 |
| nodejs#39446 | https://github.com/nodejs/node/pull/39446 |
|
| https://github.com/aduh95 |
|
| https://github.com/richardlau |
| debugger: enable linter on internal/inspector/inspect_client | https://github.com/nodejs/node/pull/39531/commits/752282a7d23cf6cd822a0ee89cac858a31b58961 |
| 752282a | https://github.com/nodejs/node/pull/39531/commits/752282a7d23cf6cd822a0ee89cac858a31b58961 |
| nodejs#38417 | https://github.com/nodejs/node/pull/38417 |
| nodejs#39446 | https://github.com/nodejs/node/pull/39446 |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
| debugger: remove unnecessary boilerplate copyright comment | https://github.com/nodejs/node/pull/39531/commits/a893694aef07f6ba04e8c9580c20b2c1e7ff3cae |
| a893694 | https://github.com/nodejs/node/pull/39531/commits/a893694aef07f6ba04e8c9580c20b2c1e7ff3cae |
| nodejs#38952 | https://github.com/nodejs/node/pull/38952 |
| nodejs#39446 | https://github.com/nodejs/node/pull/39446 |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
| debugger: align message with Node.js standard | https://github.com/nodejs/node/pull/39531/commits/0f518f3d614041012cd13cc5bff24406013420ea |
| 0f518f3 | https://github.com/nodejs/node/pull/39531/commits/0f518f3d614041012cd13cc5bff24406013420ea |
| nodejs#38400 | https://github.com/nodejs/node/pull/38400 |
| nodejs#39446 | https://github.com/nodejs/node/pull/39446 |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
| debugger: wrap lines longer than 80 chars | https://github.com/nodejs/node/pull/39531/commits/54c2b07bbaedcce9333cc12fb2a75242c18d2738 |
| 54c2b07 | https://github.com/nodejs/node/pull/39531/commits/54c2b07bbaedcce9333cc12fb2a75242c18d2738 |
| nodejs#38529 | https://github.com/nodejs/node/pull/38529 |
| nodejs#39446 | https://github.com/nodejs/node/pull/39446 |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
| debugger: avoid non-ASCII char in code file | https://github.com/nodejs/node/pull/39531/commits/ec52826d7573987b7e154142b605c9b097d469bc |
| ec52826 | https://github.com/nodejs/node/pull/39531/commits/ec52826d7573987b7e154142b605c9b097d469bc |
| nodejs#38529 | https://github.com/nodejs/node/pull/38529 |
| nodejs#39446 | https://github.com/nodejs/node/pull/39446 |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
| debugger: disable only the lint rules required by current file state | https://github.com/nodejs/node/pull/39531/commits/fcbfb84172b4ab8ae41b0fa81b977783a63163a2 |
| fcbfb84 | https://github.com/nodejs/node/pull/39531/commits/fcbfb84172b4ab8ae41b0fa81b977783a63163a2 |
| nodejs#38529 | https://github.com/nodejs/node/pull/38529 |
| nodejs#39446 | https://github.com/nodejs/node/pull/39446 |
|
| https://github.com/aduh95 |
|
| https://github.com/richardlau |
| debugger: refactor to use internal modules | https://github.com/nodejs/node/pull/39531/commits/71cf1d8cd2b5c8b3ea75ca5d1948145d9f32a829 |
| 71cf1d8 | https://github.com/nodejs/node/pull/39531/commits/71cf1d8cd2b5c8b3ea75ca5d1948145d9f32a829 |
| nodejs#38550 | https://github.com/nodejs/node/pull/38550 |
| nodejs#39446 | https://github.com/nodejs/node/pull/39446 |
|
| https://github.com/aduh95 |
|
| https://github.com/richardlau |
| debugger: refactor inspect_repl to use primordials | https://github.com/nodejs/node/pull/39531/commits/4836ccafa3e5a83c4ad4a70365f43c0ef40bf015 |
| 4836cca | https://github.com/nodejs/node/pull/39531/commits/4836ccafa3e5a83c4ad4a70365f43c0ef40bf015 |
| nodejs#38551 | https://github.com/nodejs/node/pull/38551 |
| nodejs#39446 | https://github.com/nodejs/node/pull/39446 |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
| debugger: removed unused function argument | https://github.com/nodejs/node/pull/39531/commits/f8a24b45b1dd36f705556bf5e3cc928fa7d2330c |
| f8a24b4 | https://github.com/nodejs/node/pull/39531/commits/f8a24b45b1dd36f705556bf5e3cc928fa7d2330c |
| nodejs#38850 | https://github.com/nodejs/node/pull/38850 |
| nodejs#39446 | https://github.com/nodejs/node/pull/39446 |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
| errors: add ERR_DEBUGGER_ERROR | https://github.com/nodejs/node/pull/39531/commits/013da6e3ddafdeffcac7779f3be0282a7a85fdea |
| 013da6e | https://github.com/nodejs/node/pull/39531/commits/013da6e3ddafdeffcac7779f3be0282a7a85fdea |
| nodejs#39024 | https://github.com/nodejs/node/pull/39024 |
| nodejs#39446 | https://github.com/nodejs/node/pull/39446 |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
| debugger: use ERR_DEBUGGER_ERROR in debugger client | https://github.com/nodejs/node/pull/39531/commits/81bf4c68f0743ae86b7721f5b0c04dce2052412a |
| 81bf4c6 | https://github.com/nodejs/node/pull/39531/commits/81bf4c68f0743ae86b7721f5b0c04dce2052412a |
| nodejs#39024 | https://github.com/nodejs/node/pull/39024 |
| nodejs#39446 | https://github.com/nodejs/node/pull/39446 |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
| debugger: use error codes in debugger REPL | https://github.com/nodejs/node/pull/39531/commits/e2a7104e62dd5e38291a60f7728531331c818e3d |
| e2a7104 | https://github.com/nodejs/node/pull/39531/commits/e2a7104e62dd5e38291a60f7728531331c818e3d |
| nodejs#39024 | https://github.com/nodejs/node/pull/39024 |
| nodejs#39446 | https://github.com/nodejs/node/pull/39446 |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
| errors: add ERR_DEBUGGER_STARTUP_ERROR | https://github.com/nodejs/node/pull/39531/commits/8132bf16d54324ba6ac44d802982328cdb7963a6 |
| 8132bf1 | https://github.com/nodejs/node/pull/39531/commits/8132bf16d54324ba6ac44d802982328cdb7963a6 |
| nodejs#39024 | https://github.com/nodejs/node/pull/39024 |
| nodejs#39446 | https://github.com/nodejs/node/pull/39446 |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
| debugger: use ERR_DEBUGGER_STARTUP_ERROR in _inspect.js | https://github.com/nodejs/node/pull/39531/commits/0568a2773a8915a336ee172a5f21e05c5133aa1c |
| 0568a27 | https://github.com/nodejs/node/pull/39531/commits/0568a2773a8915a336ee172a5f21e05c5133aa1c |
| nodejs#39024 | https://github.com/nodejs/node/pull/39024 |
| nodejs#39446 | https://github.com/nodejs/node/pull/39446 |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
| debugger: rename internal library for clarity | https://github.com/nodejs/node/pull/39531/commits/f07e576539b83305771e9556181a83d122bc1a7d |
| f07e576 | https://github.com/nodejs/node/pull/39531/commits/f07e576539b83305771e9556181a83d122bc1a7d |
| nodejs#39080 | https://github.com/nodejs/node/pull/39080 |
| nodejs#39446 | https://github.com/nodejs/node/pull/39446 |
|
| https://github.com/RaisinTen |
|
| https://github.com/richardlau |
| doc,url: clarify domainTo* when built without ICU | https://github.com/nodejs/node/pull/39531/commits/64140af2916a1c9886d3bf5cd9506265e9074530 |
| 64140af | https://github.com/nodejs/node/pull/39531/commits/64140af2916a1c9886d3bf5cd9506265e9074530 |
| nodejs#35099 | https://github.com/nodejs/node/pull/35099 |
| nodejs#38789 | https://github.com/nodejs/node/pull/38789 |
|
| https://github.com/guybedford |
| deps: update to cjs-module-lexer@1.2.2 | https://github.com/nodejs/node/pull/39531/commits/d9e6ee479546f5645d1eb95e58c23d73ff7c905b |
| d9e6ee4 | https://github.com/nodejs/node/pull/39531/commits/d9e6ee479546f5645d1eb95e58c23d73ff7c905b |
| nodejs#39402 | https://github.com/nodejs/node/pull/39402 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
|
Jul 26, 2021
| https://github.com/nodejs/node/pull/39531#ref-pullrequest-946906337 |
|
[v14.x backport] deps: update to cjs-module-lexer@1.2.2
#39421
| https://github.com/nodejs/node/pull/39421 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
v14.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av14.x |
| Jul 27, 2021 | https://github.com/nodejs/node/pull/39531#event-5071325847 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| force-pushed | https://github.com/nodejs/node/compare/073941c5a5a9d47a4065379b761c34024d460c3c..0061e5d20eb46827ad03f88d73c6715b75cc412c |
| 073941c | https://github.com/nodejs/node/commit/073941c5a5a9d47a4065379b761c34024d460c3c |
| 0061e5d | https://github.com/nodejs/node/commit/0061e5d20eb46827ad03f88d73c6715b75cc412c |
|
Compare
| https://github.com/nodejs/node/compare/073941c5a5a9d47a4065379b761c34024d460c3c..0061e5d20eb46827ad03f88d73c6715b75cc412c |
| July 29, 2021 16:40 | https://github.com/nodejs/node/pull/39531#event-5087177031 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Aug 3, 2021 | https://github.com/nodejs/node/pull/39531#issuecomment-891815627 |
| 89fdb47 | https://github.com/nodejs/node/commit/89fdb47f99495149410c196f9ffe132d349d0a3e |
| Please reload this page | https://github.com/nodejs/node/pull/39531 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Aug 3, 2021 | https://github.com/nodejs/node/pull/39531#event-5104562488 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39531 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Please reload this page | https://github.com/nodejs/node/pull/39531 |
|
| https://github.com/guybedford |
|
| https://github.com/targos |
|
| https://github.com/addaleax |
|
| https://github.com/richardlau |
|
| https://github.com/thomasmichaelwallace |
|
| https://github.com/Trott |
|
| https://github.com/fisker |
|
| https://github.com/XadillaX |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/legendecas |
|
| https://github.com/juanarbol |
|
| https://github.com/RaisinTen |
|
| https://github.com/VoltrexKeyva |
|
| https://github.com/pd4d10 |
|
| https://github.com/concatime |
|
| https://github.com/aduh95 |
|
| https://github.com/jesec |
|
| https://github.com/todortotev |
|
| https://github.com/waelsy123 |
|
| https://github.com/Ayase-252 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |