| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:cd4f1fcc-5d0d-401d-5adc-de52178e02bd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B26A:3AF9A7:B761B8:FFE56A:6A4E86DD |
| html-safe-nonce | 6e0e0da4abdcbc56c295ccfa389bcabb437468f0776938e896a8e3c8601e649f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjZBOjNBRjlBNzpCNzYxQjg6RkZFNTZBOjZBNEU4NkREIiwidmlzaXRvcl9pZCI6IjE4MzI1NDgxNTA1MzI4MDIyNjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | a18cf152ed6ec8f14bc606bad5ef9c90711c206ecbe8799da1910a86af070f26 |
| hovercard-subject-tag | pull_request:695773728 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/39497/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9ffe8d6b1733225f81d51e1d9d7ba0794b1da0c10a80e3bfdef545b4fe543840/nodejs/node/pull/39497 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9ffe8d6b1733225f81d51e1d9d7ba0794b1da0c10a80e3bfdef545b4fe543840/nodejs/node/pull/39497 |
| og:image:alt | PR-URL: #38979
Fixes: #32103
Fixes: #38739
Reviewed-By: Bradley Farias bradley.meck@gmail.com
Reviewed-By: Guy Bedford guybedford@gmail.com |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | aduh95 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/39497#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39497 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39497 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/39497 |
| Reload | https://github.com/nodejs/node/pull/39497 |
| Reload | https://github.com/nodejs/node/pull/39497 |
| Please reload this page | https://github.com/nodejs/node/pull/39497 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/39497 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
965
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| aduh95 | https://github.com/aduh95 |
| nodejs:v12.x-staging | https://github.com/nodejs/node/tree/v12.x-staging |
| aduh95:backport-node-specifier-resolver-fix | https://github.com/aduh95/node/tree/backport-node-specifier-resolver-fix |
| Conversation | https://github.com/nodejs/node/pull/39497 |
| Commits1 (1) | https://github.com/nodejs/node/pull/39497/commits |
| Checks | https://github.com/nodejs/node/pull/39497/checks |
| Files changed | https://github.com/nodejs/node/pull/39497/files |
| [v12.x backport] module: fix legacy node specifier resolution to resolve "main" field | https://github.com/nodejs/node/pull/39497#top |
| aduh95 | https://github.com/aduh95 |
| nodejs:v12.x-staging | https://github.com/nodejs/node/tree/v12.x-staging |
| aduh95:backport-node-specifier-resolver-fix | https://github.com/aduh95/node/tree/backport-node-specifier-resolver-fix |
|
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Jul 23, 2021 | https://github.com/nodejs/node/pull/39497#issue-951376486 |
| #38979 | https://github.com/nodejs/node/pull/38979 |
| #32103 | https://github.com/nodejs/node/issues/32103 |
| #38739 | https://github.com/nodejs/node/issues/38739 |
| Please reload this page | https://github.com/nodejs/node/pull/39497 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
v12.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av12.x |
| Jul 23, 2021 | https://github.com/nodejs/node/pull/39497#event-5059895093 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Jul 23, 2021 | https://github.com/nodejs/node/pull/39497#issuecomment-885524344 |
| @aduh95 | https://github.com/aduh95 |
| https://github.com/nodejs/node/pull/39497/checks?check_run_id=3141958951#step:5:71 | https://github.com/nodejs/node/pull/39497/checks?check_run_id=3141958951#step:5:71 |
| Please reload this page | https://github.com/nodejs/node/pull/39497 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| force-pushed | https://github.com/nodejs/node/compare/61c274b883f572280c4d28e5a201f87304d40667..6ac4a9b7d0e8211be8f8d02c5d884c4657d1391f |
| 61c274b | https://github.com/nodejs/node/commit/61c274b883f572280c4d28e5a201f87304d40667 |
| 6ac4a9b | https://github.com/nodejs/node/commit/6ac4a9b7d0e8211be8f8d02c5d884c4657d1391f |
|
Compare
| https://github.com/nodejs/node/compare/61c274b883f572280c4d28e5a201f87304d40667..6ac4a9b7d0e8211be8f8d02c5d884c4657d1391f |
| July 23, 2021 10:47 | https://github.com/nodejs/node/pull/39497#event-5060411364 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| force-pushed | https://github.com/nodejs/node/compare/69b2eae607b790be2e619195fefcce1e58a380a1..5f22ec49363ad5db8fc65e41e2f5dae09005aca6 |
| 69b2eae | https://github.com/nodejs/node/commit/69b2eae607b790be2e619195fefcce1e58a380a1 |
| 5f22ec4 | https://github.com/nodejs/node/commit/5f22ec49363ad5db8fc65e41e2f5dae09005aca6 |
|
Compare
| https://github.com/nodejs/node/compare/69b2eae607b790be2e619195fefcce1e58a380a1..5f22ec49363ad5db8fc65e41e2f5dae09005aca6 |
| July 23, 2021 11:23 | https://github.com/nodejs/node/pull/39497#event-5060554174 |
| https://github.com/ljharb |
| ljharb | https://github.com/ljharb |
| Jul 23, 2021 | https://github.com/nodejs/node/pull/39497#issuecomment-885733071 |
| Please reload this page | https://github.com/nodejs/node/pull/39497 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
|
Jul 23, 2021
| https://github.com/nodejs/node/pull/39497#pullrequestreview-713867514 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/39497/files |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 23, 2021 | https://github.com/nodejs/node/pull/39497#issuecomment-885808184 |
| https://ci.nodejs.org/job/node-test-pull-request/39244/ | https://ci.nodejs.org/job/node-test-pull-request/39244/ |
| Please reload this page | https://github.com/nodejs/node/pull/39497 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| force-pushed | https://github.com/nodejs/node/compare/632a3aea1a93ffe956bacd5f7a51708cc9d070e4..1b7af5bfe10024bd00bfe1667403a84d3552f367 |
| 632a3ae | https://github.com/nodejs/node/commit/632a3aea1a93ffe956bacd5f7a51708cc9d070e4 |
| 1b7af5b | https://github.com/nodejs/node/commit/1b7af5bfe10024bd00bfe1667403a84d3552f367 |
|
Compare
| https://github.com/nodejs/node/compare/632a3aea1a93ffe956bacd5f7a51708cc9d070e4..1b7af5bfe10024bd00bfe1667403a84d3552f367 |
| July 26, 2021 15:15 | https://github.com/nodejs/node/pull/39497#event-5069084477 |
|
| https://github.com/aduh95 |
| module: fix legacy node specifier resolution to resolve "main" field | https://github.com/nodejs/node/pull/39497/commits/43724ac6d824c2c6087b05f9eb9c9e3a5c6be81f |
| 43724ac | https://github.com/nodejs/node/pull/39497/commits/43724ac6d824c2c6087b05f9eb9c9e3a5c6be81f |
| nodejs#38979 | https://github.com/nodejs/node/pull/38979 |
| nodejs#32103 | https://github.com/nodejs/node/issues/32103 |
| nodejs#38739 | https://github.com/nodejs/node/issues/38739 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| force-pushed | https://github.com/nodejs/node/compare/5f22ec49363ad5db8fc65e41e2f5dae09005aca6..43724ac6d824c2c6087b05f9eb9c9e3a5c6be81f |
| 5f22ec4 | https://github.com/nodejs/node/commit/5f22ec49363ad5db8fc65e41e2f5dae09005aca6 |
| 43724ac | https://github.com/nodejs/node/commit/43724ac6d824c2c6087b05f9eb9c9e3a5c6be81f |
|
Compare
| https://github.com/nodejs/node/compare/5f22ec49363ad5db8fc65e41e2f5dae09005aca6..43724ac6d824c2c6087b05f9eb9c9e3a5c6be81f |
| July 28, 2021 17:15 | https://github.com/nodejs/node/pull/39497#event-5081498618 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 28, 2021 | https://github.com/nodejs/node/pull/39497#issuecomment-888480388 |
| https://ci.nodejs.org/job/node-test-pull-request/39318/ | https://ci.nodejs.org/job/node-test-pull-request/39318/ |
| Please reload this page | https://github.com/nodejs/node/pull/39497 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 28, 2021 | https://github.com/nodejs/node/pull/39497#issuecomment-888626918 |
| https://ci.nodejs.org/job/node-test-pull-request/39321/ | https://ci.nodejs.org/job/node-test-pull-request/39321/ |
| Please reload this page | https://github.com/nodejs/node/pull/39497 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Jul 28, 2021
| https://github.com/nodejs/node/pull/39497#pullrequestreview-717515206 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/39497/files/43724ac6d824c2c6087b05f9eb9c9e3a5c6be81f |
| richardlau | https://github.com/richardlau |
|
Jul 28, 2021
| https://github.com/nodejs/node/pull/39497#ref-commit-f0bb3d2 |
|
| https://github.com/aduh95 |
|
| https://github.com/richardlau |
| module: fix legacy node specifier resolution to resolve "main" field | https://github.com/nodejs/node/commit/f0bb3d2b63987fb95b733950d28542f1a91f1fd7 |
| f0bb3d2 | https://github.com/nodejs/node/commit/f0bb3d2b63987fb95b733950d28542f1a91f1fd7 |
| #38979 | https://github.com/nodejs/node/pull/38979 |
| #39497 | https://github.com/nodejs/node/pull/39497 |
| #32103 | https://github.com/nodejs/node/issues/32103 |
| #38739 | https://github.com/nodejs/node/issues/38739 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Jul 28, 2021 | https://github.com/nodejs/node/pull/39497#issuecomment-888660744 |
| f0bb3d2 | https://github.com/nodejs/node/commit/f0bb3d2b63987fb95b733950d28542f1a91f1fd7 |
| Please reload this page | https://github.com/nodejs/node/pull/39497 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Jul 28, 2021 | https://github.com/nodejs/node/pull/39497#event-5082798331 |
| richardlau | https://github.com/richardlau |
|
Jul 28, 2021
| https://github.com/nodejs/node/pull/39497#ref-commit-3e4bc1b |
|
| https://github.com/aduh95 |
|
| https://github.com/richardlau |
| module: fix legacy node specifier resolution to resolve "main" field | https://github.com/nodejs/node/commit/3e4bc1b0d351cb12d6c355e9ae9df40316f03199 |
| 3e4bc1b | https://github.com/nodejs/node/commit/3e4bc1b0d351cb12d6c355e9ae9df40316f03199 |
| #38979 | https://github.com/nodejs/node/pull/38979 |
| #39497 | https://github.com/nodejs/node/pull/39497 |
| #32103 | https://github.com/nodejs/node/issues/32103 |
| #38739 | https://github.com/nodejs/node/issues/38739 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| July 28, 2021 22:42 | https://github.com/nodejs/node/pull/39497#event-5082841883 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39497 |
|
| https://github.com/guybedford |
|
guybedford
| https://github.com/guybedford |
|
| https://github.com/nodejs/node/pull/39497/files/5f22ec49363ad5db8fc65e41e2f5dae09005aca6 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/39497/files/43724ac6d824c2c6087b05f9eb9c9e3a5c6be81f |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Please reload this page | https://github.com/nodejs/node/pull/39497 |
|
| https://github.com/aduh95 |
|
| https://github.com/richardlau |
|
| https://github.com/ljharb |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/guybedford |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |