René's URL Explorer Experiment


Title: V12.x icu 69 support. by jameshilliard · Pull Request #39451 · nodejs/node · GitHub

Open Graph Title: V12.x icu 69 support. by jameshilliard · Pull Request #39451 · nodejs/node

X Title: V12.x icu 69 support. by jameshilliard · Pull Request #39451 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This is #38497 rebased on v12.x-staging.

X Description: This is #38497 rebased on v12.x-staging.

Opengraph URL: https://github.com/nodejs/node/pull/39451

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:414348e7-c025-0ad0-ff37-54c758b42c2e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE2E2:2A256:10021D5:170E795:6A4E5350
html-safe-nonce7ea8cef90f15185591e2ed6ba5e835dc6f8bd9b28cf7f81ea26cddba1120c727
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMkUyOjJBMjU2OjEwMDIxRDU6MTcwRTc5NTo2QTRFNTM1MCIsInZpc2l0b3JfaWQiOiI2MDcyMTAxMDgyNjk1MDk1MTIwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9155cbf8e2c0c3bd74048417635b94566d4c9c59f65868d3f8e04402144cb61e
hovercard-subject-tagpull_request:692859366
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/39451/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/45f9764e9fcc98581240de8014d37fd8a3bcb78bf3ea05a09658c30f232bc12a/nodejs/node/pull/39451
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/45f9764e9fcc98581240de8014d37fd8a3bcb78bf3ea05a09658c30f232bc12a/nodejs/node/pull/39451
og:image:altThis is #38497 rebased on v12.x-staging.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejameshilliard
hostnamegithub.com
expected-hostnamegithub.com
None030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef344f1eab54fc7dfc02d0d018cda7e158c3db65c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/39451#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39451
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39451
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/39451
Reloadhttps://github.com/nodejs/node/pull/39451
Reloadhttps://github.com/nodejs/node/pull/39451
Please reload this pagehttps://github.com/nodejs/node/pull/39451
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/39451
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
jameshilliardhttps://github.com/jameshilliard
nodejs:v12.x-staginghttps://github.com/nodejs/node/tree/v12.x-staging
jameshilliard:v12.x-icuhttps://github.com/jameshilliard/node/tree/v12.x-icu
Conversationhttps://github.com/nodejs/node/pull/39451
Commits2 (2)https://github.com/nodejs/node/pull/39451/commits
Checkshttps://github.com/nodejs/node/pull/39451/checks
Files changedhttps://github.com/nodejs/node/pull/39451/files
V12.x icu 69 support.https://github.com/nodejs/node/pull/39451#top
jameshilliardhttps://github.com/jameshilliard
nodejs:v12.x-staginghttps://github.com/nodejs/node/tree/v12.x-staging
jameshilliard:v12.x-icuhttps://github.com/jameshilliard/node/tree/v12.x-icu
https://github.com/jameshilliard
jameshilliardhttps://github.com/jameshilliard
Jul 19, 2021https://github.com/nodejs/node/pull/39451#issue-947951570
#38497https://github.com/nodejs/node/pull/38497
Please reload this pagehttps://github.com/nodejs/node/pull/39451
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av12.x
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
Jul 19, 2021https://github.com/nodejs/node/pull/39451#event-5040308308
https://github.com/jameshilliard
jameshilliardhttps://github.com/jameshilliard
Jul 19, 2021 https://github.com/nodejs/node/pull/39451#ref-pullrequest-947474835
[v12.x] Fix build with ICU >= 68. #39440 https://github.com/nodejs/node/pull/39440
https://github.com/richardlau
richardlauhttps://github.com/richardlau
force-pushedhttps://github.com/nodejs/node/compare/61c274b883f572280c4d28e5a201f87304d40667..6ac4a9b7d0e8211be8f8d02c5d884c4657d1391f
61c274bhttps://github.com/nodejs/node/commit/61c274b883f572280c4d28e5a201f87304d40667
6ac4a9bhttps://github.com/nodejs/node/commit/6ac4a9b7d0e8211be8f8d02c5d884c4657d1391f
Compare https://github.com/nodejs/node/compare/61c274b883f572280c4d28e5a201f87304d40667..6ac4a9b7d0e8211be8f8d02c5d884c4657d1391f
July 23, 2021 10:47https://github.com/nodejs/node/pull/39451#event-5060411360
targoshttps://github.com/targos
July 23, 2021 12:23https://github.com/nodejs/node/pull/39451#commits-pushed-af1a3fd
https://github.com/targos
https://github.com/richardlau
deps: V8: cherry-pick 035c305ce776https://github.com/nodejs/node/pull/39451/commits/af1a3fdf33588c6ff6da1be9605da8f0df6bcc50
af1a3fdhttps://github.com/nodejs/node/pull/39451/commits/af1a3fdf33588c6ff6da1be9605da8f0df6bcc50
https://chromium-review.googlesource.com/c/v8/v8/+/2477751https://chromium-review.googlesource.com/c/v8/v8/+/2477751
v8/v8@035c305https://github.com/v8/v8/commit/035c305ce7761f51328b45f1bd83e26aef267c9d
nodejs#38497https://github.com/nodejs/node/pull/38497
https://github.com/richardlau
deps: restore minimum ICU version to 65https://github.com/nodejs/node/pull/39451/commits/7d8c7a44572910fb5230b843cfad740de7357282
7d8c7a4https://github.com/nodejs/node/pull/39451/commits/7d8c7a44572910fb5230b843cfad740de7357282
nodejs#34356https://github.com/nodejs/node/pull/34356
v8/v8@611e412https://github.com/v8/v8/commit/611e412768a7bc87a20d0315635b0bf76a5bab46
v8/v8@eeccedehttps://github.com/v8/v8/commit/eeccedee1882f1f870b37d12978cd818934b375d
nodejs#39068https://github.com/nodejs/node/pull/39068
https://github.com/richardlau
richardlauhttps://github.com/richardlau
force-pushedhttps://github.com/nodejs/node/compare/a095b32977d54a32e61381aab15841c51f266da1..7d8c7a44572910fb5230b843cfad740de7357282
a095b32https://github.com/nodejs/node/commit/a095b32977d54a32e61381aab15841c51f266da1
7d8c7a4https://github.com/nodejs/node/commit/7d8c7a44572910fb5230b843cfad740de7357282
Compare https://github.com/nodejs/node/compare/a095b32977d54a32e61381aab15841c51f266da1..7d8c7a44572910fb5230b843cfad740de7357282
July 23, 2021 11:24https://github.com/nodejs/node/pull/39451#event-5060560867
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 23, 2021https://github.com/nodejs/node/pull/39451#issuecomment-885574279
Please reload this pagehttps://github.com/nodejs/node/pull/39451
https://ci.nodejs.org/job/node-test-pull-request/39236/https://ci.nodejs.org/job/node-test-pull-request/39236/
https://ci.nodejs.org/job/node-test-commit-v8-linux/4171/https://ci.nodejs.org/job/node-test-commit-v8-linux/4171/
Please reload this pagehttps://github.com/nodejs/node/pull/39451
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 23, 2021 https://github.com/nodejs/node/pull/39451#pullrequestreview-713639423
View reviewed changes https://github.com/nodejs/node/pull/39451/files/7d8c7a44572910fb5230b843cfad740de7357282
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Jul 23, 2021 https://github.com/nodejs/node/pull/39451#pullrequestreview-713776928
View reviewed changes https://github.com/nodejs/node/pull/39451/files/7d8c7a44572910fb5230b843cfad740de7357282
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Jul 23, 2021 https://github.com/nodejs/node/pull/39451#pullrequestreview-713777105
View reviewed changes https://github.com/nodejs/node/pull/39451/files/7d8c7a44572910fb5230b843cfad740de7357282
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 23, 2021https://github.com/nodejs/node/pull/39451#issuecomment-885682990
8a9f949...632a3aehttps://github.com/nodejs/node/compare/8a9f9491a0b238245c45e18baa802cef69180446...632a3aea1a93ffe956bacd5f7a51708cc9d070e4
Please reload this pagehttps://github.com/nodejs/node/pull/39451
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 23, 2021https://github.com/nodejs/node/pull/39451#event-5061420679
richardlauhttps://github.com/richardlau
Jul 23, 2021 https://github.com/nodejs/node/pull/39451#ref-commit-7407caa
https://github.com/targos
https://github.com/richardlau
deps: V8: cherry-pick 035c305ce776https://github.com/nodejs/node/commit/7407caa55f825fda7c2a2fcd61013dde663cb649
7407caahttps://github.com/nodejs/node/commit/7407caa55f825fda7c2a2fcd61013dde663cb649
v8:11031https://bugs.chromium.org/p/v8/issues/detail?id=11031
https://chromium-review.googlesource.com/c/v8/v8/+/2477751https://chromium-review.googlesource.com/c/v8/v8/+/2477751
v8/v8@035c305https://github.com/v8/v8/commit/035c305ce7761f51328b45f1bd83e26aef267c9d
#38497https://github.com/nodejs/node/pull/38497
#39451https://github.com/nodejs/node/pull/39451
richardlauhttps://github.com/richardlau
Jul 23, 2021 https://github.com/nodejs/node/pull/39451#ref-commit-632a3ae
https://github.com/richardlau
deps: restore minimum ICU version to 65https://github.com/nodejs/node/commit/632a3aea1a93ffe956bacd5f7a51708cc9d070e4
632a3aehttps://github.com/nodejs/node/commit/632a3aea1a93ffe956bacd5f7a51708cc9d070e4
#34356https://github.com/nodejs/node/pull/34356
v8/v8@611e412https://github.com/v8/v8/commit/611e412768a7bc87a20d0315635b0bf76a5bab46
v8/v8@eeccedehttps://github.com/v8/v8/commit/eeccedee1882f1f870b37d12978cd818934b375d
#39068https://github.com/nodejs/node/pull/39068
#39451https://github.com/nodejs/node/pull/39451
https://github.com/jameshilliard
jameshilliardhttps://github.com/jameshilliard
July 23, 2021 15:48https://github.com/nodejs/node/pull/39451#event-5061785491
guybedfordhttps://github.com/guybedford
Jul 26, 2021 https://github.com/nodejs/node/pull/39451#ref-commit-99f3b73
https://github.com/targos
https://github.com/guybedford
deps: V8: cherry-pick 035c305ce776https://github.com/nodejs/node/commit/99f3b73f95e93cd2e4b5ce73b5c2539dbf5d9f58
99f3b73https://github.com/nodejs/node/commit/99f3b73f95e93cd2e4b5ce73b5c2539dbf5d9f58
v8:11031https://bugs.chromium.org/p/v8/issues/detail?id=11031
https://chromium-review.googlesource.com/c/v8/v8/+/2477751https://chromium-review.googlesource.com/c/v8/v8/+/2477751
v8/v8@035c305https://github.com/v8/v8/commit/035c305ce7761f51328b45f1bd83e26aef267c9d
#38497https://github.com/nodejs/node/pull/38497
#39451https://github.com/nodejs/node/pull/39451
guybedfordhttps://github.com/guybedford
Jul 26, 2021 https://github.com/nodejs/node/pull/39451#ref-commit-1b7af5b
https://github.com/richardlau
https://github.com/guybedford
deps: restore minimum ICU version to 65https://github.com/nodejs/node/commit/1b7af5bfe10024bd00bfe1667403a84d3552f367
1b7af5bhttps://github.com/nodejs/node/commit/1b7af5bfe10024bd00bfe1667403a84d3552f367
#34356https://github.com/nodejs/node/pull/34356
v8/v8@611e412https://github.com/v8/v8/commit/611e412768a7bc87a20d0315635b0bf76a5bab46
v8/v8@eeccedehttps://github.com/v8/v8/commit/eeccedee1882f1f870b37d12978cd818934b375d
#39068https://github.com/nodejs/node/pull/39068
#39451https://github.com/nodejs/node/pull/39451
richardlauhttps://github.com/richardlau
Jul 26, 2021 https://github.com/nodejs/node/pull/39451#ref-commit-e459c79
https://github.com/targos
https://github.com/richardlau
deps: V8: cherry-pick 035c305ce776https://github.com/nodejs/node/commit/e459c79b023d245a51861c90b7a0cfd8b703b032
e459c79https://github.com/nodejs/node/commit/e459c79b023d245a51861c90b7a0cfd8b703b032
v8:11031https://bugs.chromium.org/p/v8/issues/detail?id=11031
https://chromium-review.googlesource.com/c/v8/v8/+/2477751https://chromium-review.googlesource.com/c/v8/v8/+/2477751
v8/v8@035c305https://github.com/v8/v8/commit/035c305ce7761f51328b45f1bd83e26aef267c9d
#38497https://github.com/nodejs/node/pull/38497
#39451https://github.com/nodejs/node/pull/39451
richardlauhttps://github.com/richardlau
Jul 26, 2021 https://github.com/nodejs/node/pull/39451#ref-commit-39e9cd5
https://github.com/richardlau
deps: restore minimum ICU version to 65https://github.com/nodejs/node/commit/39e9cd540fcd5d06e86ff3347a0d3fe1bdb955bb
39e9cd5https://github.com/nodejs/node/commit/39e9cd540fcd5d06e86ff3347a0d3fe1bdb955bb
#34356https://github.com/nodejs/node/pull/34356
v8/v8@611e412https://github.com/v8/v8/commit/611e412768a7bc87a20d0315635b0bf76a5bab46
v8/v8@eeccedehttps://github.com/v8/v8/commit/eeccedee1882f1f870b37d12978cd818934b375d
#39068https://github.com/nodejs/node/pull/39068
#39451https://github.com/nodejs/node/pull/39451
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39451
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/39451/files/7d8c7a44572910fb5230b843cfad740de7357282
https://github.com/BethGriggs
BethGriggs https://github.com/BethGriggs
https://github.com/nodejs/node/pull/39451/files/7d8c7a44572910fb5230b843cfad740de7357282
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
Please reload this pagehttps://github.com/nodejs/node/pull/39451
https://github.com/jameshilliard
https://github.com/nodejs-github-bot
https://github.com/richardlau
https://github.com/BethGriggs
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.