René's URL Explorer Experiment


Title: [v12.x] Fix build with ICU >= 68. by jameshilliard · Pull Request #39440 · nodejs/node · GitHub

Open Graph Title: [v12.x] Fix build with ICU >= 68. by jameshilliard · Pull Request #39440 · nodejs/node

X Title: [v12.x] Fix build with ICU >= 68. by jameshilliard · Pull Request #39440 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Adapted from: https://chromium-review.googlesource.com/c/v8/v8/+/2477751

X Description: Adapted from: https://chromium-review.googlesource.com/c/v8/v8/+/2477751

Opengraph URL: https://github.com/nodejs/node/pull/39440

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5dde3044-b3ce-9cd0-2425-6656d05423ec
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD914:4950B:9DB6CF:D44CA3:6A4ECD8E
html-safe-noncec13c892e778a85af98c2df4897efa32e4acbbfd1d9513a42bc08ee7fad4fb29b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTE0OjQ5NTBCOjlEQjZDRjpENDRDQTM6NkE0RUNEOEUiLCJ2aXNpdG9yX2lkIjoiODIwMzc2MTkxNjU1NzgzOTc1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd58f341317c5a89084a7ebfa2a586e46fdc87546e88202514f802f56841fa8c9
hovercard-subject-tagpull_request:692450723
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/39440/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3548382152fcee94d762eaac6161f037b7468bd03f26f0a7461400770d4a8c10/nodejs/node/pull/39440
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3548382152fcee94d762eaac6161f037b7468bd03f26f0a7461400770d4a8c10/nodejs/node/pull/39440
og:image:altAdapted from: https://chromium-review.googlesource.com/c/v8/v8/+/2477751
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejameshilliard
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/39440#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39440
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39440
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/39440
Reloadhttps://github.com/nodejs/node/pull/39440
Reloadhttps://github.com/nodejs/node/pull/39440
Please reload this pagehttps://github.com/nodejs/node/pull/39440
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/39440
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
jameshilliardhttps://github.com/jameshilliard
nodejs:v12.x-staginghttps://github.com/nodejs/node/tree/v12.x-staging
jameshilliard:fix-icu-68https://github.com/jameshilliard/node/tree/fix-icu-68
Conversationhttps://github.com/nodejs/node/pull/39440
Commits1 (1)https://github.com/nodejs/node/pull/39440/commits
Checkshttps://github.com/nodejs/node/pull/39440/checks
Files changedhttps://github.com/nodejs/node/pull/39440/files
[v12.x] Fix build with ICU >= 68.https://github.com/nodejs/node/pull/39440#top
jameshilliardhttps://github.com/jameshilliard
nodejs:v12.x-staginghttps://github.com/nodejs/node/tree/v12.x-staging
jameshilliard:fix-icu-68https://github.com/jameshilliard/node/tree/fix-icu-68
https://github.com/jameshilliard
jameshilliardhttps://github.com/jameshilliard
Jul 19, 2021https://github.com/nodejs/node/pull/39440#issue-947474835
https://chromium-review.googlesource.com/c/v8/v8/+/2477751https://chromium-review.googlesource.com/c/v8/v8/+/2477751
Please reload this pagehttps://github.com/nodejs/node/pull/39440
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av12.x
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
Jul 19, 2021https://github.com/nodejs/node/pull/39440#event-5037408939
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 19, 2021https://github.com/nodejs/node/pull/39440#event-5037427924
https://github.com/aduh95
aduh95https://github.com/aduh95
Jul 19, 2021https://github.com/nodejs/node/pull/39440#issuecomment-882580278
v8/v8@035c305https://github.com/v8/v8/commit/035c305ce7761f51328b45f1bd83e26aef267c9d
https://github.com/nodejs/node/blob/master/doc/guides/maintaining-V8.md#backporting-to-abandoned-brancheshttps://github.com/nodejs/node/blob/master/doc/guides/maintaining-V8.md#backporting-to-abandoned-branches
Please reload this pagehttps://github.com/nodejs/node/pull/39440
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 19, 2021https://github.com/nodejs/node/pull/39440#issuecomment-882599827
v8/v8@035c305https://github.com/v8/v8/commit/035c305ce7761f51328b45f1bd83e26aef267c9d
https://github.com/nodejs/node/blob/master/doc/guides/maintaining-V8.md#backporting-to-abandoned-brancheshttps://github.com/nodejs/node/blob/master/doc/guides/maintaining-V8.md#backporting-to-abandoned-branches
v8/v8@035c305https://github.com/v8/v8/commit/035c305ce7761f51328b45f1bd83e26aef267c9d
#39068https://github.com/nodejs/node/pull/39068
Please reload this pagehttps://github.com/nodejs/node/pull/39440
https://github.com/jameshilliard
jameshilliardhttps://github.com/jameshilliard
Jul 19, 2021https://github.com/nodejs/node/pull/39440#issuecomment-882753878
v8/v8@035c305https://github.com/v8/v8/commit/035c305ce7761f51328b45f1bd83e26aef267c9d
Please reload this pagehttps://github.com/nodejs/node/pull/39440
https://github.com/jameshilliard
jameshilliardhttps://github.com/jameshilliard
Jul 19, 2021https://github.com/nodejs/node/pull/39440#issuecomment-882795876
v8/v8@035c305https://github.com/v8/v8/commit/035c305ce7761f51328b45f1bd83e26aef267c9d
#39068https://github.com/nodejs/node/pull/39068
#39451https://github.com/nodejs/node/pull/39451
Please reload this pagehttps://github.com/nodejs/node/pull/39440
https://github.com/richardlau
richardlauhttps://github.com/richardlau
force-pushedhttps://github.com/nodejs/node/compare/61c274b883f572280c4d28e5a201f87304d40667..6ac4a9b7d0e8211be8f8d02c5d884c4657d1391f
61c274bhttps://github.com/nodejs/node/commit/61c274b883f572280c4d28e5a201f87304d40667
6ac4a9bhttps://github.com/nodejs/node/commit/6ac4a9b7d0e8211be8f8d02c5d884c4657d1391f
Compare https://github.com/nodejs/node/compare/61c274b883f572280c4d28e5a201f87304d40667..6ac4a9b7d0e8211be8f8d02c5d884c4657d1391f
July 23, 2021 10:47https://github.com/nodejs/node/pull/39440#event-5060411367
https://github.com/jameshilliard
https://github.com/richardlau
Fix build with ICU >= 68.https://github.com/nodejs/node/pull/39440/commits/34a9207ea599fc1f7e4b76f05e60de1928c7bb95
34a9207https://github.com/nodejs/node/pull/39440/commits/34a9207ea599fc1f7e4b76f05e60de1928c7bb95
https://chromium-review.googlesource.com/c/v8/v8/+/2477751https://chromium-review.googlesource.com/c/v8/v8/+/2477751
https://github.com/richardlau
richardlauhttps://github.com/richardlau
force-pushedhttps://github.com/nodejs/node/compare/1504de672ec44080d08a97c479a23727a9c31d8b..34a9207ea599fc1f7e4b76f05e60de1928c7bb95
1504de6https://github.com/nodejs/node/commit/1504de672ec44080d08a97c479a23727a9c31d8b
34a9207https://github.com/nodejs/node/commit/34a9207ea599fc1f7e4b76f05e60de1928c7bb95
Compare https://github.com/nodejs/node/compare/1504de672ec44080d08a97c479a23727a9c31d8b..34a9207ea599fc1f7e4b76f05e60de1928c7bb95
July 23, 2021 11:45https://github.com/nodejs/node/pull/39440#event-5060635919
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 23, 2021https://github.com/nodejs/node/pull/39440#issuecomment-885582871
https://ci.nodejs.org/job/node-test-pull-request/39237/https://ci.nodejs.org/job/node-test-pull-request/39237/
Please reload this pagehttps://github.com/nodejs/node/pull/39440
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 23, 2021https://github.com/nodejs/node/pull/39440#issuecomment-885683486
#39451https://github.com/nodejs/node/pull/39451
Please reload this pagehttps://github.com/nodejs/node/pull/39440
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 23, 2021https://github.com/nodejs/node/pull/39440#event-5061424640
https://github.com/jameshilliard
jameshilliardhttps://github.com/jameshilliard
July 23, 2021 15:20https://github.com/nodejs/node/pull/39440#event-5061656242
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39440
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
Please reload this pagehttps://github.com/nodejs/node/pull/39440
https://github.com/jameshilliard
https://github.com/aduh95
https://github.com/richardlau
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.