| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d3444d30-d0e5-254d-e3fd-1c79c2291b3a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C338:2CFBC2:96B713:CD9936:6A4DDC51 |
| html-safe-nonce | a864e5e52168f101839b2fa2278379c5681a0831169c6521fbba3c6e00ce9554 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzM4OjJDRkJDMjo5NkI3MTM6Q0Q5OTM2OjZBNEREQzUxIiwidmlzaXRvcl9pZCI6IjI5NzAwNDc4MTkxNDkwNzM0OTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | fb14fb470a7487bffccf86a5ffd5f91e3054c5e4dd55b4445bdcc6d8e32328fe |
| hovercard-subject-tag | pull_request:687074815 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/39333/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4a8c2cc60fedef040c7cbeefa0a8fcc72260884f45e216a84ff7a52130a54f61/nodejs/node/pull/39333 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4a8c2cc60fedef040c7cbeefa0a8fcc72260884f45e216a84ff7a52130a54f61/nodejs/node/pull/39333 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ronag |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/39333#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39333 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39333 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/39333 |
| Reload | https://github.com/nodejs/node/pull/39333 |
| Reload | https://github.com/nodejs/node/pull/39333 |
| Please reload this page | https://github.com/nodejs/node/pull/39333 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/39333 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
963
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| ronag | https://github.com/ronag |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| nxtedition:tls-refactor-legacy | https://github.com/nxtedition/node/tree/tls-refactor-legacy |
| Conversation | https://github.com/nodejs/node/pull/39333 |
| Commits5 (5) | https://github.com/nodejs/node/pull/39333/commits |
| Checks | https://github.com/nodejs/node/pull/39333/checks |
| Files changed | https://github.com/nodejs/node/pull/39333/files |
| tls: refactor legacy | https://github.com/nodejs/node/pull/39333#top |
| ronag | https://github.com/ronag |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| nxtedition:tls-refactor-legacy | https://github.com/nxtedition/node/tree/tls-refactor-legacy |
|
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Jul 9, 2021 | https://github.com/nodejs/node/pull/39333#issue-941107491 |
| Please reload this page | https://github.com/nodejs/node/pull/39333 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
tls
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls |
| Jul 9, 2021 | https://github.com/nodejs/node/pull/39333#event-5002500713 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| jasnell | https://github.com/jasnell |
| mcollina | https://github.com/mcollina |
| July 9, 2021 22:51 | https://github.com/nodejs/node/pull/39333#event-5002500714 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Jul 9, 2021 | https://github.com/nodejs/node/pull/39333#event-5002501232 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/05527e6919076f9734d1de78fe4a117f174e1386..0c8ca4fc776173a81e800b3818cead135e03c414 |
| 05527e6 | https://github.com/nodejs/node/commit/05527e6919076f9734d1de78fe4a117f174e1386 |
| 0c8ca4f | https://github.com/nodejs/node/commit/0c8ca4fc776173a81e800b3818cead135e03c414 |
|
Compare
| https://github.com/nodejs/node/compare/05527e6919076f9734d1de78fe4a117f174e1386..0c8ca4fc776173a81e800b3818cead135e03c414 |
| July 9, 2021 22:51 | https://github.com/nodejs/node/pull/39333#event-5002501498 |
|
| https://github.com/ronag |
| tls: move legacy code into own file | https://github.com/nodejs/node/pull/39333/commits/c446fad9546b92c623fe6c9ea90fd148663dc8e7 |
| c446fad | https://github.com/nodejs/node/pull/39333/commits/c446fad9546b92c623fe6c9ea90fd148663dc8e7 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| force-pushed | https://github.com/nodejs/node/compare/0c8ca4fc776173a81e800b3818cead135e03c414..c446fad9546b92c623fe6c9ea90fd148663dc8e7 |
| 0c8ca4f | https://github.com/nodejs/node/commit/0c8ca4fc776173a81e800b3818cead135e03c414 |
| c446fad | https://github.com/nodejs/node/commit/c446fad9546b92c623fe6c9ea90fd148663dc8e7 |
|
Compare
| https://github.com/nodejs/node/compare/0c8ca4fc776173a81e800b3818cead135e03c414..c446fad9546b92c623fe6c9ea90fd148663dc8e7 |
| July 9, 2021 22:53 | https://github.com/nodejs/node/pull/39333#event-5002504754 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Jul 9, 2021 | https://github.com/nodejs/node/pull/39333#issuecomment-877497335 |
| Please reload this page | https://github.com/nodejs/node/pull/39333 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Jul 9, 2021 | https://github.com/nodejs/node/pull/39333#event-5002506442 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Jul 9, 2021 | https://github.com/nodejs/node/pull/39333#event-5002525381 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jul 9, 2021 | https://github.com/nodejs/node/pull/39333#event-5002532391 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 9, 2021 | https://github.com/nodejs/node/pull/39333#issuecomment-877501882 |
| https://ci.nodejs.org/job/node-test-pull-request/38928/ | https://ci.nodejs.org/job/node-test-pull-request/38928/ |
| Please reload this page | https://github.com/nodejs/node/pull/39333 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Jul 10, 2021
| https://github.com/nodejs/node/pull/39333#pullrequestreview-703480238 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/39333/files/c446fad9546b92c623fe6c9ea90fd148663dc8e7 |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/39333#pullrequestreview-703480238 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/39333 |
|
| https://github.com/ronag |
| fixup | https://github.com/nodejs/node/pull/39333/commits/694677a45efd2468ed341e52455cf0ae2423b529 |
| 694677a | https://github.com/nodejs/node/pull/39333/commits/694677a45efd2468ed341e52455cf0ae2423b529 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jul 10, 2021 | https://github.com/nodejs/node/pull/39333#event-5002991206 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jul 10, 2021 | https://github.com/nodejs/node/pull/39333#event-5002998343 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 10, 2021 | https://github.com/nodejs/node/pull/39333#issuecomment-877594924 |
| https://ci.nodejs.org/job/node-test-pull-request/38936/ | https://ci.nodejs.org/job/node-test-pull-request/38936/ |
| Please reload this page | https://github.com/nodejs/node/pull/39333 |
| ronag | https://github.com/ronag |
| July 10, 2021 10:32 | https://github.com/nodejs/node/pull/39333#commits-pushed-be942d6 |
|
| https://github.com/ronag |
| fixup | https://github.com/nodejs/node/pull/39333/commits/be942d6ee968df22a81108bf87df5c8be525671b |
| be942d6 | https://github.com/nodejs/node/pull/39333/commits/be942d6ee968df22a81108bf87df5c8be525671b |
|
| https://github.com/ronag |
| fixup | https://github.com/nodejs/node/pull/39333/commits/61c0d47cb23d718773eadbd6c4522c3fc5b01b51 |
| 61c0d47 | https://github.com/nodejs/node/pull/39333/commits/61c0d47cb23d718773eadbd6c4522c3fc5b01b51 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 10, 2021 | https://github.com/nodejs/node/pull/39333#issuecomment-877679780 |
| https://ci.nodejs.org/job/node-test-pull-request/38947/ | https://ci.nodejs.org/job/node-test-pull-request/38947/ |
| Please reload this page | https://github.com/nodejs/node/pull/39333 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 10, 2021 | https://github.com/nodejs/node/pull/39333#issuecomment-877691638 |
| https://ci.nodejs.org/job/node-test-pull-request/38949/ | https://ci.nodejs.org/job/node-test-pull-request/38949/ |
| Please reload this page | https://github.com/nodejs/node/pull/39333 |
|
| https://github.com/ronag |
| fixup | https://github.com/nodejs/node/pull/39333/commits/c3bcce7123a2d773a841e35bd60a553af883812e |
| c3bcce7 | https://github.com/nodejs/node/pull/39333/commits/c3bcce7123a2d773a841e35bd60a553af883812e |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 10, 2021 | https://github.com/nodejs/node/pull/39333#issuecomment-877694235 |
| Please reload this page | https://github.com/nodejs/node/pull/39333 |
| https://ci.nodejs.org/job/node-test-pull-request/38950/ | https://ci.nodejs.org/job/node-test-pull-request/38950/ |
| Please reload this page | https://github.com/nodejs/node/pull/39333 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| BridgeAR | https://github.com/BridgeAR |
| aduh95 | https://github.com/aduh95 |
| July 11, 2021 08:42 | https://github.com/nodejs/node/pull/39333#event-5003946253 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jul 11, 2021
| https://github.com/nodejs/node/pull/39333#pullrequestreview-703568037 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/39333/files/c3bcce7123a2d773a841e35bd60a553af883812e |
| lib/internal/tls/parse-cert-string.js | https://github.com/nodejs/node/pull/39333/files/c3bcce7123a2d773a841e35bd60a553af883812e#diff-44e832a766b2c562de411164587f0857784c41bf2664836e7a75c6a2a98aaa34 |
| aduh95 | https://github.com/aduh95 |
| Jul 11, 2021 | https://github.com/nodejs/node/pull/39333#discussion_r667453371 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/39333 |
| ronag | https://github.com/ronag |
|
Jul 11, 2021
| https://github.com/nodejs/node/pull/39333#ref-commit-5960f16 |
|
| https://github.com/ronag |
| tls: move legacy code into own file | https://github.com/nodejs/node/commit/5960f16713af08892c487beb1c60849a84bfd001 |
| 5960f16 | https://github.com/nodejs/node/commit/5960f16713af08892c487beb1c60849a84bfd001 |
| #39333 | https://github.com/nodejs/node/pull/39333 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Jul 11, 2021 | https://github.com/nodejs/node/pull/39333#issuecomment-877829943 |
| 5960f16 | https://github.com/nodejs/node/commit/5960f16713af08892c487beb1c60849a84bfd001 |
| Please reload this page | https://github.com/nodejs/node/pull/39333 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Jul 11, 2021 | https://github.com/nodejs/node/pull/39333#event-5004332473 |
| targos | https://github.com/targos |
|
Jul 13, 2021
| https://github.com/nodejs/node/pull/39333#ref-commit-dfe99d2 |
|
| https://github.com/ronag |
|
| https://github.com/targos |
| tls: move legacy code into own file | https://github.com/nodejs/node/commit/dfe99d2aac3bb80d80a0c0e05cb9f395b4f82406 |
| dfe99d2 | https://github.com/nodejs/node/commit/dfe99d2aac3bb80d80a0c0e05cb9f395b4f82406 |
| #39333 | https://github.com/nodejs/node/pull/39333 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jul 13, 2021
| https://github.com/nodejs/node/pull/39333#ref-pullrequest-942839117 |
|
v16.5.0 release proposal
#39373
| https://github.com/nodejs/node/pull/39373 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
dont-land-on-v14.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v14.x |
| Sep 4, 2021 | https://github.com/nodejs/node/pull/39333#event-5256363696 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39333 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/39333/files/c446fad9546b92c623fe6c9ea90fd148663dc8e7 |
|
| https://github.com/aduh95 |
|
aduh95
| https://github.com/aduh95 |
|
| https://github.com/nodejs/node/pull/39333/files/c3bcce7123a2d773a841e35bd60a553af883812e |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
tls
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls |
| Please reload this page | https://github.com/nodejs/node/pull/39333 |
|
| https://github.com/ronag |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mcollina |
|
| https://github.com/aduh95 |
|
| https://github.com/targos |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |