René's URL Explorer Experiment


Title: stream: don't emit prefinish after error or close by ronag · Pull Request #39332 · nodejs/node · GitHub

Open Graph Title: stream: don't emit prefinish after error or close by ronag · Pull Request #39332 · nodejs/node

X Title: stream: don't emit prefinish after error or close by ronag · Pull Request #39332 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Opengraph URL: https://github.com/nodejs/node/pull/39332

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d9066d91-b33f-c313-78b2-b0147743e4a7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9558:B72C9:148951A:1C73BE7:6A4DEF1B
html-safe-nonced80400a658c9b300b4d404e8593dad9124f196a88f2bf5cc0d8e309316f26e30
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTU4OkI3MkM5OjE0ODk1MUE6MUM3M0JFNzo2QTRERUYxQiIsInZpc2l0b3JfaWQiOiI3MzQ4MTUyMDE5NzA4NjY5NzIzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd31193df7be783b8fe43abf452d1ccd9f875dc428f8398862985b88936d6d835
hovercard-subject-tagpull_request:687071137
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/39332/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7fe17b8cfbd26ded055449a3c009ef27207ace80c9f45703a483b598d43ff44d/nodejs/node/pull/39332
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7fe17b8cfbd26ded055449a3c009ef27207ace80c9f45703a483b598d43ff44d/nodejs/node/pull/39332
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/39332#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39332
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39332
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/39332
Reloadhttps://github.com/nodejs/node/pull/39332
Reloadhttps://github.com/nodejs/node/pull/39332
Please reload this pagehttps://github.com/nodejs/node/pull/39332
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/39332
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:stream-prefinish-closehttps://github.com/nxtedition/node/tree/stream-prefinish-close
Conversationhttps://github.com/nodejs/node/pull/39332
Commits1 (1)https://github.com/nodejs/node/pull/39332/commits
Checkshttps://github.com/nodejs/node/pull/39332/checks
Files changedhttps://github.com/nodejs/node/pull/39332/files
stream: don't emit prefinish after error or closehttps://github.com/nodejs/node/pull/39332#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:stream-prefinish-closehttps://github.com/nxtedition/node/tree/stream-prefinish-close
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 9, 2021https://github.com/nodejs/node/pull/39332#issue-941103183
Please reload this pagehttps://github.com/nodejs/node/pull/39332
https://github.com/ronag
stream: don't emit prefinish after error or closehttps://github.com/nodejs/node/pull/39332/commits/3697a8ddfa8bf46a4326b0a7be2654df66b5ed2a
3697a8dhttps://github.com/nodejs/node/pull/39332/commits/3697a8ddfa8bf46a4326b0a7be2654df66b5ed2a
https://github.com/ronag
ronaghttps://github.com/ronag
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 9, 2021https://github.com/nodejs/node/pull/39332#event-5002474408
https://github.com/ronag
ronaghttps://github.com/ronag
mcollinahttps://github.com/mcollina
July 9, 2021 22:37https://github.com/nodejs/node/pull/39332#event-5002474411
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 9, 2021https://github.com/nodejs/node/pull/39332#issuecomment-877492100
Please reload this pagehttps://github.com/nodejs/node/pull/39332
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jul 9, 2021https://github.com/nodejs/node/pull/39332#event-5002474923
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 9, 2021https://github.com/nodejs/node/pull/39332#event-5002487967
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 9, 2021https://github.com/nodejs/node/pull/39332#issuecomment-877494472
https://ci.nodejs.org/job/node-test-pull-request/38927/https://ci.nodejs.org/job/node-test-pull-request/38927/
Please reload this pagehttps://github.com/nodejs/node/pull/39332
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 10, 2021 https://github.com/nodejs/node/pull/39332#pullrequestreview-703479955
View reviewed changes https://github.com/nodejs/node/pull/39332/files/3697a8ddfa8bf46a4326b0a7be2654df66b5ed2a
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/39332#pullrequestreview-703479955
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/39332
https://github.com/mcollina
mcollinahttps://github.com/mcollina
lts-watch-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v14.x
Jul 10, 2021https://github.com/nodejs/node/pull/39332#event-5002958747
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 10, 2021https://github.com/nodejs/node/pull/39332#issuecomment-877587012
Please reload this pagehttps://github.com/nodejs/node/pull/39332
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 10, 2021https://github.com/nodejs/node/pull/39332#issuecomment-877592438
Please reload this pagehttps://github.com/nodejs/node/pull/39332
https://ci.nodejs.org/job/node-test-pull-request/38935/https://ci.nodejs.org/job/node-test-pull-request/38935/
Please reload this pagehttps://github.com/nodejs/node/pull/39332
https://github.com/ronag
ronaghttps://github.com/ronag
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
review wanted https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jul 10, 2021https://github.com/nodejs/node/pull/39332#event-5002991477
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 10, 2021 https://github.com/nodejs/node/pull/39332#pullrequestreview-703535128
View reviewed changes https://github.com/nodejs/node/pull/39332/files/3697a8ddfa8bf46a4326b0a7be2654df66b5ed2a
ronaghttps://github.com/ronag
Jul 11, 2021 https://github.com/nodejs/node/pull/39332#ref-commit-7a7ba82
https://github.com/ronag
stream: don't emit prefinish after error or closehttps://github.com/nodejs/node/commit/7a7ba8223420a4d24a9d7bfb3e1e52ba4cc17452
7a7ba82https://github.com/nodejs/node/commit/7a7ba8223420a4d24a9d7bfb3e1e52ba4cc17452
#39332https://github.com/nodejs/node/pull/39332
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 11, 2021https://github.com/nodejs/node/pull/39332#issuecomment-877830056
7a7ba82https://github.com/nodejs/node/commit/7a7ba8223420a4d24a9d7bfb3e1e52ba4cc17452
Please reload this pagehttps://github.com/nodejs/node/pull/39332
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 11, 2021https://github.com/nodejs/node/pull/39332#event-5004333130
targoshttps://github.com/targos
Jul 13, 2021 https://github.com/nodejs/node/pull/39332#ref-commit-1fc6382
https://github.com/ronag
https://github.com/targos
stream: don't emit prefinish after error or closehttps://github.com/nodejs/node/commit/1fc6382942db5f177305836168c6baba45f8c82c
1fc6382https://github.com/nodejs/node/commit/1fc6382942db5f177305836168c6baba45f8c82c
#39332https://github.com/nodejs/node/pull/39332
https://github.com/targos
targoshttps://github.com/targos
Jul 13, 2021 https://github.com/nodejs/node/pull/39332#ref-pullrequest-942839117
v16.5.0 release proposal #39373 https://github.com/nodejs/node/pull/39373
https://github.com/targos
targoshttps://github.com/targos
backport-requested-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v14.x
Sep 4, 2021https://github.com/nodejs/node/pull/39332#event-5256257623
https://github.com/targos
targoshttps://github.com/targos
Sep 4, 2021https://github.com/nodejs/node/pull/39332#issuecomment-912937450
Please reload this pagehttps://github.com/nodejs/node/pull/39332
Please reload this pagehttps://github.com/nodejs/node/pull/39332
https://github.com/targos
targoshttps://github.com/targos
baking-for-lts https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abaking-for-lts
Sep 4, 2021https://github.com/nodejs/node/pull/39332#event-5256259171
https://github.com/martin-g
martin-ghttps://github.com/martin-g
Oct 6, 2021https://github.com/nodejs/node/pull/39332#issuecomment-937073358
apache/avro#1354https://github.com/apache/avro/pull/1354
https://github.com/apache/avro/blob/8f0b8d68c3fc10b6a5fc09bae4a5c30defe53897/lang/js/lib/protocols.js#L1050-L1103https://github.com/apache/avro/blob/8f0b8d68c3fc10b6a5fc09bae4a5c30defe53897/lang/js/lib/protocols.js#L1050-L1103
https://github.com/apache/avro/blob/8f0b8d68c3fc10b6a5fc09bae4a5c30defe53897/lang/js/test/test_protocols.js#L200-L219https://github.com/apache/avro/blob/8f0b8d68c3fc10b6a5fc09bae4a5c30defe53897/lang/js/test/test_protocols.js#L200-L219
Please reload this pagehttps://github.com/nodejs/node/pull/39332
https://github.com/martin-g
martin-ghttps://github.com/martin-g
Oct 6, 2021 https://github.com/nodejs/node/pull/39332#ref-pullrequest-1019112713
AVRO-3171 JS: fix test failures on Node.js 16 apache/avro#1354 https://github.com/apache/avro/pull/1354
https://github.com/targos
targoshttps://github.com/targos
baking-for-lts https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abaking-for-lts
backport-requested-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v14.x
Sep 16, 2022https://github.com/nodejs/node/pull/39332#event-7401952703
https://github.com/targos
targoshttps://github.com/targos
dont-land-on-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v14.x
Sep 16, 2022https://github.com/nodejs/node/pull/39332#event-7401953493
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39332
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/39332/files/3697a8ddfa8bf46a4326b0a7be2654df66b5ed2a
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/39332/files/3697a8ddfa8bf46a4326b0a7be2654df66b5ed2a
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
review wanted https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/39332
https://github.com/ronag
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/targos
https://github.com/martin-g
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.