René's URL Explorer Experiment


Title: stream: cleanup async handling by ronag · Pull Request #39329 · nodejs/node · GitHub

Open Graph Title: stream: cleanup async handling by ronag · Pull Request #39329 · nodejs/node

X Title: stream: cleanup async handling by ronag · Pull Request #39329 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Cleanup async stream method handling. Removes duplicate code and unifies behavior.

X Description: Cleanup async stream method handling. Removes duplicate code and unifies behavior.

Opengraph URL: https://github.com/nodejs/node/pull/39329

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ff404d20-e253-bb38-ff26-a5c111b74405
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE778:2CD26:497CD9:6BEF08:6A4E0A19
html-safe-nonceb09e1cf1435e173f805bf15ecc52b6fae7976e1a118cee422885f0d6e9260139
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzc4OjJDRDI2OjQ5N0NEOTo2QkVGMDg6NkE0RTBBMTkiLCJ2aXNpdG9yX2lkIjoiNjUwMjMzMjY4MTE5OTQyMTk3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac09a534ac0e4589e715eb52ea85819a762abea0b1d4687e5702ea50eb17846065
hovercard-subject-tagpull_request:686964394
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/39329/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/badf2d6eedbda218855d0d9d756ef9cbd363074285314604d6d8f65fe3b85ec7/nodejs/node/pull/39329
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/badf2d6eedbda218855d0d9d756ef9cbd363074285314604d6d8f65fe3b85ec7/nodejs/node/pull/39329
og:image:altCleanup async stream method handling. Removes duplicate code and unifies behavior.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
Nonedf0492960db29b4938cb72070351d6b1d0c6c0767b27ceb8394bbf4fcc0223c6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release51470c353b8a1f52a88d3e3cc2014b17ab8cc1ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/39329#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39329
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39329
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/39329
Reloadhttps://github.com/nodejs/node/pull/39329
Reloadhttps://github.com/nodejs/node/pull/39329
Please reload this pagehttps://github.com/nodejs/node/pull/39329
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/39329
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:stream-asynchttps://github.com/nxtedition/node/tree/stream-async
Conversationhttps://github.com/nodejs/node/pull/39329
Commits3 (3)https://github.com/nodejs/node/pull/39329/commits
Checkshttps://github.com/nodejs/node/pull/39329/checks
Files changedhttps://github.com/nodejs/node/pull/39329/files
stream: cleanup async handlinghttps://github.com/nodejs/node/pull/39329#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:stream-asynchttps://github.com/nxtedition/node/tree/stream-async
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 9, 2021https://github.com/nodejs/node/pull/39329#issue-940975979
Please reload this pagehttps://github.com/nodejs/node/pull/39329
Please reload this pagehttps://github.com/nodejs/node/pull/39329
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 9, 2021https://github.com/nodejs/node/pull/39329#issuecomment-877371791
Please reload this pagehttps://github.com/nodejs/node/pull/39329
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jul 9, 2021https://github.com/nodejs/node/pull/39329#event-5001692482
https://github.com/ronag
ronaghttps://github.com/ronag
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jul 9, 2021https://github.com/nodejs/node/pull/39329#event-5001694325
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/bb1557b0708e08e90c931e240cca6984b97acd48..9c108becfcf507884536d3e2c6d825c7bc746f53
bb1557bhttps://github.com/nodejs/node/commit/bb1557b0708e08e90c931e240cca6984b97acd48
9c108behttps://github.com/nodejs/node/commit/9c108becfcf507884536d3e2c6d825c7bc746f53
Compare https://github.com/nodejs/node/compare/bb1557b0708e08e90c931e240cca6984b97acd48..9c108becfcf507884536d3e2c6d825c7bc746f53
July 9, 2021 18:27https://github.com/nodejs/node/pull/39329#event-5001722005
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 9, 2021https://github.com/nodejs/node/pull/39329#event-5001730816
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 9, 2021https://github.com/nodejs/node/pull/39329#issuecomment-877377897
https://ci.nodejs.org/job/node-test-pull-request/38922/https://ci.nodejs.org/job/node-test-pull-request/38922/
Please reload this pagehttps://github.com/nodejs/node/pull/39329
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/495aa7ae9ee8a793a9331e005d76430709e3b525..71a01e014d0bc476a47b83b80f20b3c545be67b2
495aa7ahttps://github.com/nodejs/node/commit/495aa7ae9ee8a793a9331e005d76430709e3b525
71a01e0https://github.com/nodejs/node/commit/71a01e014d0bc476a47b83b80f20b3c545be67b2
Compare https://github.com/nodejs/node/compare/495aa7ae9ee8a793a9331e005d76430709e3b525..71a01e014d0bc476a47b83b80f20b3c545be67b2
July 9, 2021 18:36https://github.com/nodejs/node/pull/39329#event-5001753971
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 9, 2021 https://github.com/nodejs/node/pull/39329#pullrequestreview-703416883
View reviewed changes https://github.com/nodejs/node/pull/39329/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/39329#pullrequestreview-703416883
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/39329
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 9, 2021 https://github.com/nodejs/node/pull/39329#pullrequestreview-703420740
View reviewed changes https://github.com/nodejs/node/pull/39329/files
https://github.com/ronag
ronaghttps://github.com/ronag
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 9, 2021https://github.com/nodejs/node/pull/39329#event-5002439386
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 9, 2021https://github.com/nodejs/node/pull/39329#event-5002455535
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 9, 2021https://github.com/nodejs/node/pull/39329#issuecomment-877489094
https://ci.nodejs.org/job/node-test-pull-request/38926/https://ci.nodejs.org/job/node-test-pull-request/38926/
Please reload this pagehttps://github.com/nodejs/node/pull/39329
https://github.com/mcollina
mcollinahttps://github.com/mcollina
dont-land-on-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v12.x
baking-for-lts https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abaking-for-lts
Jul 10, 2021https://github.com/nodejs/node/pull/39329#event-5002960625
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 10, 2021https://github.com/nodejs/node/pull/39329#issuecomment-877633304
https://ci.nodejs.org/job/node-test-pull-request/38939/https://ci.nodejs.org/job/node-test-pull-request/38939/
Please reload this pagehttps://github.com/nodejs/node/pull/39329
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 10, 2021https://github.com/nodejs/node/pull/39329#issuecomment-877668135
https://ci.nodejs.org/job/node-test-pull-request/38945/https://ci.nodejs.org/job/node-test-pull-request/38945/
Please reload this pagehttps://github.com/nodejs/node/pull/39329
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 11, 2021https://github.com/nodejs/node/pull/39329#issuecomment-877763363
https://ci.nodejs.org/job/node-test-pull-request/38959/https://ci.nodejs.org/job/node-test-pull-request/38959/
Please reload this pagehttps://github.com/nodejs/node/pull/39329
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 11, 2021https://github.com/nodejs/node/pull/39329#issuecomment-877815242
https://ci.nodejs.org/job/node-test-pull-request/38964/https://ci.nodejs.org/job/node-test-pull-request/38964/
Please reload this pagehttps://github.com/nodejs/node/pull/39329
ronaghttps://github.com/ronag
July 11, 2021 18:42https://github.com/nodejs/node/pull/39329#commits-pushed-f115b89
https://github.com/ronag
stream: cleanup async handlinghttps://github.com/nodejs/node/pull/39329/commits/f115b89b5ec279e0ae7ad4ea1db7e9e38f22779e
f115b89https://github.com/nodejs/node/pull/39329/commits/f115b89b5ec279e0ae7ad4ea1db7e9e38f22779e
https://github.com/ronag
fixuphttps://github.com/nodejs/node/pull/39329/commits/873314c54912f38ca6edbe0fd5dd15e6468499db
873314chttps://github.com/nodejs/node/pull/39329/commits/873314c54912f38ca6edbe0fd5dd15e6468499db
https://github.com/ronag
fixuphttps://github.com/nodejs/node/pull/39329/commits/a722ca37e91c42af172bc19dd79f774920596867
a722ca3https://github.com/nodejs/node/pull/39329/commits/a722ca37e91c42af172bc19dd79f774920596867
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/0acc48e1f7780f46a25014456891d3544db4ba29..a722ca37e91c42af172bc19dd79f774920596867
0acc48ehttps://github.com/nodejs/node/commit/0acc48e1f7780f46a25014456891d3544db4ba29
a722ca3https://github.com/nodejs/node/commit/a722ca37e91c42af172bc19dd79f774920596867
Compare https://github.com/nodejs/node/compare/0acc48e1f7780f46a25014456891d3544db4ba29..a722ca37e91c42af172bc19dd79f774920596867
July 11, 2021 16:43https://github.com/nodejs/node/pull/39329#event-5004334333
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 11, 2021https://github.com/nodejs/node/pull/39329#issuecomment-877830267
https://ci.nodejs.org/job/node-test-pull-request/38965/https://ci.nodejs.org/job/node-test-pull-request/38965/
Please reload this pagehttps://github.com/nodejs/node/pull/39329
ronaghttps://github.com/ronag
Jul 11, 2021 https://github.com/nodejs/node/pull/39329#ref-commit-f2f6872
https://github.com/ronag
stream: cleanup async handlinghttps://github.com/nodejs/node/commit/f2f6872b5c9fd7a11884b2d8e9fa250dfb5e7b43
f2f6872https://github.com/nodejs/node/commit/f2f6872b5c9fd7a11884b2d8e9fa250dfb5e7b43
#39329https://github.com/nodejs/node/pull/39329
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 11, 2021https://github.com/nodejs/node/pull/39329#issuecomment-877834803
f2f6872https://github.com/nodejs/node/commit/f2f6872b5c9fd7a11884b2d8e9fa250dfb5e7b43
Please reload this pagehttps://github.com/nodejs/node/pull/39329
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 11, 2021https://github.com/nodejs/node/pull/39329#event-5004363142
targoshttps://github.com/targos
Jul 13, 2021 https://github.com/nodejs/node/pull/39329#ref-commit-cb32f69
https://github.com/ronag
https://github.com/targos
stream: cleanup async handlinghttps://github.com/nodejs/node/commit/cb32f69e005153fac2dc7cda33a6373435e430c2
cb32f69https://github.com/nodejs/node/commit/cb32f69e005153fac2dc7cda33a6373435e430c2
#39329https://github.com/nodejs/node/pull/39329
https://github.com/targos
targoshttps://github.com/targos
Jul 13, 2021 https://github.com/nodejs/node/pull/39329#ref-pullrequest-942839117
v16.5.0 release proposal #39373 https://github.com/nodejs/node/pull/39373
https://github.com/tchetwin
tchetwinhttps://github.com/tchetwin
Jul 26, 2021 https://github.com/nodejs/node/pull/39329#ref-issue-953186515
v16.5.0 change in async writable._final() behaviour #39535 https://github.com/nodejs/node/issues/39535
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 27, 2021 https://github.com/nodejs/node/pull/39329#ref-pullrequest-953169906
v16.6.0 proposal #39534 https://github.com/nodejs/node/pull/39534
https://github.com/Flarna
Flarnahttps://github.com/Flarna
Jul 27, 2021https://github.com/nodejs/node/pull/39329#issuecomment-887418012
@ronaghttps://github.com/ronag
#39535https://github.com/nodejs/node/issues/39535
Please reload this pagehttps://github.com/nodejs/node/pull/39329
https://github.com/ronag
ronaghttps://github.com/ronag
dont-land-on-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v14.x
Jul 27, 2021https://github.com/nodejs/node/pull/39329#event-5073597179
https://github.com/targos
targoshttps://github.com/targos
baking-for-lts https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abaking-for-lts
Sep 16, 2022https://github.com/nodejs/node/pull/39329#event-7401947416
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39329
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/39329/files/71a01e014d0bc476a47b83b80f20b3c545be67b2
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/39329/files/71a01e014d0bc476a47b83b80f20b3c545be67b2
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/39329
https://github.com/ronag
https://github.com/nodejs-github-bot
https://github.com/Flarna
https://github.com/mcollina
https://github.com/jasnell
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.