| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f69b9ca1-822a-5932-ec7b-d02c85a230c6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D038:306D2B:CE2D93:12175B1:6A4E86DC |
| html-safe-nonce | 4bbd65300bc81441845611d2c07dd9cdcf9a89de45aba4ef4605fb46187e027c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDM4OjMwNkQyQjpDRTJEOTM6MTIxNzVCMTo2QTRFODZEQyIsInZpc2l0b3JfaWQiOiIzNzk3ODI1MzY0NzE5Mzg3ODAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b5e3942430202d7728d158849bff22771211621c2100eecd5dacb6f4e00307d9 |
| hovercard-subject-tag | pull_request:686473910 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/39319/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b77caf84dfb397112d9c9ad7795afebfe6f4100dec81525fa1383c6be22618d5/nodejs/node/pull/39319 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b77caf84dfb397112d9c9ad7795afebfe6f4100dec81525fa1383c6be22618d5/nodejs/node/pull/39319 |
| og:image:alt | Fixes: #39205 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | himself65 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/39319#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39319 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39319 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/39319 |
| Reload | https://github.com/nodejs/node/pull/39319 |
| Reload | https://github.com/nodejs/node/pull/39319 |
| Please reload this page | https://github.com/nodejs/node/pull/39319 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/39319 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
965
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| himself65 | https://github.com/himself65 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| himself65:20210709-crypto-fix | https://github.com/himself65/node/tree/20210709-crypto-fix |
| Conversation | https://github.com/nodejs/node/pull/39319 |
| Commits17 (17) | https://github.com/nodejs/node/pull/39319/commits |
| Checks | https://github.com/nodejs/node/pull/39319/checks |
| Files changed | https://github.com/nodejs/node/pull/39319/files |
| crypto: fix generateKeyPair with encoding 'jwk' | https://github.com/nodejs/node/pull/39319#top |
| himself65 | https://github.com/himself65 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| himself65:20210709-crypto-fix | https://github.com/himself65/node/tree/20210709-crypto-fix |
|
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
| Jul 9, 2021 | https://github.com/nodejs/node/pull/39319#issue-940396804 |
| #39205 | https://github.com/nodejs/node/issues/39205 |
| Please reload this page | https://github.com/nodejs/node/pull/39319 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
| Jul 9, 2021 | https://github.com/nodejs/node/pull/39319#event-4998219917 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
| jasnell | https://github.com/jasnell |
| July 9, 2021 04:09 | https://github.com/nodejs/node/pull/39319#event-4998219924 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Jul 9, 2021 | https://github.com/nodejs/node/pull/39319#event-4998220520 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
| Jul 9, 2021 | https://github.com/nodejs/node/pull/39319#event-4998257830 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
| force-pushed | https://github.com/nodejs/node/compare/80509570c29652cbbfa3cedf3b42594ad839e81f..68df3f7a00683d0e4261cccbbab5766e75fd8470 |
| 8050957 | https://github.com/nodejs/node/commit/80509570c29652cbbfa3cedf3b42594ad839e81f |
| 68df3f7 | https://github.com/nodejs/node/commit/68df3f7a00683d0e4261cccbbab5766e75fd8470 |
|
Compare
| https://github.com/nodejs/node/compare/80509570c29652cbbfa3cedf3b42594ad839e81f..68df3f7a00683d0e4261cccbbab5766e75fd8470 |
| July 9, 2021 04:52 | https://github.com/nodejs/node/pull/39319#event-4998315818 |
| https://github.com/VoltrexKeyva |
| VoltrexKeyva | https://github.com/VoltrexKeyva |
|
Jul 9, 2021
| https://github.com/nodejs/node/pull/39319#pullrequestreview-702722363 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/39319/files |
| lib/internal/crypto/keygen.js | https://github.com/nodejs/node/pull/39319/files#diff-dce5609306b3cc0cf6380ac524959f6b6de6fced1c42fd1ed0e8175d1f6b23df |
| Please reload this page | https://github.com/nodejs/node/pull/39319 |
| https://github.com/VoltrexKeyva |
| VoltrexKeyva | https://github.com/VoltrexKeyva |
|
Jul 9, 2021
| https://github.com/nodejs/node/pull/39319#pullrequestreview-702729378 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/39319/files |
| lib/internal/crypto/keygen.js | https://github.com/nodejs/node/pull/39319/files#diff-dce5609306b3cc0cf6380ac524959f6b6de6fced1c42fd1ed0e8175d1f6b23df |
| Please reload this page | https://github.com/nodejs/node/pull/39319 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 10, 2021 | https://github.com/nodejs/node/pull/39319#issuecomment-877687961 |
| Please reload this page | https://github.com/nodejs/node/pull/39319 |
| https://github.com/panva |
| panva | https://github.com/panva |
| July 10, 2021 21:03 | https://github.com/nodejs/node/pull/39319#event-5003592930 |
| https://github.com/panva |
| panva | https://github.com/panva |
|
Jul 11, 2021
| https://github.com/nodejs/node/pull/39319#pullrequestreview-703556346 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/39319/files |
| panva | https://github.com/panva |
| Please reload this page | https://github.com/nodejs/node/pull/39319 |
| https://github.com/nodejs/node/pull/39319#pullrequestreview-703556346 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @himself65 | https://github.com/himself65 |
| https://github.com/nodejs/node/blob/v16.4.2/lib/internal/crypto/keys.js#L240-L247 | https://github.com/nodejs/node/blob/v16.4.2/lib/internal/crypto/keys.js#L240-L247 |
| https://github.com/nodejs/node/blob/v16.4.2/lib/internal/crypto/keys.js#L193-L213 | https://github.com/nodejs/node/blob/v16.4.2/lib/internal/crypto/keys.js#L193-L213 |
| Please reload this page | https://github.com/nodejs/node/pull/39319 |
| test/parallel/test-crypto-keygen.js | https://github.com/nodejs/node/pull/39319/files#diff-a8ca9cf1f986d6c6b75d22592ed05f4726e34b37ae8583bb47d09b69183a1474 |
| Please reload this page | https://github.com/nodejs/node/pull/39319 |
| https://github.com/panva |
| panva | https://github.com/panva |
|
Jul 11, 2021
| https://github.com/nodejs/node/pull/39319#pullrequestreview-703558307 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/39319/files |
| test/parallel/test-crypto-keygen.js | https://github.com/nodejs/node/pull/39319/files#diff-a8ca9cf1f986d6c6b75d22592ed05f4726e34b37ae8583bb47d09b69183a1474 |
| Please reload this page | https://github.com/nodejs/node/pull/39319 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
| Jul 12, 2021 | https://github.com/nodejs/node/pull/39319#issuecomment-877940315 |
| Please reload this page | https://github.com/nodejs/node/pull/39319 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
| force-pushed | https://github.com/nodejs/node/compare/da40de34817dd282cba575daa47cc91637fb8f3a..790e4ff77f9dc500c495b80f7321a6092dfba6b9 |
| da40de3 | https://github.com/nodejs/node/commit/da40de34817dd282cba575daa47cc91637fb8f3a |
| 790e4ff | https://github.com/nodejs/node/commit/790e4ff77f9dc500c495b80f7321a6092dfba6b9 |
|
Compare
| https://github.com/nodejs/node/compare/da40de34817dd282cba575daa47cc91637fb8f3a..790e4ff77f9dc500c495b80f7321a6092dfba6b9 |
| July 14, 2021 02:51 | https://github.com/nodejs/node/pull/39319#event-5017168604 |
| himself65 | https://github.com/himself65 |
| July 19, 2021 11:00 | https://github.com/nodejs/node/pull/39319#commits-pushed-032bb15 |
|
| https://github.com/himself65 |
| crypto: fix generateKeyPair with encoding 'jwk' | https://github.com/nodejs/node/pull/39319/commits/032bb15b367f4598634761b64678d575f328fb39 |
| 032bb15 | https://github.com/nodejs/node/pull/39319/commits/032bb15b367f4598634761b64678d575f328fb39 |
| nodejs#39205 | https://github.com/nodejs/node/issues/39205 |
|
| https://github.com/himself65 |
|
| https://github.com/VoltrexKeyva |
| fixup!: Update lib/internal/crypto/keygen.js | https://github.com/nodejs/node/pull/39319/commits/edcc4c17942d1240da50837861a6e5f71497795d |
| edcc4c1 | https://github.com/nodejs/node/pull/39319/commits/edcc4c17942d1240da50837861a6e5f71497795d |
|
| https://github.com/himself65 |
|
| https://github.com/VoltrexKeyva |
| fixup!: Update lib/internal/crypto/keygen.js | https://github.com/nodejs/node/pull/39319/commits/5a204974f8e5c12d7feb53e71cabebd00a31b8e8 |
| 5a20497 | https://github.com/nodejs/node/pull/39319/commits/5a204974f8e5c12d7feb53e71cabebd00a31b8e8 |
|
| https://github.com/himself65 |
|
| https://github.com/panva |
| fixup!: Update test/parallel/test-crypto-keygen.js | https://github.com/nodejs/node/pull/39319/commits/f81c8594ace5c1d0da1670c6d9624d706e4b0075 |
| f81c859 | https://github.com/nodejs/node/pull/39319/commits/f81c8594ace5c1d0da1670c6d9624d706e4b0075 |
|
| https://github.com/himself65 |
|
| https://github.com/panva |
| fixup!: Update test/parallel/test-crypto-keygen.js | https://github.com/nodejs/node/pull/39319/commits/5d0b081dd765e37039e7eece29e1e5a548aefdab |
| 5d0b081 | https://github.com/nodejs/node/pull/39319/commits/5d0b081dd765e37039e7eece29e1e5a548aefdab |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
| force-pushed | https://github.com/nodejs/node/compare/790e4ff77f9dc500c495b80f7321a6092dfba6b9..5d0b081dd765e37039e7eece29e1e5a548aefdab |
| 790e4ff | https://github.com/nodejs/node/commit/790e4ff77f9dc500c495b80f7321a6092dfba6b9 |
| 5d0b081 | https://github.com/nodejs/node/commit/5d0b081dd765e37039e7eece29e1e5a548aefdab |
|
Compare
| https://github.com/nodejs/node/compare/790e4ff77f9dc500c495b80f7321a6092dfba6b9..5d0b081dd765e37039e7eece29e1e5a548aefdab |
| July 19, 2021 03:01 | https://github.com/nodejs/node/pull/39319#event-5035892723 |
| himself65 | https://github.com/himself65 |
| July 19, 2021 14:05 | https://github.com/nodejs/node/pull/39319#commits-pushed-a5672f1 |
|
| https://github.com/himself65 |
| fixup!: passing format 'jwk' | https://github.com/nodejs/node/pull/39319/commits/a5672f111a0f887bc62e2eea89989bdc136cc34b |
| a5672f1 | https://github.com/nodejs/node/pull/39319/commits/a5672f111a0f887bc62e2eea89989bdc136cc34b |
|
| https://github.com/himself65 |
| fixup!: move crv_name check to c++ part | https://github.com/nodejs/node/pull/39319/commits/95bd164a9bad1fc2b690e204e7b2a57ed78b1a2f |
| 95bd164 | https://github.com/nodejs/node/pull/39319/commits/95bd164a9bad1fc2b690e204e7b2a57ed78b1a2f |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
| Jul 19, 2021 | https://github.com/nodejs/node/pull/39319#issuecomment-882318246 |
| Please reload this page | https://github.com/nodejs/node/pull/39319 |
| himself65 | https://github.com/himself65 |
| July 19, 2021 15:40 | https://github.com/nodejs/node/pull/39319#commits-pushed-353a397 |
|
| https://github.com/himself65 |
| fixup!: lint fixes | https://github.com/nodejs/node/pull/39319/commits/353a397f9ee7912ddd6cc382794b60075ae28941 |
| 353a397 | https://github.com/nodejs/node/pull/39319/commits/353a397f9ee7912ddd6cc382794b60075ae28941 |
|
| https://github.com/himself65 |
| fixup!: remove unused | https://github.com/nodejs/node/pull/39319/commits/bf63e1a51d75ebb8ea093f1dfbc12e519138b273 |
| bf63e1a | https://github.com/nodejs/node/pull/39319/commits/bf63e1a51d75ebb8ea093f1dfbc12e519138b273 |
|
| https://github.com/himself65 |
| fixup!: cpp lint fix | https://github.com/nodejs/node/pull/39319/commits/b9eb514b1b6f0aadcb24bb76be256d377be40108 |
| b9eb514 | https://github.com/nodejs/node/pull/39319/commits/b9eb514b1b6f0aadcb24bb76be256d377be40108 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
| Jul 19, 2021 | https://github.com/nodejs/node/pull/39319#issuecomment-882320919 |
| node/src/crypto/crypto_ec.cc | https://github.com/nodejs/node/blob/95bd164a9bad1fc2b690e204e7b2a57ed78b1a2f/src/crypto/crypto_ec.cc#L790-L812 |
| 95bd164 | https://github.com/nodejs/node/commit/95bd164a9bad1fc2b690e204e7b2a57ed78b1a2f |
| Please reload this page | https://github.com/nodejs/node/pull/39319 |
| https://github.com/panva |
| panva | https://github.com/panva |
| tniessen | https://github.com/tniessen |
| July 19, 2021 12:46 | https://github.com/nodejs/node/pull/39319#event-5038230398 |
| https://github.com/panva |
| panva | https://github.com/panva |
| stale review | https://github.com/nodejs/node/pull/39319#pullrequestreview-703558307 |
| July 19, 2021 13:28 | https://github.com/nodejs/node/pull/39319#event-5038467781 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39319 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39319 |
| https://github.com/panva |
| panva | https://github.com/panva |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Jul 19, 2021 | https://github.com/nodejs/node/pull/39319#event-5040668902 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39319 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
| Jul 20, 2021 | https://github.com/nodejs/node/pull/39319#issuecomment-883038681 |
| Please reload this page | https://github.com/nodejs/node/pull/39319 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39319 |
| https://github.com/panva |
| panva | https://github.com/panva |
|
Jul 20, 2021
| https://github.com/nodejs/node/pull/39319#pullrequestreview-710395874 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/39319/files/700fc5fc986a1e4372d095634ca0a84f73c267fd |
| https://github.com/panva |
| panva | https://github.com/panva |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jul 20, 2021 | https://github.com/nodejs/node/pull/39319#event-5043329468 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 20, 2021 | https://github.com/nodejs/node/pull/39319#issuecomment-883422896 |
| https://ci.nodejs.org/job/node-test-pull-request/39170/ | https://ci.nodejs.org/job/node-test-pull-request/39170/ |
| Please reload this page | https://github.com/nodejs/node/pull/39319 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
| Jul 23, 2021 | https://github.com/nodejs/node/pull/39319#issuecomment-885755224 |
| Please reload this page | https://github.com/nodejs/node/pull/39319 |
| https://github.com/panva |
| panva | https://github.com/panva |
| Jul 24, 2021 | https://github.com/nodejs/node/pull/39319#issuecomment-886036394 |
| Please reload this page | https://github.com/nodejs/node/pull/39319 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jul 26, 2021
| https://github.com/nodejs/node/pull/39319#pullrequestreview-715007207 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/39319/files/700fc5fc986a1e4372d095634ca0a84f73c267fd |
| https://github.com/panva |
| panva | https://github.com/panva |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Jul 26, 2021 | https://github.com/nodejs/node/pull/39319#event-5069269161 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jul 26, 2021 | https://github.com/nodejs/node/pull/39319#issuecomment-886819590 |
| 257312a | https://github.com/nodejs/node/commit/257312ac7562578dd91ece1e6efd9df1c73a5629 |
| Please reload this page | https://github.com/nodejs/node/pull/39319 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jul 26, 2021 | https://github.com/nodejs/node/pull/39319#event-5069278959 |
| jasnell | https://github.com/jasnell |
|
Jul 26, 2021
| https://github.com/nodejs/node/pull/39319#ref-commit-257312a |
|
| https://github.com/himself65 |
|
| https://github.com/jasnell |
| crypto: fix generateKeyPair with encoding 'jwk' | https://github.com/nodejs/node/commit/257312ac7562578dd91ece1e6efd9df1c73a5629 |
| 257312a | https://github.com/nodejs/node/commit/257312ac7562578dd91ece1e6efd9df1c73a5629 |
| #39205 | https://github.com/nodejs/node/issues/39205 |
| #39319 | https://github.com/nodejs/node/pull/39319 |
| https://github.com/panva |
| panva | https://github.com/panva |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Jul 26, 2021 | https://github.com/nodejs/node/pull/39319#event-5069284168 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
| July 30, 2021 12:50 | https://github.com/nodejs/node/pull/39319#event-5091310580 |
| targos | https://github.com/targos |
|
Aug 2, 2021
| https://github.com/nodejs/node/pull/39319#ref-commit-cbf6a01 |
|
| https://github.com/himself65 |
|
| https://github.com/targos |
| crypto: fix generateKeyPair with encoding 'jwk' | https://github.com/nodejs/node/commit/cbf6a01c177c5acbe3a606cffe4dfb5b8007964b |
| cbf6a01 | https://github.com/nodejs/node/commit/cbf6a01c177c5acbe3a606cffe4dfb5b8007964b |
| #39205 | https://github.com/nodejs/node/issues/39205 |
| #39319 | https://github.com/nodejs/node/pull/39319 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Aug 2, 2021
| https://github.com/nodejs/node/pull/39319#ref-pullrequest-958377911 |
|
v16.6.1 release proposal
#39631
| https://github.com/nodejs/node/pull/39631 |
| codebytere | https://github.com/codebytere |
|
Aug 9, 2021
| https://github.com/nodejs/node/pull/39319#ref-commit-542f156 |
|
| https://github.com/codebytere |
| crypto: fix generateKeyPair with encoding 'jwk' | https://github.com/electron/electron/commit/542f1567eae12d780a36652015e573c7a165e02b |
| 542f156 | https://github.com/electron/electron/commit/542f1567eae12d780a36652015e573c7a165e02b |
| nodejs/node#39319 | https://github.com/nodejs/node/pull/39319 |
| codebytere | https://github.com/codebytere |
|
Aug 9, 2021
| https://github.com/nodejs/node/pull/39319#ref-commit-7dc05d3 |
|
| https://github.com/codebytere |
| crypto: fix generateKeyPair with encoding 'jwk' | https://github.com/electron/electron/commit/7dc05d328eb034b1df0357f6a187145a53f893df |
| 7dc05d3 | https://github.com/electron/electron/commit/7dc05d328eb034b1df0357f6a187145a53f893df |
| nodejs/node#39319 | https://github.com/nodejs/node/pull/39319 |
| codebytere | https://github.com/codebytere |
|
Aug 18, 2021
| https://github.com/nodejs/node/pull/39319#ref-commit-9001f6b |
|
| https://github.com/codebytere |
| crypto: fix generateKeyPair with encoding 'jwk' | https://github.com/electron/electron/commit/9001f6b9865c04380cee99e46f5fe2bee254aba3 |
| 9001f6b | https://github.com/electron/electron/commit/9001f6b9865c04380cee99e46f5fe2bee254aba3 |
| nodejs/node#39319 | https://github.com/nodejs/node/pull/39319 |
| codebytere | https://github.com/codebytere |
|
Aug 18, 2021
| https://github.com/nodejs/node/pull/39319#ref-commit-ee1cc59 |
|
| https://github.com/codebytere |
| crypto: fix generateKeyPair with encoding 'jwk' | https://github.com/electron/electron/commit/ee1cc59857869e9c29ee8a5dd7f675e2d4549d0f |
| ee1cc59 | https://github.com/electron/electron/commit/ee1cc59857869e9c29ee8a5dd7f675e2d4549d0f |
| nodejs/node#39319 | https://github.com/nodejs/node/pull/39319 |
| codebytere | https://github.com/codebytere |
|
Aug 20, 2021
| https://github.com/nodejs/node/pull/39319#ref-commit-fb990ba |
|
| https://github.com/apps/electron-roller |
|
| https://github.com/codebytere |
|
| https://github.com/apps/patchup |
| chore: bump node to v16.7.0 (main) ( | https://github.com/electron/electron/commit/fb990ba1eb5628820557f5d375fb3b5d827970e9 |
| #30350 | https://github.com/electron/electron/pull/30350 |
| ) | https://github.com/electron/electron/commit/fb990ba1eb5628820557f5d375fb3b5d827970e9 |
| fb990ba | https://github.com/electron/electron/commit/fb990ba1eb5628820557f5d375fb3b5d827970e9 |
| nodejs/node#39319 | https://github.com/nodejs/node/pull/39319 |
| nodejs/node#39293 | https://github.com/nodejs/node/pull/39293 |
| nodejs/node#39378 | https://github.com/nodejs/node/pull/39378 |
| nodejs/node#39386 | https://github.com/nodejs/node/pull/39386 |
| nodejs/node#39319 | https://github.com/nodejs/node/pull/39319 |
| nodejs/node#39462 | https://github.com/nodejs/node/pull/39462 |
| nodejs/node#39653 | https://github.com/nodejs/node/pull/39653 |
| nodejs/node#39724 | https://github.com/nodejs/node/pull/39724 |
| nodejs/node#39525 | https://github.com/nodejs/node/pull/39525 |
| https://github.com/panva |
| panva | https://github.com/panva |
|
Aug 21, 2021
| https://github.com/nodejs/node/pull/39319#ref-pullrequest-976108016 |
|
crypto: fix JWK RSA-PSS SubtleCrypto.exportKey
#39828
| https://github.com/nodejs/node/pull/39828 |
| BlackHole1 | https://github.com/BlackHole1 |
|
Aug 30, 2021
| https://github.com/nodejs/node/pull/39319#ref-commit-8f39830 |
|
| https://github.com/apps/electron-roller |
|
| https://github.com/codebytere |
|
| https://github.com/apps/patchup |
|
| https://github.com/BlackHole1 |
| chore: bump node to v16.7.0 (main) ( | https://github.com/BlackHole1/electron/commit/8f398306f034f3be6156c3b8ca9c90fccc00a432 |
| electron#30350 | https://github.com/electron/electron/pull/30350 |
| ) | https://github.com/BlackHole1/electron/commit/8f398306f034f3be6156c3b8ca9c90fccc00a432 |
| 8f39830 | https://github.com/BlackHole1/electron/commit/8f398306f034f3be6156c3b8ca9c90fccc00a432 |
| nodejs/node#39319 | https://github.com/nodejs/node/pull/39319 |
| nodejs/node#39293 | https://github.com/nodejs/node/pull/39293 |
| nodejs/node#39378 | https://github.com/nodejs/node/pull/39378 |
| nodejs/node#39386 | https://github.com/nodejs/node/pull/39386 |
| nodejs/node#39319 | https://github.com/nodejs/node/pull/39319 |
| nodejs/node#39462 | https://github.com/nodejs/node/pull/39462 |
| nodejs/node#39653 | https://github.com/nodejs/node/pull/39653 |
| nodejs/node#39724 | https://github.com/nodejs/node/pull/39724 |
| nodejs/node#39525 | https://github.com/nodejs/node/pull/39525 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
dont-land-on-v14.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v14.x |
| Sep 4, 2021 | https://github.com/nodejs/node/pull/39319#event-5256412422 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39319 |
|
| https://github.com/panva |
|
panva
| https://github.com/panva |
|
| https://github.com/nodejs/node/pull/39319/files/700fc5fc986a1e4372d095634ca0a84f73c267fd |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/39319/files/700fc5fc986a1e4372d095634ca0a84f73c267fd |
|
| https://github.com/tniessen |
|
tniessen
| https://github.com/tniessen |
|
| https://github.com/VoltrexKeyva |
|
VoltrexKeyva
| https://github.com/VoltrexKeyva |
|
| https://github.com/nodejs/node/pull/39319/files/89791149ff6841782208b8035efa0ab25f0f74ca |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
Using JWK as encoding format for public key in crypto.generateKeyPairSync() throws an error
| https://github.com/nodejs/node/issues/39205 |
| Please reload this page | https://github.com/nodejs/node/pull/39319 |
|
| https://github.com/himself65 |
|
| https://github.com/Trott |
|
| https://github.com/panva |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/jasnell |
|
| https://github.com/VoltrexKeyva |
|
| https://github.com/targos |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |