René's URL Explorer Experiment


Title: streams: use finished for pump by ronag · Pull Request #39203 · nodejs/node · GitHub

Open Graph Title: streams: use finished for pump by ronag · Pull Request #39203 · nodejs/node

X Title: streams: use finished for pump by ronag · Pull Request #39203 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Re-use existing compay logic for pump by using finished. Also cleans up logic a bit.

X Description: Re-use existing compay logic for pump by using finished. Also cleans up logic a bit.

Opengraph URL: https://github.com/nodejs/node/pull/39203

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c5b5f62e-a396-095e-bb65-983226f2e9c3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8408:2373EB:9B8CD2:D1ABEF:6A4ECD4F
html-safe-nonce5123488d3d5597368cc5a0f3a0adfb4829b7106225d750a86fa4d0700582dbda
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDA4OjIzNzNFQjo5QjhDRDI6RDFBQkVGOjZBNEVDRDRGIiwidmlzaXRvcl9pZCI6IjU4NDEyMDQ5MjA3NjI0MjA1NTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace87dd41d053416d27d1e405ee81a9c47817d9eca31c4f4558d519852a8ae7838
hovercard-subject-tagpull_request:680650416
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/39203/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c3e4bcf2f4734f27466fc46407eca855f829ca1fe667583ff55196533d861c58/nodejs/node/pull/39203
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c3e4bcf2f4734f27466fc46407eca855f829ca1fe667583ff55196533d861c58/nodejs/node/pull/39203
og:image:altRe-use existing compay logic for pump by using finished. Also cleans up logic a bit.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/39203#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39203
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39203
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/39203
Reloadhttps://github.com/nodejs/node/pull/39203
Reloadhttps://github.com/nodejs/node/pull/39203
Please reload this pagehttps://github.com/nodejs/node/pull/39203
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/39203
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:pump4https://github.com/nxtedition/node/tree/pump4
Conversationhttps://github.com/nodejs/node/pull/39203
Commits4 (4)https://github.com/nodejs/node/pull/39203/commits
Checkshttps://github.com/nodejs/node/pull/39203/checks
Files changedhttps://github.com/nodejs/node/pull/39203/files
streams: use finished for pumphttps://github.com/nodejs/node/pull/39203#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:pump4https://github.com/nxtedition/node/tree/pump4
https://github.com/ronag
ronaghttps://github.com/ronag
Jun 30, 2021https://github.com/nodejs/node/pull/39203#issue-933445543
Please reload this pagehttps://github.com/nodejs/node/pull/39203
https://github.com/ronag
streams: use finished for pumphttps://github.com/nodejs/node/pull/39203/commits/e9a2cc4f73c42c7e9b54559c5e83efe16b1dffb3
e9a2cc4https://github.com/nodejs/node/pull/39203/commits/e9a2cc4f73c42c7e9b54559c5e83efe16b1dffb3
https://github.com/ronag
ronaghttps://github.com/ronag
mcollinahttps://github.com/mcollina
June 30, 2021 08:36https://github.com/nodejs/node/pull/39203#event-4958106689
https://github.com/ronag
ronaghttps://github.com/ronag
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Jun 30, 2021https://github.com/nodejs/node/pull/39203#event-4958107189
https://github.com/ronag
ronaghttps://github.com/ronag
Jun 30, 2021https://github.com/nodejs/node/pull/39203#issuecomment-871206960
Please reload this pagehttps://github.com/nodejs/node/pull/39203
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jun 30, 2021https://github.com/nodejs/node/pull/39203#event-4958108018
https://github.com/ronag
ronaghttps://github.com/ronag
Jun 30, 2021 https://github.com/nodejs/node/pull/39203#pullrequestreview-695849307
View reviewed changes https://github.com/nodejs/node/pull/39203/files/e9a2cc4f73c42c7e9b54559c5e83efe16b1dffb3
test/parallel/test-stream-pipeline.jshttps://github.com/nodejs/node/pull/39203/files/e9a2cc4f73c42c7e9b54559c5e83efe16b1dffb3#diff-a67241f46cd58ac94c8d56acb3b727310465bdf493535654f71bb384f8a80057
ronaghttps://github.com/ronag
Jun 30, 2021https://github.com/nodejs/node/pull/39203#discussion_r661250846
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/39203
ronaghttps://github.com/ronag
June 30, 2021 10:39https://github.com/nodejs/node/pull/39203#commits-pushed-882f412
https://github.com/ronag
fixuphttps://github.com/nodejs/node/pull/39203/commits/882f4122b9a3d71ebd6c08737a61f8f063124373
882f412https://github.com/nodejs/node/pull/39203/commits/882f4122b9a3d71ebd6c08737a61f8f063124373
https://github.com/ronag
fixuphttps://github.com/nodejs/node/pull/39203/commits/a4a04d00c099a48e3399d685d60b97532b87c8d0
a4a04d0https://github.com/nodejs/node/pull/39203/commits/a4a04d00c099a48e3399d685d60b97532b87c8d0
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jun 30, 2021 https://github.com/nodejs/node/pull/39203#pullrequestreview-695887832
View reviewed changes https://github.com/nodejs/node/pull/39203/files/a4a04d00c099a48e3399d685d60b97532b87c8d0
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/39203#pullrequestreview-695887832
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/39203
https://github.com/ronag
ronaghttps://github.com/ronag
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jun 30, 2021https://github.com/nodejs/node/pull/39203#event-4958351844
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 30, 2021https://github.com/nodejs/node/pull/39203#issuecomment-871238602
https://ci.nodejs.org/job/node-test-pull-request/38816/https://ci.nodejs.org/job/node-test-pull-request/38816/
Please reload this pagehttps://github.com/nodejs/node/pull/39203
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Jun 30, 2021https://github.com/nodejs/node/pull/39203#issuecomment-871373408
Please reload this pagehttps://github.com/nodejs/node/pull/39203
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Jun 30, 2021 https://github.com/nodejs/node/pull/39203#pullrequestreview-696124589
View reviewed changes https://github.com/nodejs/node/pull/39203/files/a4a04d00c099a48e3399d685d60b97532b87c8d0
https://github.com/aduh95
aduh95https://github.com/aduh95
Jul 1, 2021 https://github.com/nodejs/node/pull/39203#pullrequestreview-697334254
View reviewed changes https://github.com/nodejs/node/pull/39203/files/a4a04d00c099a48e3399d685d60b97532b87c8d0
lib/internal/streams/pipeline.jshttps://github.com/nodejs/node/pull/39203/files/a4a04d00c099a48e3399d685d60b97532b87c8d0#diff-95c23fb6674af85f6f23a374851af6cccf58fb4617d73897df5078ba537a862c
Please reload this pagehttps://github.com/nodejs/node/pull/39203
https://github.com/ronag
https://github.com/aduh95
Update lib/internal/streams/pipeline.jshttps://github.com/nodejs/node/pull/39203/commits/bc3e7eadbba73426198a02331d40160a7795521a
bc3e7eahttps://github.com/nodejs/node/pull/39203/commits/bc3e7eadbba73426198a02331d40160a7795521a
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 2, 2021https://github.com/nodejs/node/pull/39203#issuecomment-872809137
3203396https://github.com/nodejs/node/commit/320339630d0366298c9c62a537bcfeec62b9d038
Please reload this pagehttps://github.com/nodejs/node/pull/39203
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 2, 2021https://github.com/nodejs/node/pull/39203#event-4970052464
ronaghttps://github.com/ronag
Jul 2, 2021 https://github.com/nodejs/node/pull/39203#ref-commit-3203396
https://github.com/ronag
stream: use finished for pumphttps://github.com/nodejs/node/commit/320339630d0366298c9c62a537bcfeec62b9d038
3203396https://github.com/nodejs/node/commit/320339630d0366298c9c62a537bcfeec62b9d038
#39203https://github.com/nodejs/node/pull/39203
targoshttps://github.com/targos
Jul 11, 2021 https://github.com/nodejs/node/pull/39203#ref-commit-35b6669
https://github.com/ronag
https://github.com/targos
stream: use finished for pumphttps://github.com/nodejs/node/commit/35b6669e13f0a59e0d34ef328bcfd067b828e208
35b6669https://github.com/nodejs/node/commit/35b6669e13f0a59e0d34ef328bcfd067b828e208
#39203https://github.com/nodejs/node/pull/39203
https://github.com/targos
targoshttps://github.com/targos
Jul 13, 2021 https://github.com/nodejs/node/pull/39203#ref-pullrequest-942839117
v16.5.0 release proposal #39373 https://github.com/nodejs/node/pull/39373
https://github.com/ronag
ronaghttps://github.com/ronag
dont-land-on-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v12.x
dont-land-on-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v12.x
Jul 13, 2021https://github.com/nodejs/node/pull/39203#event-5012168683
https://github.com/targos
targoshttps://github.com/targos
dont-land-on-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v14.x
Sep 4, 2021https://github.com/nodejs/node/pull/39203#event-5256298684
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39203
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/39203/files/a4a04d00c099a48e3399d685d60b97532b87c8d0
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/39203/files/a4a04d00c099a48e3399d685d60b97532b87c8d0
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/39203/files/a4a04d00c099a48e3399d685d60b97532b87c8d0
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/39203
https://github.com/ronag
https://github.com/nodejs-github-bot
https://github.com/mscdex
https://github.com/mcollina
https://github.com/benjamingr
https://github.com/aduh95
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.