René's URL Explorer Experiment


Title: errors: remove eager stack generation for node errors by devsnek · Pull Request #39182 · nodejs/node · GitHub

Open Graph Title: errors: remove eager stack generation for node errors by devsnek · Pull Request #39182 · nodejs/node

X Title: errors: remove eager stack generation for node errors by devsnek · Pull Request #39182 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Moves logic from addCodeToName to prepareStackTrace, which saves some upfront perf and also allows node errors to be overridden by overrideStackTrace. cc @guybedford

X Description: Moves logic from addCodeToName to prepareStackTrace, which saves some upfront perf and also allows node errors to be overridden by overrideStackTrace. cc @guybedford

Opengraph URL: https://github.com/nodejs/node/pull/39182

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:dd91e10e-f799-4638-c9f2-115f9110f0ee
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idACAC:3DD3FA:678096:8CBA90:6A4DAD91
html-safe-nonce442fb61a2e21d70c5ac7ce552a9f30bb669eb6d8c0d6395c99a68d35ebb005c5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQ0FDOjNERDNGQTo2NzgwOTY6OENCQTkwOjZBNERBRDkxIiwidmlzaXRvcl9pZCI6IjMyMjM1OTUyMDA1MTQyMDcxMjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacdb23bd60a804c156379ed11a006503261714ba91282d22fedfd094cdcad98d09
hovercard-subject-tagpull_request:679179125
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/39182/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/46894ce1639b9d718577999382df2a271799328c874b3065615c02fb1764c96b/nodejs/node/pull/39182
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/46894ce1639b9d718577999382df2a271799328c874b3065615c02fb1764c96b/nodejs/node/pull/39182
og:image:altMoves logic from addCodeToName to prepareStackTrace, which saves some upfront perf and also allows node errors to be overridden by overrideStackTrace. cc @guybedford
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedevsnek
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release32f7b614aca06e6bbd89842b1370df1328264f68
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/39182#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39182
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39182
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/39182
Reloadhttps://github.com/nodejs/node/pull/39182
Reloadhttps://github.com/nodejs/node/pull/39182
Please reload this pagehttps://github.com/nodejs/node/pull/39182
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/39182
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 962 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
devsnekhttps://github.com/devsnek
nodejs:masterhttps://github.com/nodejs/node/tree/master
devsnek:better-error-stuffhttps://github.com/devsnek/node/tree/better-error-stuff
Conversationhttps://github.com/nodejs/node/pull/39182
Commits1 (1)https://github.com/nodejs/node/pull/39182/commits
Checkshttps://github.com/nodejs/node/pull/39182/checks
Files changedhttps://github.com/nodejs/node/pull/39182/files
errors: remove eager stack generation for node errorshttps://github.com/nodejs/node/pull/39182#top
devsnekhttps://github.com/devsnek
nodejs:masterhttps://github.com/nodejs/node/tree/master
devsnek:better-error-stuffhttps://github.com/devsnek/node/tree/better-error-stuff
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Jun 28, 2021https://github.com/nodejs/node/pull/39182#issue-931730036
Please reload this pagehttps://github.com/nodejs/node/pull/39182
@guybedfordhttps://github.com/guybedford
Please reload this pagehttps://github.com/nodejs/node/pull/39182
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
errors https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jun 28, 2021https://github.com/nodejs/node/pull/39182#event-4948423109
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Jul 2, 2021 https://github.com/nodejs/node/pull/39182#pullrequestreview-698460043
View reviewed changes https://github.com/nodejs/node/pull/39182/files
guybedfordhttps://github.com/guybedford
https://github.com/nodejs/node/pull/39182#pullrequestreview-698460043
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/39182
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 2, 2021https://github.com/nodejs/node/pull/39182#issuecomment-873222218
https://ci.nodejs.org/job/node-test-pull-request/38831/https://ci.nodejs.org/job/node-test-pull-request/38831/
Please reload this pagehttps://github.com/nodejs/node/pull/39182
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 2, 2021https://github.com/nodejs/node/pull/39182#issuecomment-873291162
https://ci.nodejs.org/job/node-test-pull-request/38833/https://ci.nodejs.org/job/node-test-pull-request/38833/
Please reload this pagehttps://github.com/nodejs/node/pull/39182
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 3, 2021https://github.com/nodejs/node/pull/39182#issuecomment-873340957
https://ci.nodejs.org/job/node-test-pull-request/38834/https://ci.nodejs.org/job/node-test-pull-request/38834/
Please reload this pagehttps://github.com/nodejs/node/pull/39182
https://github.com/devsnek
devsnekhttps://github.com/devsnek
BridgeARhttps://github.com/BridgeAR
July 3, 2021 04:08https://github.com/nodejs/node/pull/39182#event-4973800561
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Jul 3, 2021https://github.com/nodejs/node/pull/39182#issuecomment-873341192
Please reload this pagehttps://github.com/nodejs/node/pull/39182
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 3, 2021https://github.com/nodejs/node/pull/39182#issuecomment-873344167
https://ci.nodejs.org/job/node-test-pull-request/38835/https://ci.nodejs.org/job/node-test-pull-request/38835/
Please reload this pagehttps://github.com/nodejs/node/pull/39182
https://github.com/devsnek
devsnekhttps://github.com/devsnek
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jul 3, 2021https://github.com/nodejs/node/pull/39182#event-4974354743
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Jul 5, 2021https://github.com/nodejs/node/pull/39182#issuecomment-874203811
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/39182
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Jul 5, 2021https://github.com/nodejs/node/pull/39182#issuecomment-874235783
Please reload this pagehttps://github.com/nodejs/node/pull/39182
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 8, 2021 https://github.com/nodejs/node/pull/39182#pullrequestreview-701558311
View reviewed changes https://github.com/nodejs/node/pull/39182/files
https://github.com/devsnek
errors: remove eager stack generation for node errorshttps://github.com/nodejs/node/pull/39182/commits/17821703ccf23df62cbef4d6a1d490201118d8d3
1782170https://github.com/nodejs/node/pull/39182/commits/17821703ccf23df62cbef4d6a1d490201118d8d3
nodejs#39182https://github.com/nodejs/node/pull/39182
https://github.com/devsnek
devsnekhttps://github.com/devsnek
force-pushedhttps://github.com/nodejs/node/compare/3943432d07a11337b46a583707221ca884417461..17821703ccf23df62cbef4d6a1d490201118d8d3
3943432https://github.com/nodejs/node/commit/3943432d07a11337b46a583707221ca884417461
1782170https://github.com/nodejs/node/commit/17821703ccf23df62cbef4d6a1d490201118d8d3
Compare https://github.com/nodejs/node/compare/3943432d07a11337b46a583707221ca884417461..17821703ccf23df62cbef4d6a1d490201118d8d3
July 8, 2021 01:53https://github.com/nodejs/node/pull/39182#event-4992215303
https://github.com/devsnek
devsnekhttps://github.com/devsnek
1782170https://github.com/nodejs/node/commit/17821703ccf23df62cbef4d6a1d490201118d8d3
Jul 8, 2021https://github.com/nodejs/node/pull/39182#event-4992216202
https://github.com/devsnek
devsnekhttps://github.com/devsnek
July 8, 2021 01:53https://github.com/nodejs/node/pull/39182#event-4992216898
targoshttps://github.com/targos
Jul 11, 2021 https://github.com/nodejs/node/pull/39182#ref-commit-33cad27
https://github.com/devsnek
https://github.com/targos
errors: remove eager stack generation for node errorshttps://github.com/nodejs/node/commit/33cad271c583536befefaa9d320228c59c122ad3
33cad27https://github.com/nodejs/node/commit/33cad271c583536befefaa9d320228c59c122ad3
#39182https://github.com/nodejs/node/pull/39182
https://github.com/targos
targoshttps://github.com/targos
Jul 13, 2021 https://github.com/nodejs/node/pull/39182#ref-pullrequest-942839117
v16.5.0 release proposal #39373 https://github.com/nodejs/node/pull/39373
https://github.com/cspotcode
cspotcodehttps://github.com/cspotcode
Jul 19, 2021 https://github.com/nodejs/node/pull/39182#ref-issue-948030010
Removes error code from node errors evanw/node-source-map-support#291 https://github.com/evanw/node-source-map-support/issues/291
https://github.com/targos
targoshttps://github.com/targos
backport-blocked-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v14.x
Sep 4, 2021https://github.com/nodejs/node/pull/39182#event-5256343261
[Snyk] Security upgrade wrangler from 2.21.3 to 4.24.4 naiba4/cloudflare-docs#32 https://github.com/naiba4/cloudflare-docs/pull/32
[Snyk] Security upgrade wrangler from 2.21.3 to 3.114.17 naiba4/cloudflare-docs#33 https://github.com/naiba4/cloudflare-docs/pull/33
[Snyk] Security upgrade semantic-release from 19.0.2 to 25.0.0 naiba4/zksync-docs#19 https://github.com/naiba4/zksync-docs/pull/19
[Snyk] Security upgrade semantic-release from 19.0.2 to 25.0.0 naiba4/zksync-docs#20 https://github.com/naiba4/zksync-docs/pull/20
chore(deps-dev): bump @openzeppelin/contracts from 4.8.2 to 4.9.6 in /smart-contract-example Dustin4444/awesome-kurtosis#18 https://github.com/Dustin4444/awesome-kurtosis/pull/18
chore(deps): bump qs and express in /simple-api/server Dustin4444/awesome-kurtosis#19 https://github.com/Dustin4444/awesome-kurtosis/pull/19
chore(deps-dev): bump minimatch from 3.1.2 to 3.1.5 in /simple-api/server Dustin4444/awesome-kurtosis#20 https://github.com/Dustin4444/awesome-kurtosis/pull/20
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39182
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/39182/files/3943432d07a11337b46a583707221ca884417461
https://github.com/guybedford
guybedford https://github.com/guybedford
https://github.com/nodejs/node/pull/39182/files/d85057c278608e74436c92709894598c3179e8ae
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
errors https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
Please reload this pagehttps://github.com/nodejs/node/pull/39182
https://github.com/devsnek
https://github.com/nodejs-github-bot
https://github.com/guybedford
https://github.com/jasnell
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.