René's URL Explorer Experiment


Title: readline: allow completer to rewrite existing input by addaleax · Pull Request #39178 · nodejs/node · GitHub

Open Graph Title: readline: allow completer to rewrite existing input by addaleax · Pull Request #39178 · nodejs/node

X Title: readline: allow completer to rewrite existing input by addaleax · Pull Request #39178 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Sometimes, it makes sense for a completer to change the existing input, e.g. by adjusting the casing (imagine a completer that corrects Number.isNan to Number.IsNaN, for example). This commit allow...

X Description: Sometimes, it makes sense for a completer to change the existing input, e.g. by adjusting the casing (imagine a completer that corrects Number.isNan to Number.IsNaN, for example). This commit allow...

Opengraph URL: https://github.com/nodejs/node/pull/39178

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:dd6a86ad-48fd-63ee-b59a-c017cc55170e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE7D6:193F03:102E6B1:166C8F6:6A4DDB73
html-safe-nonce5d39511c10061304dec3bf1f1fd7f826eb6a6fc3a05e6b419f84948b4531650d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFN0Q2OjE5M0YwMzoxMDJFNkIxOjE2NkM4RjY6NkE0RERCNzMiLCJ2aXNpdG9yX2lkIjoiNzQyODk4MTIyNTQ1NTIxMzQyNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8f5af95ae843a1e1b7ef25d87e5e289dab012a646db8ef7bd64bb999851d7064
hovercard-subject-tagpull_request:679047327
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/39178/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/dcc7d9c2e06b9bd4595327e0994cd195852bd6fc9db6a11f3a8d4521425e8dab/nodejs/node/pull/39178
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dcc7d9c2e06b9bd4595327e0994cd195852bd6fc9db6a11f3a8d4521425e8dab/nodejs/node/pull/39178
og:image:altSometimes, it makes sense for a completer to change the existing input, e.g. by adjusting the casing (imagine a completer that corrects Number.isNan to Number.IsNaN, for example). This commit allow...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/39178#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39178
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39178
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/39178
Reloadhttps://github.com/nodejs/node/pull/39178
Reloadhttps://github.com/nodejs/node/pull/39178
Please reload this pagehttps://github.com/nodejs/node/pull/39178
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/39178
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:readline-completion-exchangehttps://github.com/addaleax/node/tree/readline-completion-exchange
Conversationhttps://github.com/nodejs/node/pull/39178
Commits5 (5)https://github.com/nodejs/node/pull/39178/commits
Checkshttps://github.com/nodejs/node/pull/39178/checks
Files changedhttps://github.com/nodejs/node/pull/39178/files
readline: allow completer to rewrite existing inputhttps://github.com/nodejs/node/pull/39178#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:readline-completion-exchangehttps://github.com/addaleax/node/tree/readline-completion-exchange
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 28, 2021https://github.com/nodejs/node/pull/39178#issue-931571801
Please reload this pagehttps://github.com/nodejs/node/pull/39178
https://github.com/addaleax
readline: allow completer to rewrite existing inputhttps://github.com/nodejs/node/pull/39178/commits/4d5636e10498a8e2a11745b728c9462b9d467c6c
4d5636ehttps://github.com/nodejs/node/pull/39178/commits/4d5636e10498a8e2a11745b728c9462b9d467c6c
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
readline https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline
Jun 28, 2021https://github.com/nodejs/node/pull/39178#event-4947447589
addaleaxhttps://github.com/addaleax
June 28, 2021 15:34https://github.com/nodejs/node/pull/39178#commits-pushed-e69cd1d
https://github.com/addaleax
fixup! readline: allow completer to rewrite existing inputhttps://github.com/nodejs/node/pull/39178/commits/e69cd1da8f0c30788589d8b430138e8f705c3986
e69cd1dhttps://github.com/nodejs/node/pull/39178/commits/e69cd1da8f0c30788589d8b430138e8f705c3986
https://github.com/addaleax
fixup! readline: allow completer to rewrite existing inputhttps://github.com/nodejs/node/pull/39178/commits/4b4e6c3b81aa2f4562a3db60e77379f05f12922f
4b4e6c3https://github.com/nodejs/node/pull/39178/commits/4b4e6c3b81aa2f4562a3db60e77379f05f12922f
https://github.com/aduh95
aduh95https://github.com/aduh95
Jun 28, 2021 https://github.com/nodejs/node/pull/39178#pullrequestreview-694021020
View reviewed changes https://github.com/nodejs/node/pull/39178/files/4b4e6c3b81aa2f4562a3db60e77379f05f12922f
aduh95https://github.com/aduh95
https://github.com/nodejs/node/pull/39178#pullrequestreview-694021020
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/39178
lib/readline.jshttps://github.com/nodejs/node/pull/39178/files/4b4e6c3b81aa2f4562a3db60e77379f05f12922f#diff-36f855786dc2ab46536bcb72a1f08f98c9b730ffa5dcd9dcff2ff952d7ee5c50
Please reload this pagehttps://github.com/nodejs/node/pull/39178
lib/readline.jshttps://github.com/nodejs/node/pull/39178/files/4b4e6c3b81aa2f4562a3db60e77379f05f12922f#diff-36f855786dc2ab46536bcb72a1f08f98c9b730ffa5dcd9dcff2ff952d7ee5c50
Please reload this pagehttps://github.com/nodejs/node/pull/39178
https://github.com/addaleax
https://github.com/aduh95
fixup! readline: allow completer to rewrite existing inputhttps://github.com/nodejs/node/pull/39178/commits/697cf5d46ed43dd0488f4b85ed549a553dd1ff7a
697cf5dhttps://github.com/nodejs/node/pull/39178/commits/697cf5d46ed43dd0488f4b85ed549a553dd1ff7a
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 28, 2021https://github.com/nodejs/node/pull/39178#issuecomment-869742045
Please reload this pagehttps://github.com/nodejs/node/pull/39178
https://github.com/aduh95
aduh95https://github.com/aduh95
Jun 28, 2021 https://github.com/nodejs/node/pull/39178#pullrequestreview-694040702
View reviewed changes https://github.com/nodejs/node/pull/39178/files/697cf5d46ed43dd0488f4b85ed549a553dd1ff7a
https://github.com/addaleax
fixup! readline: allow completer to rewrite existing inputhttps://github.com/nodejs/node/pull/39178/commits/0a38e282ecbf7ff90c0c86f5a08054951c028557
0a38e28https://github.com/nodejs/node/pull/39178/commits/0a38e282ecbf7ff90c0c86f5a08054951c028557
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Jun 28, 2021 https://github.com/nodejs/node/pull/39178#pullrequestreview-694052333
View reviewed changes https://github.com/nodejs/node/pull/39178/files/0a38e282ecbf7ff90c0c86f5a08054951c028557
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jun 28, 2021https://github.com/nodejs/node/pull/39178#event-4948072290
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 28, 2021https://github.com/nodejs/node/pull/39178#issuecomment-869764178
https://ci.nodejs.org/job/node-test-pull-request/38783/https://ci.nodejs.org/job/node-test-pull-request/38783/
Please reload this pagehttps://github.com/nodejs/node/pull/39178
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 28, 2021 https://github.com/nodejs/node/pull/39178#pullrequestreview-694085900
View reviewed changes https://github.com/nodejs/node/pull/39178/files/0a38e282ecbf7ff90c0c86f5a08054951c028557
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 28, 2021https://github.com/nodejs/node/pull/39178#issuecomment-869843272
https://ci.nodejs.org/job/node-test-pull-request/38787/https://ci.nodejs.org/job/node-test-pull-request/38787/
Please reload this pagehttps://github.com/nodejs/node/pull/39178
https://github.com/aduh95
aduh95https://github.com/aduh95
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jun 28, 2021https://github.com/nodejs/node/pull/39178#event-4948626714
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 29, 2021 https://github.com/nodejs/node/pull/39178#pullrequestreview-694507459
View reviewed changes https://github.com/nodejs/node/pull/39178/files/0a38e282ecbf7ff90c0c86f5a08054951c028557
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jun 30, 2021 https://github.com/nodejs/node/pull/39178#pullrequestreview-695999738
View reviewed changes https://github.com/nodejs/node/pull/39178/files/0a38e282ecbf7ff90c0c86f5a08054951c028557
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jul 5, 2021https://github.com/nodejs/node/pull/39178#event-4977981802
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jul 5, 2021https://github.com/nodejs/node/pull/39178#event-4978016136
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 5, 2021https://github.com/nodejs/node/pull/39178#issuecomment-874038879
392213a...64e4837https://github.com/nodejs/node/compare/392213a3873ca702e49a16911b3cb74348b6cbab...64e483701191c5920c48dd9fbcacb76a55ca3968
Please reload this pagehttps://github.com/nodejs/node/pull/39178
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 5, 2021https://github.com/nodejs/node/pull/39178#event-4978016874
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 5, 2021 https://github.com/nodejs/node/pull/39178#ref-commit-64e4837
https://github.com/addaleax
https://github.com/nodejs-github-bot
readline: allow completer to rewrite existing inputhttps://github.com/nodejs/node/commit/64e483701191c5920c48dd9fbcacb76a55ca3968
64e4837https://github.com/nodejs/node/commit/64e483701191c5920c48dd9fbcacb76a55ca3968
#39178https://github.com/nodejs/node/pull/39178
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
July 5, 2021 11:30https://github.com/nodejs/node/pull/39178#event-4978027820
ejose19https://github.com/ejose19
Jul 5, 2021 https://github.com/nodejs/node/pull/39178#ref-commit-c5db850
https://github.com/addaleax
https://github.com/ejose19
readline: allow completer to rewrite existing inputhttps://github.com/ejose19/node/commit/c5db850438e4cd724677df5e095c23577b4b7f3d
c5db850https://github.com/ejose19/node/commit/c5db850438e4cd724677df5e095c23577b4b7f3d
nodejs#39178https://github.com/nodejs/node/pull/39178
targoshttps://github.com/targos
Jul 11, 2021 https://github.com/nodejs/node/pull/39178#ref-commit-20cc8ec
https://github.com/addaleax
https://github.com/targos
readline: allow completer to rewrite existing inputhttps://github.com/nodejs/node/commit/20cc8ec2af295fd84a014843f06f8421aead261e
20cc8echttps://github.com/nodejs/node/commit/20cc8ec2af295fd84a014843f06f8421aead261e
#39178https://github.com/nodejs/node/pull/39178
https://github.com/targos
targoshttps://github.com/targos
Jul 13, 2021 https://github.com/nodejs/node/pull/39178#ref-pullrequest-942839117
v16.5.0 release proposal #39373 https://github.com/nodejs/node/pull/39373
targoshttps://github.com/targos
Sep 4, 2021 https://github.com/nodejs/node/pull/39178#ref-commit-6c87b59
https://github.com/addaleax
https://github.com/targos
readline: allow completer to rewrite existing inputhttps://github.com/nodejs/node/commit/6c87b591d94698e2c79cd4004846b131d22a89ea
6c87b59https://github.com/nodejs/node/commit/6c87b591d94698e2c79cd4004846b131d22a89ea
#39178https://github.com/nodejs/node/pull/39178
https://github.com/targos
targoshttps://github.com/targos
Sep 4, 2021 https://github.com/nodejs/node/pull/39178#ref-pullrequest-988299806
v14.18.0 release proposal #39990 https://github.com/nodejs/node/pull/39990
mwalbeckhttps://github.com/mwalbeck
Oct 6, 2021 https://github.com/nodejs/node/pull/39178#ref-commit-b56d53d
https://github.com/mwalbeck
Update Node.js to v14.18.0 (#52)https://github.com/mwalbeck/docker-jellyfin-livestream/commit/b56d53d9104e89f2e984ef3001e6825d34762598
b56d53dhttps://github.com/mwalbeck/docker-jellyfin-livestream/commit/b56d53d9104e89f2e984ef3001e6825d34762598
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39178
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/39178/files/0a38e282ecbf7ff90c0c86f5a08054951c028557
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/39178/files/0a38e282ecbf7ff90c0c86f5a08054951c028557
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/39178/files/0a38e282ecbf7ff90c0c86f5a08054951c028557
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/39178/files/697cf5d46ed43dd0488f4b85ed549a553dd1ff7a
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/39178/files/0a38e282ecbf7ff90c0c86f5a08054951c028557
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
readline https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline
Please reload this pagehttps://github.com/nodejs/node/pull/39178
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/cjihrig
https://github.com/tniessen
https://github.com/devsnek
https://github.com/aduh95
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.