| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:60d24631-0084-5441-d4b3-d0d45fc1a63b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A5B4:13A77B:494BE6:6317C1:6969D7C2 |
| html-safe-nonce | 1a63064bc183369a2821fbd766b33ecd4b7c2eda72b66fbd45167dd51586ffd8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNUI0OjEzQTc3Qjo0OTRCRTY6NjMxN0MxOjY5NjlEN0MyIiwidmlzaXRvcl9pZCI6IjIzODczNzM3ODI0NTY3MTkyOTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 807d6275820e09252f55ebdba43c9b38d226e53bc3db7ae50a1392114fb01878 |
| hovercard-subject-tag | pull_request:678592591 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/39175/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/197c874ed98334cef6b0cc9f7b239e3ea723ee3a86ef55e0f04603a2ce8cbd83/nodejs/node/pull/39175 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/197c874ed98334cef6b0cc9f7b239e3ea723ee3a86ef55e0f04603a2ce8cbd83/nodejs/node/pull/39175 |
| og:image:alt | This PR attempts to improve the usability of the ERR_REQUIRE_ESM error messages with two major improvements:
When the module being required contains parseable ESM syntax, constrain the suggested f... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | guybedford |
| hostname | github.com |
| expected-hostname | github.com |
| None | acedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 83c08c21cdda978090dc44364b71aa5bc6dcea79 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/39175#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39175 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39175 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/39175 |
| Reload | https://github.com/nodejs/node/pull/39175 |
| Reload | https://github.com/nodejs/node/pull/39175 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/39175#issue-comment-box |
| guybedford | https://github.com/guybedford |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| guybedford:require-esm-improvements | https://github.com/guybedford/node/tree/require-esm-improvements |
|
esm: refine ERR_REQUIRE_ESM errors
| https://github.com/nodejs/node/pull/39175#top |
| guybedford | https://github.com/guybedford |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| guybedford:require-esm-improvements | https://github.com/guybedford/node/tree/require-esm-improvements |
|
Conversation
55
| https://github.com/nodejs/node/pull/39175 |
|
Commits
17
| https://github.com/nodejs/node/pull/39175/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/39175/checks |
|
Files changed
| https://github.com/nodejs/node/pull/39175/files |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| Jun 27, 2021 | https://github.com/nodejs/node/pull/39175#issue-931035337 |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
errors
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Jun 27, 2021 | https://github.com/nodejs/node/pull/39175#event-4944394798 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| Jun 27, 2021 | https://github.com/nodejs/node/pull/39175#issuecomment-869234488 |
| @GeoffreyBooth | https://github.com/GeoffreyBooth |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| force-pushed | https://github.com/nodejs/node/compare/ff5d5f79a82479706ffdd0ec9bf6084b0b5fafd6..1f59c8fa68bbe664a24e15b09c629d2c678aa70d |
| ff5d5f7 | https://github.com/nodejs/node/commit/ff5d5f79a82479706ffdd0ec9bf6084b0b5fafd6 |
| 1f59c8f | https://github.com/nodejs/node/commit/1f59c8fa68bbe664a24e15b09c629d2c678aa70d |
|
Compare
| https://github.com/nodejs/node/compare/ff5d5f79a82479706ffdd0ec9bf6084b0b5fafd6..1f59c8fa68bbe664a24e15b09c629d2c678aa70d |
| June 27, 2021 22:50 | https://github.com/nodejs/node/pull/39175#event-4944397316 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jun 27, 2021
| https://github.com/nodejs/node/pull/39175#pullrequestreview-693461019 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/39175/files |
| lib/internal/errors.js | https://github.com/nodejs/node/pull/39175/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jun 27, 2021
| https://github.com/nodejs/node/pull/39175#pullrequestreview-693461114 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/39175/files |
| lib/internal/errors.js | https://github.com/nodejs/node/pull/39175/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
|
Jun 28, 2021
| https://github.com/nodejs/node/pull/39175#pullrequestreview-693483719 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/39175/files |
| lib/internal/errors.js | https://github.com/nodejs/node/pull/39175/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
| https://github.com/ljharb |
| ljharb | https://github.com/ljharb |
|
Jun 28, 2021
| https://github.com/nodejs/node/pull/39175#pullrequestreview-693559635 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/39175/files |
| lib/internal/errors.js | https://github.com/nodejs/node/pull/39175/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
| lib/internal/modules/cjs/helpers.js | https://github.com/nodejs/node/pull/39175/files#diff-d0c27bc16c57ecdd9a4369bc8b33091cdf2cdd87dd347d580bcd86b310f73d18 |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jun 28, 2021
| https://github.com/nodejs/node/pull/39175#pullrequestreview-693672286 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/39175/files |
| lib/internal/errors.js | https://github.com/nodejs/node/pull/39175/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
| lib/internal/errors.js | https://github.com/nodejs/node/pull/39175/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c |
| aduh95 | https://github.com/aduh95 |
| Jun 28, 2021 | https://github.com/nodejs/node/pull/39175#discussion_r659573636 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
| guybedford | https://github.com/guybedford |
| Jun 28, 2021 | https://github.com/nodejs/node/pull/39175#discussion_r659759088 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @devsnek | https://github.com/devsnek |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
| lib/internal/errors.js | https://github.com/nodejs/node/pull/39175/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
| lib/internal/modules/cjs/helpers.js | https://github.com/nodejs/node/pull/39175/files#diff-d0c27bc16c57ecdd9a4369bc8b33091cdf2cdd87dd347d580bcd86b310f73d18 |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jun 28, 2021
| https://github.com/nodejs/node/pull/39175#pullrequestreview-693857221 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/39175/files |
| src/node_errors.cc | https://github.com/nodejs/node/pull/39175/files#diff-090d65062da5652b79f8a641489e4bd33b37faf28b8e91cc2ac31ab43084a3d2 |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jun 28, 2021
| https://github.com/nodejs/node/pull/39175#ref-issue-665695433 |
|
Improve documentation on Dual Module Packages
#34515
| https://github.com/nodejs/node/issues/34515 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| force-pushed | https://github.com/nodejs/node/compare/d41671ccbe7534e5d039c1715ef3098e8a55c83e..8be551d9dff6ff151dd28cb27cd7a6a9582bfb7f |
| d41671c | https://github.com/nodejs/node/commit/d41671ccbe7534e5d039c1715ef3098e8a55c83e |
| 8be551d | https://github.com/nodejs/node/commit/8be551d9dff6ff151dd28cb27cd7a6a9582bfb7f |
|
Compare
| https://github.com/nodejs/node/compare/d41671ccbe7534e5d039c1715ef3098e8a55c83e..8be551d9dff6ff151dd28cb27cd7a6a9582bfb7f |
| July 8, 2021 17:14 | https://github.com/nodejs/node/pull/39175#event-4996248295 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| devsnek | https://github.com/devsnek |
| July 8, 2021 17:15 | https://github.com/nodejs/node/pull/39175#event-4996251147 |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
| Jul 8, 2021 | https://github.com/nodejs/node/pull/39175#issuecomment-876610063 |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| Jul 8, 2021 | https://github.com/nodejs/node/pull/39175#issuecomment-876620751 |
| @devsnek | https://github.com/devsnek |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| devsnek | https://github.com/devsnek |
| stale review | https://github.com/nodejs/node/pull/39175#pullrequestreview-693483719 |
| July 8, 2021 17:53 | https://github.com/nodejs/node/pull/39175#event-4996417358 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| Jul 8, 2021 | https://github.com/nodejs/node/pull/39175#issuecomment-876638712 |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
| https://github.com/bmeck |
| bmeck | https://github.com/bmeck |
|
Jul 8, 2021
| https://github.com/nodejs/node/pull/39175#pullrequestreview-702489982 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/39175/files |
| bmeck | https://github.com/bmeck |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
| https://github.com/nodejs/node/pull/39175#pullrequestreview-702489982 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jul 9, 2021
| https://github.com/nodejs/node/pull/39175#pullrequestreview-703055707 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/39175/files |
| lib/internal/errors.js | https://github.com/nodejs/node/pull/39175/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c |
| targos | https://github.com/targos |
| Jul 9, 2021 | https://github.com/nodejs/node/pull/39175#discussion_r666953457 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
| guybedford | https://github.com/guybedford |
| Jul 12, 2021 | https://github.com/nodejs/node/pull/39175#discussion_r668283000 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jul 12, 2021
| https://github.com/nodejs/node/pull/39175#ref-issue-941489165 |
|
Detect require vs. import based on the entry point, not package.json
#39353
| https://github.com/nodejs/node/issues/39353 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jul 12, 2021
| https://github.com/nodejs/node/pull/39175#pullrequestreview-704565917 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/39175/files |
| test/es-module/test-cjs-esm-warn.js | https://github.com/nodejs/node/pull/39175/files#diff-2ce8479190aa7c61723996ee6df6d2656c2ba1657da54999622791e1e4a57547 |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
| test/es-module/test-cjs-esm-warn.js | https://github.com/nodejs/node/pull/39175/files#diff-2ce8479190aa7c61723996ee6df6d2656c2ba1657da54999622791e1e4a57547 |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
| lib/internal/modules/cjs/loader.js | https://github.com/nodejs/node/pull/39175/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142 |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
| lib/internal/modules/cjs/loader.js | https://github.com/nodejs/node/pull/39175/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142 |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
| guybedford | https://github.com/guybedford |
| July 12, 2021 14:58 | https://github.com/nodejs/node/pull/39175#commits-pushed-15babc4 |
|
| https://github.com/guybedford |
| esm: refine ERR_REQUIRE_ESM errors | https://github.com/nodejs/node/pull/39175/commits/15babc4f1db8e5084c4694c441cb36079aa77d50 |
| 15babc4 | https://github.com/nodejs/node/pull/39175/commits/15babc4f1db8e5084c4694c441cb36079aa77d50 |
|
| https://github.com/guybedford |
| fixup: space | https://github.com/nodejs/node/pull/39175/commits/8b6d578e781408f195e0673ddd98ff30a8d92033 |
| 8b6d578 | https://github.com/nodejs/node/pull/39175/commits/8b6d578e781408f195e0673ddd98ff30a8d92033 |
|
| https://github.com/guybedford |
| fixup: arrow fn | https://github.com/nodejs/node/pull/39175/commits/0d129ba05c070345b6ded60fb4f3c906d25d77b3 |
| 0d129ba | https://github.com/nodejs/node/pull/39175/commits/0d129ba05c070345b6ded60fb4f3c906d25d77b3 |
|
| https://github.com/guybedford |
|
| https://github.com/aduh95 |
| fixup: Apply suggestions from code review | https://github.com/nodejs/node/pull/39175/commits/7765a14aebd87335aa08a5626f6307ce235316d4 |
| 7765a14 | https://github.com/nodejs/node/pull/39175/commits/7765a14aebd87335aa08a5626f6307ce235316d4 |
|
| https://github.com/guybedford |
| fixup: pr feedback | https://github.com/nodejs/node/pull/39175/commits/187c7b948bab687923a8e2a78ea9eaf5df9d405f |
| 187c7b9 | https://github.com/nodejs/node/pull/39175/commits/187c7b948bab687923a8e2a78ea9eaf5df9d405f |
|
| https://github.com/guybedford |
| fixup: errors linting | https://github.com/nodejs/node/pull/39175/commits/8fbf23bfe27a52ada56da44c4cbfb8758f0d0fd7 |
| 8fbf23b | https://github.com/nodejs/node/pull/39175/commits/8fbf23bfe27a52ada56da44c4cbfb8758f0d0fd7 |
|
| https://github.com/guybedford |
| fixup: simplify internal stack frame hiding | https://github.com/nodejs/node/pull/39175/commits/fdd9b31f3eaf4125fdaca7edba3944ce76428ef2 |
| fdd9b31 | https://github.com/nodejs/node/pull/39175/commits/fdd9b31f3eaf4125fdaca7edba3944ce76428ef2 |
|
| https://github.com/guybedford |
| fixup: tests | https://github.com/nodejs/node/pull/39175/commits/af548b5f71f78d121bca878b2c7aae860e93ada1 |
| af548b5 | https://github.com/nodejs/node/pull/39175/commits/af548b5f71f78d121bca878b2c7aae860e93ada1 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39175 |
|
| https://github.com/guybedford |
| fixup: lazily load acorn | https://github.com/nodejs/node/pull/39175/commits/b156244365bbd30d11cdf712a232f5d1b9926372 |
| b156244 | https://github.com/nodejs/node/pull/39175/commits/b156244365bbd30d11cdf712a232f5d1b9926372 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39175 |
|
| https://github.com/guybedford |
| fixup: bootstrap list | https://github.com/nodejs/node/pull/39175/commits/cf5879f4ed6af519d4911b018ba780f44dea7e2e |
| cf5879f | https://github.com/nodejs/node/pull/39175/commits/cf5879f4ed6af519d4911b018ba780f44dea7e2e |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39175 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 15, 2021 | https://github.com/nodejs/node/pull/39175#issuecomment-880698204 |
| https://ci.nodejs.org/job/node-test-pull-request/39069/ | https://ci.nodejs.org/job/node-test-pull-request/39069/ |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
| guybedford | https://github.com/guybedford |
|
Jul 15, 2021
| https://github.com/nodejs/node/pull/39175#ref-commit-e2a6399 |
|
| https://github.com/guybedford |
| esm: refine ERR_REQUIRE_ESM errors | https://github.com/nodejs/node/commit/e2a6399be742f53103474d9fc1e56fadf7f90ccc |
|
| https://github.com/nodejs/node/commit/e2a6399be742f53103474d9fc1e56fadf7f90ccc#comments |
| e2a6399 | https://github.com/nodejs/node/commit/e2a6399be742f53103474d9fc1e56fadf7f90ccc |
| #39175 | https://github.com/nodejs/node/pull/39175 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| Jul 15, 2021 | https://github.com/nodejs/node/pull/39175#issuecomment-880810441 |
| e2a6399 | https://github.com/nodejs/node/commit/e2a6399be742f53103474d9fc1e56fadf7f90ccc |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| Jul 15, 2021 | https://github.com/nodejs/node/pull/39175#event-5026302388 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| July 15, 2021 15:52 | https://github.com/nodejs/node/pull/39175#event-5026302628 |
| targos | https://github.com/targos |
|
Jul 17, 2021
| https://github.com/nodejs/node/pull/39175#ref-commit-cb105b2 |
|
| https://github.com/guybedford |
|
| https://github.com/targos |
| esm: refine ERR_REQUIRE_ESM errors | https://github.com/nodejs/node/commit/cb105b247bb7014c37c57a7a5bb575a97b527533 |
| cb105b2 | https://github.com/nodejs/node/commit/cb105b247bb7014c37c57a7a5bb575a97b527533 |
| #39175 | https://github.com/nodejs/node/pull/39175 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jul 24, 2021
| https://github.com/nodejs/node/pull/39175#ref-pullrequest-952091397 |
|
module: refine enrichCJSError
#39507
| https://github.com/nodejs/node/pull/39507 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Jul 26, 2021
| https://github.com/nodejs/node/pull/39175#ref-pullrequest-953169906 |
|
v16.6.0 proposal
#39534
| https://github.com/nodejs/node/pull/39534 |
| BethGriggs | https://github.com/BethGriggs |
|
Jul 29, 2021
| https://github.com/nodejs/node/pull/39175#ref-commit-93eff3f |
|
| https://github.com/guybedford |
|
| https://github.com/BethGriggs |
| esm: refine ERR_REQUIRE_ESM errors | https://github.com/nodejs/node/commit/93eff3f5a62ac7993fb0948db57a936d3c282a79 |
| 93eff3f | https://github.com/nodejs/node/commit/93eff3f5a62ac7993fb0948db57a936d3c282a79 |
| #39175 | https://github.com/nodejs/node/pull/39175 |
| olizilla | https://github.com/olizilla |
|
Jul 30, 2021
| https://github.com/nodejs/node/pull/39175#ref-commit-e99ce8c |
|
| https://github.com/olizilla |
| fix: force webpack to load ESM config | https://github.com/web3-storage/web3.storage/commit/e99ce8c37673e5184a89933f5fb47375448f7f96 |
| e99ce8c | https://github.com/web3-storage/web3.storage/commit/e99ce8c37673e5184a89933f5fb47375448f7f96 |
| nodejs/node#39175 | https://github.com/nodejs/node/pull/39175 |
| https://github.com/webpack/webpack-cli/blob/a660ffcbeb2807bce1554f787297e697464abd59/packages/webpack-cli/lib/webpack-cli.js#L50-L51 | https://github.com/webpack/webpack-cli/blob/a660ffcbeb2807bce1554f787297e697464abd59/packages/webpack-cli/lib/webpack-cli.js#L50-L51 |
| https://github.com/olizilla |
| olizilla | https://github.com/olizilla |
|
Jul 30, 2021
| https://github.com/nodejs/node/pull/39175#ref-pullrequest-956791693 |
|
fix: force webpack to load ESM config
web3-storage/web3.storage#247
| https://github.com/web3-storage/web3.storage/pull/247 |
| olizilla | https://github.com/olizilla |
|
Jul 30, 2021
| https://github.com/nodejs/node/pull/39175#ref-commit-055ed61 |
|
| https://github.com/olizilla |
| fix: force webpack to load ESM config ( | https://github.com/web3-storage/web3.storage/commit/055ed6109ecedbf335ebe01f03a89a7b9362c147 |
| #247 | https://github.com/web3-storage/web3.storage/pull/247 |
| ) | https://github.com/web3-storage/web3.storage/commit/055ed6109ecedbf335ebe01f03a89a7b9362c147 |
| 055ed61 | https://github.com/web3-storage/web3.storage/commit/055ed6109ecedbf335ebe01f03a89a7b9362c147 |
| nodejs/node#39175 | https://github.com/nodejs/node/pull/39175 |
| https://github.com/webpack/webpack-cli/blob/a660ffcbeb2807bce1554f787297e697464abd59/packages/webpack-cli/lib/webpack-cli.js#L50-L51 | https://github.com/webpack/webpack-cli/blob/a660ffcbeb2807bce1554f787297e697464abd59/packages/webpack-cli/lib/webpack-cli.js#L50-L51 |
| https://github.com/olizilla |
| olizilla | https://github.com/olizilla |
|
Jul 31, 2021
| https://github.com/nodejs/node/pull/39175#ref-issue-957196954 |
|
TypeError loading webpack.config.js in ESM project with node v16.6
webpack/webpack-cli#2864
| https://github.com/webpack/webpack-cli/issues/2864 |
| johndmulhausen | https://github.com/johndmulhausen |
|
Aug 6, 2021
| https://github.com/nodejs/node/pull/39175#ref-commit-89c11ee |
|
| https://github.com/olizilla |
| fix: force webpack to load ESM config ( | https://github.com/web3-storage/web3.storage/commit/89c11ee80f0a011265131dc0ce9e6a9300473a3a |
| #247 | https://github.com/web3-storage/web3.storage/pull/247 |
| ) | https://github.com/web3-storage/web3.storage/commit/89c11ee80f0a011265131dc0ce9e6a9300473a3a |
| 89c11ee | https://github.com/web3-storage/web3.storage/commit/89c11ee80f0a011265131dc0ce9e6a9300473a3a |
| nodejs/node#39175 | https://github.com/nodejs/node/pull/39175 |
| https://github.com/webpack/webpack-cli/blob/a660ffcbeb2807bce1554f787297e697464abd59/packages/webpack-cli/lib/webpack-cli.js#L50-L51 | https://github.com/webpack/webpack-cli/blob/a660ffcbeb2807bce1554f787297e697464abd59/packages/webpack-cli/lib/webpack-cli.js#L50-L51 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
backport-blocked-v14.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v14.x |
| Sep 4, 2021 | https://github.com/nodejs/node/pull/39175#event-5256393300 |
| https://github.com/danielcompton |
| danielcompton | https://github.com/danielcompton |
|
Sep 6, 2023
| https://github.com/nodejs/node/pull/39175#ref-pullrequest-1884866366 |
|
esm: clarify ERR_REQUIRE_ESM errors
#49521
| https://github.com/nodejs/node/pull/49521 |
| danielcompton | https://github.com/danielcompton |
|
Sep 6, 2023
| https://github.com/nodejs/node/pull/39175#ref-commit-c5b69ed |
|
| https://github.com/danielcompton |
| esm: clarify ERR_REQUIRE_ESM errors | https://github.com/danielcompton/node/commit/c5b69edf779a0845ffa63b9bf8503f9ff2906663 |
| c5b69ed | https://github.com/danielcompton/node/commit/c5b69edf779a0845ffa63b9bf8503f9ff2906663 |
| nodejs#39175 | https://github.com/nodejs/node/pull/39175 |
| danielcompton | https://github.com/danielcompton |
|
Sep 6, 2023
| https://github.com/nodejs/node/pull/39175#ref-commit-ebd7153 |
|
| https://github.com/danielcompton |
| esm: clarify ERR_REQUIRE_ESM errors | https://github.com/danielcompton/node/commit/ebd71535a0a06e54657b507309f2d1475005f404 |
| ebd7153 | https://github.com/danielcompton/node/commit/ebd71535a0a06e54657b507309f2d1475005f404 |
| nodejs#39175 | https://github.com/nodejs/node/pull/39175 |
| nodejs#39175 | https://github.com/nodejs/node/pull/39175 |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
Sep 15, 2023
| https://github.com/nodejs/node/pull/39175#ref-commit-6a489df |
|
| https://github.com/danielcompton |
| esm: clarify ERR_REQUIRE_ESM errors | https://github.com/nodejs/node/commit/6a489df73b0ab64f8fab016a7a71e209066fdb82 |
| 6a489df | https://github.com/nodejs/node/commit/6a489df73b0ab64f8fab016a7a71e209066fdb82 |
| #39175 | https://github.com/nodejs/node/pull/39175 |
| #39175 | https://github.com/nodejs/node/pull/39175 |
| #49521 | https://github.com/nodejs/node/pull/49521 |
| ruyadorno | https://github.com/ruyadorno |
|
Sep 28, 2023
| https://github.com/nodejs/node/pull/39175#ref-commit-3a9ea09 |
|
| https://github.com/danielcompton |
|
| https://github.com/ruyadorno |
| esm: clarify ERR_REQUIRE_ESM errors | https://github.com/nodejs/node/commit/3a9ea0925a15dc36c48067bf22adb14786d8d3eb |
| 3a9ea09 | https://github.com/nodejs/node/commit/3a9ea0925a15dc36c48067bf22adb14786d8d3eb |
| #39175 | https://github.com/nodejs/node/pull/39175 |
| #39175 | https://github.com/nodejs/node/pull/39175 |
| #49521 | https://github.com/nodejs/node/pull/49521 |
| alexfernandez | https://github.com/alexfernandez |
|
Nov 1, 2023
| https://github.com/nodejs/node/pull/39175#ref-commit-7673ee4 |
|
| https://github.com/danielcompton |
|
| https://github.com/alexfernandez |
| esm: clarify ERR_REQUIRE_ESM errors | https://github.com/alexfernandez/node/commit/7673ee4b3f534a987e3b601398871f38b7d75d59 |
| 7673ee4 | https://github.com/alexfernandez/node/commit/7673ee4b3f534a987e3b601398871f38b7d75d59 |
| nodejs#39175 | https://github.com/nodejs/node/pull/39175 |
| nodejs#39175 | https://github.com/nodejs/node/pull/39175 |
| nodejs#49521 | https://github.com/nodejs/node/pull/49521 |
| targos | https://github.com/targos |
|
Nov 11, 2023
| https://github.com/nodejs/node/pull/39175#ref-commit-40ffd28 |
|
| https://github.com/danielcompton |
|
| https://github.com/targos |
| esm: clarify ERR_REQUIRE_ESM errors | https://github.com/targos/node/commit/40ffd2890ae292d69b3098148b12c32e205580c3 |
| 40ffd28 | https://github.com/targos/node/commit/40ffd2890ae292d69b3098148b12c32e205580c3 |
| nodejs#39175 | https://github.com/nodejs/node/pull/39175 |
| nodejs#39175 | https://github.com/nodejs/node/pull/39175 |
| nodejs#49521 | https://github.com/nodejs/node/pull/49521 |
| targos | https://github.com/targos |
|
Nov 23, 2023
| https://github.com/nodejs/node/pull/39175#ref-commit-51ced0f |
|
| https://github.com/danielcompton |
|
| https://github.com/targos |
| esm: clarify ERR_REQUIRE_ESM errors | https://github.com/nodejs/node/commit/51ced0f1a1a996212e1c7fe647b60cdb64d71b7e |
| 51ced0f | https://github.com/nodejs/node/commit/51ced0f1a1a996212e1c7fe647b60cdb64d71b7e |
| #39175 | https://github.com/nodejs/node/pull/39175 |
| #39175 | https://github.com/nodejs/node/pull/39175 |
| #49521 | https://github.com/nodejs/node/pull/49521 |
| #50669 | https://github.com/nodejs/node/pull/50669 |
| sercher | https://github.com/sercher |
|
Apr 25, 2024
| https://github.com/nodejs/node/pull/39175#ref-commit-53e302e |
|
| https://github.com/sercher |
| esm: clarify ERR_REQUIRE_ESM errors | https://github.com/sercher/graaljs/commit/53e302ebb1835aa2fe76274e0b09cfee2341bb3e |
| 53e302e | https://github.com/sercher/graaljs/commit/53e302ebb1835aa2fe76274e0b09cfee2341bb3e |
| nodejs/node#39175 | https://github.com/nodejs/node/pull/39175 |
| nodejs/node#49521 | https://github.com/nodejs/node/pull/49521 |
| nodejs/node#50669 | https://github.com/nodejs/node/pull/50669 |
| sercher | https://github.com/sercher |
|
Apr 25, 2024
| https://github.com/nodejs/node/pull/39175#ref-commit-4328950 |
|
| https://github.com/sercher |
| esm: clarify ERR_REQUIRE_ESM errors | https://github.com/sercher/graaljs/commit/43289507404beb849fc3ea3aca5d411d80524693 |
| 4328950 | https://github.com/sercher/graaljs/commit/43289507404beb849fc3ea3aca5d411d80524693 |
| nodejs/node#39175 | https://github.com/nodejs/node/pull/39175 |
| nodejs/node#49521 | https://github.com/nodejs/node/pull/49521 |
| nodejs/node#50669 | https://github.com/nodejs/node/pull/50669 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39175 |
|
| https://github.com/ljharb |
|
ljharb
| https://github.com/ljharb |
|
| https://github.com/nodejs/node/pull/39175/files/26f225902934fc437ec2f759dd5f429e4d33824d |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/39175/files/26f225902934fc437ec2f759dd5f429e4d33824d |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/39175/files/52ceda15c831a69f3a6e2a7b489eb3004f6b3962 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/39175/files/12b200942de5ea192a57b3c08ed57c694a5c9ab8 |
|
| https://github.com/aduh95 |
|
aduh95
| https://github.com/aduh95 |
|
| https://github.com/nodejs/node/pull/39175/files/e628c0a7f198c5e7aa0b58d9fd0d50d44a7c62fb |
|
| https://github.com/devsnek |
|
devsnek
| https://github.com/devsnek |
|
| https://github.com/zackschuster |
|
zackschuster
| https://github.com/zackschuster |
|
| https://github.com/nodejs/node/pull/39175/files/26f225902934fc437ec2f759dd5f429e4d33824d |
|
| https://github.com/bmeck |
|
bmeck
| https://github.com/bmeck |
|
| https://github.com/nodejs/node/pull/39175/files/52ceda15c831a69f3a6e2a7b489eb3004f6b3962 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
errors
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Please reload this page | https://github.com/nodejs/node/pull/39175 |
|
| https://github.com/guybedford |
|
| https://github.com/devsnek |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/ljharb |
|
| https://github.com/bmeck |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/targos |
|
| https://github.com/zackschuster |
|
| https://github.com/aduh95 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |