René's URL Explorer Experiment


Title: crypto: move OPENSSL_IS_BORINGSSL guard by codebytere · Pull Request #39136 · nodejs/node · GitHub

Open Graph Title: crypto: move OPENSSL_IS_BORINGSSL guard by codebytere · Pull Request #39136 · nodejs/node

X Title: crypto: move OPENSSL_IS_BORINGSSL guard by codebytere · Pull Request #39136 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: BoringSSL does not support secure heap or CRYPTO_secure_malloc_init, so move the end of the OPENSSL_IS_BORINGSSL guard down a bit to reflect this. Electron is currently floating a patch for this, w...

X Description: BoringSSL does not support secure heap or CRYPTO_secure_malloc_init, so move the end of the OPENSSL_IS_BORINGSSL guard down a bit to reflect this. Electron is currently floating a patch for this, w...

Opengraph URL: https://github.com/nodejs/node/pull/39136

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:50f3114e-3dc0-9831-00f8-b05672f36962
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF78:3C7B3B:36B7FC:4B0403:6A4D9E27
html-safe-nonce6ce0dd530aacbd87205701c8ca13e2a8e7b98dad033ca4d6764afbbe78139680
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjc4OjNDN0IzQjozNkI3RkM6NEIwNDAzOjZBNEQ5RTI3IiwidmlzaXRvcl9pZCI6Ijk3ODg4MTIyMzg3Mzg5NTk3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac40073073a327150ee940e5f27903ab97726149b636c443cb403a316835ee6651
hovercard-subject-tagpull_request:676868136
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/39136/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0d7988acbef909fd6211730fd53a8fbcba25af7ffc3809bf462b69641528fa3f/nodejs/node/pull/39136
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0d7988acbef909fd6211730fd53a8fbcba25af7ffc3809bf462b69641528fa3f/nodejs/node/pull/39136
og:image:altBoringSSL does not support secure heap or CRYPTO_secure_malloc_init, so move the end of the OPENSSL_IS_BORINGSSL guard down a bit to reflect this. Electron is currently floating a patch for this, w...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecodebytere
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7f13faa65cccc9b729d674da83335d5dcfdfd193
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/39136#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39136
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39136
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/39136
Reloadhttps://github.com/nodejs/node/pull/39136
Reloadhttps://github.com/nodejs/node/pull/39136
Please reload this pagehttps://github.com/nodejs/node/pull/39136
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/39136
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
codebyterehttps://github.com/codebytere
nodejs:masterhttps://github.com/nodejs/node/tree/master
codebytere:move-openssl-is-boringssl-guardhttps://github.com/codebytere/node/tree/move-openssl-is-boringssl-guard
Conversationhttps://github.com/nodejs/node/pull/39136
Commits1 (1)https://github.com/nodejs/node/pull/39136/commits
Checkshttps://github.com/nodejs/node/pull/39136/checks
Files changedhttps://github.com/nodejs/node/pull/39136/files
crypto: move OPENSSL_IS_BORINGSSL guardhttps://github.com/nodejs/node/pull/39136#top
codebyterehttps://github.com/codebytere
nodejs:masterhttps://github.com/nodejs/node/tree/master
codebytere:move-openssl-is-boringssl-guardhttps://github.com/codebytere/node/tree/move-openssl-is-boringssl-guard
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jun 24, 2021https://github.com/nodejs/node/pull/39136#issue-928939873
Please reload this pagehttps://github.com/nodejs/node/pull/39136
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jun 24, 2021https://github.com/nodejs/node/pull/39136#event-4932875367
https://github.com/codebytere
codebyterehttps://github.com/codebytere
jasnellhttps://github.com/jasnell
June 24, 2021 07:41https://github.com/nodejs/node/pull/39136#event-4932885675
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 25, 2021 https://github.com/nodejs/node/pull/39136#pullrequestreview-692445636
View reviewed changes https://github.com/nodejs/node/pull/39136/files
https://github.com/codebytere
codebyterehttps://github.com/codebytere
tniessenhttps://github.com/tniessen
June 29, 2021 12:09https://github.com/nodejs/node/pull/39136#event-4953138179
https://github.com/codebytere
codebyterehttps://github.com/codebytere
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jun 29, 2021https://github.com/nodejs/node/pull/39136#event-4953148392
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 29, 2021https://github.com/nodejs/node/pull/39136#issuecomment-870541559
https://ci.nodejs.org/job/node-test-pull-request/38795/https://ci.nodejs.org/job/node-test-pull-request/38795/
Please reload this pagehttps://github.com/nodejs/node/pull/39136
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jun 29, 2021 https://github.com/nodejs/node/pull/39136#pullrequestreview-695025364
View reviewed changes https://github.com/nodejs/node/pull/39136/files
src/crypto/crypto_util.cchttps://github.com/nodejs/node/pull/39136/files#diff-44f169afcf633347349f172323ec642b8f25c09502990d488f161c1cb37f12b7
Please reload this pagehttps://github.com/nodejs/node/pull/39136
https://github.com/codebytere
crypto: move OPENSSL_IS_BORINGSSL guardhttps://github.com/nodejs/node/pull/39136/commits/61603f86d301236c5061b242d9ac73a6a1afc401
61603f8https://github.com/nodejs/node/pull/39136/commits/61603f86d301236c5061b242d9ac73a6a1afc401
https://github.com/codebytere
codebyterehttps://github.com/codebytere
force-pushedhttps://github.com/nodejs/node/compare/2b56eb43afed01e915ad3e6c571ed794c2ed7f31..61603f86d301236c5061b242d9ac73a6a1afc401
2b56eb4https://github.com/nodejs/node/commit/2b56eb43afed01e915ad3e6c571ed794c2ed7f31
61603f8https://github.com/nodejs/node/commit/61603f86d301236c5061b242d9ac73a6a1afc401
Compare https://github.com/nodejs/node/compare/2b56eb43afed01e915ad3e6c571ed794c2ed7f31..61603f86d301236c5061b242d9ac73a6a1afc401
June 29, 2021 13:39https://github.com/nodejs/node/pull/39136#event-4953708311
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 29, 2021https://github.com/nodejs/node/pull/39136#issuecomment-870609367
https://ci.nodejs.org/job/node-test-pull-request/38799/https://ci.nodejs.org/job/node-test-pull-request/38799/
Please reload this pagehttps://github.com/nodejs/node/pull/39136
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jun 29, 2021 https://github.com/nodejs/node/pull/39136#pullrequestreview-695050656
View reviewed changes https://github.com/nodejs/node/pull/39136/files/61603f86d301236c5061b242d9ac73a6a1afc401
tniessenhttps://github.com/tniessen
https://github.com/nodejs/node/pull/39136#pullrequestreview-695050656
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/39136
https://github.com/nodejs
nodejshttps://github.com/nodejs
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 29, 2021https://github.com/nodejs/node/pull/39136#event-4956259263
https://github.com/nodejs
nodejshttps://github.com/nodejs
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 30, 2021https://github.com/nodejs/node/pull/39136#event-4957997656
https://github.com/nodejs
nodejshttps://github.com/nodejs
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 30, 2021https://github.com/nodejs/node/pull/39136#event-4957999259
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 30, 2021https://github.com/nodejs/node/pull/39136#issuecomment-871193695
https://ci.nodejs.org/job/node-test-pull-request/38814/https://ci.nodejs.org/job/node-test-pull-request/38814/
Please reload this pagehttps://github.com/nodejs/node/pull/39136
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jun 30, 2021https://github.com/nodejs/node/pull/39136#issuecomment-871256068
a9f9d2bhttps://github.com/nodejs/node/commit/a9f9d2b3b7ca75e8813dca1e46c151495855a81f
Please reload this pagehttps://github.com/nodejs/node/pull/39136
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jun 30, 2021https://github.com/nodejs/node/pull/39136#event-4958488445
https://github.com/codebytere
codebyterehttps://github.com/codebytere
June 30, 2021 09:47https://github.com/nodejs/node/pull/39136#event-4958488729
codebyterehttps://github.com/codebytere
Jun 30, 2021 https://github.com/nodejs/node/pull/39136#ref-commit-a9f9d2b
https://github.com/codebytere
crypto: move OPENSSL_IS_BORINGSSL guardhttps://github.com/nodejs/node/commit/a9f9d2b3b7ca75e8813dca1e46c151495855a81f
a9f9d2bhttps://github.com/nodejs/node/commit/a9f9d2b3b7ca75e8813dca1e46c151495855a81f
#39136https://github.com/nodejs/node/pull/39136
targoshttps://github.com/targos
Jul 11, 2021 https://github.com/nodejs/node/pull/39136#ref-commit-4202274
https://github.com/codebytere
https://github.com/targos
crypto: move OPENSSL_IS_BORINGSSL guardhttps://github.com/nodejs/node/commit/42022748511bee3db21baed9064cc0c138c4eb59
4202274https://github.com/nodejs/node/commit/42022748511bee3db21baed9064cc0c138c4eb59
#39136https://github.com/nodejs/node/pull/39136
https://github.com/targos
targoshttps://github.com/targos
Jul 13, 2021 https://github.com/nodejs/node/pull/39136#ref-pullrequest-942839117
v16.5.0 release proposal #39373 https://github.com/nodejs/node/pull/39373
codebyterehttps://github.com/codebytere
Jul 14, 2021 https://github.com/nodejs/node/pull/39136#ref-commit-736a876
https://github.com/codebytere
chore: various BoringSSL/OpenSSL upstreamshttps://github.com/electron/electron/commit/736a876ba6236a88cc00ec039b5fec1e34b520ad
736a876https://github.com/electron/electron/commit/736a876ba6236a88cc00ec039b5fec1e34b520ad
nodejs/node#39136https://github.com/nodejs/node/pull/39136
nodejs/node#39138https://github.com/nodejs/node/pull/39138
nodejs/node#39054https://github.com/nodejs/node/pull/39054
jkleinschttps://github.com/jkleinsc
Jul 15, 2021 https://github.com/nodejs/node/pull/39136#ref-commit-063ac19
https://github.com/apps/electron-roller
https://github.com/apps/patchup
https://github.com/jkleinsc
https://github.com/codebytere
chore: bump node to v16.5.0 (main) (https://github.com/electron/electron/commit/063ac1971244e9d0411a6046e4840c975e38f726
#30031https://github.com/electron/electron/pull/30031
)https://github.com/electron/electron/commit/063ac1971244e9d0411a6046e4840c975e38f726
063ac19https://github.com/electron/electron/commit/063ac1971244e9d0411a6046e4840c975e38f726
nodejs/node#39288https://github.com/nodejs/node/pull/39288
nodejs/node#39069https://github.com/nodejs/node/pull/39069
nodejs/node#39136https://github.com/nodejs/node/pull/39136
nodejs/node#39138https://github.com/nodejs/node/pull/39138
nodejs/node#39054https://github.com/nodejs/node/pull/39054
nodejs/node#39300https://github.com/nodejs/node/pull/39300
nodejs/node#39069https://github.com/nodejs/node/pull/39069
BlackHole1https://github.com/BlackHole1
Aug 30, 2021 https://github.com/nodejs/node/pull/39136#ref-commit-04880ca
https://github.com/apps/electron-roller
https://github.com/apps/patchup
https://github.com/jkleinsc
https://github.com/codebytere
https://github.com/BlackHole1
chore: bump node to v16.5.0 (main) (https://github.com/BlackHole1/electron/commit/04880cacbf2005e36720755d822b0da8449e4ad5
electron#30031https://github.com/electron/electron/pull/30031
)https://github.com/BlackHole1/electron/commit/04880cacbf2005e36720755d822b0da8449e4ad5
04880cahttps://github.com/BlackHole1/electron/commit/04880cacbf2005e36720755d822b0da8449e4ad5
nodejs/node#39288https://github.com/nodejs/node/pull/39288
nodejs/node#39069https://github.com/nodejs/node/pull/39069
nodejs/node#39136https://github.com/nodejs/node/pull/39136
nodejs/node#39138https://github.com/nodejs/node/pull/39138
nodejs/node#39054https://github.com/nodejs/node/pull/39054
nodejs/node#39300https://github.com/nodejs/node/pull/39300
nodejs/node#39069https://github.com/nodejs/node/pull/39069
https://github.com/targos
targoshttps://github.com/targos
dont-land-on-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v14.x
Sep 4, 2021https://github.com/nodejs/node/pull/39136#event-5256287917
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39136
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/39136/files/2b56eb43afed01e915ad3e6c571ed794c2ed7f31
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/39136/files/61603f86d301236c5061b242d9ac73a6a1afc401
https://github.com/jasnell
jasnell https://github.com/jasnell
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Please reload this pagehttps://github.com/nodejs/node/pull/39136
https://github.com/codebytere
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/tniessen
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.