René's URL Explorer Experiment


Title: Fix building with external builtins #39090 by mmomtchev · Pull Request #39091 · nodejs/node · GitHub

Open Graph Title: Fix building with external builtins #39090 by mmomtchev · Pull Request #39091 · nodejs/node

X Title: Fix building with external builtins #39090 by mmomtchev · Pull Request #39091 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #39090

X Description: Fixes: #39090

Mail addresses
anna@addaleax.net
duhamelantoine1995@gmail.com
cjihrig@gmail.com
raisinten@gmail.com
luigipinca@gmail.com
momtchil@momtchev.com

Opengraph URL: https://github.com/nodejs/node/pull/39091

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:37dbf52f-b3d6-7d38-49a5-814f43a623cf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id85D0:34BFFD:1D92732:28B9513:6A4EC57B
html-safe-nonce2851a18ba61abd717c469eff12865f1fa2f714f8e594699aa64d3f71d8f22d58
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NUQwOjM0QkZGRDoxRDkyNzMyOjI4Qjk1MTM6NkE0RUM1N0IiLCJ2aXNpdG9yX2lkIjoiMTQzNTU4OTc3NTMzOTczNDM5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac12493f80a434df1379726c8c5dc7ed415c76e0c4460120577f767b3933d94317
hovercard-subject-tagpull_request:673891306
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/39091/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/17a2c03b91b59803936643a3e502693d10cbcf0951c51246ef2826b3cb7b7ebb/nodejs/node/pull/39091
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/17a2c03b91b59803936643a3e502693d10cbcf0951c51246ef2826b3cb7b7ebb/nodejs/node/pull/39091
og:image:altFixes: #39090
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemmomtchev
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/39091#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39091
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39091
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/39091
Reloadhttps://github.com/nodejs/node/pull/39091
Reloadhttps://github.com/nodejs/node/pull/39091
Please reload this pagehttps://github.com/nodejs/node/pull/39091
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/39091
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
aduh95https://github.com/aduh95
nodejs:masterhttps://github.com/nodejs/node/tree/master
mmomtchev:nobuiltins-buildhttps://github.com/mmomtchev/node/tree/nobuiltins-build
Conversationhttps://github.com/nodejs/node/pull/39091
Commits1 (1)https://github.com/nodejs/node/pull/39091/commits
Checkshttps://github.com/nodejs/node/pull/39091/checks
Files changedhttps://github.com/nodejs/node/pull/39091/files
Fix building with external builtins #39090https://github.com/nodejs/node/pull/39091#top
aduh95https://github.com/aduh95
nodejs:masterhttps://github.com/nodejs/node/tree/master
mmomtchev:nobuiltins-buildhttps://github.com/mmomtchev/node/tree/nobuiltins-build
https://github.com/mmomtchev
mmomtchevhttps://github.com/mmomtchev
Jun 19, 2021https://github.com/nodejs/node/pull/39091#issue-925409789
Please reload this pagehttps://github.com/nodejs/node/pull/39091
#39090https://github.com/nodejs/node/issues/39090
Please reload this pagehttps://github.com/nodejs/node/pull/39091
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jun 19, 2021https://github.com/nodejs/node/pull/39091#event-4912551660
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 20, 2021 https://github.com/nodejs/node/pull/39091#pullrequestreview-687920755
View reviewed changes https://github.com/nodejs/node/pull/39091/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jun 20, 2021https://github.com/nodejs/node/pull/39091#event-4913550616
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 20, 2021https://github.com/nodejs/node/pull/39091#event-4913555324
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 20, 2021https://github.com/nodejs/node/pull/39091#issuecomment-864576981
https://ci.nodejs.org/job/node-test-pull-request/38705/https://ci.nodejs.org/job/node-test-pull-request/38705/
Please reload this pagehttps://github.com/nodejs/node/pull/39091
https://github.com/aduh95
aduh95https://github.com/aduh95
Jun 20, 2021 https://github.com/nodejs/node/pull/39091#pullrequestreview-687938982
View reviewed changes https://github.com/nodejs/node/pull/39091/files
https://github.com/aduh95
aduh95https://github.com/aduh95
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jun 20, 2021https://github.com/nodejs/node/pull/39091#event-4913767906
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 20, 2021https://github.com/nodejs/node/pull/39091#issuecomment-864609416
https://ci.nodejs.org/job/node-test-pull-request/38707/https://ci.nodejs.org/job/node-test-pull-request/38707/
Please reload this pagehttps://github.com/nodejs/node/pull/39091
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 20, 2021 https://github.com/nodejs/node/pull/39091#pullrequestreview-687944992
View reviewed changes https://github.com/nodejs/node/pull/39091/files
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Jun 21, 2021 https://github.com/nodejs/node/pull/39091#pullrequestreview-688500108
View reviewed changes https://github.com/nodejs/node/pull/39091/files
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jun 21, 2021 https://github.com/nodejs/node/pull/39091#pullrequestreview-688798418
View reviewed changes https://github.com/nodejs/node/pull/39091/files
https://github.com/aduh95
aduh95https://github.com/aduh95
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jun 26, 2021https://github.com/nodejs/node/pull/39091#event-4942981976
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jun 26, 2021https://github.com/nodejs/node/pull/39091#event-4942986378
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jun 26, 2021https://github.com/nodejs/node/pull/39091#issuecomment-869010531
#39091https://github.com/nodejs/node/pull/39091
#39090https://github.com/nodejs/node/issues/39090
https://github.com/nodejs/node/actions/runs/974315611
https://github.com/nodejs/node/actions/runs/974315611https://github.com/nodejs/node/actions/runs/974315611
Please reload this pagehttps://github.com/nodejs/node/pull/39091
https://github.com/mmomtchev
https://github.com/aduh95
build: fix building with external builtinshttps://github.com/nodejs/node/pull/39091/commits/19b80cc4ece088c0b02e556e217481b3ade744ff
19b80cchttps://github.com/nodejs/node/pull/39091/commits/19b80cc4ece088c0b02e556e217481b3ade744ff
nodejs#39091https://github.com/nodejs/node/pull/39091
nodejs#39090https://github.com/nodejs/node/issues/39090
https://github.com/aduh95
aduh95https://github.com/aduh95
force-pushedhttps://github.com/nodejs/node/compare/74b12e6d13de849a5876d7a9d1cadcd04667f79d..19b80cc4ece088c0b02e556e217481b3ade744ff
74b12e6https://github.com/nodejs/node/commit/74b12e6d13de849a5876d7a9d1cadcd04667f79d
19b80cchttps://github.com/nodejs/node/commit/19b80cc4ece088c0b02e556e217481b3ade744ff
Compare https://github.com/nodejs/node/compare/74b12e6d13de849a5876d7a9d1cadcd04667f79d..19b80cc4ece088c0b02e556e217481b3ade744ff
June 26, 2021 14:27https://github.com/nodejs/node/pull/39091#event-4942990788
https://github.com/aduh95
aduh95https://github.com/aduh95
Jun 26, 2021https://github.com/nodejs/node/pull/39091#issuecomment-869011211
19b80cchttps://github.com/nodejs/node/commit/19b80cc4ece088c0b02e556e217481b3ade744ff
Please reload this pagehttps://github.com/nodejs/node/pull/39091
https://github.com/aduh95
aduh95https://github.com/aduh95
19b80cchttps://github.com/nodejs/node/commit/19b80cc4ece088c0b02e556e217481b3ade744ff
Jun 26, 2021https://github.com/nodejs/node/pull/39091#event-4942991089
targoshttps://github.com/targos
Jul 11, 2021 https://github.com/nodejs/node/pull/39091#ref-commit-65b56b3
https://github.com/mmomtchev
https://github.com/targos
build: fix building with external builtinshttps://github.com/nodejs/node/commit/65b56b3774471b95a48cfa0658c3faefe1728970
65b56b3https://github.com/nodejs/node/commit/65b56b3774471b95a48cfa0658c3faefe1728970
#39091https://github.com/nodejs/node/pull/39091
#39090https://github.com/nodejs/node/issues/39090
https://github.com/targos
targoshttps://github.com/targos
Jul 13, 2021 https://github.com/nodejs/node/pull/39091#ref-pullrequest-942839117
v16.5.0 release proposal #39373 https://github.com/nodejs/node/pull/39373
https://github.com/aduh95
aduh95https://github.com/aduh95
Jul 17, 2021 https://github.com/nodejs/node/pull/39091#ref-pullrequest-946841603
[v14.x backport] src: use SPrintF in ProcessEmitWarning #39419 https://github.com/nodejs/node/pull/39419
RaisinTenhttps://github.com/RaisinTen
Jul 18, 2021 https://github.com/nodejs/node/pull/39091#ref-commit-e91b66f
https://github.com/mmomtchev
https://github.com/RaisinTen
build: fix building with external builtinshttps://github.com/RaisinTen/node/commit/e91b66ff373fbfe7f04297721453c63ff2b026ba
e91b66fhttps://github.com/RaisinTen/node/commit/e91b66ff373fbfe7f04297721453c63ff2b026ba
nodejs#39091https://github.com/nodejs/node/pull/39091
nodejs#39090https://github.com/nodejs/node/issues/39090
https://github.com/targos
targoshttps://github.com/targos
backport-open-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-open-v14.x
Jul 18, 2021https://github.com/nodejs/node/pull/39091#event-5034745704
richardlauhttps://github.com/richardlau
Jul 19, 2021 https://github.com/nodejs/node/pull/39091#ref-commit-86ab15d
https://github.com/mmomtchev
https://github.com/richardlau
build: fix building with external builtinshttps://github.com/RaisinTen/node/commit/86ab15d3669bba7a4790a842990deaafc2b2b2d0
86ab15dhttps://github.com/RaisinTen/node/commit/86ab15d3669bba7a4790a842990deaafc2b2b2d0
nodejs#39091https://github.com/nodejs/node/pull/39091
nodejs#39090https://github.com/nodejs/node/issues/39090
richardlauhttps://github.com/richardlau
Jul 19, 2021 https://github.com/nodejs/node/pull/39091#ref-commit-5f7c331
https://github.com/mmomtchev
https://github.com/richardlau
build: fix building with external builtinshttps://github.com/nodejs/node/commit/5f7c331da4b3e9b035704323f094756ae792e2d9
5f7c331https://github.com/nodejs/node/commit/5f7c331da4b3e9b035704323f094756ae792e2d9
#39091https://github.com/nodejs/node/pull/39091
#39419https://github.com/nodejs/node/pull/39419
#39090https://github.com/nodejs/node/issues/39090
https://github.com/richardlau
richardlauhttps://github.com/richardlau
backported-to-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v14.x
backport-open-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-open-v14.x
Jul 20, 2021https://github.com/nodejs/node/pull/39091#event-5041309629
richardlauhttps://github.com/richardlau
Jul 20, 2021 https://github.com/nodejs/node/pull/39091#ref-commit-1ab4f81
https://github.com/mmomtchev
https://github.com/richardlau
build: fix building with external builtinshttps://github.com/nodejs/node/commit/1ab4f81abc38762b46ef448dcf9f6e7ea33dc573
1ab4f81https://github.com/nodejs/node/commit/1ab4f81abc38762b46ef448dcf9f6e7ea33dc573
#39091https://github.com/nodejs/node/pull/39091
#39419https://github.com/nodejs/node/pull/39419
#39090https://github.com/nodejs/node/issues/39090
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 20, 2021 https://github.com/nodejs/node/pull/39091#ref-pullrequest-948590637
v14.17.4 proposal #39466 https://github.com/nodejs/node/pull/39466
https://github.com/targos
targoshttps://github.com/targos
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
Sep 5, 2021https://github.com/nodejs/node/pull/39091#event-5257329435
foxxyzhttps://github.com/foxxyz
Oct 18, 2021 https://github.com/nodejs/node/pull/39091#ref-commit-72c0c71
https://github.com/mmomtchev
https://github.com/foxxyz
build: fix building with external builtinshttps://github.com/foxxyz/node/commit/72c0c71da1231e5a3c05da728b84fa3a8f73db73
72c0c71https://github.com/foxxyz/node/commit/72c0c71da1231e5a3c05da728b84fa3a8f73db73
nodejs#39091https://github.com/nodejs/node/pull/39091
nodejs#39419https://github.com/nodejs/node/pull/39419
nodejs#39090https://github.com/nodejs/node/issues/39090
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F39091
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/39091/files/74b12e6d13de849a5876d7a9d1cadcd04667f79d
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/39091/files/74b12e6d13de849a5876d7a9d1cadcd04667f79d
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/39091/files/74b12e6d13de849a5876d7a9d1cadcd04667f79d
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/39091/files/74b12e6d13de849a5876d7a9d1cadcd04667f79d
https://github.com/RaisinTen
RaisinTen https://github.com/RaisinTen
https://github.com/nodejs/node/pull/39091/files/74b12e6d13de849a5876d7a9d1cadcd04667f79d
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Fix the externally loaded builtins build https://github.com/nodejs/node/issues/39090
Please reload this pagehttps://github.com/nodejs/node/pull/39091
https://github.com/mmomtchev
https://github.com/nodejs-github-bot
https://github.com/aduh95
https://github.com/addaleax
https://github.com/lpinca
https://github.com/cjihrig
https://github.com/RaisinTen
https://github.com/targos
https://github.com/richardlau
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.