René's URL Explorer Experiment


Title: node-api: avoid SecondPassCallback crash by mhdawson · Pull Request #38899 · nodejs/node · GitHub

Open Graph Title: node-api: avoid SecondPassCallback crash by mhdawson · Pull Request #38899 · nodejs/node

X Title: node-api: avoid SecondPassCallback crash by mhdawson · Pull Request #38899 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: PR #38000 added indirection so that we could stop finalization in cases where it had been scheduled in a second pass callback but we were doing it in advance in environment teardown. Unforunately w...

X Description: PR #38000 added indirection so that we could stop finalization in cases where it had been scheduled in a second pass callback but we were doing it in advance in environment teardown. Unforunately w...

Mail addresses
mdawson@devrus.com

Opengraph URL: https://github.com/nodejs/node/pull/38899

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b1723a62-b962-5872-e905-eb9348551977
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB268:3C81B0:5289A4:785B6F:6A4E0922
html-safe-noncedf481776e91d65288b74aee9d15a5bdba97254e5a35fc7add75fc992fcdb3d69
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjY4OjNDODFCMDo1Mjg5QTQ6Nzg1QjZGOjZBNEUwOTIyIiwidmlzaXRvcl9pZCI6IjcxNDA4MjEyMzA5MzI1OTI5MzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace3dce8ae8ffdca70dab49802e5ed8b688fbd602da2a4966d00979d6ccd0e84d5
hovercard-subject-tagpull_request:659599338
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/38899/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e03db9a77e1f1cb97e0bb0e76e587c36d8dd596074e887fdf4ddb538e7a2fee0/nodejs/node/pull/38899
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e03db9a77e1f1cb97e0bb0e76e587c36d8dd596074e887fdf4ddb538e7a2fee0/nodejs/node/pull/38899
og:image:altPR #38000 added indirection so that we could stop finalization in cases where it had been scheduled in a second pass callback but we were doing it in advance in environment teardown. Unforunately w...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemhdawson
hostnamegithub.com
expected-hostnamegithub.com
Nonedf0492960db29b4938cb72070351d6b1d0c6c0767b27ceb8394bbf4fcc0223c6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release52bde38e24398476f8eb1e0760c81346c6a00812
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/38899#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38899
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38899
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/38899
Reloadhttps://github.com/nodejs/node/pull/38899
Reloadhttps://github.com/nodejs/node/pull/38899
Please reload this pagehttps://github.com/nodejs/node/pull/38899
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/38899
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
mhdawsonhttps://github.com/mhdawson
nodejs:masterhttps://github.com/nodejs/node/tree/master
mhdawson:node-api-finalization-againhttps://github.com/mhdawson/io.js/tree/node-api-finalization-again
Conversationhttps://github.com/nodejs/node/pull/38899
Commits1 (1)https://github.com/nodejs/node/pull/38899/commits
Checkshttps://github.com/nodejs/node/pull/38899/checks
Files changedhttps://github.com/nodejs/node/pull/38899/files
node-api: avoid SecondPassCallback crashhttps://github.com/nodejs/node/pull/38899#top
mhdawsonhttps://github.com/mhdawson
nodejs:masterhttps://github.com/nodejs/node/tree/master
mhdawson:node-api-finalization-againhttps://github.com/mhdawson/io.js/tree/node-api-finalization-again
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jun 2, 2021https://github.com/nodejs/node/pull/38899#issue-908963794
#38000https://github.com/nodejs/node/pull/38000
#38273 (comment)https://github.com/nodejs/node/pull/38273#issuecomment-852403751
Please reload this pagehttps://github.com/nodejs/node/pull/38899
https://github.com/mhdawson
node-api: avoid SecondPassCallback crashhttps://github.com/nodejs/node/pull/38899/commits/77cbb34650e43aa8e97a1e6509911b17426a9ab2
77cbb34https://github.com/nodejs/node/pull/38899/commits/77cbb34650e43aa8e97a1e6509911b17426a9ab2
nodejs#38000https://github.com/nodejs/node/pull/38000
nodejs#38273 (comment)https://github.com/nodejs/node/pull/38273#issuecomment-852403751
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jun 2, 2021https://github.com/nodejs/node/pull/38899#event-4828882806
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jun 2, 2021 https://github.com/nodejs/node/pull/38899#ref-pullrequest-860413824
deps: update V8 to 9.1 #38273 https://github.com/nodejs/node/pull/38273
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jun 2, 2021https://github.com/nodejs/node/pull/38899#issuecomment-852648170
@legendecashttps://github.com/legendecas
Please reload this pagehttps://github.com/nodejs/node/pull/38899
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 2, 2021https://github.com/nodejs/node/pull/38899#issuecomment-852816915
https://ci.nodejs.org/job/node-test-pull-request/38444/https://ci.nodejs.org/job/node-test-pull-request/38444/
Please reload this pagehttps://github.com/nodejs/node/pull/38899
https://github.com/bl-ue
bl-uehttps://github.com/bl-ue
Jun 2, 2021 https://github.com/nodejs/node/pull/38899#pullrequestreview-674140550
View reviewed changes https://github.com/nodejs/node/pull/38899/files/77cbb34650e43aa8e97a1e6509911b17426a9ab2
https://github.com/targos
targoshttps://github.com/targos
Jun 2, 2021https://github.com/nodejs/node/pull/38899#issuecomment-853086821
Please reload this pagehttps://github.com/nodejs/node/pull/38899
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 3, 2021https://github.com/nodejs/node/pull/38899#issuecomment-853583940
https://ci.nodejs.org/job/node-test-pull-request/38470/https://ci.nodejs.org/job/node-test-pull-request/38470/
Please reload this pagehttps://github.com/nodejs/node/pull/38899
https://github.com/legendecas
legendecashttps://github.com/legendecas
Jun 3, 2021 https://github.com/nodejs/node/pull/38899#pullrequestreview-674924374
View reviewed changes https://github.com/nodejs/node/pull/38899/files/77cbb34650e43aa8e97a1e6509911b17426a9ab2
src/js_native_api_v8.cchttps://github.com/nodejs/node/pull/38899/files/77cbb34650e43aa8e97a1e6509911b17426a9ab2#diff-4b35cbf831be523a4f3e5aac3729c95490ed220892695d0e4245c15c1f63cfc1
legendecashttps://github.com/legendecas
Jun 3, 2021https://github.com/nodejs/node/pull/38899#discussion_r644524874
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/38899
mhdawsonhttps://github.com/mhdawson
Jun 3, 2021https://github.com/nodejs/node/pull/38899#discussion_r645071938
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@legendecashttps://github.com/legendecas
Please reload this pagehttps://github.com/nodejs/node/pull/38899
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jun 3, 2021 https://github.com/nodejs/node/pull/38899#pullrequestreview-675653594
View reviewed changes https://github.com/nodejs/node/pull/38899/files/77cbb34650e43aa8e97a1e6509911b17426a9ab2
src/js_native_api_v8.cchttps://github.com/nodejs/node/pull/38899/files/77cbb34650e43aa8e97a1e6509911b17426a9ab2#diff-4b35cbf831be523a4f3e5aac3729c95490ed220892695d0e4245c15c1f63cfc1
mhdawsonhttps://github.com/mhdawson
Jun 3, 2021https://github.com/nodejs/node/pull/38899#discussion_r645071676
Please reload this pagehttps://github.com/nodejs/node/pull/38899
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@legendecashttps://github.com/legendecas
Please reload this pagehttps://github.com/nodejs/node/pull/38899
legendecashttps://github.com/legendecas
Jun 4, 2021https://github.com/nodejs/node/pull/38899#discussion_r645622907
Please reload this pagehttps://github.com/nodejs/node/pull/38899
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/38899
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jun 3, 2021https://github.com/nodejs/node/pull/38899#issuecomment-854123230
@gabrielschulhofhttps://github.com/gabrielschulhof
Please reload this pagehttps://github.com/nodejs/node/pull/38899
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jun 3, 2021https://github.com/nodejs/node/pull/38899#issuecomment-854125752
Please reload this pagehttps://github.com/nodejs/node/pull/38899
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jun 3, 2021https://github.com/nodejs/node/pull/38899#issuecomment-854129589
Please reload this pagehttps://github.com/nodejs/node/pull/38899
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 4, 2021https://github.com/nodejs/node/pull/38899#issuecomment-854453402
https://ci.nodejs.org/job/node-test-pull-request/38487/https://ci.nodejs.org/job/node-test-pull-request/38487/
Please reload this pagehttps://github.com/nodejs/node/pull/38899
https://github.com/targos
targoshttps://github.com/targos
Jun 4, 2021https://github.com/nodejs/node/pull/38899#issuecomment-854623786
Please reload this pagehttps://github.com/nodejs/node/pull/38899
https://github.com/targos
targoshttps://github.com/targos
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Jun 4, 2021https://github.com/nodejs/node/pull/38899#event-4842602058
https://github.com/legendecas
legendecashttps://github.com/legendecas
Jun 4, 2021 https://github.com/nodejs/node/pull/38899#pullrequestreview-676358941
View reviewed changes https://github.com/nodejs/node/pull/38899/files/77cbb34650e43aa8e97a1e6509911b17426a9ab2
src/js_native_api_v8.cchttps://github.com/nodejs/node/pull/38899/files/77cbb34650e43aa8e97a1e6509911b17426a9ab2#diff-4b35cbf831be523a4f3e5aac3729c95490ed220892695d0e4245c15c1f63cfc1
legendecashttps://github.com/legendecas
Jun 4, 2021https://github.com/nodejs/node/pull/38899#discussion_r645624653
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/38899
https://github.com/legendecas
legendecashttps://github.com/legendecas
Jun 4, 2021 https://github.com/nodejs/node/pull/38899#pullrequestreview-676437833
View reviewed changes https://github.com/nodejs/node/pull/38899/files/77cbb34650e43aa8e97a1e6509911b17426a9ab2
legendecashttps://github.com/legendecas
https://github.com/nodejs/node/pull/38899#pullrequestreview-676437833
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/38899
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jun 4, 2021https://github.com/nodejs/node/pull/38899#issuecomment-854984034
https://ci.nodejs.org/job/node-test-pull-request/38495/https://ci.nodejs.org/job/node-test-pull-request/38495/
Please reload this pagehttps://github.com/nodejs/node/pull/38899
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 4, 2021https://github.com/nodejs/node/pull/38899#issuecomment-854984048
https://ci.nodejs.org/job/node-test-pull-request/38495/https://ci.nodejs.org/job/node-test-pull-request/38495/
Please reload this pagehttps://github.com/nodejs/node/pull/38899
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 5, 2021https://github.com/nodejs/node/pull/38899#issuecomment-855204811
https://ci.nodejs.org/job/node-test-pull-request/38496/https://ci.nodejs.org/job/node-test-pull-request/38496/
Please reload this pagehttps://github.com/nodejs/node/pull/38899
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 7, 2021https://github.com/nodejs/node/pull/38899#issuecomment-855900659
https://ci.nodejs.org/job/node-test-pull-request/38518/https://ci.nodejs.org/job/node-test-pull-request/38518/
Please reload this pagehttps://github.com/nodejs/node/pull/38899
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 7, 2021 https://github.com/nodejs/node/pull/38899#pullrequestreview-677498780
View reviewed changes https://github.com/nodejs/node/pull/38899/files/77cbb34650e43aa8e97a1e6509911b17426a9ab2
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 7, 2021https://github.com/nodejs/node/pull/38899#issuecomment-855997365
https://ci.nodejs.org/job/node-test-pull-request/38519/https://ci.nodejs.org/job/node-test-pull-request/38519/
Please reload this pagehttps://github.com/nodejs/node/pull/38899
https://github.com/targos
targoshttps://github.com/targos
Jun 8, 2021 https://github.com/nodejs/node/pull/38899#ref-issue-913475954
Node.js Technical Steering Committee (TSC) Meeting 2021-06-10 nodejs/TSC#1036 https://github.com/nodejs/TSC/issues/1036
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 8, 2021https://github.com/nodejs/node/pull/38899#issuecomment-856485740
https://ci.nodejs.org/job/node-test-pull-request/38524/https://ci.nodejs.org/job/node-test-pull-request/38524/
Please reload this pagehttps://github.com/nodejs/node/pull/38899
targoshttps://github.com/targos
Jun 8, 2021 https://github.com/nodejs/node/pull/38899#ref-commit-65a7fd3
https://github.com/mhdawson
https://github.com/targos
node-api: avoid SecondPassCallback crashhttps://github.com/nodejs/node/commit/65a7fd3e23b6f7be6a066f3f5ffe87a36ba66360
65a7fd3https://github.com/nodejs/node/commit/65a7fd3e23b6f7be6a066f3f5ffe87a36ba66360
#38000https://github.com/nodejs/node/pull/38000
#38273 (comment)https://github.com/nodejs/node/pull/38273#issuecomment-852403751
#38899https://github.com/nodejs/node/pull/38899
https://github.com/targos
targoshttps://github.com/targos
Jun 8, 2021https://github.com/nodejs/node/pull/38899#issuecomment-856704993
65a7fd3https://github.com/nodejs/node/commit/65a7fd3e23b6f7be6a066f3f5ffe87a36ba66360
Please reload this pagehttps://github.com/nodejs/node/pull/38899
https://github.com/targos
targoshttps://github.com/targos
Jun 8, 2021https://github.com/nodejs/node/pull/38899#event-4858024797
https://github.com/legendecas
legendecashttps://github.com/legendecas
Jun 8, 2021 https://github.com/nodejs/node/pull/38899#ref-pullrequest-915091979
node-api: refactor to cctest v8impl::Reference #38970 https://github.com/nodejs/node/pull/38970
targoshttps://github.com/targos
Jun 11, 2021 https://github.com/nodejs/node/pull/38899#ref-commit-ec3e5b4
https://github.com/mhdawson
https://github.com/targos
node-api: avoid SecondPassCallback crashhttps://github.com/nodejs/node/commit/ec3e5b4c15c6712fdb2174f4ced5a6afbbee3e9d
ec3e5b4https://github.com/nodejs/node/commit/ec3e5b4c15c6712fdb2174f4ced5a6afbbee3e9d
#38000https://github.com/nodejs/node/pull/38000
#38273 (comment)https://github.com/nodejs/node/pull/38273#issuecomment-852403751
#38899https://github.com/nodejs/node/pull/38899
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
Jun 14, 2021 https://github.com/nodejs/node/pull/38899#ref-pullrequest-920527459
v16.4.0 proposal #39031 https://github.com/nodejs/node/pull/39031
https://github.com/legendecas
legendecashttps://github.com/legendecas
Jul 8, 2021 https://github.com/nodejs/node/pull/38899#ref-pullrequest-864096391
src: remove unused guards around node-api reference #38334 https://github.com/nodejs/node/pull/38334
richardlauhttps://github.com/richardlau
Jul 19, 2021 https://github.com/nodejs/node/pull/38899#ref-commit-ab5c227
https://github.com/mhdawson
https://github.com/richardlau
node-api: avoid SecondPassCallback crashhttps://github.com/nodejs/node/commit/ab5c2273996ec5797d2f723e5bc2dfb2319dfe32
ab5c227https://github.com/nodejs/node/commit/ab5c2273996ec5797d2f723e5bc2dfb2319dfe32
#38000https://github.com/nodejs/node/pull/38000
#38273 (comment)https://github.com/nodejs/node/pull/38273#issuecomment-852403751
#38899https://github.com/nodejs/node/pull/38899
richardlauhttps://github.com/richardlau
Jul 20, 2021 https://github.com/nodejs/node/pull/38899#ref-commit-cd3305a
https://github.com/mhdawson
https://github.com/richardlau
node-api: avoid SecondPassCallback crashhttps://github.com/nodejs/node/commit/cd3305a9e4b85f356d9e5f1835a3e1dbe94ca662
cd3305ahttps://github.com/nodejs/node/commit/cd3305a9e4b85f356d9e5f1835a3e1dbe94ca662
#38000https://github.com/nodejs/node/pull/38000
#38273 (comment)https://github.com/nodejs/node/pull/38273#issuecomment-852403751
#38899https://github.com/nodejs/node/pull/38899
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 20, 2021 https://github.com/nodejs/node/pull/38899#ref-pullrequest-948590637
v14.17.4 proposal #39466 https://github.com/nodejs/node/pull/39466
foxxyzhttps://github.com/foxxyz
Oct 18, 2021 https://github.com/nodejs/node/pull/38899#ref-commit-21c28df
https://github.com/mhdawson
https://github.com/foxxyz
node-api: avoid SecondPassCallback crashhttps://github.com/foxxyz/node/commit/21c28df91ac25d9ae8d3b4a59337e31888051dc4
21c28dfhttps://github.com/foxxyz/node/commit/21c28df91ac25d9ae8d3b4a59337e31888051dc4
nodejs#38000https://github.com/nodejs/node/pull/38000
nodejs#38273 (comment)https://github.com/nodejs/node/pull/38273#issuecomment-852403751
nodejs#38899https://github.com/nodejs/node/pull/38899
https://github.com/legendecas
legendecashttps://github.com/legendecas
Mar 27, 2022 https://github.com/nodejs/node/pull/38899#ref-issue-1172166519
Node.js 12.x need to cherry-pick https://github.com/nodejs/node/pull/37616 #42376 https://github.com/nodejs/node/issues/42376
legendecashttps://github.com/legendecas
Mar 29, 2022 https://github.com/nodejs/node/pull/38899#ref-commit-b9d99d7
https://github.com/mhdawson
https://github.com/legendecas
node-api: avoid SecondPassCallback crashhttps://github.com/legendecas/node/commit/b9d99d7770c60ea419d823220cca5e856c4a2b23
b9d99d7https://github.com/legendecas/node/commit/b9d99d7770c60ea419d823220cca5e856c4a2b23
nodejs#38000https://github.com/nodejs/node/pull/38000
nodejs#38273 (comment)https://github.com/nodejs/node/pull/38273#issuecomment-852403751
nodejs#38899https://github.com/nodejs/node/pull/38899
richardlauhttps://github.com/richardlau
Mar 30, 2022 https://github.com/nodejs/node/pull/38899#ref-commit-e23c04f
https://github.com/mhdawson
https://github.com/richardlau
node-api: avoid SecondPassCallback crashhttps://github.com/nodejs/node/commit/e23c04f0dcb4a7fbe40bfdac842f15147a819111
e23c04fhttps://github.com/nodejs/node/commit/e23c04f0dcb4a7fbe40bfdac842f15147a819111
#38000https://github.com/nodejs/node/pull/38000
#38273 (comment)https://github.com/nodejs/node/pull/38273#issuecomment-852403751
#38899https://github.com/nodejs/node/pull/38899
#42512https://github.com/nodejs/node/pull/42512
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Mar 30, 2022 https://github.com/nodejs/node/pull/38899#ref-pullrequest-1186734465
v12.22.12 proposal #42531 https://github.com/nodejs/node/pull/42531
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38899
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/38899/files/77cbb34650e43aa8e97a1e6509911b17426a9ab2
https://github.com/legendecas
legendecas https://github.com/legendecas
https://github.com/nodejs/node/pull/38899/files/77cbb34650e43aa8e97a1e6509911b17426a9ab2
https://github.com/bl-ue
bl-ue https://github.com/bl-ue
https://github.com/nodejs/node/pull/38899/files/77cbb34650e43aa8e97a1e6509911b17426a9ab2
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Please reload this pagehttps://github.com/nodejs/node/pull/38899
https://github.com/mhdawson
https://github.com/nodejs-github-bot
https://github.com/targos
https://github.com/jasnell
https://github.com/legendecas
https://github.com/bl-ue
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.