René's URL Explorer Experiment


Title: doc,url: clarify domainTo* when built without ICU by RaisinTen · Pull Request #38789 · nodejs/node · GitHub

Open Graph Title: doc,url: clarify domainTo* when built without ICU by RaisinTen · Pull Request #38789 · nodejs/node

X Title: doc,url: clarify domainTo* when built without ICU by RaisinTen · Pull Request #38789 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Continuation of: #35099 Signed-off-by: Darshan Sen raisinten@gmail.com

X Description: Continuation of: #35099 Signed-off-by: Darshan Sen raisinten@gmail.com

Mail addresses
raisinten@gmail.com

Opengraph URL: https://github.com/nodejs/node/pull/38789

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ca488c53-9224-1516-8900-d5eb3b4a4f46
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE5C2:322E35:2B3E0B3:3C4C0F5:6A4F60D2
html-safe-nonce2f9fdc833954281a286b8ba5cce3266327f6738fd1a23ea86850ae72354861a7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNUMyOjMyMkUzNToyQjNFMEIzOjNDNEMwRjU6NkE0RjYwRDIiLCJ2aXNpdG9yX2lkIjoiMjI2Mzk0MTU2Nzc1NTU0MjczOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd4d84d87b5289a024dcd8bfceea6c3c734bf0448b910b6bb0304af1c0c825193
hovercard-subject-tagpull_request:650810990
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/38789/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f606145b68c048a6c5c41669d16230e95324f823afa356713860b10b8f7746e7/nodejs/node/pull/38789
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f606145b68c048a6c5c41669d16230e95324f823afa356713860b10b8f7746e7/nodejs/node/pull/38789
og:image:altContinuation of: #35099 Signed-off-by: Darshan Sen raisinten@gmail.com
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameRaisinTen
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/38789#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38789
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38789
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/38789
Reloadhttps://github.com/nodejs/node/pull/38789
Reloadhttps://github.com/nodejs/node/pull/38789
Please reload this pagehttps://github.com/nodejs/node/pull/38789
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/38789
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 970 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
aduh95https://github.com/aduh95
nodejs:masterhttps://github.com/nodejs/node/tree/master
RaisinTen:url/warn-when-operation-requires-ICUhttps://github.com/RaisinTen/node/tree/url/warn-when-operation-requires-ICU
Conversationhttps://github.com/nodejs/node/pull/38789
Commits1 (1)https://github.com/nodejs/node/pull/38789/commits
Checkshttps://github.com/nodejs/node/pull/38789/checks
Files changedhttps://github.com/nodejs/node/pull/38789/files
doc,url: clarify domainTo* when built without ICUhttps://github.com/nodejs/node/pull/38789#top
aduh95https://github.com/aduh95
nodejs:masterhttps://github.com/nodejs/node/tree/master
RaisinTen:url/warn-when-operation-requires-ICUhttps://github.com/RaisinTen/node/tree/url/warn-when-operation-requires-ICU
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
May 23, 2021https://github.com/nodejs/node/pull/38789#issue-899048941
#35099https://github.com/nodejs/node/pull/35099
Please reload this pagehttps://github.com/nodejs/node/pull/38789
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
May 23, 2021https://github.com/nodejs/node/pull/38789#event-4783465277
https://github.com/aduh95
aduh95https://github.com/aduh95
May 23, 2021https://github.com/nodejs/node/pull/38789#issuecomment-846586008
Please reload this pagehttps://github.com/nodejs/node/pull/38789
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 23, 2021 https://github.com/nodejs/node/pull/38789#pullrequestreview-666295819
View reviewed changes https://github.com/nodejs/node/pull/38789/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
May 24, 2021https://github.com/nodejs/node/pull/38789#event-4786728951
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 24, 2021 https://github.com/nodejs/node/pull/38789#pullrequestreview-666738333
View reviewed changes https://github.com/nodejs/node/pull/38789/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/38789#pullrequestreview-666738333
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/38789
src/node_url.hhttps://github.com/nodejs/node/pull/38789/files#diff-7e23159812307ede1fccf32f78173a09df24cfcdbf4fb6b7c5c92d23a7adb569
addaleaxhttps://github.com/addaleax
May 24, 2021https://github.com/nodejs/node/pull/38789#discussion_r637946284
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/38789
src/node_url.cchttps://github.com/nodejs/node/pull/38789/files#diff-3ea8ea727fd1024465c848244a01d422fa4647b640ef6c91ee536bf5de6c86b7
addaleaxhttps://github.com/addaleax
May 24, 2021https://github.com/nodejs/node/pull/38789#discussion_r637947929
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/38789
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
May 24, 2021https://github.com/nodejs/node/pull/38789#issuecomment-847085790
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/38789
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 24, 2021https://github.com/nodejs/node/pull/38789#issuecomment-847094056
@RaisinTenhttps://github.com/RaisinTen
Please reload this pagehttps://github.com/nodejs/node/pull/38789
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
May 25, 2021https://github.com/nodejs/node/pull/38789#issuecomment-847664099
Please reload this pagehttps://github.com/nodejs/node/pull/38789
node/doc/api/url.mdhttps://github.com/nodejs/node/blob/ab71af34533a43e4d8d788e8ed678bf572672458/doc/api/url.md#L174-L175
ab71af3https://github.com/nodejs/node/commit/ab71af34533a43e4d8d788e8ed678bf572672458
Please reload this pagehttps://github.com/nodejs/node/pull/38789
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
force-pushedhttps://github.com/nodejs/node/compare/e31fd7a9b958fe66dc5529d9f8daf775c9f3dc42..17b38d781beac552c502c62686c4cf58ad020ff2
e31fd7ahttps://github.com/nodejs/node/commit/e31fd7a9b958fe66dc5529d9f8daf775c9f3dc42
17b38d7https://github.com/nodejs/node/commit/17b38d781beac552c502c62686c4cf58ad020ff2
Compare https://github.com/nodejs/node/compare/e31fd7a9b958fe66dc5529d9f8daf775c9f3dc42..17b38d781beac552c502c62686c4cf58ad020ff2
May 25, 2021 08:25https://github.com/nodejs/node/pull/38789#event-4791032607
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
May 25, 2021https://github.com/nodejs/node/pull/38789#event-4791036338
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
addaleaxhttps://github.com/addaleax
aduh95https://github.com/aduh95
jasnellhttps://github.com/jasnell
May 25, 2021 08:28https://github.com/nodejs/node/pull/38789#event-4791050414
https://github.com/aduh95
aduh95https://github.com/aduh95
May 25, 2021 https://github.com/nodejs/node/pull/38789#pullrequestreview-667540732
View reviewed changes https://github.com/nodejs/node/pull/38789/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 26, 2021 https://github.com/nodejs/node/pull/38789#pullrequestreview-669022329
View reviewed changes https://github.com/nodejs/node/pull/38789/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aurl
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
May 26, 2021https://github.com/nodejs/node/pull/38789#event-4799406419
https://github.com/RaisinTen
https://github.com/aduh95
doc,url: clarify domainTo* when built without ICUhttps://github.com/nodejs/node/pull/38789/commits/bbab59d7ca7d4d49965940f67df6a0087cf0fd82
bbab59dhttps://github.com/nodejs/node/pull/38789/commits/bbab59d7ca7d4d49965940f67df6a0087cf0fd82
nodejs#35099https://github.com/nodejs/node/pull/35099
nodejs#38789https://github.com/nodejs/node/pull/38789
https://github.com/aduh95
aduh95https://github.com/aduh95
force-pushedhttps://github.com/nodejs/node/compare/17b38d781beac552c502c62686c4cf58ad020ff2..bbab59d7ca7d4d49965940f67df6a0087cf0fd82
17b38d7https://github.com/nodejs/node/commit/17b38d781beac552c502c62686c4cf58ad020ff2
bbab59dhttps://github.com/nodejs/node/commit/bbab59d7ca7d4d49965940f67df6a0087cf0fd82
Compare https://github.com/nodejs/node/compare/17b38d781beac552c502c62686c4cf58ad020ff2..bbab59d7ca7d4d49965940f67df6a0087cf0fd82
May 26, 2021 13:57https://github.com/nodejs/node/pull/38789#event-4799582463
https://github.com/aduh95
aduh95https://github.com/aduh95
May 26, 2021https://github.com/nodejs/node/pull/38789#issuecomment-848792722
bbab59dhttps://github.com/nodejs/node/commit/bbab59d7ca7d4d49965940f67df6a0087cf0fd82
Please reload this pagehttps://github.com/nodejs/node/pull/38789
https://github.com/aduh95
aduh95https://github.com/aduh95
bbab59dhttps://github.com/nodejs/node/commit/bbab59d7ca7d4d49965940f67df6a0087cf0fd82
May 26, 2021https://github.com/nodejs/node/pull/38789#event-4799588019
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
May 26, 2021 13:58https://github.com/nodejs/node/pull/38789#event-4799589639
danielleadamshttps://github.com/danielleadams
May 31, 2021 https://github.com/nodejs/node/pull/38789#ref-commit-0c063a1
https://github.com/RaisinTen
https://github.com/danielleadams
doc,url: clarify domainTo* when built without ICUhttps://github.com/nodejs/node/commit/0c063a1258b14fabc84bdfae71cb1806372427f0
0c063a1https://github.com/nodejs/node/commit/0c063a1258b14fabc84bdfae71cb1806372427f0
#35099https://github.com/nodejs/node/pull/35099
#38789https://github.com/nodejs/node/pull/38789
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
May 31, 2021 https://github.com/nodejs/node/pull/38789#ref-pullrequest-907685851
v16.3.0 proposal #38874 https://github.com/nodejs/node/pull/38874
https://github.com/richardlau
richardlauhttps://github.com/richardlau
dont-land-on-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v14.x
Jul 16, 2021https://github.com/nodejs/node/pull/38789#event-5031367236
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 16, 2021https://github.com/nodejs/node/pull/38789#issuecomment-881504882
#35099https://github.com/nodejs/node/pull/35099
Please reload this pagehttps://github.com/nodejs/node/pull/38789
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Jul 17, 2021https://github.com/nodejs/node/pull/38789#issuecomment-881902137
Please reload this pagehttps://github.com/nodejs/node/pull/38789
@richardlauhttps://github.com/richardlau
#35099https://github.com/nodejs/node/pull/35099
Please reload this pagehttps://github.com/nodejs/node/pull/38789
richardlauhttps://github.com/richardlau
Jul 22, 2021 https://github.com/nodejs/node/pull/38789#ref-commit-64140af
https://github.com/RaisinTen
https://github.com/richardlau
doc,url: clarify domainTo* when built without ICUhttps://github.com/nodejs/node/commit/64140af2916a1c9886d3bf5cd9506265e9074530
64140afhttps://github.com/nodejs/node/commit/64140af2916a1c9886d3bf5cd9506265e9074530
#35099https://github.com/nodejs/node/pull/35099
#38789https://github.com/nodejs/node/pull/38789
https://github.com/richardlau
richardlauhttps://github.com/richardlau
dont-land-on-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v14.x
Jul 22, 2021https://github.com/nodejs/node/pull/38789#event-5056586514
richardlauhttps://github.com/richardlau
Jul 22, 2021 https://github.com/nodejs/node/pull/38789#ref-commit-2ff671e
https://github.com/RaisinTen
https://github.com/richardlau
doc,url: clarify domainTo* when built without ICUhttps://github.com/nodejs/node/commit/2ff671e4c452a98d9c24a91693d6f23196d3d7c6
2ff671ehttps://github.com/nodejs/node/commit/2ff671e4c452a98d9c24a91693d6f23196d3d7c6
#35099https://github.com/nodejs/node/pull/35099
#38789https://github.com/nodejs/node/pull/38789
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 22, 2021 https://github.com/nodejs/node/pull/38789#ref-pullrequest-948590637
v14.17.4 proposal #39466 https://github.com/nodejs/node/pull/39466
foxxyzhttps://github.com/foxxyz
Oct 18, 2021 https://github.com/nodejs/node/pull/38789#ref-commit-d81846d
https://github.com/RaisinTen
https://github.com/foxxyz
doc,url: clarify domainTo* when built without ICUhttps://github.com/foxxyz/node/commit/d81846d859db0eb9fb1f909e804a68964be8f384
d81846dhttps://github.com/foxxyz/node/commit/d81846d859db0eb9fb1f909e804a68964be8f384
nodejs#35099https://github.com/nodejs/node/pull/35099
nodejs#38789https://github.com/nodejs/node/pull/38789
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38789
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/38789/files/17b38d781beac552c502c62686c4cf58ad020ff2
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/38789/files/17b38d781beac552c502c62686c4cf58ad020ff2
https://github.com/jasnell
jasnell https://github.com/jasnell
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aurl
Please reload this pagehttps://github.com/nodejs/node/pull/38789
https://github.com/RaisinTen
https://github.com/aduh95
https://github.com/addaleax
https://github.com/richardlau
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.