René's URL Explorer Experiment


Title: http: refactor to make servername option normalization testable by pd4d10 · Pull Request #38733 · nodejs/node · GitHub

Open Graph Title: http: refactor to make servername option normalization testable by pd4d10 · Pull Request #38733 · nodejs/node

X Title: http: refactor to make servername option normalization testable by pd4d10 · Pull Request #38733 · nodejs/node

Description: Refs: https://coverage.nodejs.org/coverage-36bb31be5f0b85a0/lib/_http_agent.js.html#L316

Open Graph Description: Refs: https://coverage.nodejs.org/coverage-36bb31be5f0b85a0/lib/_http_agent.js.html#L316

X Description: Refs: https://coverage.nodejs.org/coverage-36bb31be5f0b85a0/lib/_http_agent.js.html#L316

Opengraph URL: https://github.com/nodejs/node/pull/38733

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7ef0152d-6b22-6d7b-44ca-05273c0051b9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8C74:3F06C5:A2772A:DDE324:6969EF26
html-safe-nonce5a4c66186017e898ca1560ec527880fd47ee7e1086bf943c5d1a0bf89230bede
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Qzc0OjNGMDZDNTpBMjc3MkE6RERFMzI0OjY5NjlFRjI2IiwidmlzaXRvcl9pZCI6IjI4MTU5NTAyNTUxODQwMTUxNDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc4e90a4175b895023ec4722cc9a0b8b6d8395f4371e9dd86cdb34baf1f3205e2
hovercard-subject-tagpull_request:647420503
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/38733/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/99cf7eb866678e02cd4344c9862158f94808a77ee8bdf90fa7d8c9390be5f892/nodejs/node/pull/38733
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/99cf7eb866678e02cd4344c9862158f94808a77ee8bdf90fa7d8c9390be5f892/nodejs/node/pull/38733
og:image:altRefs: https://coverage.nodejs.org/coverage-36bb31be5f0b85a0/lib/_http_agent.js.html#L316
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepd4d10
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/38733#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38733
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38733
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/38733
Reloadhttps://github.com/nodejs/node/pull/38733
Reloadhttps://github.com/nodejs/node/pull/38733
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/38733
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/38733
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/38733#issue-comment-box
aduh95https://github.com/aduh95
nodejs:mainhttps://github.com/nodejs/node/tree/main
pd4d10:patch-http-agenthttps://github.com/pd4d10/node/tree/patch-http-agent
http: refactor to make servername option normalization testable https://github.com/nodejs/node/pull/38733#top
aduh95https://github.com/aduh95
nodejs:mainhttps://github.com/nodejs/node/tree/main
pd4d10:patch-http-agenthttps://github.com/pd4d10/node/tree/patch-http-agent
Conversation 6 https://github.com/nodejs/node/pull/38733
Commits 2 https://github.com/nodejs/node/pull/38733/commits
Checks 0 https://github.com/nodejs/node/pull/38733/checks
Files changed https://github.com/nodejs/node/pull/38733/files
Please reload this pagehttps://github.com/nodejs/node/pull/38733
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/pd4d10
pd4d10https://github.com/pd4d10
May 19, 2021https://github.com/nodejs/node/pull/38733#issue-895164228
https://coverage.nodejs.org/coverage-36bb31be5f0b85a0/lib/_http_agent.js.html#L316https://coverage.nodejs.org/coverage-36bb31be5f0b85a0/lib/_http_agent.js.html#L316
Please reload this pagehttps://github.com/nodejs/node/pull/38733
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
May 19, 2021https://github.com/nodejs/node/pull/38733#event-4765173557
https://github.com/Ayase-252
Ayase-252https://github.com/Ayase-252
May 19, 2021 https://github.com/nodejs/node/pull/38733#pullrequestreview-662960144
View reviewed changes https://github.com/nodejs/node/pull/38733/files
lib/_http_agent.jshttps://github.com/nodejs/node/pull/38733/files#diff-82c531677b9ab4e260025e0397fb0ac4d4316459fa5d16346324e39584cfce96
Ayase-252https://github.com/Ayase-252
May 19, 2021https://github.com/nodejs/node/pull/38733#discussion_r635062308
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/38733
aduh95https://github.com/aduh95
Sep 20, 2023https://github.com/nodejs/node/pull/38733#discussion_r1331153200
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/38733
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/2d76238f9184c9009bfa395848a120ac3e5b98e5..ca3ed363ffefa4819c1414aff7ffca34b53a7b95
2d76238https://github.com/nodejs/node/commit/2d76238f9184c9009bfa395848a120ac3e5b98e5
ca3ed36https://github.com/nodejs/node/commit/ca3ed363ffefa4819c1414aff7ffca34b53a7b95
Compare https://github.com/nodejs/node/compare/2d76238f9184c9009bfa395848a120ac3e5b98e5..ca3ed363ffefa4819c1414aff7ffca34b53a7b95
November 12, 2022 01:49https://github.com/nodejs/node/pull/38733#event-7795751581
https://github.com/pd4d10
https://github.com/aduh95
http: refactor to make servername option normalization testablehttps://github.com/nodejs/node/pull/38733/commits/b43137afb457346c802ceb92317f69b25d41026d
b43137ahttps://github.com/nodejs/node/pull/38733/commits/b43137afb457346c802ceb92317f69b25d41026d
https://coverage.nodejs.org/coverage-36bb31be5f0b85a0/lib/_http_agent.js.html#L316https://coverage.nodejs.org/coverage-36bb31be5f0b85a0/lib/_http_agent.js.html#L316
https://github.com/aduh95
aduh95https://github.com/aduh95
force-pushedhttps://github.com/nodejs/node/compare/ac673df8334979ff1a1ad9298948140a9de692b9..b43137afb457346c802ceb92317f69b25d41026d
ac673dfhttps://github.com/nodejs/node/commit/ac673df8334979ff1a1ad9298948140a9de692b9
b43137ahttps://github.com/nodejs/node/commit/b43137afb457346c802ceb92317f69b25d41026d
Compare https://github.com/nodejs/node/compare/ac673df8334979ff1a1ad9298948140a9de692b9..b43137afb457346c802ceb92317f69b25d41026d
September 20, 2023 07:45https://github.com/nodejs/node/pull/38733#event-10419323111
https://github.com/aduh95
aduh95https://github.com/aduh95
Sep 20, 2023 https://github.com/nodejs/node/pull/38733#pullrequestreview-1634901059
View reviewed changes https://github.com/nodejs/node/pull/38733/files/3e95caf0b97265c14ab6b7d07736206906143844
lib/_http_agent.jshttps://github.com/nodejs/node/pull/38733/files#diff-82c531677b9ab4e260025e0397fb0ac4d4316459fa5d16346324e39584cfce96
aduh95https://github.com/aduh95
Sep 20, 2023https://github.com/nodejs/node/pull/38733#discussion_r1331153200
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/38733
https://github.com/aduh95
aduh95https://github.com/aduh95
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 20, 2023https://github.com/nodejs/node/pull/38733#event-10419327172
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 20, 2023https://github.com/nodejs/node/pull/38733#event-10419371305
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 20, 2023https://github.com/nodejs/node/pull/38733#issuecomment-1727158445
https://ci.nodejs.org/job/node-test-pull-request/54079/https://ci.nodejs.org/job/node-test-pull-request/54079/
Please reload this pagehttps://github.com/nodejs/node/pull/38733
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 20, 2023https://github.com/nodejs/node/pull/38733#issuecomment-1728137796
https://ci.nodejs.org/job/node-test-pull-request/54092/https://ci.nodejs.org/job/node-test-pull-request/54092/
Please reload this pagehttps://github.com/nodejs/node/pull/38733
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 21, 2023 https://github.com/nodejs/node/pull/38733#ref-issue-1905872811
CI Reliability 2023-09-21 nodejs/reliability#672 https://github.com/nodejs/reliability/issues/672
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 21, 2023https://github.com/nodejs/node/pull/38733#issuecomment-1730197058
https://ci.nodejs.org/job/node-test-pull-request/54141/https://ci.nodejs.org/job/node-test-pull-request/54141/
Please reload this pagehttps://github.com/nodejs/node/pull/38733
CI Reliability 2023-09-22 nodejs/reliability#673 https://github.com/nodejs/reliability/issues/673
CI Reliability 2023-09-23 nodejs/reliability#674 https://github.com/nodejs/reliability/issues/674
CI Reliability 2023-09-24 nodejs/reliability#675 https://github.com/nodejs/reliability/issues/675
https://github.com/pd4d10
Merge branch 'main' into patch-http-agenthttps://github.com/nodejs/node/pull/38733/commits/3e95caf0b97265c14ab6b7d07736206906143844
3e95cafhttps://github.com/nodejs/node/pull/38733/commits/3e95caf0b97265c14ab6b7d07736206906143844
https://github.com/aduh95
aduh95https://github.com/aduh95
b866e38https://github.com/nodejs/node/commit/b866e38192b9c9015aadc88f69e672cee6428e11
Oct 6, 2023https://github.com/nodejs/node/pull/38733#event-10575284849
https://github.com/aduh95
aduh95https://github.com/aduh95
Oct 6, 2023https://github.com/nodejs/node/pull/38733#issuecomment-1750687874
b866e38https://github.com/nodejs/node/commit/b866e38192b9c9015aadc88f69e672cee6428e11
Please reload this pagehttps://github.com/nodejs/node/pull/38733
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Oct 9, 2023 https://github.com/nodejs/node/pull/38733#ref-pullrequest-1912846720
2023-10-17, Version 21.0.0 (Current) #49870 https://github.com/nodejs/node/pull/49870
alexfernandezhttps://github.com/alexfernandez
Nov 1, 2023 https://github.com/nodejs/node/pull/38733#ref-commit-fb214f4
https://github.com/pd4d10
https://github.com/alexfernandez
http: refactor to make servername option normalization testablehttps://github.com/alexfernandez/node/commit/fb214f4ca62dedf1e8305cd8d1feacca7c2fae97
fb214f4https://github.com/alexfernandez/node/commit/fb214f4ca62dedf1e8305cd8d1feacca7c2fae97
https://coverage.nodejs.org/coverage-36bb31be5f0b85a0/lib/_http_agent.js.html#L316https://coverage.nodejs.org/coverage-36bb31be5f0b85a0/lib/_http_agent.js.html#L316
nodejs#38733https://github.com/nodejs/node/pull/38733
targoshttps://github.com/targos
Nov 11, 2023 https://github.com/nodejs/node/pull/38733#ref-commit-f46bcf1
https://github.com/pd4d10
https://github.com/targos
http: refactor to make servername option normalization testablehttps://github.com/nodejs/node/commit/f46bcf1749e4d45d4afc31b1d470070dda4dd52b
f46bcf1https://github.com/nodejs/node/commit/f46bcf1749e4d45d4afc31b1d470070dda4dd52b
https://coverage.nodejs.org/coverage-36bb31be5f0b85a0/lib/_http_agent.js.html#L316https://coverage.nodejs.org/coverage-36bb31be5f0b85a0/lib/_http_agent.js.html#L316
#38733https://github.com/nodejs/node/pull/38733
https://github.com/targos
targoshttps://github.com/targos
Nov 12, 2023 https://github.com/nodejs/node/pull/38733#ref-pullrequest-1989293723
v20.10.0 release proposal #50682 https://github.com/nodejs/node/pull/50682
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Dec 6, 2023 https://github.com/nodejs/node/pull/38733#ref-pullrequest-2029497346
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41 https://github.com/nodesource/nsolid/pull/41
debadree25https://github.com/debadree25
Apr 15, 2024 https://github.com/nodejs/node/pull/38733#ref-commit-fe7c701
https://github.com/pd4d10
https://github.com/debadree25
http: refactor to make servername option normalization testablehttps://github.com/debadree25/node/commit/fe7c701ff591ae05ae1fa36da5a081048439c983
fe7c701https://github.com/debadree25/node/commit/fe7c701ff591ae05ae1fa36da5a081048439c983
https://coverage.nodejs.org/coverage-36bb31be5f0b85a0/lib/_http_agent.js.html#L316https://coverage.nodejs.org/coverage-36bb31be5f0b85a0/lib/_http_agent.js.html#L316
nodejs#38733https://github.com/nodejs/node/pull/38733
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38733
https://github.com/Ayase-252
Ayase-252 https://github.com/Ayase-252
https://github.com/nodejs/node/pull/38733/files/ac673df8334979ff1a1ad9298948140a9de692b9
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/38733/files/3e95caf0b97265c14ab6b7d07736206906143844
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/38733
https://github.com/pd4d10
https://github.com/nodejs-github-bot
https://github.com/aduh95
https://github.com/Ayase-252
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.