René's URL Explorer Experiment


Title: stream: allow empty string as first stream of pipeline by Ayase-252 · Pull Request #38723 · nodejs/node · GitHub

Open Graph Title: stream: allow empty string as first stream of pipeline by Ayase-252 · Pull Request #38723 · nodejs/node

X Title: stream: allow empty string as first stream of pipeline by Ayase-252 · Pull Request #38723 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Empty string '' should be allowed as first stream of pipeline per doc as Iterable. Fixes: #38721

X Description: Empty string '' should be allowed as first stream of pipeline per doc as Iterable. Fixes: #38721

Opengraph URL: https://github.com/nodejs/node/pull/38723

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:39843619-623f-7054-72fd-4e788731c375
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDFAA:3EE845:67C7413:916F792:6A4FBDA3
html-safe-nonce86152d72a217942b1aa282223a382bebc7318554a9972bd3465c5d80871b94a2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERkFBOjNFRTg0NTo2N0M3NDEzOjkxNkY3OTI6NkE0RkJEQTMiLCJ2aXNpdG9yX2lkIjoiMjAwMDY1MTEzNDY4MzgyMzUyMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7ba0b7e9f1f262399b1bde96f49feb09955fcc4dfb16e060bd1fb6e6d8ae74a5
hovercard-subject-tagpull_request:646872625
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/38723/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4107a7a225ae01fa074a1315ee1a9d312bc38c9b610319a1918d4d0f6b2975ed/nodejs/node/pull/38723
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4107a7a225ae01fa074a1315ee1a9d312bc38c9b610319a1918d4d0f6b2975ed/nodejs/node/pull/38723
og:image:altEmpty string '' should be allowed as first stream of pipeline per doc as Iterable. Fixes: #38721
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAyase-252
hostnamegithub.com
expected-hostnamegithub.com
None7d8f8209b188a80e19a6957836ab9229715797be5db1a04163963c674ccc33f6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseea848e83cf3bf3613dd7b13d52965a684fd23ec5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/38723#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38723
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38723
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/38723
Reloadhttps://github.com/nodejs/node/pull/38723
Reloadhttps://github.com/nodejs/node/pull/38723
Please reload this pagehttps://github.com/nodejs/node/pull/38723
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/38723
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Ayase-252https://github.com/Ayase-252
nodejs:masterhttps://github.com/nodejs/node/tree/master
Ayase-252:fix/38721-streamhttps://github.com/Ayase-252/node/tree/fix/38721-stream
Conversationhttps://github.com/nodejs/node/pull/38723
Commits2 (2)https://github.com/nodejs/node/pull/38723/commits
Checkshttps://github.com/nodejs/node/pull/38723/checks
Files changedhttps://github.com/nodejs/node/pull/38723/files
stream: allow empty string as first stream of pipelinehttps://github.com/nodejs/node/pull/38723#top
Ayase-252https://github.com/Ayase-252
nodejs:masterhttps://github.com/nodejs/node/tree/master
Ayase-252:fix/38721-streamhttps://github.com/Ayase-252/node/tree/fix/38721-stream
https://github.com/Ayase-252
Ayase-252https://github.com/Ayase-252
May 18, 2021https://github.com/nodejs/node/pull/38723#issue-894520580
Please reload this pagehttps://github.com/nodejs/node/pull/38723
dochttps://nodejs.org/api/stream.html#stream_stream_pipeline_source_transforms_destination_callback
#38721https://github.com/nodejs/node/issues/38721
Please reload this pagehttps://github.com/nodejs/node/pull/38723
https://github.com/Ayase-252
stream: allow empty string as source of pipelinehttps://github.com/nodejs/node/pull/38723/commits/e704e99049e1a47e1ce03f9bfcca448760877333
e704e99https://github.com/nodejs/node/pull/38723/commits/e704e99049e1a47e1ce03f9bfcca448760877333
nodejs#38721https://github.com/nodejs/node/issues/38721
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 18, 2021 https://github.com/nodejs/node/pull/38723#pullrequestreview-662265876
View reviewed changes https://github.com/nodejs/node/pull/38723/files/e704e99049e1a47e1ce03f9bfcca448760877333
https://github.com/aduh95
aduh95https://github.com/aduh95
May 18, 2021 https://github.com/nodejs/node/pull/38723#pullrequestreview-662344777
View reviewed changes https://github.com/nodejs/node/pull/38723/files/e704e99049e1a47e1ce03f9bfcca448760877333
lib/internal/streams/utils.jshttps://github.com/nodejs/node/pull/38723/files/e704e99049e1a47e1ce03f9bfcca448760877333#diff-f6bb8d20fdc5fc83de8857bce39f345a5a36fe27f64570a7801b14985c73d961
Please reload this pagehttps://github.com/nodejs/node/pull/38723
https://github.com/Ayase-252
https://github.com/aduh95
fixup!: simplify test conditionhttps://github.com/nodejs/node/pull/38723/commits/a0fb263b95ab7f0c9fc3c73cad36bdbd4a75bd0c
a0fb263https://github.com/nodejs/node/pull/38723/commits/a0fb263b95ab7f0c9fc3c73cad36bdbd4a75bd0c
https://github.com/Ayase-252
Ayase-252https://github.com/Ayase-252
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
May 19, 2021https://github.com/nodejs/node/pull/38723#event-4763810335
https://github.com/aduh95
aduh95https://github.com/aduh95
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 19, 2021https://github.com/nodejs/node/pull/38723#event-4765096163
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 19, 2021https://github.com/nodejs/node/pull/38723#issuecomment-843873174
Please reload this pagehttps://github.com/nodejs/node/pull/38723
https://ci.nodejs.org/job/node-test-pull-request/38190/https://ci.nodejs.org/job/node-test-pull-request/38190/
Please reload this pagehttps://github.com/nodejs/node/pull/38723
https://github.com/ronag
ronaghttps://github.com/ronag
May 19, 2021 https://github.com/nodejs/node/pull/38723#pullrequestreview-663358928
View reviewed changes https://github.com/nodejs/node/pull/38723/files/a0fb263b95ab7f0c9fc3c73cad36bdbd4a75bd0c
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 19, 2021 https://github.com/nodejs/node/pull/38723#pullrequestreview-663413238
View reviewed changes https://github.com/nodejs/node/pull/38723/files/a0fb263b95ab7f0c9fc3c73cad36bdbd4a75bd0c
https://github.com/lpinca
lpincahttps://github.com/lpinca
May 19, 2021 https://github.com/nodejs/node/pull/38723#pullrequestreview-663574964
View reviewed changes https://github.com/nodejs/node/pull/38723/files/a0fb263b95ab7f0c9fc3c73cad36bdbd4a75bd0c
https://github.com/Lxxyx
Lxxyxhttps://github.com/Lxxyx
May 20, 2021 https://github.com/nodejs/node/pull/38723#pullrequestreview-664129182
View reviewed changes https://github.com/nodejs/node/pull/38723/files/a0fb263b95ab7f0c9fc3c73cad36bdbd4a75bd0c
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
May 20, 2021 https://github.com/nodejs/node/pull/38723#pullrequestreview-664374782
View reviewed changes https://github.com/nodejs/node/pull/38723/files/a0fb263b95ab7f0c9fc3c73cad36bdbd4a75bd0c
https://github.com/jasnell
jasnellhttps://github.com/jasnell
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
May 20, 2021https://github.com/nodejs/node/pull/38723#event-4773461022
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 20, 2021https://github.com/nodejs/node/pull/38723#issuecomment-845282465
b9ef539https://github.com/nodejs/node/commit/b9ef539eae9a86763f72e50eda68cfde29db485d
Please reload this pagehttps://github.com/nodejs/node/pull/38723
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 20, 2021https://github.com/nodejs/node/pull/38723#event-4774666262
jasnellhttps://github.com/jasnell
May 20, 2021 https://github.com/nodejs/node/pull/38723#ref-commit-b9ef539
https://github.com/Ayase-252
https://github.com/jasnell
stream: allow empty string as source of pipelinehttps://github.com/nodejs/node/commit/b9ef539eae9a86763f72e50eda68cfde29db485d
b9ef539https://github.com/nodejs/node/commit/b9ef539eae9a86763f72e50eda68cfde29db485d
#38721https://github.com/nodejs/node/issues/38721
#38723https://github.com/nodejs/node/pull/38723
https://github.com/Ayase-252
Ayase-252https://github.com/Ayase-252
May 21, 2021 14:15https://github.com/nodejs/node/pull/38723#event-4779548660
danielleadamshttps://github.com/danielleadams
May 31, 2021 https://github.com/nodejs/node/pull/38723#ref-commit-4131f94
https://github.com/Ayase-252
https://github.com/danielleadams
stream: allow empty string as source of pipelinehttps://github.com/nodejs/node/commit/4131f94ca84b7ad536794508c41c7c2014e5816e
4131f94https://github.com/nodejs/node/commit/4131f94ca84b7ad536794508c41c7c2014e5816e
#38721https://github.com/nodejs/node/issues/38721
#38723https://github.com/nodejs/node/pull/38723
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
May 31, 2021 https://github.com/nodejs/node/pull/38723#ref-pullrequest-907685851
v16.3.0 proposal #38874 https://github.com/nodejs/node/pull/38874
https://github.com/richardlau
richardlauhttps://github.com/richardlau
backport-blocked-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v14.x
Jul 16, 2021https://github.com/nodejs/node/pull/38723#event-5030301967
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 16, 2021https://github.com/nodejs/node/pull/38723#issuecomment-881370576
#37508https://github.com/nodejs/node/pull/37508
Please reload this pagehttps://github.com/nodejs/node/pull/38723
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38723
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/38723/files/a0fb263b95ab7f0c9fc3c73cad36bdbd4a75bd0c
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/38723/files/a0fb263b95ab7f0c9fc3c73cad36bdbd4a75bd0c
https://github.com/ronag
ronag https://github.com/ronag
https://github.com/nodejs/node/pull/38723/files/a0fb263b95ab7f0c9fc3c73cad36bdbd4a75bd0c
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/38723/files/e704e99049e1a47e1ce03f9bfcca448760877333
https://github.com/Lxxyx
Lxxyx https://github.com/Lxxyx
https://github.com/nodejs/node/pull/38723/files/a0fb263b95ab7f0c9fc3c73cad36bdbd4a75bd0c
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/38723/files/e704e99049e1a47e1ce03f9bfcca448760877333
https://github.com/RaisinTen
RaisinTen https://github.com/RaisinTen
https://github.com/nodejs/node/pull/38723/files/a0fb263b95ab7f0c9fc3c73cad36bdbd4a75bd0c
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
stream.pipeline does not accept zero-length string as a valid first argument https://github.com/nodejs/node/issues/38721
Please reload this pagehttps://github.com/nodejs/node/pull/38723
https://github.com/Ayase-252
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/richardlau
https://github.com/lpinca
https://github.com/ronag
https://github.com/BridgeAR
https://github.com/Lxxyx
https://github.com/aduh95
https://github.com/RaisinTen
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.