René's URL Explorer Experiment


Title: src: use HandleScope in StreamReq::Done() by RaisinTen · Pull Request #38720 · nodejs/node · GitHub

Open Graph Title: src: use HandleScope in StreamReq::Done() by RaisinTen · Pull Request #38720 · nodejs/node

X Title: src: use HandleScope in StreamReq::Done() by RaisinTen · Pull Request #38720 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #38707

X Description: Fixes: #38707

Opengraph URL: https://github.com/nodejs/node/pull/38720

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d9cb3fdb-2a0e-7e39-58fd-db46f8f16260
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCE40:E21C4:48F4EDD:66DB4B9:6A4FC0E0
html-safe-nonceacffb18e08ef2910352c91c7238f9050cbd89aef16fe6965b9d15e39d4f296c0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRTQwOkUyMUM0OjQ4RjRFREQ6NjZEQjRCOTo2QTRGQzBFMCIsInZpc2l0b3JfaWQiOiI1ODcwMjI1ODExNzkwNzI3MzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfcfcb4c009d1864b20fb0d20842ea7da0fcca70c2ab214dca0eadd1d00d2a5db
hovercard-subject-tagpull_request:646802496
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/38720/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f9707100f14e53f0e90a2d670315e10fe8beafec57475e833ff527e15745952e/nodejs/node/pull/38720
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f9707100f14e53f0e90a2d670315e10fe8beafec57475e833ff527e15745952e/nodejs/node/pull/38720
og:image:altFixes: #38707
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameRaisinTen
hostnamegithub.com
expected-hostnamegithub.com
None7d8f8209b188a80e19a6957836ab9229715797be5db1a04163963c674ccc33f6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseea848e83cf3bf3613dd7b13d52965a684fd23ec5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/38720#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38720
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38720
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/38720
Reloadhttps://github.com/nodejs/node/pull/38720
Reloadhttps://github.com/nodejs/node/pull/38720
Please reload this pagehttps://github.com/nodejs/node/pull/38720
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/38720
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
RaisinTenhttps://github.com/RaisinTen
nodejs:masterhttps://github.com/nodejs/node/tree/master
RaisinTen:src/use-HandleScope-in-StreamReq.Donehttps://github.com/RaisinTen/node/tree/src/use-HandleScope-in-StreamReq.Done
Conversationhttps://github.com/nodejs/node/pull/38720
Commits2 (2)https://github.com/nodejs/node/pull/38720/commits
Checkshttps://github.com/nodejs/node/pull/38720/checks
Files changedhttps://github.com/nodejs/node/pull/38720/files
src: use HandleScope in StreamReq::Done()https://github.com/nodejs/node/pull/38720#top
RaisinTenhttps://github.com/RaisinTen
nodejs:masterhttps://github.com/nodejs/node/tree/master
RaisinTen:src/use-HandleScope-in-StreamReq.Donehttps://github.com/RaisinTen/node/tree/src/use-HandleScope-in-StreamReq.Done
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
May 18, 2021https://github.com/nodejs/node/pull/38720#issue-894437933
#38707https://github.com/nodejs/node/issues/38707
Please reload this pagehttps://github.com/nodejs/node/pull/38720
https://github.com/RaisinTen
src: use HandleScope in StreamReq::Done()https://github.com/nodejs/node/pull/38720/commits/8787d00a8bc341889235861777cc6efc2fdf76b5
8787d00https://github.com/nodejs/node/pull/38720/commits/8787d00a8bc341889235861777cc6efc2fdf76b5
nodejs#38707https://github.com/nodejs/node/issues/38707
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 18, 2021 https://github.com/nodejs/node/pull/38720#pullrequestreview-662160525
View reviewed changes https://github.com/nodejs/node/pull/38720/files/8787d00a8bc341889235861777cc6efc2fdf76b5
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38720
https://github.com/Ayase-252
Ayase-252https://github.com/Ayase-252
May 18, 2021 https://github.com/nodejs/node/pull/38720#pullrequestreview-662182304
View reviewed changes https://github.com/nodejs/node/pull/38720/files/8787d00a8bc341889235861777cc6efc2fdf76b5
test/parallel/test-https-agent-unref-socket.jshttps://github.com/nodejs/node/pull/38720/files/8787d00a8bc341889235861777cc6efc2fdf76b5#diff-d744508470736ab5747bdf18a8f8f5d4ba3cde9dce3af6e968af55142a3f5344
Please reload this pagehttps://github.com/nodejs/node/pull/38720
https://github.com/RaisinTen
https://github.com/Ayase-252
Apply suggestions from code reviewhttps://github.com/nodejs/node/pull/38720/commits/d89dbd1303e526129a4a94e6c03fd8f919c6a976
d89dbd1https://github.com/nodejs/node/pull/38720/commits/d89dbd1303e526129a4a94e6c03fd8f919c6a976
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38720
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 18, 2021 https://github.com/nodejs/node/pull/38720#pullrequestreview-662231242
View reviewed changes https://github.com/nodejs/node/pull/38720/files/d89dbd1303e526129a4a94e6c03fd8f919c6a976
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38720
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 19, 2021https://github.com/nodejs/node/pull/38720#event-4767049503
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38720
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38720
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 21, 2021https://github.com/nodejs/node/pull/38720#issuecomment-846218481
Please reload this pagehttps://github.com/nodejs/node/pull/38720
https://ci.nodejs.org/job/node-test-pull-request/38254/https://ci.nodejs.org/job/node-test-pull-request/38254/
Please reload this pagehttps://github.com/nodejs/node/pull/38720
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 21, 2021https://github.com/nodejs/node/pull/38720#issuecomment-846264578
fcdb1dbhttps://github.com/nodejs/node/commit/fcdb1db6af393073fb15aac9181379244af07dd6
Please reload this pagehttps://github.com/nodejs/node/pull/38720
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 21, 2021https://github.com/nodejs/node/pull/38720#event-4781390718
jasnellhttps://github.com/jasnell
May 21, 2021 https://github.com/nodejs/node/pull/38720#ref-commit-fcdb1db
https://github.com/RaisinTen
https://github.com/jasnell
src: use HandleScope in StreamReq::Done()https://github.com/nodejs/node/commit/fcdb1db6af393073fb15aac9181379244af07dd6
fcdb1dbhttps://github.com/nodejs/node/commit/fcdb1db6af393073fb15aac9181379244af07dd6
#38707https://github.com/nodejs/node/issues/38707
#38720https://github.com/nodejs/node/pull/38720
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
May 22, 2021 14:35https://github.com/nodejs/node/pull/38720#event-4782402268
danielleadamshttps://github.com/danielleadams
May 31, 2021 https://github.com/nodejs/node/pull/38720#ref-commit-4e33532
https://github.com/RaisinTen
https://github.com/danielleadams
src: use HandleScope in StreamReq::Done()https://github.com/nodejs/node/commit/4e3353223e5a3f7e9a0ab2cdf22ed1a36fc83a3c
4e33532https://github.com/nodejs/node/commit/4e3353223e5a3f7e9a0ab2cdf22ed1a36fc83a3c
#38707https://github.com/nodejs/node/issues/38707
#38720https://github.com/nodejs/node/pull/38720
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
May 31, 2021 https://github.com/nodejs/node/pull/38720#ref-pullrequest-907685851
v16.3.0 proposal #38874 https://github.com/nodejs/node/pull/38874
richardlauhttps://github.com/richardlau
Jul 16, 2021 https://github.com/nodejs/node/pull/38720#ref-commit-c254186
https://github.com/RaisinTen
https://github.com/richardlau
src: use HandleScope in StreamReq::Done()https://github.com/nodejs/node/commit/c2541864ece29fe4cac33b9d0051fac4906d6289
c254186https://github.com/nodejs/node/commit/c2541864ece29fe4cac33b9d0051fac4906d6289
#38707https://github.com/nodejs/node/issues/38707
#38720https://github.com/nodejs/node/pull/38720
richardlauhttps://github.com/richardlau
Jul 19, 2021 https://github.com/nodejs/node/pull/38720#ref-commit-ee66cfc
https://github.com/RaisinTen
https://github.com/richardlau
src: use HandleScope in StreamReq::Done()https://github.com/nodejs/node/commit/ee66cfca79932fe30eed66e7f8cda726753907a5
ee66cfchttps://github.com/nodejs/node/commit/ee66cfca79932fe30eed66e7f8cda726753907a5
#38707https://github.com/nodejs/node/issues/38707
#38720https://github.com/nodejs/node/pull/38720
richardlauhttps://github.com/richardlau
Jul 20, 2021 https://github.com/nodejs/node/pull/38720#ref-commit-2d32031
https://github.com/RaisinTen
https://github.com/richardlau
src: use HandleScope in StreamReq::Done()https://github.com/nodejs/node/commit/2d32031724363a98270b13243015ef6a3e5db3e9
2d32031https://github.com/nodejs/node/commit/2d32031724363a98270b13243015ef6a3e5db3e9
#38707https://github.com/nodejs/node/issues/38707
#38720https://github.com/nodejs/node/pull/38720
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 20, 2021 https://github.com/nodejs/node/pull/38720#ref-pullrequest-948590637
v14.17.4 proposal #39466 https://github.com/nodejs/node/pull/39466
foxxyzhttps://github.com/foxxyz
Oct 18, 2021 https://github.com/nodejs/node/pull/38720#ref-commit-efba51f
https://github.com/RaisinTen
https://github.com/foxxyz
src: use HandleScope in StreamReq::Done()https://github.com/foxxyz/node/commit/efba51faf9732c6561b5278b3af2b053a5d24061
efba51fhttps://github.com/foxxyz/node/commit/efba51faf9732c6561b5278b3af2b053a5d24061
nodejs#38707https://github.com/nodejs/node/issues/38707
nodejs#38720https://github.com/nodejs/node/pull/38720
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38720
https://github.com/Ayase-252
Ayase-252 https://github.com/Ayase-252
https://github.com/nodejs/node/pull/38720/files/8787d00a8bc341889235861777cc6efc2fdf76b5
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/38720/files/8787d00a8bc341889235861777cc6efc2fdf76b5
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/38720/files/d89dbd1303e526129a4a94e6c03fd8f919c6a976
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Unref a socket raise v8 error https://github.com/nodejs/node/issues/38707
Please reload this pagehttps://github.com/nodejs/node/pull/38720
https://github.com/RaisinTen
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/addaleax
https://github.com/Ayase-252
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.