René's URL Explorer Experiment


Title: stream: add Transform.by utility function (updated) by safareli · Pull Request #38696 · nodejs/node · GitHub

Open Graph Title: stream: add Transform.by utility function (updated) by safareli · Pull Request #38696 · nodejs/node

X Title: stream: add Transform.by utility function (updated) by safareli · Pull Request #38696 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Updated #28501

X Description: Updated #28501

Opengraph URL: https://github.com/nodejs/node/pull/38696

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:95b1913f-58fe-dda7-3c4b-35e26372f365
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idECC8:14C1A2:4FB82A9:709D896:6A501E07
html-safe-nonceee81ad3cf62ea54445f600cb378dcbd493b3740f47f730cacdb59bc8ba203816
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0M4OjE0QzFBMjo0RkI4MkE5OjcwOUQ4OTY6NkE1MDFFMDciLCJ2aXNpdG9yX2lkIjoiNTc4MjY5NDAxMDA1ODQ0ODM5MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac746dd588a0729d875fc0e19742409fadcdf4778a2dd239d8c1061468d5c8d970
hovercard-subject-tagpull_request:645127193
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/38696/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/012e447943e24dce057015a1a49c9a945d781fe5c9cf3d5e98ff91115b967742/nodejs/node/pull/38696
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/012e447943e24dce057015a1a49c9a945d781fe5c9cf3d5e98ff91115b967742/nodejs/node/pull/38696
og:image:altUpdated #28501
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesafareli
hostnamegithub.com
expected-hostnamegithub.com
None14f013003d3992e8746116a6f2f55cd2fdaccd329ee0423392831ae051ecb535
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26ee7c1a62943cf19a6fcc1d1ac93ac83465c885
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/38696#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38696
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38696
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/38696
Reloadhttps://github.com/nodejs/node/pull/38696
Reloadhttps://github.com/nodejs/node/pull/38696
Please reload this pagehttps://github.com/nodejs/node/pull/38696
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/38696
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 977 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
safarelihttps://github.com/safareli
nodejs:masterhttps://github.com/nodejs/node/tree/master
safareli:transform-byhttps://github.com/safareli/node/tree/transform-by
Conversationhttps://github.com/nodejs/node/pull/38696
Commits43 (43)https://github.com/nodejs/node/pull/38696/commits
Checkshttps://github.com/nodejs/node/pull/38696/checks
Files changedhttps://github.com/nodejs/node/pull/38696/files
stream: add Transform.by utility function (updated)https://github.com/nodejs/node/pull/38696#top
safarelihttps://github.com/safareli
nodejs:masterhttps://github.com/nodejs/node/tree/master
safareli:transform-byhttps://github.com/safareli/node/tree/transform-by
https://github.com/safareli
safarelihttps://github.com/safareli
May 15, 2021https://github.com/nodejs/node/pull/38696#issue-892419364
#28501https://github.com/nodejs/node/pull/28501
Please reload this pagehttps://github.com/nodejs/node/pull/38696
December 16, 2019 12:00https://github.com/nodejs/node/pull/38696#commits-pushed-d957541
stream: add Transform.by utility functionhttps://github.com/nodejs/node/pull/38696/commits/d957541a46c9ec651491f13e9973517914746a02
d957541https://github.com/nodejs/node/pull/38696/commits/d957541a46c9ec651491f13e9973517914746a02
docs: stream.Transform.by typohttps://github.com/nodejs/node/pull/38696/commits/9005e46658af53718305af2d2f3d5af7086b0efd
9005e46https://github.com/nodejs/node/pull/38696/commits/9005e46658af53718305af2d2f3d5af7086b0efd
stream: Transform.by SourceIterator next optimizationhttps://github.com/nodejs/node/pull/38696/commits/944f228fd26d4627176dc907d97c34fd34f626b9
944f228https://github.com/nodejs/node/pull/38696/commits/944f228fd26d4627176dc907d97c34fd34f626b9
https://github.com/davidmarkclements
https://github.com/vsemozhetbyt
docs: Transform.by doc tweakshttps://github.com/nodejs/node/pull/38696/commits/84c84c9fdf00d0594031925cfb46ad12a84f6aaf
84c84c9https://github.com/nodejs/node/pull/38696/commits/84c84c9fdf00d0594031925cfb46ad12a84f6aaf
https://github.com/davidmarkclements
docs: sort type-parser types alphabetically within their groupshttps://github.com/nodejs/node/pull/38696/commits/a1937c7aa1afd904530ddecf71e9c4527209dbb5
a1937c7https://github.com/nodejs/node/pull/38696/commits/a1937c7aa1afd904530ddecf71e9c4527209dbb5
https://github.com/davidmarkclements
docs: sort type-parser types alphabetically within their groupshttps://github.com/nodejs/node/pull/38696/commits/ad35382afcde499d48c48061954dda1d63c2b9b3
ad35382https://github.com/nodejs/node/pull/38696/commits/ad35382afcde499d48c48061954dda1d63c2b9b3
https://github.com/davidmarkclements
docs: typohttps://github.com/nodejs/node/pull/38696/commits/8d82c5b93395de435bed75ae7b6c469cad68ee0d
8d82c5bhttps://github.com/nodejs/node/pull/38696/commits/8d82c5b93395de435bed75ae7b6c469cad68ee0d
https://github.com/davidmarkclements
https://github.com/addaleax
docs: Transform.by clarify as async iterablehttps://github.com/nodejs/node/pull/38696/commits/7a1ef775ca88c24fef87fa312c41956adf59f976
7a1ef77https://github.com/nodejs/node/pull/38696/commits/7a1ef775ca88c24fef87fa312c41956adf59f976
https://github.com/davidmarkclements
stream: Transform. by remove unnecessary defensive codehttps://github.com/nodejs/node/pull/38696/commits/57074456c1a64282ff5bf2692045f2719af4a449
5707445https://github.com/nodejs/node/pull/38696/commits/57074456c1a64282ff5bf2692045f2719af4a449
https://github.com/davidmarkclements
https://github.com/addaleax
stream: Transform.by code stylehttps://github.com/nodejs/node/pull/38696/commits/970ed3d69edf8a5b4e3ed4ee13ecc7ad63fdbf82
970ed3dhttps://github.com/nodejs/node/pull/38696/commits/970ed3d69edf8a5b4e3ed4ee13ecc7ad63fdbf82
stream: Transform.by minor refactoringhttps://github.com/nodejs/node/pull/38696/commits/6e67a8584c0e0e19476280d32bb8c1b2d70410d4
6e67a85https://github.com/nodejs/node/pull/38696/commits/6e67a8584c0e0e19476280d32bb8c1b2d70410d4
streams: Transform.by check fn return value instead of fn instancehttps://github.com/nodejs/node/pull/38696/commits/98aebc5dabc7fa6afb38c14ae700387959639a34
98aebc5https://github.com/nodejs/node/pull/38696/commits/98aebc5dabc7fa6afb38c14ae700387959639a34
docs: emphasize Transform.by objectMode default behaviourhttps://github.com/nodejs/node/pull/38696/commits/eee19c591ecf4195912e280a0f3dd59eb6781de3
eee19c5https://github.com/nodejs/node/pull/38696/commits/eee19c591ecf4195912e280a0f3dd59eb6781de3
https://github.com/davidmarkclements
https://github.com/vsemozhetbyt
docs: Transform.by function naming conventionhttps://github.com/nodejs/node/pull/38696/commits/26e96be1ea86a33c3878eace10d2aebc7f8f2848
26e96behttps://github.com/nodejs/node/pull/38696/commits/26e96be1ea86a33c3878eace10d2aebc7f8f2848
docs: add transform content to streams <-> async generators compatibi…https://github.com/nodejs/node/pull/38696/commits/185a6f481a02cff0eeebb2f4acbbed80e4b4648d
185a6f4https://github.com/nodejs/node/pull/38696/commits/185a6f481a02cff0eeebb2f4acbbed80e4b4648d
docs: includemissing parenshttps://github.com/nodejs/node/pull/38696/commits/8e73c519c6b380b800966e356546ba180fedef5e
8e73c51https://github.com/nodejs/node/pull/38696/commits/8e73c519c6b380b800966e356546ba180fedef5e
tests: preempt conflict withhttps://github.com/nodejs/node/pull/38696/commits/b73347f5d5467197d0e5890bcd1f9201a818b342
nodejs#28566https://github.com/nodejs/node/pull/28566
b73347fhttps://github.com/nodejs/node/pull/38696/commits/b73347f5d5467197d0e5890bcd1f9201a818b342
tests: fix transform async iterator testhttps://github.com/nodejs/node/pull/38696/commits/9789a5b1e64c05ccbd06bf70f7ca6aa8a718a5d8
9789a5bhttps://github.com/nodejs/node/pull/38696/commits/9789a5b1e64c05ccbd06bf70f7ca6aa8a718a5d8
https://github.com/davidmarkclements
https://github.com/addaleax
docs: add meta data to Transform.byhttps://github.com/nodejs/node/pull/38696/commits/bad0bfdd491562a5c85307a9e36ad32ae0b0d9a3
bad0bfdhttps://github.com/nodejs/node/pull/38696/commits/bad0bfdd491562a5c85307a9e36ad32ae0b0d9a3
stream: error handling bug fix, ensure stream is destroyed after proc…https://github.com/nodejs/node/pull/38696/commits/f2c8b229ba06fc047536156c0e1969a950f8d3cb
f2c8b22https://github.com/nodejs/node/pull/38696/commits/f2c8b229ba06fc047536156c0e1969a950f8d3cb
https://github.com/davidmarkclements
https://github.com/vsemozhetbyt
Update doc/api/stream.mdhttps://github.com/nodejs/node/pull/38696/commits/001fe014a2de99dbf4db6b47ad0748b9211717db
001fe01https://github.com/nodejs/node/pull/38696/commits/001fe014a2de99dbf4db6b47ad0748b9211717db
https://github.com/davidmarkclements
https://github.com/vsemozhetbyt
Update doc/api/stream.mdhttps://github.com/nodejs/node/pull/38696/commits/9545ee02105474c300f5001a8371aaf8cc01d461
9545ee0https://github.com/nodejs/node/pull/38696/commits/9545ee02105474c300f5001a8371aaf8cc01d461
https://github.com/davidmarkclements
https://github.com/vsemozhetbyt
Update doc/api/stream.mdhttps://github.com/nodejs/node/pull/38696/commits/f0fa8b61952751cd14a22d1d9db885f4cc994c13
f0fa8b6https://github.com/nodejs/node/pull/38696/commits/f0fa8b61952751cd14a22d1d9db885f4cc994c13
https://github.com/davidmarkclements
https://github.com/vsemozhetbyt
Update doc/api/stream.mdhttps://github.com/nodejs/node/pull/38696/commits/b504b15eaa1844fdadd5942d190f22cbcd7d9b77
b504b15https://github.com/nodejs/node/pull/38696/commits/b504b15eaa1844fdadd5942d190f22cbcd7d9b77
streams: Transform.by, rm unncessary checkhttps://github.com/nodejs/node/pull/38696/commits/447a895818606d73d0e7f6d09bc528bc07eab8d1
447a895https://github.com/nodejs/node/pull/38696/commits/447a895818606d73d0e7f6d09bc528bc07eab8d1
lint fixeshttps://github.com/nodejs/node/pull/38696/commits/2fe96e46d186b6be83b0eaeb6ae6769521487670
2fe96e4https://github.com/nodejs/node/pull/38696/commits/2fe96e46d186b6be83b0eaeb6ae6769521487670
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
errors https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
May 15, 2021https://github.com/nodejs/node/pull/38696#event-4749868472
https://github.com/safareli
https://github.com/Trott
Apply stream.md suggestions from code reviewhttps://github.com/nodejs/node/pull/38696/commits/a98544111d453fabc59f3010a522bef7d0eb8f02
a985441https://github.com/nodejs/node/pull/38696/commits/a98544111d453fabc59f3010a522bef7d0eb8f02
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 4, 2021https://github.com/nodejs/node/pull/38696#issuecomment-854451305
https://ci.nodejs.org/job/node-test-pull-request/38486/https://ci.nodejs.org/job/node-test-pull-request/38486/
Please reload this pagehttps://github.com/nodejs/node/pull/38696
https://github.com/aduh95
aduh95https://github.com/aduh95
Jun 4, 2021 https://github.com/nodejs/node/pull/38696#pullrequestreview-676031238
View reviewed changes https://github.com/nodejs/node/pull/38696/files/a98544111d453fabc59f3010a522bef7d0eb8f02
doc/api/stream.mdhttps://github.com/nodejs/node/pull/38696/files/b4b5441804e5955f10b49e42a71a9e77993995f5#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90
Please reload this pagehttps://github.com/nodejs/node/pull/38696
lib/internal/streams/transform.jshttps://github.com/nodejs/node/pull/38696/files/a98544111d453fabc59f3010a522bef7d0eb8f02#diff-4f114d20059e8e6bb574ad3f260258720a795fad78be4c99c38a6e157429e8bc
Please reload this pagehttps://github.com/nodejs/node/pull/38696
lib/internal/streams/transform.jshttps://github.com/nodejs/node/pull/38696/files/a98544111d453fabc59f3010a522bef7d0eb8f02#diff-4f114d20059e8e6bb574ad3f260258720a795fad78be4c99c38a6e157429e8bc
Please reload this pagehttps://github.com/nodejs/node/pull/38696
lib/internal/streams/transform.jshttps://github.com/nodejs/node/pull/38696/files/a98544111d453fabc59f3010a522bef7d0eb8f02#diff-4f114d20059e8e6bb574ad3f260258720a795fad78be4c99c38a6e157429e8bc
Please reload this pagehttps://github.com/nodejs/node/pull/38696
lib/internal/streams/transform.jshttps://github.com/nodejs/node/pull/38696/files/a98544111d453fabc59f3010a522bef7d0eb8f02#diff-4f114d20059e8e6bb574ad3f260258720a795fad78be4c99c38a6e157429e8bc
Please reload this pagehttps://github.com/nodejs/node/pull/38696
lib/internal/streams/transform.jshttps://github.com/nodejs/node/pull/38696/files/a98544111d453fabc59f3010a522bef7d0eb8f02#diff-4f114d20059e8e6bb574ad3f260258720a795fad78be4c99c38a6e157429e8bc
Please reload this pagehttps://github.com/nodejs/node/pull/38696
lib/internal/streams/transform.jshttps://github.com/nodejs/node/pull/38696/files/a98544111d453fabc59f3010a522bef7d0eb8f02#diff-4f114d20059e8e6bb574ad3f260258720a795fad78be4c99c38a6e157429e8bc
Please reload this pagehttps://github.com/nodejs/node/pull/38696
https://github.com/safareli
applyhttps://github.com/nodejs/node/pull/38696/commits/e0c1f0e222fdf1e98104409b4f96974d46721921
@aduh95https://github.com/aduh95
suggestionshttps://github.com/nodejs/node/pull/38696/commits/e0c1f0e222fdf1e98104409b4f96974d46721921
e0c1f0ehttps://github.com/nodejs/node/pull/38696/commits/e0c1f0e222fdf1e98104409b4f96974d46721921
https://github.com/aduh95
aduh95https://github.com/aduh95
Jun 6, 2021 https://github.com/nodejs/node/pull/38696#pullrequestreview-676861281
View reviewed changes https://github.com/nodejs/node/pull/38696/files/e0c1f0e222fdf1e98104409b4f96974d46721921
doc/api/stream.mdhttps://github.com/nodejs/node/pull/38696/files/e0c1f0e222fdf1e98104409b4f96974d46721921#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90
Please reload this pagehttps://github.com/nodejs/node/pull/38696
https://github.com/aduh95
aduh95https://github.com/aduh95
Jun 6, 2021 https://github.com/nodejs/node/pull/38696#pullrequestreview-676861349
View reviewed changes https://github.com/nodejs/node/pull/38696/files/e0c1f0e222fdf1e98104409b4f96974d46721921
aduh95https://github.com/aduh95
https://github.com/nodejs/node/pull/38696#pullrequestreview-676861349
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/38696
lib/internal/streams/transform.jshttps://github.com/nodejs/node/pull/38696/files/e0c1f0e222fdf1e98104409b4f96974d46721921#diff-4f114d20059e8e6bb574ad3f260258720a795fad78be4c99c38a6e157429e8bc
Please reload this pagehttps://github.com/nodejs/node/pull/38696
lib/internal/streams/transform.jshttps://github.com/nodejs/node/pull/38696/files/e0c1f0e222fdf1e98104409b4f96974d46721921#diff-4f114d20059e8e6bb574ad3f260258720a795fad78be4c99c38a6e157429e8bc
Please reload this pagehttps://github.com/nodejs/node/pull/38696
safarelihttps://github.com/safareli
June 6, 2021 17:04https://github.com/nodejs/node/pull/38696#commits-pushed-c5c862d
https://github.com/safareli
https://github.com/aduh95
Apply suggestions from code reviewhttps://github.com/nodejs/node/pull/38696/commits/c5c862d13cc93eb4ca1336c4b0a800f52508f698
c5c862dhttps://github.com/nodejs/node/pull/38696/commits/c5c862d13cc93eb4ca1336c4b0a800f52508f698
https://github.com/safareli
https://github.com/aduh95
Update doc/api/stream.mdhttps://github.com/nodejs/node/pull/38696/commits/adc6059c9c700018854f03f15cd6d48ebe1a44c1
adc6059https://github.com/nodejs/node/pull/38696/commits/adc6059c9c700018854f03f15cd6d48ebe1a44c1
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jun 8, 2021 https://github.com/nodejs/node/pull/38696#pullrequestreview-678308564
View reviewed changes https://github.com/nodejs/node/pull/38696/files/adc6059c9c700018854f03f15cd6d48ebe1a44c1
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/38696#pullrequestreview-678308564
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/38696
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jun 8, 2021https://github.com/nodejs/node/pull/38696#issuecomment-856619247
Please reload this pagehttps://github.com/nodejs/node/pull/38696
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 8, 2021https://github.com/nodejs/node/pull/38696#issuecomment-856619634
https://ci.nodejs.org/job/node-test-pull-request/38527/https://ci.nodejs.org/job/node-test-pull-request/38527/
Please reload this pagehttps://github.com/nodejs/node/pull/38696
https://github.com/safareli
safarelihttps://github.com/safareli
Jun 8, 2021https://github.com/nodejs/node/pull/38696#issuecomment-856669086
herehttps://github.com/nodejs/node/pull/38696/files#diff-300f00c229d4084c3369e4486a27b04c5121af4f01188370165197022743f9b8R48
Please reload this pagehttps://github.com/nodejs/node/pull/38696
https://github.com/aymen94
aymen94https://github.com/aymen94
Jun 8, 2021 https://github.com/nodejs/node/pull/38696#pullrequestreview-678482127
View reviewed changes https://github.com/nodejs/node/pull/38696/files/adc6059c9c700018854f03f15cd6d48ebe1a44c1
https://github.com/aduh95
aduh95https://github.com/aduh95
Jun 8, 2021 https://github.com/nodejs/node/pull/38696#pullrequestreview-678495656
View reviewed changes https://github.com/nodejs/node/pull/38696/files/adc6059c9c700018854f03f15cd6d48ebe1a44c1
test/parallel/test-stream-transform-by.jshttps://github.com/nodejs/node/pull/38696/files/adc6059c9c700018854f03f15cd6d48ebe1a44c1#diff-300f00c229d4084c3369e4486a27b04c5121af4f01188370165197022743f9b8
aduh95https://github.com/aduh95
Jun 8, 2021https://github.com/nodejs/node/pull/38696#discussion_r647424234
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/38696
safarelihttps://github.com/safareli
Jun 8, 2021https://github.com/nodejs/node/pull/38696#discussion_r647630529
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/38696
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jun 8, 2021 https://github.com/nodejs/node/pull/38696#pullrequestreview-678719745
View reviewed changes https://github.com/nodejs/node/pull/38696/files/adc6059c9c700018854f03f15cd6d48ebe1a44c1
lib/internal/streams/transform.jshttps://github.com/nodejs/node/pull/38696/files/adc6059c9c700018854f03f15cd6d48ebe1a44c1#diff-4f114d20059e8e6bb574ad3f260258720a795fad78be4c99c38a6e157429e8bc
mcollinahttps://github.com/mcollina
Jun 8, 2021https://github.com/nodejs/node/pull/38696#discussion_r647588909
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/38696
safarelihttps://github.com/safareli
Jun 8, 2021https://github.com/nodejs/node/pull/38696#discussion_r647628435
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/38696
https://github.com/safareli
assign encoding to the async generatorhttps://github.com/nodejs/node/pull/38696/commits/967989efa319aed035f6512cab867d3726688086
967989ehttps://github.com/nodejs/node/pull/38696/commits/967989efa319aed035f6512cab867d3726688086
https://github.com/safareli
safarelihttps://github.com/safareli
Jun 8, 2021 https://github.com/nodejs/node/pull/38696#pullrequestreview-678819413
View reviewed changes https://github.com/nodejs/node/pull/38696/files/adc6059c9c700018854f03f15cd6d48ebe1a44c1
test/parallel/test-stream-transform-by.jshttps://github.com/nodejs/node/pull/38696/files/adc6059c9c700018854f03f15cd6d48ebe1a44c1#diff-300f00c229d4084c3369e4486a27b04c5121af4f01188370165197022743f9b8
safarelihttps://github.com/safareli
Jun 8, 2021https://github.com/nodejs/node/pull/38696#discussion_r647662759
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/38696
mcollinahttps://github.com/mcollina
Jun 10, 2021https://github.com/nodejs/node/pull/38696#discussion_r649321940
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/38696
safarelihttps://github.com/safareli
Jun 10, 2021https://github.com/nodejs/node/pull/38696#discussion_r649405469
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/38696
mcollinahttps://github.com/mcollina
Jun 11, 2021https://github.com/nodejs/node/pull/38696#discussion_r649799268
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/38696
mcollinahttps://github.com/mcollina
Jun 15, 2021https://github.com/nodejs/node/pull/38696#discussion_r651630519
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@safarelihttps://github.com/safareli
Please reload this pagehttps://github.com/nodejs/node/pull/38696
safarelihttps://github.com/safareli
Jun 15, 2021https://github.com/nodejs/node/pull/38696#discussion_r651643175
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/38696
https://github.com/mcollina
mcollinahttps://github.com/mcollina
notable-change https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Jun 9, 2021https://github.com/nodejs/node/pull/38696#event-4863141167
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jun 9, 2021 https://github.com/nodejs/node/pull/38696#pullrequestreview-679640483
View reviewed changes https://github.com/nodejs/node/pull/38696/files/967989efa319aed035f6512cab867d3726688086
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/38696#pullrequestreview-679640483
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/38696
lib/internal/streams/transform.jshttps://github.com/nodejs/node/pull/38696/files/967989efa319aed035f6512cab867d3726688086#diff-4f114d20059e8e6bb574ad3f260258720a795fad78be4c99c38a6e157429e8bc
Please reload this pagehttps://github.com/nodejs/node/pull/38696
lib/internal/streams/transform.jshttps://github.com/nodejs/node/pull/38696/files/967989efa319aed035f6512cab867d3726688086#diff-4f114d20059e8e6bb574ad3f260258720a795fad78be4c99c38a6e157429e8bc
Please reload this pagehttps://github.com/nodejs/node/pull/38696
lib/internal/streams/transform.jshttps://github.com/nodejs/node/pull/38696/files/967989efa319aed035f6512cab867d3726688086#diff-4f114d20059e8e6bb574ad3f260258720a795fad78be4c99c38a6e157429e8bc
Please reload this pagehttps://github.com/nodejs/node/pull/38696
https://github.com/safareli
add encoding to yieldhttps://github.com/nodejs/node/pull/38696/commits/6ccafaba0e4e92ba7ed3582711bc29a9042c2030
6ccafabhttps://github.com/nodejs/node/pull/38696/commits/6ccafaba0e4e92ba7ed3582711bc29a9042c2030
https://github.com/safareli
safarelihttps://github.com/safareli
Jun 9, 2021https://github.com/nodejs/node/pull/38696#issuecomment-857857234
Please reload this pagehttps://github.com/nodejs/node/pull/38696
@sounisi5011https://github.com/sounisi5011
stream-transform-fromhttps://www.npmjs.com/package/@sounisi5011/stream-transform-from
Please reload this pagehttps://github.com/nodejs/node/pull/38696
https://github.com/sounisi5011
sounisi5011https://github.com/sounisi5011
Jun 9, 2021https://github.com/nodejs/node/pull/38696#issuecomment-858031299
Please reload this pagehttps://github.com/nodejs/node/pull/38696
@sounisi5011https://github.com/sounisi5011
stream-transform-fromhttps://www.npmjs.com/package/@sounisi5011/stream-transform-from
#38696 (comment)https://github.com/nodejs/node/pull/38696#issuecomment-857857234
@sounisi5011/stream-transform-fromhttps://www.npmjs.com/package/@sounisi5011/stream-transform-from
streams.Transform.from() did not exist in Node.jshttps://github.com/nodejs/node/issues/27140
Please reload this pagehttps://github.com/nodejs/node/pull/38696
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Jun 14, 2021 https://github.com/nodejs/node/pull/38696#pullrequestreview-682590581
View reviewed changes https://github.com/nodejs/node/pull/38696/files/6ccafaba0e4e92ba7ed3582711bc29a9042c2030
lib/internal/streams/transform.jshttps://github.com/nodejs/node/pull/38696/files/6ccafaba0e4e92ba7ed3582711bc29a9042c2030#diff-4f114d20059e8e6bb574ad3f260258720a795fad78be4c99c38a6e157429e8bc
Please reload this pagehttps://github.com/nodejs/node/pull/38696
https://github.com/safareli
try fix some testshttps://github.com/nodejs/node/pull/38696/commits/9bccc233a7b59577c137a6b83193456d6fbdbbcb
9bccc23https://github.com/nodejs/node/pull/38696/commits/9bccc233a7b59577c137a6b83193456d6fbdbbcb
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 15, 2021https://github.com/nodejs/node/pull/38696#issuecomment-861457476
https://ci.nodejs.org/job/node-test-pull-request/38636/https://ci.nodejs.org/job/node-test-pull-request/38636/
Please reload this pagehttps://github.com/nodejs/node/pull/38696
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jun 17, 2021https://github.com/nodejs/node/pull/38696#issuecomment-863277625
Please reload this pagehttps://github.com/nodejs/node/pull/38696
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 1, 2021 https://github.com/nodejs/node/pull/38696#ref-pullrequest-920409935
stream: compose #39029 https://github.com/nodejs/node/pull/39029
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 3, 2022https://github.com/nodejs/node/pull/38696#issuecomment-1004173089
Please reload this pagehttps://github.com/nodejs/node/pull/38696
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 3, 2022https://github.com/nodejs/node/pull/38696#event-5835884420
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38696
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/38696/files/6ccafaba0e4e92ba7ed3582711bc29a9042c2030
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/38696/files/b4b5441804e5955f10b49e42a71a9e77993995f5
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/38696/files/adc6059c9c700018854f03f15cd6d48ebe1a44c1
https://github.com/RaisinTen
RaisinTen https://github.com/RaisinTen
https://github.com/nodejs/node/pull/38696/files/6ccafaba0e4e92ba7ed3582711bc29a9042c2030
https://github.com/ronag
ronag https://github.com/ronag
https://github.com/nodejs/node/pull/38696/files/307e926fac9624b8a7b3ea5e173d4e4c6a21871b
https://github.com/thefourtheye
thefourtheye https://github.com/thefourtheye
https://github.com/nodejs/node/pull/38696/files/6ccafaba0e4e92ba7ed3582711bc29a9042c2030
https://github.com/aymen94
aymen94 https://github.com/aymen94
https://github.com/nodejs/node/pull/38696/files/adc6059c9c700018854f03f15cd6d48ebe1a44c1
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
errors https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
notable-change https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Please reload this pagehttps://github.com/nodejs/node/pull/38696
https://github.com/safareli
https://github.com/nodejs-github-bot
https://github.com/ronag
https://github.com/mcollina
https://github.com/sounisi5011
https://github.com/thefourtheye
https://github.com/Trott
https://github.com/aymen94
https://github.com/aduh95
https://github.com/RaisinTen
https://github.com/davidmarkclements
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.