| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:95b1913f-58fe-dda7-3c4b-35e26372f365 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ECC8:14C1A2:4FB82A9:709D896:6A501E07 |
| html-safe-nonce | ee81ad3cf62ea54445f600cb378dcbd493b3740f47f730cacdb59bc8ba203816 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0M4OjE0QzFBMjo0RkI4MkE5OjcwOUQ4OTY6NkE1MDFFMDciLCJ2aXNpdG9yX2lkIjoiNTc4MjY5NDAxMDA1ODQ0ODM5MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 746dd588a0729d875fc0e19742409fadcdf4778a2dd239d8c1061468d5c8d970 |
| hovercard-subject-tag | pull_request:645127193 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/38696/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/012e447943e24dce057015a1a49c9a945d781fe5c9cf3d5e98ff91115b967742/nodejs/node/pull/38696 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/012e447943e24dce057015a1a49c9a945d781fe5c9cf3d5e98ff91115b967742/nodejs/node/pull/38696 |
| og:image:alt | Updated #28501 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | safareli |
| hostname | github.com |
| expected-hostname | github.com |
| None | 14f013003d3992e8746116a6f2f55cd2fdaccd329ee0423392831ae051ecb535 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 26ee7c1a62943cf19a6fcc1d1ac93ac83465c885 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/38696#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38696 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38696 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/38696 |
| Reload | https://github.com/nodejs/node/pull/38696 |
| Reload | https://github.com/nodejs/node/pull/38696 |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
977
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| safareli | https://github.com/safareli |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| safareli:transform-by | https://github.com/safareli/node/tree/transform-by |
| Conversation | https://github.com/nodejs/node/pull/38696 |
| Commits43 (43) | https://github.com/nodejs/node/pull/38696/commits |
| Checks | https://github.com/nodejs/node/pull/38696/checks |
| Files changed | https://github.com/nodejs/node/pull/38696/files |
| stream: add Transform.by utility function (updated) | https://github.com/nodejs/node/pull/38696#top |
| safareli | https://github.com/safareli |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| safareli:transform-by | https://github.com/safareli/node/tree/transform-by |
|
| https://github.com/safareli |
| safareli | https://github.com/safareli |
| May 15, 2021 | https://github.com/nodejs/node/pull/38696#issue-892419364 |
| #28501 | https://github.com/nodejs/node/pull/28501 |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| December 16, 2019 12:00 | https://github.com/nodejs/node/pull/38696#commits-pushed-d957541 |
| stream: add Transform.by utility function | https://github.com/nodejs/node/pull/38696/commits/d957541a46c9ec651491f13e9973517914746a02 |
| d957541 | https://github.com/nodejs/node/pull/38696/commits/d957541a46c9ec651491f13e9973517914746a02 |
| docs: stream.Transform.by typo | https://github.com/nodejs/node/pull/38696/commits/9005e46658af53718305af2d2f3d5af7086b0efd |
| 9005e46 | https://github.com/nodejs/node/pull/38696/commits/9005e46658af53718305af2d2f3d5af7086b0efd |
| stream: Transform.by SourceIterator next optimization | https://github.com/nodejs/node/pull/38696/commits/944f228fd26d4627176dc907d97c34fd34f626b9 |
| 944f228 | https://github.com/nodejs/node/pull/38696/commits/944f228fd26d4627176dc907d97c34fd34f626b9 |
|
| https://github.com/davidmarkclements |
|
| https://github.com/vsemozhetbyt |
| docs: Transform.by doc tweaks | https://github.com/nodejs/node/pull/38696/commits/84c84c9fdf00d0594031925cfb46ad12a84f6aaf |
| 84c84c9 | https://github.com/nodejs/node/pull/38696/commits/84c84c9fdf00d0594031925cfb46ad12a84f6aaf |
|
| https://github.com/davidmarkclements |
| docs: sort type-parser types alphabetically within their groups | https://github.com/nodejs/node/pull/38696/commits/a1937c7aa1afd904530ddecf71e9c4527209dbb5 |
| a1937c7 | https://github.com/nodejs/node/pull/38696/commits/a1937c7aa1afd904530ddecf71e9c4527209dbb5 |
|
| https://github.com/davidmarkclements |
| docs: sort type-parser types alphabetically within their groups | https://github.com/nodejs/node/pull/38696/commits/ad35382afcde499d48c48061954dda1d63c2b9b3 |
| ad35382 | https://github.com/nodejs/node/pull/38696/commits/ad35382afcde499d48c48061954dda1d63c2b9b3 |
|
| https://github.com/davidmarkclements |
| docs: typo | https://github.com/nodejs/node/pull/38696/commits/8d82c5b93395de435bed75ae7b6c469cad68ee0d |
| 8d82c5b | https://github.com/nodejs/node/pull/38696/commits/8d82c5b93395de435bed75ae7b6c469cad68ee0d |
|
| https://github.com/davidmarkclements |
|
| https://github.com/addaleax |
| docs: Transform.by clarify as async iterable | https://github.com/nodejs/node/pull/38696/commits/7a1ef775ca88c24fef87fa312c41956adf59f976 |
| 7a1ef77 | https://github.com/nodejs/node/pull/38696/commits/7a1ef775ca88c24fef87fa312c41956adf59f976 |
|
| https://github.com/davidmarkclements |
| stream: Transform. by remove unnecessary defensive code | https://github.com/nodejs/node/pull/38696/commits/57074456c1a64282ff5bf2692045f2719af4a449 |
| 5707445 | https://github.com/nodejs/node/pull/38696/commits/57074456c1a64282ff5bf2692045f2719af4a449 |
|
| https://github.com/davidmarkclements |
|
| https://github.com/addaleax |
| stream: Transform.by code style | https://github.com/nodejs/node/pull/38696/commits/970ed3d69edf8a5b4e3ed4ee13ecc7ad63fdbf82 |
| 970ed3d | https://github.com/nodejs/node/pull/38696/commits/970ed3d69edf8a5b4e3ed4ee13ecc7ad63fdbf82 |
| stream: Transform.by minor refactoring | https://github.com/nodejs/node/pull/38696/commits/6e67a8584c0e0e19476280d32bb8c1b2d70410d4 |
| 6e67a85 | https://github.com/nodejs/node/pull/38696/commits/6e67a8584c0e0e19476280d32bb8c1b2d70410d4 |
| streams: Transform.by check fn return value instead of fn instance | https://github.com/nodejs/node/pull/38696/commits/98aebc5dabc7fa6afb38c14ae700387959639a34 |
| 98aebc5 | https://github.com/nodejs/node/pull/38696/commits/98aebc5dabc7fa6afb38c14ae700387959639a34 |
| docs: emphasize Transform.by objectMode default behaviour | https://github.com/nodejs/node/pull/38696/commits/eee19c591ecf4195912e280a0f3dd59eb6781de3 |
| eee19c5 | https://github.com/nodejs/node/pull/38696/commits/eee19c591ecf4195912e280a0f3dd59eb6781de3 |
|
| https://github.com/davidmarkclements |
|
| https://github.com/vsemozhetbyt |
| docs: Transform.by function naming convention | https://github.com/nodejs/node/pull/38696/commits/26e96be1ea86a33c3878eace10d2aebc7f8f2848 |
| 26e96be | https://github.com/nodejs/node/pull/38696/commits/26e96be1ea86a33c3878eace10d2aebc7f8f2848 |
| docs: add transform content to streams <-> async generators compatibi… | https://github.com/nodejs/node/pull/38696/commits/185a6f481a02cff0eeebb2f4acbbed80e4b4648d |
| 185a6f4 | https://github.com/nodejs/node/pull/38696/commits/185a6f481a02cff0eeebb2f4acbbed80e4b4648d |
| docs: includemissing parens | https://github.com/nodejs/node/pull/38696/commits/8e73c519c6b380b800966e356546ba180fedef5e |
| 8e73c51 | https://github.com/nodejs/node/pull/38696/commits/8e73c519c6b380b800966e356546ba180fedef5e |
| tests: preempt conflict with | https://github.com/nodejs/node/pull/38696/commits/b73347f5d5467197d0e5890bcd1f9201a818b342 |
| nodejs#28566 | https://github.com/nodejs/node/pull/28566 |
| b73347f | https://github.com/nodejs/node/pull/38696/commits/b73347f5d5467197d0e5890bcd1f9201a818b342 |
| tests: fix transform async iterator test | https://github.com/nodejs/node/pull/38696/commits/9789a5b1e64c05ccbd06bf70f7ca6aa8a718a5d8 |
| 9789a5b | https://github.com/nodejs/node/pull/38696/commits/9789a5b1e64c05ccbd06bf70f7ca6aa8a718a5d8 |
|
| https://github.com/davidmarkclements |
|
| https://github.com/addaleax |
| docs: add meta data to Transform.by | https://github.com/nodejs/node/pull/38696/commits/bad0bfdd491562a5c85307a9e36ad32ae0b0d9a3 |
| bad0bfd | https://github.com/nodejs/node/pull/38696/commits/bad0bfdd491562a5c85307a9e36ad32ae0b0d9a3 |
| stream: error handling bug fix, ensure stream is destroyed after proc… | https://github.com/nodejs/node/pull/38696/commits/f2c8b229ba06fc047536156c0e1969a950f8d3cb |
| f2c8b22 | https://github.com/nodejs/node/pull/38696/commits/f2c8b229ba06fc047536156c0e1969a950f8d3cb |
|
| https://github.com/davidmarkclements |
|
| https://github.com/vsemozhetbyt |
| Update doc/api/stream.md | https://github.com/nodejs/node/pull/38696/commits/001fe014a2de99dbf4db6b47ad0748b9211717db |
| 001fe01 | https://github.com/nodejs/node/pull/38696/commits/001fe014a2de99dbf4db6b47ad0748b9211717db |
|
| https://github.com/davidmarkclements |
|
| https://github.com/vsemozhetbyt |
| Update doc/api/stream.md | https://github.com/nodejs/node/pull/38696/commits/9545ee02105474c300f5001a8371aaf8cc01d461 |
| 9545ee0 | https://github.com/nodejs/node/pull/38696/commits/9545ee02105474c300f5001a8371aaf8cc01d461 |
|
| https://github.com/davidmarkclements |
|
| https://github.com/vsemozhetbyt |
| Update doc/api/stream.md | https://github.com/nodejs/node/pull/38696/commits/f0fa8b61952751cd14a22d1d9db885f4cc994c13 |
| f0fa8b6 | https://github.com/nodejs/node/pull/38696/commits/f0fa8b61952751cd14a22d1d9db885f4cc994c13 |
|
| https://github.com/davidmarkclements |
|
| https://github.com/vsemozhetbyt |
| Update doc/api/stream.md | https://github.com/nodejs/node/pull/38696/commits/b504b15eaa1844fdadd5942d190f22cbcd7d9b77 |
| b504b15 | https://github.com/nodejs/node/pull/38696/commits/b504b15eaa1844fdadd5942d190f22cbcd7d9b77 |
| streams: Transform.by, rm unncessary check | https://github.com/nodejs/node/pull/38696/commits/447a895818606d73d0e7f6d09bc528bc07eab8d1 |
| 447a895 | https://github.com/nodejs/node/pull/38696/commits/447a895818606d73d0e7f6d09bc528bc07eab8d1 |
| lint fixes | https://github.com/nodejs/node/pull/38696/commits/2fe96e46d186b6be83b0eaeb6ae6769521487670 |
| 2fe96e4 | https://github.com/nodejs/node/pull/38696/commits/2fe96e46d186b6be83b0eaeb6ae6769521487670 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
errors
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| May 15, 2021 | https://github.com/nodejs/node/pull/38696#event-4749868472 |
|
| https://github.com/safareli |
|
| https://github.com/Trott |
| Apply stream.md suggestions from code review | https://github.com/nodejs/node/pull/38696/commits/a98544111d453fabc59f3010a522bef7d0eb8f02 |
| a985441 | https://github.com/nodejs/node/pull/38696/commits/a98544111d453fabc59f3010a522bef7d0eb8f02 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 4, 2021 | https://github.com/nodejs/node/pull/38696#issuecomment-854451305 |
| https://ci.nodejs.org/job/node-test-pull-request/38486/ | https://ci.nodejs.org/job/node-test-pull-request/38486/ |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jun 4, 2021
| https://github.com/nodejs/node/pull/38696#pullrequestreview-676031238 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/38696/files/a98544111d453fabc59f3010a522bef7d0eb8f02 |
| doc/api/stream.md | https://github.com/nodejs/node/pull/38696/files/b4b5441804e5955f10b49e42a71a9e77993995f5#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| lib/internal/streams/transform.js | https://github.com/nodejs/node/pull/38696/files/a98544111d453fabc59f3010a522bef7d0eb8f02#diff-4f114d20059e8e6bb574ad3f260258720a795fad78be4c99c38a6e157429e8bc |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| lib/internal/streams/transform.js | https://github.com/nodejs/node/pull/38696/files/a98544111d453fabc59f3010a522bef7d0eb8f02#diff-4f114d20059e8e6bb574ad3f260258720a795fad78be4c99c38a6e157429e8bc |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| lib/internal/streams/transform.js | https://github.com/nodejs/node/pull/38696/files/a98544111d453fabc59f3010a522bef7d0eb8f02#diff-4f114d20059e8e6bb574ad3f260258720a795fad78be4c99c38a6e157429e8bc |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| lib/internal/streams/transform.js | https://github.com/nodejs/node/pull/38696/files/a98544111d453fabc59f3010a522bef7d0eb8f02#diff-4f114d20059e8e6bb574ad3f260258720a795fad78be4c99c38a6e157429e8bc |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| lib/internal/streams/transform.js | https://github.com/nodejs/node/pull/38696/files/a98544111d453fabc59f3010a522bef7d0eb8f02#diff-4f114d20059e8e6bb574ad3f260258720a795fad78be4c99c38a6e157429e8bc |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| lib/internal/streams/transform.js | https://github.com/nodejs/node/pull/38696/files/a98544111d453fabc59f3010a522bef7d0eb8f02#diff-4f114d20059e8e6bb574ad3f260258720a795fad78be4c99c38a6e157429e8bc |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
|
| https://github.com/safareli |
| apply | https://github.com/nodejs/node/pull/38696/commits/e0c1f0e222fdf1e98104409b4f96974d46721921 |
| @aduh95 | https://github.com/aduh95 |
| suggestions | https://github.com/nodejs/node/pull/38696/commits/e0c1f0e222fdf1e98104409b4f96974d46721921 |
| e0c1f0e | https://github.com/nodejs/node/pull/38696/commits/e0c1f0e222fdf1e98104409b4f96974d46721921 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jun 6, 2021
| https://github.com/nodejs/node/pull/38696#pullrequestreview-676861281 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/38696/files/e0c1f0e222fdf1e98104409b4f96974d46721921 |
| doc/api/stream.md | https://github.com/nodejs/node/pull/38696/files/e0c1f0e222fdf1e98104409b4f96974d46721921#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jun 6, 2021
| https://github.com/nodejs/node/pull/38696#pullrequestreview-676861349 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/38696/files/e0c1f0e222fdf1e98104409b4f96974d46721921 |
| aduh95 | https://github.com/aduh95 |
| https://github.com/nodejs/node/pull/38696#pullrequestreview-676861349 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| lib/internal/streams/transform.js | https://github.com/nodejs/node/pull/38696/files/e0c1f0e222fdf1e98104409b4f96974d46721921#diff-4f114d20059e8e6bb574ad3f260258720a795fad78be4c99c38a6e157429e8bc |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| lib/internal/streams/transform.js | https://github.com/nodejs/node/pull/38696/files/e0c1f0e222fdf1e98104409b4f96974d46721921#diff-4f114d20059e8e6bb574ad3f260258720a795fad78be4c99c38a6e157429e8bc |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| safareli | https://github.com/safareli |
| June 6, 2021 17:04 | https://github.com/nodejs/node/pull/38696#commits-pushed-c5c862d |
|
| https://github.com/safareli |
|
| https://github.com/aduh95 |
| Apply suggestions from code review | https://github.com/nodejs/node/pull/38696/commits/c5c862d13cc93eb4ca1336c4b0a800f52508f698 |
| c5c862d | https://github.com/nodejs/node/pull/38696/commits/c5c862d13cc93eb4ca1336c4b0a800f52508f698 |
|
| https://github.com/safareli |
|
| https://github.com/aduh95 |
| Update doc/api/stream.md | https://github.com/nodejs/node/pull/38696/commits/adc6059c9c700018854f03f15cd6d48ebe1a44c1 |
| adc6059 | https://github.com/nodejs/node/pull/38696/commits/adc6059c9c700018854f03f15cd6d48ebe1a44c1 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Jun 8, 2021
| https://github.com/nodejs/node/pull/38696#pullrequestreview-678308564 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/38696/files/adc6059c9c700018854f03f15cd6d48ebe1a44c1 |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/38696#pullrequestreview-678308564 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Jun 8, 2021 | https://github.com/nodejs/node/pull/38696#issuecomment-856619247 |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 8, 2021 | https://github.com/nodejs/node/pull/38696#issuecomment-856619634 |
| https://ci.nodejs.org/job/node-test-pull-request/38527/ | https://ci.nodejs.org/job/node-test-pull-request/38527/ |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| https://github.com/safareli |
| safareli | https://github.com/safareli |
| Jun 8, 2021 | https://github.com/nodejs/node/pull/38696#issuecomment-856669086 |
| here | https://github.com/nodejs/node/pull/38696/files#diff-300f00c229d4084c3369e4486a27b04c5121af4f01188370165197022743f9b8R48 |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| https://github.com/aymen94 |
| aymen94 | https://github.com/aymen94 |
|
Jun 8, 2021
| https://github.com/nodejs/node/pull/38696#pullrequestreview-678482127 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/38696/files/adc6059c9c700018854f03f15cd6d48ebe1a44c1 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jun 8, 2021
| https://github.com/nodejs/node/pull/38696#pullrequestreview-678495656 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/38696/files/adc6059c9c700018854f03f15cd6d48ebe1a44c1 |
| test/parallel/test-stream-transform-by.js | https://github.com/nodejs/node/pull/38696/files/adc6059c9c700018854f03f15cd6d48ebe1a44c1#diff-300f00c229d4084c3369e4486a27b04c5121af4f01188370165197022743f9b8 |
| aduh95 | https://github.com/aduh95 |
| Jun 8, 2021 | https://github.com/nodejs/node/pull/38696#discussion_r647424234 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| safareli | https://github.com/safareli |
| Jun 8, 2021 | https://github.com/nodejs/node/pull/38696#discussion_r647630529 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Jun 8, 2021
| https://github.com/nodejs/node/pull/38696#pullrequestreview-678719745 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/38696/files/adc6059c9c700018854f03f15cd6d48ebe1a44c1 |
| lib/internal/streams/transform.js | https://github.com/nodejs/node/pull/38696/files/adc6059c9c700018854f03f15cd6d48ebe1a44c1#diff-4f114d20059e8e6bb574ad3f260258720a795fad78be4c99c38a6e157429e8bc |
| mcollina | https://github.com/mcollina |
| Jun 8, 2021 | https://github.com/nodejs/node/pull/38696#discussion_r647588909 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| safareli | https://github.com/safareli |
| Jun 8, 2021 | https://github.com/nodejs/node/pull/38696#discussion_r647628435 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
|
| https://github.com/safareli |
| assign encoding to the async generator | https://github.com/nodejs/node/pull/38696/commits/967989efa319aed035f6512cab867d3726688086 |
| 967989e | https://github.com/nodejs/node/pull/38696/commits/967989efa319aed035f6512cab867d3726688086 |
| https://github.com/safareli |
| safareli | https://github.com/safareli |
|
Jun 8, 2021
| https://github.com/nodejs/node/pull/38696#pullrequestreview-678819413 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/38696/files/adc6059c9c700018854f03f15cd6d48ebe1a44c1 |
| test/parallel/test-stream-transform-by.js | https://github.com/nodejs/node/pull/38696/files/adc6059c9c700018854f03f15cd6d48ebe1a44c1#diff-300f00c229d4084c3369e4486a27b04c5121af4f01188370165197022743f9b8 |
| safareli | https://github.com/safareli |
| Jun 8, 2021 | https://github.com/nodejs/node/pull/38696#discussion_r647662759 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| mcollina | https://github.com/mcollina |
| Jun 10, 2021 | https://github.com/nodejs/node/pull/38696#discussion_r649321940 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| safareli | https://github.com/safareli |
| Jun 10, 2021 | https://github.com/nodejs/node/pull/38696#discussion_r649405469 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| mcollina | https://github.com/mcollina |
| Jun 11, 2021 | https://github.com/nodejs/node/pull/38696#discussion_r649799268 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| mcollina | https://github.com/mcollina |
| Jun 15, 2021 | https://github.com/nodejs/node/pull/38696#discussion_r651630519 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @safareli | https://github.com/safareli |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| safareli | https://github.com/safareli |
| Jun 15, 2021 | https://github.com/nodejs/node/pull/38696#discussion_r651643175 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
notable-change
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Jun 9, 2021 | https://github.com/nodejs/node/pull/38696#event-4863141167 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Jun 9, 2021
| https://github.com/nodejs/node/pull/38696#pullrequestreview-679640483 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/38696/files/967989efa319aed035f6512cab867d3726688086 |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/38696#pullrequestreview-679640483 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| lib/internal/streams/transform.js | https://github.com/nodejs/node/pull/38696/files/967989efa319aed035f6512cab867d3726688086#diff-4f114d20059e8e6bb574ad3f260258720a795fad78be4c99c38a6e157429e8bc |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| lib/internal/streams/transform.js | https://github.com/nodejs/node/pull/38696/files/967989efa319aed035f6512cab867d3726688086#diff-4f114d20059e8e6bb574ad3f260258720a795fad78be4c99c38a6e157429e8bc |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| lib/internal/streams/transform.js | https://github.com/nodejs/node/pull/38696/files/967989efa319aed035f6512cab867d3726688086#diff-4f114d20059e8e6bb574ad3f260258720a795fad78be4c99c38a6e157429e8bc |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
|
| https://github.com/safareli |
| add encoding to yield | https://github.com/nodejs/node/pull/38696/commits/6ccafaba0e4e92ba7ed3582711bc29a9042c2030 |
| 6ccafab | https://github.com/nodejs/node/pull/38696/commits/6ccafaba0e4e92ba7ed3582711bc29a9042c2030 |
| https://github.com/safareli |
| safareli | https://github.com/safareli |
| Jun 9, 2021 | https://github.com/nodejs/node/pull/38696#issuecomment-857857234 |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| @sounisi5011 | https://github.com/sounisi5011 |
| stream-transform-from | https://www.npmjs.com/package/@sounisi5011/stream-transform-from |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| https://github.com/sounisi5011 |
| sounisi5011 | https://github.com/sounisi5011 |
| Jun 9, 2021 | https://github.com/nodejs/node/pull/38696#issuecomment-858031299 |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| @sounisi5011 | https://github.com/sounisi5011 |
| stream-transform-from | https://www.npmjs.com/package/@sounisi5011/stream-transform-from |
| #38696 (comment) | https://github.com/nodejs/node/pull/38696#issuecomment-857857234 |
| @sounisi5011/stream-transform-from | https://www.npmjs.com/package/@sounisi5011/stream-transform-from |
| streams.Transform.from() did not exist in Node.js | https://github.com/nodejs/node/issues/27140 |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
|
Jun 14, 2021
| https://github.com/nodejs/node/pull/38696#pullrequestreview-682590581 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/38696/files/6ccafaba0e4e92ba7ed3582711bc29a9042c2030 |
| lib/internal/streams/transform.js | https://github.com/nodejs/node/pull/38696/files/6ccafaba0e4e92ba7ed3582711bc29a9042c2030#diff-4f114d20059e8e6bb574ad3f260258720a795fad78be4c99c38a6e157429e8bc |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
|
| https://github.com/safareli |
| try fix some tests | https://github.com/nodejs/node/pull/38696/commits/9bccc233a7b59577c137a6b83193456d6fbdbbcb |
| 9bccc23 | https://github.com/nodejs/node/pull/38696/commits/9bccc233a7b59577c137a6b83193456d6fbdbbcb |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 15, 2021 | https://github.com/nodejs/node/pull/38696#issuecomment-861457476 |
| https://ci.nodejs.org/job/node-test-pull-request/38636/ | https://ci.nodejs.org/job/node-test-pull-request/38636/ |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Jun 17, 2021 | https://github.com/nodejs/node/pull/38696#issuecomment-863277625 |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Jul 1, 2021
| https://github.com/nodejs/node/pull/38696#ref-pullrequest-920409935 |
|
stream: compose
#39029
| https://github.com/nodejs/node/pull/39029 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Jan 3, 2022 | https://github.com/nodejs/node/pull/38696#issuecomment-1004173089 |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Jan 3, 2022 | https://github.com/nodejs/node/pull/38696#event-5835884420 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38696 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/38696/files/6ccafaba0e4e92ba7ed3582711bc29a9042c2030 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/38696/files/b4b5441804e5955f10b49e42a71a9e77993995f5 |
|
| https://github.com/aduh95 |
|
aduh95
| https://github.com/aduh95 |
|
| https://github.com/nodejs/node/pull/38696/files/adc6059c9c700018854f03f15cd6d48ebe1a44c1 |
|
| https://github.com/RaisinTen |
|
RaisinTen
| https://github.com/RaisinTen |
|
| https://github.com/nodejs/node/pull/38696/files/6ccafaba0e4e92ba7ed3582711bc29a9042c2030 |
|
| https://github.com/ronag |
|
ronag
| https://github.com/ronag |
|
| https://github.com/nodejs/node/pull/38696/files/307e926fac9624b8a7b3ea5e173d4e4c6a21871b |
|
| https://github.com/thefourtheye |
|
thefourtheye
| https://github.com/thefourtheye |
|
| https://github.com/nodejs/node/pull/38696/files/6ccafaba0e4e92ba7ed3582711bc29a9042c2030 |
|
| https://github.com/aymen94 |
|
aymen94
| https://github.com/aymen94 |
|
| https://github.com/nodejs/node/pull/38696/files/adc6059c9c700018854f03f15cd6d48ebe1a44c1 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
errors
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
notable-change
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Please reload this page | https://github.com/nodejs/node/pull/38696 |
|
| https://github.com/safareli |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/ronag |
|
| https://github.com/mcollina |
|
| https://github.com/sounisi5011 |
|
| https://github.com/thefourtheye |
|
| https://github.com/Trott |
|
| https://github.com/aymen94 |
|
| https://github.com/aduh95 |
|
| https://github.com/RaisinTen |
|
| https://github.com/davidmarkclements |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |