| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:bdb7e26d-e4ff-c5cc-1eca-cf25e66c56a4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9F44:1EE1:19BD22C:23B09A2:6A4F4B79 |
| html-safe-nonce | 24d359c06be59baabb982adb090fcc4bd2213bc8843d324842ec80b8ddff3a52 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjQ0OjFFRTE6MTlCRDIyQzoyM0IwOUEyOjZBNEY0Qjc5IiwidmlzaXRvcl9pZCI6IjgzNTkxODMzMDUzOTI3MzcxNDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 794713567ca4577646fa466c0c60e6d5b4847f6ec1c685a1d2aecb51979114fb |
| hovercard-subject-tag | pull_request:645040452 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/38692/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/12bcb7531ec36121706adde463bb6ff8f87ae658733763a22ad170d383587fdc/nodejs/node/pull/38692 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/12bcb7531ec36121706adde463bb6ff8f87ae658733763a22ad170d383587fdc/nodejs/node/pull/38692 |
| og:image:alt | The convention for js-native-api/:
.c or .cc has the entry point
The name of the target is |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gabrielschulhof |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/38692#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38692 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38692 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/38692 |
| Reload | https://github.com/nodejs/node/pull/38692 |
| Reload | https://github.com/nodejs/node/pull/38692 |
| Please reload this page | https://github.com/nodejs/node/pull/38692 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/38692 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
969
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gabrielschulhof:name-js-native-api-tests-more-consistently | https://github.com/gabrielschulhof/node/tree/name-js-native-api-tests-more-consistently |
| Conversation | https://github.com/nodejs/node/pull/38692 |
| Commits1 (1) | https://github.com/nodejs/node/pull/38692/commits |
| Checks | https://github.com/nodejs/node/pull/38692/checks |
| Files changed | https://github.com/nodejs/node/pull/38692/files |
| test: give js-native-api tests consistent names | https://github.com/nodejs/node/pull/38692#top |
| gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gabrielschulhof:name-js-native-api-tests-more-consistently | https://github.com/gabrielschulhof/node/tree/name-js-native-api-tests-more-consistently |
|
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| May 14, 2021 | https://github.com/nodejs/node/pull/38692#issue-892305735 |
| Please reload this page | https://github.com/nodejs/node/pull/38692 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| May 14, 2021 | https://github.com/nodejs/node/pull/38692#event-4749311083 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| May 14, 2021 | https://github.com/nodejs/node/pull/38692#event-4749311351 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| legendecas | https://github.com/legendecas |
| mhdawson | https://github.com/mhdawson |
| May 14, 2021 23:43 | https://github.com/nodejs/node/pull/38692#event-4749311825 |
|
| https://github.com/gabrielschulhof |
| test: give js-native-api tests consistent names | https://github.com/nodejs/node/pull/38692/commits/565c4c4edbfe3201885ef35433dbeaefafc780b5 |
| 565c4c4 | https://github.com/nodejs/node/pull/38692/commits/565c4c4edbfe3201885ef35433dbeaefafc780b5 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| force-pushed | https://github.com/nodejs/node/compare/caa6990c8f266251eb1f55367f53b264996623c0..565c4c4edbfe3201885ef35433dbeaefafc780b5 |
| caa6990 | https://github.com/nodejs/node/commit/caa6990c8f266251eb1f55367f53b264996623c0 |
| 565c4c4 | https://github.com/nodejs/node/commit/565c4c4edbfe3201885ef35433dbeaefafc780b5 |
|
Compare
| https://github.com/nodejs/node/compare/caa6990c8f266251eb1f55367f53b264996623c0..565c4c4edbfe3201885ef35433dbeaefafc780b5 |
| May 15, 2021 03:12 | https://github.com/nodejs/node/pull/38692#event-4749509432 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
May 16, 2021
| https://github.com/nodejs/node/pull/38692#pullrequestreview-660402058 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/38692/files/565c4c4edbfe3201885ef35433dbeaefafc780b5 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
May 17, 2021
| https://github.com/nodejs/node/pull/38692#pullrequestreview-661099029 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/38692/files/565c4c4edbfe3201885ef35433dbeaefafc780b5 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
May 17, 2021
| https://github.com/nodejs/node/pull/38692#pullrequestreview-661199087 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/38692/files/565c4c4edbfe3201885ef35433dbeaefafc780b5 |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node/pull/38692#pullrequestreview-661199087 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/38692 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
|
May 17, 2021
| https://github.com/nodejs/node/pull/38692#pullrequestreview-661202246 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/38692/files/565c4c4edbfe3201885ef35433dbeaefafc780b5 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 17, 2021 | https://github.com/nodejs/node/pull/38692#issuecomment-842485873 |
| https://ci.nodejs.org/job/node-test-pull-request/38162/ | https://ci.nodejs.org/job/node-test-pull-request/38162/ |
| Please reload this page | https://github.com/nodejs/node/pull/38692 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
May 17, 2021
| https://github.com/nodejs/node/pull/38692#pullrequestreview-661318985 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/38692/files/565c4c4edbfe3201885ef35433dbeaefafc780b5 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 19, 2021 | https://github.com/nodejs/node/pull/38692#issuecomment-844131991 |
| https://ci.nodejs.org/job/node-test-pull-request/38197/ | https://ci.nodejs.org/job/node-test-pull-request/38197/ |
| Please reload this page | https://github.com/nodejs/node/pull/38692 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 19, 2021 | https://github.com/nodejs/node/pull/38692#issuecomment-844433596 |
| https://ci.nodejs.org/job/node-test-pull-request/38216/ | https://ci.nodejs.org/job/node-test-pull-request/38216/ |
| Please reload this page | https://github.com/nodejs/node/pull/38692 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| May 19, 2021 | https://github.com/nodejs/node/pull/38692#issuecomment-844433691 |
| https://ci.nodejs.org/job/node-test-pull-request/38216/ | https://ci.nodejs.org/job/node-test-pull-request/38216/ |
| Please reload this page | https://github.com/nodejs/node/pull/38692 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| May 19, 2021 | https://github.com/nodejs/node/pull/38692#issuecomment-844457120 |
| #38226 | https://github.com/nodejs/node/issues/38226 |
| Please reload this page | https://github.com/nodejs/node/pull/38692 |
| mhdawson | https://github.com/mhdawson |
|
May 19, 2021
| https://github.com/nodejs/node/pull/38692#ref-commit-3f025cb |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/mhdawson |
| test: give js-native-api tests consistent names | https://github.com/nodejs/node/commit/3f025cb5d036a20ef92526360fa6b5356a7ee51a |
| 3f025cb | https://github.com/nodejs/node/commit/3f025cb5d036a20ef92526360fa6b5356a7ee51a |
| #38692 | https://github.com/nodejs/node/pull/38692 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| May 19, 2021 | https://github.com/nodejs/node/pull/38692#issuecomment-844465445 |
| 3f025cb | https://github.com/nodejs/node/commit/3f025cb5d036a20ef92526360fa6b5356a7ee51a |
| Please reload this page | https://github.com/nodejs/node/pull/38692 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| May 19, 2021 | https://github.com/nodejs/node/pull/38692#event-4769224974 |
| danielleadams | https://github.com/danielleadams |
|
May 31, 2021
| https://github.com/nodejs/node/pull/38692#ref-commit-6da4aa3 |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/danielleadams |
| test: give js-native-api tests consistent names | https://github.com/nodejs/node/commit/6da4aa30c6f31dbcb83579bf82192d8418e0dc9b |
| 6da4aa3 | https://github.com/nodejs/node/commit/6da4aa30c6f31dbcb83579bf82192d8418e0dc9b |
| #38692 | https://github.com/nodejs/node/pull/38692 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
May 31, 2021
| https://github.com/nodejs/node/pull/38692#ref-pullrequest-907685851 |
|
v16.3.0 proposal
#38874
| https://github.com/nodejs/node/pull/38874 |
| richardlau | https://github.com/richardlau |
|
Jul 16, 2021
| https://github.com/nodejs/node/pull/38692#ref-commit-4ecf9b0 |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/richardlau |
| test: give js-native-api tests consistent names | https://github.com/nodejs/node/commit/4ecf9b043453c98756b3cbc7ce5d857d152a7314 |
| 4ecf9b0 | https://github.com/nodejs/node/commit/4ecf9b043453c98756b3cbc7ce5d857d152a7314 |
| #38692 | https://github.com/nodejs/node/pull/38692 |
| richardlau | https://github.com/richardlau |
|
Jul 19, 2021
| https://github.com/nodejs/node/pull/38692#ref-commit-6fb9f79 |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/richardlau |
| test: give js-native-api tests consistent names | https://github.com/nodejs/node/commit/6fb9f79c49c0c89476b1919c8568ac4b27841d56 |
| 6fb9f79 | https://github.com/nodejs/node/commit/6fb9f79c49c0c89476b1919c8568ac4b27841d56 |
| #38692 | https://github.com/nodejs/node/pull/38692 |
| richardlau | https://github.com/richardlau |
|
Jul 20, 2021
| https://github.com/nodejs/node/pull/38692#ref-commit-e265d8e |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/richardlau |
| test: give js-native-api tests consistent names | https://github.com/nodejs/node/commit/e265d8ee1b10ddfe0fdddf2287c295d71c5c2530 |
| e265d8e | https://github.com/nodejs/node/commit/e265d8ee1b10ddfe0fdddf2287c295d71c5c2530 |
| #38692 | https://github.com/nodejs/node/pull/38692 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Jul 20, 2021
| https://github.com/nodejs/node/pull/38692#ref-pullrequest-948590637 |
|
v14.17.4 proposal
#39466
| https://github.com/nodejs/node/pull/39466 |
| foxxyz | https://github.com/foxxyz |
|
Oct 18, 2021
| https://github.com/nodejs/node/pull/38692#ref-commit-6109f6d |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/foxxyz |
| test: give js-native-api tests consistent names | https://github.com/foxxyz/node/commit/6109f6da1240c3df069e8ecd1871f95ca11d19f8 |
| 6109f6d | https://github.com/foxxyz/node/commit/6109f6da1240c3df069e8ecd1871f95ca11d19f8 |
| nodejs#38692 | https://github.com/nodejs/node/pull/38692 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| March 17, 2023 19:00 | https://github.com/nodejs/node/pull/38692#event-8781590021 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38692 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/38692/files/565c4c4edbfe3201885ef35433dbeaefafc780b5 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/38692/files/565c4c4edbfe3201885ef35433dbeaefafc780b5 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/38692/files/565c4c4edbfe3201885ef35433dbeaefafc780b5 |
|
| https://github.com/legendecas |
|
legendecas
| https://github.com/legendecas |
|
| https://github.com/nodejs/node/pull/38692/files/565c4c4edbfe3201885ef35433dbeaefafc780b5 |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/38692/files/565c4c4edbfe3201885ef35433dbeaefafc780b5 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/38692 |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mhdawson |
|
| https://github.com/jasnell |
|
| https://github.com/Trott |
|
| https://github.com/lpinca |
|
| https://github.com/legendecas |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |