René's URL Explorer Experiment


Title: src: update cares_wrap OpenBSD defines by addaleax · Pull Request #38670 · nodejs/node · GitHub

Open Graph Title: src: update cares_wrap OpenBSD defines by addaleax · Pull Request #38670 · nodejs/node

X Title: src: update cares_wrap OpenBSD defines by addaleax · Pull Request #38670 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Move the #defines back into cares_wrap.cc, as they are part of the implementation, not the declarations used in cares_wrap.h, and apply the suggestion from #38572 (comment) to make the defines a bi...

X Description: Move the #defines back into cares_wrap.cc, as they are part of the implementation, not the declarations used in cares_wrap.h, and apply the suggestion from #38572 (comment) to make the defines a bi...

Opengraph URL: https://github.com/nodejs/node/pull/38670

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b1f90305-8dee-5112-4621-97228de0c814
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB304:320EB:BA764A:105877B:6A4E86E1
html-safe-noncec9de986f67ee7dbe88bec8e76c6ddbe3231662f931c39c5657e2eeaa3e4e0629
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzA0OjMyMEVCOkJBNzY0QToxMDU4NzdCOjZBNEU4NkUxIiwidmlzaXRvcl9pZCI6IjkwMzMxMzIxODc0NTMzOTI2MTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac99e3396eb2bf8f77d0df40883a733144882775ec912d28de9094e7f3153a4d07
hovercard-subject-tagpull_request:643990061
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/38670/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d562f5dbf3d2009ab2a81a4977a6b9b7c695edc0e9dde2ddbd13adf8a059c62c/nodejs/node/pull/38670
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d562f5dbf3d2009ab2a81a4977a6b9b7c695edc0e9dde2ddbd13adf8a059c62c/nodejs/node/pull/38670
og:image:altMove the #defines back into cares_wrap.cc, as they are part of the implementation, not the declarations used in cares_wrap.h, and apply the suggestion from #38572 (comment) to make the defines a bi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/38670#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38670
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38670
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/38670
Reloadhttps://github.com/nodejs/node/pull/38670
Reloadhttps://github.com/nodejs/node/pull/38670
Please reload this pagehttps://github.com/nodejs/node/pull/38670
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/38670
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:38572-masterhttps://github.com/addaleax/node/tree/38572-master
Conversationhttps://github.com/nodejs/node/pull/38670
Commits1 (1)https://github.com/nodejs/node/pull/38670/commits
Checkshttps://github.com/nodejs/node/pull/38670/checks
Files changedhttps://github.com/nodejs/node/pull/38670/files
src: update cares_wrap OpenBSD defineshttps://github.com/nodejs/node/pull/38670#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:38572-masterhttps://github.com/addaleax/node/tree/38572-master
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 13, 2021https://github.com/nodejs/node/pull/38670#issue-891062732
#38572 (comment)https://github.com/nodejs/node/pull/38572#discussion_r627809407
#38572https://github.com/nodejs/node/pull/38572
Please reload this pagehttps://github.com/nodejs/node/pull/38670
https://github.com/addaleax
src: update cares_wrap OpenBSD defineshttps://github.com/nodejs/node/pull/38670/commits/10a4b78ec8d9a29fdc4f9b4f0f801dacbf56873d
10a4b78https://github.com/nodejs/node/pull/38670/commits/10a4b78ec8d9a29fdc4f9b4f0f801dacbf56873d
nodejs#38572 (comment)https://github.com/nodejs/node/pull/38572#discussion_r627809407
nodejs#38572https://github.com/nodejs/node/pull/38572
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 13, 2021 https://github.com/nodejs/node/pull/38670#ref-pullrequest-877816030
Update cares_wrap.cc #38572 https://github.com/nodejs/node/pull/38572
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
cares https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acares
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
May 13, 2021https://github.com/nodejs/node/pull/38670#event-4741993181
https://github.com/richardlau
richardlauhttps://github.com/richardlau
May 13, 2021 https://github.com/nodejs/node/pull/38670#pullrequestreview-658960662
View reviewed changes https://github.com/nodejs/node/pull/38670/files/10a4b78ec8d9a29fdc4f9b4f0f801dacbf56873d
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 14, 2021 https://github.com/nodejs/node/pull/38670#pullrequestreview-659814220
View reviewed changes https://github.com/nodejs/node/pull/38670/files/10a4b78ec8d9a29fdc4f9b4f0f801dacbf56873d
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 14, 2021 https://github.com/nodejs/node/pull/38670#pullrequestreview-659934574
View reviewed changes https://github.com/nodejs/node/pull/38670/files/10a4b78ec8d9a29fdc4f9b4f0f801dacbf56873d
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
May 14, 2021https://github.com/nodejs/node/pull/38670#event-4747608646
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 14, 2021https://github.com/nodejs/node/pull/38670#issuecomment-841316647
https://ci.nodejs.org/job/node-test-pull-request/38083/https://ci.nodejs.org/job/node-test-pull-request/38083/
Please reload this pagehttps://github.com/nodejs/node/pull/38670
https://github.com/Trott
Trotthttps://github.com/Trott
May 15, 2021 https://github.com/nodejs/node/pull/38670#pullrequestreview-660310020
View reviewed changes https://github.com/nodejs/node/pull/38670/files/10a4b78ec8d9a29fdc4f9b4f0f801dacbf56873d
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 15, 2021https://github.com/nodejs/node/pull/38670#issuecomment-841606704
https://ci.nodejs.org/job/node-test-pull-request/38106/https://ci.nodejs.org/job/node-test-pull-request/38106/
Please reload this pagehttps://github.com/nodejs/node/pull/38670
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 17, 2021https://github.com/nodejs/node/pull/38670#issuecomment-842444904
75340f3https://github.com/nodejs/node/commit/75340f3c524cbe8602ba8f5a48b8bf8572bad8f1
Please reload this pagehttps://github.com/nodejs/node/pull/38670
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 17, 2021https://github.com/nodejs/node/pull/38670#event-4755553073
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 17, 2021 16:02https://github.com/nodejs/node/pull/38670#event-4755553338
addaleaxhttps://github.com/addaleax
May 17, 2021 https://github.com/nodejs/node/pull/38670#ref-commit-75340f3
https://github.com/addaleax
src: update cares_wrap OpenBSD defineshttps://github.com/nodejs/node/commit/75340f3c524cbe8602ba8f5a48b8bf8572bad8f1
75340f3https://github.com/nodejs/node/commit/75340f3c524cbe8602ba8f5a48b8bf8572bad8f1
#38572 (comment)https://github.com/nodejs/node/pull/38572#discussion_r627809407
#38572https://github.com/nodejs/node/pull/38572
#38670https://github.com/nodejs/node/pull/38670
targoshttps://github.com/targos
May 18, 2021 https://github.com/nodejs/node/pull/38670#ref-commit-524a9d6
https://github.com/addaleax
https://github.com/targos
src: update cares_wrap OpenBSD defineshttps://github.com/nodejs/node/commit/524a9d6fcd19a1be8481a68236ecf5a5d3f01172
524a9d6https://github.com/nodejs/node/commit/524a9d6fcd19a1be8481a68236ecf5a5d3f01172
#38572 (comment)https://github.com/nodejs/node/pull/38572#discussion_r627809407
#38572https://github.com/nodejs/node/pull/38572
#38670https://github.com/nodejs/node/pull/38670
https://github.com/targos
targoshttps://github.com/targos
May 18, 2021 https://github.com/nodejs/node/pull/38670#ref-pullrequest-894269673
v16.2.0 release proposal #38719 https://github.com/nodejs/node/pull/38719
targoshttps://github.com/targos
May 30, 2021 https://github.com/nodejs/node/pull/38670#ref-commit-ab58700
https://github.com/addaleax
https://github.com/targos
src: update cares_wrap OpenBSD defineshttps://github.com/nodejs/node/commit/ab5870043a6441344327891d8e5a0aaa8efe96dd
ab58700https://github.com/nodejs/node/commit/ab5870043a6441344327891d8e5a0aaa8efe96dd
#38572 (comment)https://github.com/nodejs/node/pull/38572#discussion_r627809407
#38572https://github.com/nodejs/node/pull/38572
#38670https://github.com/nodejs/node/pull/38670
targoshttps://github.com/targos
Jun 5, 2021 https://github.com/nodejs/node/pull/38670#ref-commit-b22b270
https://github.com/addaleax
https://github.com/targos
src: update cares_wrap OpenBSD defineshttps://github.com/nodejs/node/commit/b22b270ce1dcfa9db2618ba4f1f00148b5aec4c0
b22b270https://github.com/nodejs/node/commit/b22b270ce1dcfa9db2618ba4f1f00148b5aec4c0
#38572 (comment)https://github.com/nodejs/node/pull/38572#discussion_r627809407
#38572https://github.com/nodejs/node/pull/38572
#38670https://github.com/nodejs/node/pull/38670
targoshttps://github.com/targos
Jun 5, 2021 https://github.com/nodejs/node/pull/38670#ref-commit-bcf539c
https://github.com/addaleax
https://github.com/targos
src: update cares_wrap OpenBSD defineshttps://github.com/nodejs/node/commit/bcf539ce08726240b76923cba270d1f9d7805610
bcf539chttps://github.com/nodejs/node/commit/bcf539ce08726240b76923cba270d1f9d7805610
#38572 (comment)https://github.com/nodejs/node/pull/38572#discussion_r627809407
#38572https://github.com/nodejs/node/pull/38572
#38670https://github.com/nodejs/node/pull/38670
https://github.com/targos
targoshttps://github.com/targos
Jun 6, 2021 https://github.com/nodejs/node/pull/38670#ref-pullrequest-912748369
v14.17.1 release proposal #38948 https://github.com/nodejs/node/pull/38948
targoshttps://github.com/targos
Jun 11, 2021 https://github.com/nodejs/node/pull/38670#ref-commit-8809ef9
https://github.com/addaleax
https://github.com/targos
src: update cares_wrap OpenBSD defineshttps://github.com/nodejs/node/commit/8809ef98f92cfe5bd349e425ebe0e69c51ea9153
8809ef9https://github.com/nodejs/node/commit/8809ef98f92cfe5bd349e425ebe0e69c51ea9153
#38572 (comment)https://github.com/nodejs/node/pull/38572#discussion_r627809407
#38572https://github.com/nodejs/node/pull/38572
#38670https://github.com/nodejs/node/pull/38670
richardlauhttps://github.com/richardlau
Jul 23, 2021 https://github.com/nodejs/node/pull/38670#ref-commit-2ce08cf
https://github.com/addaleax
https://github.com/richardlau
src: update cares_wrap OpenBSD defineshttps://github.com/nodejs/node/commit/2ce08cfe1d029af8c9db70385da1bdde1382901d
2ce08cfhttps://github.com/nodejs/node/commit/2ce08cfe1d029af8c9db70385da1bdde1382901d
#38572 (comment)https://github.com/nodejs/node/pull/38572#discussion_r627809407
#38572https://github.com/nodejs/node/pull/38572
#38670https://github.com/nodejs/node/pull/38670
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 23, 2021 https://github.com/nodejs/node/pull/38670#ref-pullrequest-951746328
v12.22.4 proposal #39500 https://github.com/nodejs/node/pull/39500
guybedfordhttps://github.com/guybedford
Jul 26, 2021 https://github.com/nodejs/node/pull/38670#ref-commit-4a85a4b
https://github.com/addaleax
https://github.com/guybedford
src: update cares_wrap OpenBSD defineshttps://github.com/nodejs/node/commit/4a85a4bf91543c7b99b67312749295610d9e869c
4a85a4bhttps://github.com/nodejs/node/commit/4a85a4bf91543c7b99b67312749295610d9e869c
#38572 (comment)https://github.com/nodejs/node/pull/38572#discussion_r627809407
#38572https://github.com/nodejs/node/pull/38572
#38670https://github.com/nodejs/node/pull/38670
richardlauhttps://github.com/richardlau
Jul 26, 2021 https://github.com/nodejs/node/pull/38670#ref-commit-30ce0e6
https://github.com/addaleax
https://github.com/richardlau
src: update cares_wrap OpenBSD defineshttps://github.com/nodejs/node/commit/30ce0e66ae53899438e5fe2812c0ceee4f00d2e4
30ce0e6https://github.com/nodejs/node/commit/30ce0e66ae53899438e5fe2812c0ceee4f00d2e4
#38572 (comment)https://github.com/nodejs/node/pull/38572#discussion_r627809407
#38572https://github.com/nodejs/node/pull/38572
#38670https://github.com/nodejs/node/pull/38670
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38670
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/38670/files/10a4b78ec8d9a29fdc4f9b4f0f801dacbf56873d
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/38670/files/10a4b78ec8d9a29fdc4f9b4f0f801dacbf56873d
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/38670/files/10a4b78ec8d9a29fdc4f9b4f0f801dacbf56873d
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/38670/files/10a4b78ec8d9a29fdc4f9b4f0f801dacbf56873d
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
cares https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acares
Please reload this pagehttps://github.com/nodejs/node/pull/38670
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/Trott
https://github.com/cjihrig
https://github.com/richardlau
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.