René's URL Explorer Experiment


Title: node-api: fix shutdown crashes by mhdawson · Pull Request #38492 · nodejs/node · GitHub

Open Graph Title: node-api: fix shutdown crashes by mhdawson · Pull Request #38492 · nodejs/node

X Title: node-api: fix shutdown crashes by mhdawson · Pull Request #38492 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Refs: nodejs/node-addon-api#906 Ensure that finalization is not defered during shutdown. The env for the addon is deleted immediately after iterating the list of finalizers to be run. Defering caus...

X Description: Refs: nodejs/node-addon-api#906 Ensure that finalization is not defered during shutdown. The env for the addon is deleted immediately after iterating the list of finalizers to be run. Defering caus...

Mail addresses
mdawson@devrus.com

Opengraph URL: https://github.com/nodejs/node/pull/38492

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f8281fd9-8c4b-1df9-af44-19a1512040e4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEA58:88322:B78416:10CB3ED:6A4E1D2A
html-safe-nonce9e64e69a674ad07ffc3a1b2d8dcc35a09376a9ce7b451773c94aa1ffe55e1915
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTU4Ojg4MzIyOkI3ODQxNjoxMENCM0VEOjZBNEUxRDJBIiwidmlzaXRvcl9pZCI6IjMyMDI4Mjg1NzQwNzY1NzUwMTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4ce84128e26e09071a233aefe7c159f257309ec08a0e80d368f1a0d8c318b30e
hovercard-subject-tagpull_request:628234922
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/38492/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cca15404a298528a5e9496c15afd165627f1a7fe59c8e1189351307644acbef3/nodejs/node/pull/38492
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cca15404a298528a5e9496c15afd165627f1a7fe59c8e1189351307644acbef3/nodejs/node/pull/38492
og:image:altRefs: nodejs/node-addon-api#906 Ensure that finalization is not defered during shutdown. The env for the addon is deleted immediately after iterating the list of finalizers to be run. Defering caus...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemhdawson
hostnamegithub.com
expected-hostnamegithub.com
None030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5fe497b4815fcce3df76c0e246faa739a82c3124
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/38492#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38492
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38492
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/38492
Reloadhttps://github.com/nodejs/node/pull/38492
Reloadhttps://github.com/nodejs/node/pull/38492
Please reload this pagehttps://github.com/nodejs/node/pull/38492
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/38492
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
mhdawsonhttps://github.com/mhdawson
nodejs:masterhttps://github.com/nodejs/node/tree/master
mhdawson:node-api-crash-fixhttps://github.com/mhdawson/io.js/tree/node-api-crash-fix
Conversationhttps://github.com/nodejs/node/pull/38492
Commits6 (6)https://github.com/nodejs/node/pull/38492/commits
Checkshttps://github.com/nodejs/node/pull/38492/checks
Files changedhttps://github.com/nodejs/node/pull/38492/files
node-api: fix shutdown crasheshttps://github.com/nodejs/node/pull/38492#top
mhdawsonhttps://github.com/mhdawson
nodejs:masterhttps://github.com/nodejs/node/tree/master
mhdawson:node-api-crash-fixhttps://github.com/mhdawson/io.js/tree/node-api-crash-fix
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Apr 30, 2021https://github.com/nodejs/node/pull/38492#issue-873411914
nodejs/node-addon-api#906https://github.com/nodejs/node-addon-api/issues/906
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/mhdawson
node-api: fix shutdown crasheshttps://github.com/nodejs/node/pull/38492/commits/02f28792027c302338b77e02b0764c351a8c4098
02f2879https://github.com/nodejs/node/pull/38492/commits/02f28792027c302338b77e02b0764c351a8c4098
nodejs/node-addon-api#906https://github.com/nodejs/node-addon-api/issues/906
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
April 30, 2021 22:00https://github.com/nodejs/node/pull/38492#event-4672245044
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Apr 30, 2021https://github.com/nodejs/node/pull/38492#event-4672245512
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Apr 30, 2021https://github.com/nodejs/node/pull/38492#issuecomment-830424834
Please reload this pagehttps://github.com/nodejs/node/pull/38492
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Apr 30, 2021 https://github.com/nodejs/node/pull/38492#pullrequestreview-649664788
View reviewed changes https://github.com/nodejs/node/pull/38492/files/02f28792027c302338b77e02b0764c351a8c4098
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/38492#pullrequestreview-649664788
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Apr 30, 2021https://github.com/nodejs/node/pull/38492#issuecomment-830451099
@gabrielschulhofhttps://github.com/gabrielschulhof
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Apr 30, 2021https://github.com/nodejs/node/pull/38492#issuecomment-830451557
#38469https://github.com/nodejs/node/pull/38469
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 1, 2021https://github.com/nodejs/node/pull/38492#issuecomment-830637372
nodejs/node-addon-api#906 (comment)https://github.com/nodejs/node-addon-api/issues/906#issuecomment-830154436
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 1, 2021 https://github.com/nodejs/node/pull/38492#ref-issue-807567523
Intermittent failure in ThreadSafe function nodejs/node-addon-api#906 https://github.com/nodejs/node-addon-api/issues/906
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 1, 2021https://github.com/nodejs/node/pull/38492#issuecomment-830644443
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 1, 2021https://github.com/nodejs/node/pull/38492#issuecomment-830648565
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 1, 2021https://github.com/nodejs/node/pull/38492#issuecomment-830658560
@mhdawsonhttps://github.com/mhdawson
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 1, 2021https://github.com/nodejs/node/pull/38492#issuecomment-830659241
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/mhdawson
squash: add other place Finalization is deferredhttps://github.com/nodejs/node/pull/38492/commits/d39704b57121ce832255fa1be1017714411a62d6
d39704bhttps://github.com/nodejs/node/pull/38492/commits/d39704b57121ce832255fa1be1017714411a62d6
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 1, 2021https://github.com/nodejs/node/pull/38492#issuecomment-830697428
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 1, 2021 https://github.com/nodejs/node/pull/38492#pullrequestreview-649820955
View reviewed changes https://github.com/nodejs/node/pull/38492/files/d39704b57121ce832255fa1be1017714411a62d6
src/node_api.cchttps://github.com/nodejs/node/pull/38492/files/02f28792027c302338b77e02b0764c351a8c4098..d39704b57121ce832255fa1be1017714411a62d6#diff-2057dbe503dbb37a65a74cf86e056d50c27ba828070577e0f7f07e734365c9bc
addaleaxhttps://github.com/addaleax
May 1, 2021https://github.com/nodejs/node/pull/38492#discussion_r624570604
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/38492
mhdawsonhttps://github.com/mhdawson
May 2, 2021https://github.com/nodejs/node/pull/38492#discussion_r624700808
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/38492
mhdawsonhttps://github.com/mhdawson
May 2, 2021https://github.com/nodejs/node/pull/38492#discussion_r624701096
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/38492
mhdawsonhttps://github.com/mhdawson
May 2, 2021 09:57https://github.com/nodejs/node/pull/38492#commits-pushed-4033914
https://github.com/mhdawson
squash: ref/unref when using SetImmediatehttps://github.com/nodejs/node/pull/38492/commits/403391496963b1a40d2ad6d974397c6dc7731bcf
4033914https://github.com/nodejs/node/pull/38492/commits/403391496963b1a40d2ad6d974397c6dc7731bcf
https://github.com/mhdawson
squash: fixup spacinghttps://github.com/nodejs/node/pull/38492/commits/0eeee2fcf0e087e86e80dbe641640cb7ea8394b7
0eeee2fhttps://github.com/nodejs/node/pull/38492/commits/0eeee2fcf0e087e86e80dbe641640cb7ea8394b7
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 3, 2021https://github.com/nodejs/node/pull/38492#issuecomment-831248458
nodejs/node-addon-api#906https://github.com/nodejs/node-addon-api/issues/906
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 6, 2021https://github.com/nodejs/node/pull/38492#issuecomment-833181934
@legendecashttps://github.com/legendecas
@gabrielschulhofhttps://github.com/gabrielschulhof
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/legendecas
legendecashttps://github.com/legendecas
May 6, 2021https://github.com/nodejs/node/pull/38492#issuecomment-833615817
Please reload this pagehttps://github.com/nodejs/node/pull/38492
@mhdawsonhttps://github.com/mhdawson
#38000https://github.com/nodejs/node/pull/38000
#38000https://github.com/nodejs/node/pull/38000
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 6, 2021https://github.com/nodejs/node/pull/38492#issuecomment-833762888
@legendecashttps://github.com/legendecas
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 6, 2021https://github.com/nodejs/node/pull/38492#issuecomment-833867471
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 6, 2021https://github.com/nodejs/node/pull/38492#issuecomment-833867917
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 7, 2021https://github.com/nodejs/node/pull/38492#issuecomment-833957104
Please reload this pagehttps://github.com/nodejs/node/pull/38492
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/legendecas
legendecashttps://github.com/legendecas
May 7, 2021https://github.com/nodejs/node/pull/38492#issuecomment-833975643
@legendecashttps://github.com/legendecas
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 7, 2021https://github.com/nodejs/node/pull/38492#issuecomment-834356613
@legendecashttps://github.com/legendecas
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 7, 2021https://github.com/nodejs/node/pull/38492#issuecomment-834357495
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/legendecas
legendecashttps://github.com/legendecas
May 7, 2021https://github.com/nodejs/node/pull/38492#issuecomment-834364943
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/nodejs/node/blob/master/src/node_binding.cc#L475-478https://github.com/nodejs/node/blob/master/src/node_binding.cc#L475-478
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 19, 2021 https://github.com/nodejs/node/pull/38492#pullrequestreview-663615825
View reviewed changes https://github.com/nodejs/node/pull/38492/files/558a765f3dad635f8ec61f63d121848d3cd8264f
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/38492#pullrequestreview-663615825
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@mhdawsonhttps://github.com/mhdawson
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 19, 2021https://github.com/nodejs/node/pull/38492#issuecomment-844441330
Please reload this pagehttps://github.com/nodejs/node/pull/38492
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 19, 2021https://github.com/nodejs/node/pull/38492#issuecomment-844442437
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://ci.nodejs.org/job/node-test-pull-request/38218/https://ci.nodejs.org/job/node-test-pull-request/38218/
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 19, 2021https://github.com/nodejs/node/pull/38492#issuecomment-844468139
https://ci.nodejs.org/job/node-test-pull-request/38218/https://ci.nodejs.org/job/node-test-pull-request/38218/
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 20, 2021https://github.com/nodejs/node/pull/38492#issuecomment-844700768
https://ci.nodejs.org/job/node-test-pull-request/38221/https://ci.nodejs.org/job/node-test-pull-request/38221/
Please reload this pagehttps://github.com/nodejs/node/pull/38492
mhdawsonhttps://github.com/mhdawson
May 20, 2021 https://github.com/nodejs/node/pull/38492#ref-commit-c32c5f0
https://github.com/mhdawson
node-api: fix shutdown crasheshttps://github.com/nodejs/node/commit/c32c5f0d433996695bcef02737038b0213f1831e
c32c5f0https://github.com/nodejs/node/commit/c32c5f0d433996695bcef02737038b0213f1831e
nodejs/node-addon-api#906https://github.com/nodejs/node-addon-api/issues/906
#38492https://github.com/nodejs/node/pull/38492
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 20, 2021https://github.com/nodejs/node/pull/38492#issuecomment-845165358
c32c5f0https://github.com/nodejs/node/commit/c32c5f0d433996695bcef02737038b0213f1831e
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 20, 2021https://github.com/nodejs/node/pull/38492#event-4773715550
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
v16.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av16.x
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
May 20, 2021https://github.com/nodejs/node/pull/38492#event-4773744916
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 20, 2021https://github.com/nodejs/node/pull/38492#issuecomment-845234789
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/targos
targoshttps://github.com/targos
lts-watch-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v14.x
May 30, 2021https://github.com/nodejs/node/pull/38492#event-4816943229
https://github.com/targos
targoshttps://github.com/targos
May 30, 2021https://github.com/nodejs/node/pull/38492#issuecomment-850972881
Please reload this pagehttps://github.com/nodejs/node/pull/38492
targoshttps://github.com/targos
May 30, 2021 https://github.com/nodejs/node/pull/38492#ref-commit-5ed4b9d
https://github.com/mhdawson
https://github.com/targos
node-api: fix shutdown crasheshttps://github.com/nodejs/node/commit/5ed4b9dacbb1dd26fd7a5ad9ae8e5020aadb1b05
5ed4b9dhttps://github.com/nodejs/node/commit/5ed4b9dacbb1dd26fd7a5ad9ae8e5020aadb1b05
nodejs/node-addon-api#906https://github.com/nodejs/node-addon-api/issues/906
#38492https://github.com/nodejs/node/pull/38492
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 31, 2021https://github.com/nodejs/node/pull/38492#issuecomment-851541471
@targoshttps://github.com/targos
Please reload this pagehttps://github.com/nodejs/node/pull/38492
danielleadamshttps://github.com/danielleadams
May 31, 2021 https://github.com/nodejs/node/pull/38492#ref-commit-496f7ea
https://github.com/mhdawson
https://github.com/danielleadams
node-api: fix shutdown crasheshttps://github.com/nodejs/node/commit/496f7eae925a3a6174b167ceec4e5c2bc815e911
496f7eahttps://github.com/nodejs/node/commit/496f7eae925a3a6174b167ceec4e5c2bc815e911
nodejs/node-addon-api#906https://github.com/nodejs/node-addon-api/issues/906
#38492https://github.com/nodejs/node/pull/38492
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
May 31, 2021 https://github.com/nodejs/node/pull/38492#ref-pullrequest-907685851
v16.3.0 proposal #38874 https://github.com/nodejs/node/pull/38874
targoshttps://github.com/targos
Jun 5, 2021 https://github.com/nodejs/node/pull/38492#ref-commit-e60acd7
https://github.com/mhdawson
https://github.com/targos
node-api: fix shutdown crasheshttps://github.com/nodejs/node/commit/e60acd7ada96ff713947064c4389ac85dd0e526b
e60acd7https://github.com/nodejs/node/commit/e60acd7ada96ff713947064c4389ac85dd0e526b
nodejs/node-addon-api#906https://github.com/nodejs/node-addon-api/issues/906
#38492https://github.com/nodejs/node/pull/38492
targoshttps://github.com/targos
Jun 5, 2021 https://github.com/nodejs/node/pull/38492#ref-commit-8ccd867
https://github.com/mhdawson
https://github.com/targos
node-api: fix shutdown crasheshttps://github.com/nodejs/node/commit/8ccd8676f4804ddaff61fb65d8a75bfcd3af35c9
8ccd867https://github.com/nodejs/node/commit/8ccd8676f4804ddaff61fb65d8a75bfcd3af35c9
nodejs/node-addon-api#906https://github.com/nodejs/node-addon-api/issues/906
#38492https://github.com/nodejs/node/pull/38492
https://github.com/targos
targoshttps://github.com/targos
Jun 6, 2021 https://github.com/nodejs/node/pull/38492#ref-pullrequest-912748369
v14.17.1 release proposal #38948 https://github.com/nodejs/node/pull/38948
targoshttps://github.com/targos
Jun 11, 2021 https://github.com/nodejs/node/pull/38492#ref-commit-5995221
https://github.com/mhdawson
https://github.com/targos
node-api: fix shutdown crasheshttps://github.com/nodejs/node/commit/5995221ced27658cf9fa034e2d9844dfa2562d54
5995221https://github.com/nodejs/node/commit/5995221ced27658cf9fa034e2d9844dfa2562d54
nodejs/node-addon-api#906https://github.com/nodejs/node-addon-api/issues/906
#38492https://github.com/nodejs/node/pull/38492
https://github.com/legendecas
legendecashttps://github.com/legendecas
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Mar 29, 2022https://github.com/nodejs/node/pull/38492#event-6328180004
https://github.com/legendecas
legendecashttps://github.com/legendecas
Mar 29, 2022 https://github.com/nodejs/node/pull/38492#ref-issue-1172166519
Node.js 12.x need to cherry-pick https://github.com/nodejs/node/pull/37616 #42376 https://github.com/nodejs/node/issues/42376
legendecashttps://github.com/legendecas
Mar 29, 2022 https://github.com/nodejs/node/pull/38492#ref-commit-3939bba
https://github.com/mhdawson
https://github.com/legendecas
node-api: fix shutdown crasheshttps://github.com/legendecas/node/commit/3939bba723fbbbb98d0c1bfc76f37c5bf146c280
3939bbahttps://github.com/legendecas/node/commit/3939bba723fbbbb98d0c1bfc76f37c5bf146c280
nodejs/node-addon-api#906https://github.com/nodejs/node-addon-api/issues/906
nodejs#38492https://github.com/nodejs/node/pull/38492
richardlauhttps://github.com/richardlau
Mar 30, 2022 https://github.com/nodejs/node/pull/38492#ref-commit-a7224c9
https://github.com/mhdawson
https://github.com/richardlau
node-api: fix shutdown crasheshttps://github.com/nodejs/node/commit/a7224c9559519c830d751766b4d874b21f896fa9
a7224c9https://github.com/nodejs/node/commit/a7224c9559519c830d751766b4d874b21f896fa9
nodejs/node-addon-api#906https://github.com/nodejs/node-addon-api/issues/906
#38492https://github.com/nodejs/node/pull/38492
#42512https://github.com/nodejs/node/pull/42512
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Mar 30, 2022 https://github.com/nodejs/node/pull/38492#ref-pullrequest-1186734465
v12.22.12 proposal #42531 https://github.com/nodejs/node/pull/42531
pproencahttps://github.com/pproenca
Jan 1, 2026 https://github.com/nodejs/node/pull/38492#ref-commit-f348140
https://github.com/pproenca
fix(native): remove AdjustExternalMemory from destructors to fix Node…https://github.com/pproenca/node-webcodecs/commit/f348140ad1e2a2c572f535ff4e245d40e82c8af2
f348140https://github.com/pproenca/node-webcodecs/commit/f348140ad1e2a2c572f535ff4e245d40e82c8af2
nodejs/node-addon-api#1153https://github.com/nodejs/node-addon-api/issues/1153
nodejs/node#38492https://github.com/nodejs/node/pull/38492
pproencahttps://github.com/pproenca
Jan 4, 2026 https://github.com/nodejs/node/pull/38492#ref-commit-4b4f931
https://github.com/pproenca
fix(native): remove AdjustExternalMemory from destructors to fix Node…https://github.com/pproenca/node-webcodecs/commit/4b4f9317cb215b3a8dd12520b6d907f93ac232cc
4b4f931https://github.com/pproenca/node-webcodecs/commit/4b4f9317cb215b3a8dd12520b6d907f93ac232cc
nodejs/node-addon-api#1153https://github.com/nodejs/node-addon-api/issues/1153
nodejs/node#38492https://github.com/nodejs/node/pull/38492
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38492
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/38492/files/558a765f3dad635f8ec61f63d121848d3cd8264f
https://github.com/gabrielschulhof
gabrielschulhof https://github.com/gabrielschulhof
https://github.com/nodejs/node/pull/38492/files/558a765f3dad635f8ec61f63d121848d3cd8264f
https://github.com/legendecas
legendecas https://github.com/legendecas
https://github.com/nodejs/node/pull/38492/files/f42e1f48671e41158e0e37f5abaf28ab67428892
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Please reload this pagehttps://github.com/nodejs/node/pull/38492
https://github.com/mhdawson
https://github.com/addaleax
https://github.com/legendecas
https://github.com/nodejs-github-bot
https://github.com/gabrielschulhof
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.