René's URL Explorer Experiment


Title: doc: clarify that fs.Dir async iterator closes automatically by jasnell · Pull Request #38438 · nodejs/node · GitHub

Open Graph Title: doc: clarify that fs.Dir async iterator closes automatically by jasnell · Pull Request #38438 · nodejs/node

X Title: doc: clarify that fs.Dir async iterator closes automatically by jasnell · Pull Request #38438 · nodejs/node

Description: Signed-off-by: James M Snell jasnell@gmail.com Fixes: #35148

Open Graph Description: Signed-off-by: James M Snell jasnell@gmail.com Fixes: #35148

X Description: Signed-off-by: James M Snell jasnell@gmail.com Fixes: #35148

Mail addresses
jasnell@gmail.com

Opengraph URL: https://github.com/nodejs/node/pull/38438

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b976fdea-677e-83c8-bdcb-79d57f4d9dd4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8E4E:2B1AB1:94694E:C2C8CE:696AF358
html-safe-nonce077fe61ea248e1d7945dbb2e493a21d984f87d9470e42e18ec8a7710bbf13586
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTRFOjJCMUFCMTo5NDY5NEU6QzJDOENFOjY5NkFGMzU4IiwidmlzaXRvcl9pZCI6IjQ2MTgzODQ4MTYyNjMwNjY0NTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6e908ffe6fac82d49f0391bf2fdfd3357d12fbe6824e2cb8066b246251753e38
hovercard-subject-tagpull_request:624421993
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/38438/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9bf0d8109a0128d9be0987701b51564a603ad5472dadd94fc411ca835ea3b5ed/nodejs/node/pull/38438
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9bf0d8109a0128d9be0987701b51564a603ad5472dadd94fc411ca835ea3b5ed/nodejs/node/pull/38438
og:image:altSigned-off-by: James M Snell jasnell@gmail.com Fixes: #35148
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasnell
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/38438#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38438
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38438
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/38438
Reloadhttps://github.com/nodejs/node/pull/38438
Reloadhttps://github.com/nodejs/node/pull/38438
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/38438
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 692 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/38438
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/38438#issue-comment-box
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:fs-clarify-dir-async-iterator-closehttps://github.com/jasnell/node/tree/fs-clarify-dir-async-iterator-close
doc: clarify that fs.Dir async iterator closes automatically https://github.com/nodejs/node/pull/38438#top
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:fs-clarify-dir-async-iterator-closehttps://github.com/jasnell/node/tree/fs-clarify-dir-async-iterator-close
Conversation 2 https://github.com/nodejs/node/pull/38438
Commits 2 https://github.com/nodejs/node/pull/38438/commits
Checks 0 https://github.com/nodejs/node/pull/38438/checks
Files changed https://github.com/nodejs/node/pull/38438/files
Please reload this pagehttps://github.com/nodejs/node/pull/38438
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 27, 2021https://github.com/nodejs/node/pull/38438#issue-868986099
Please reload this pagehttps://github.com/nodejs/node/pull/38438
#35148https://github.com/nodejs/node/issues/35148
Please reload this pagehttps://github.com/nodejs/node/pull/38438
jasnellhttps://github.com/jasnell
April 27, 2021 08:32https://github.com/nodejs/node/pull/38438#commits-pushed-f17a968
https://github.com/jasnell
doc: clarify that fs.Dir async iterator closes automaticallyhttps://github.com/nodejs/node/pull/38438/commits/f17a9680ff5622be083a90b1ef81b8123411952d
f17a968https://github.com/nodejs/node/pull/38438/commits/f17a9680ff5622be083a90b1ef81b8123411952d
nodejs#35148https://github.com/nodejs/node/issues/35148
https://github.com/jasnell
fixup! test: fix test to allow quictls fork of OpenSSL 3https://github.com/nodejs/node/pull/38438/commits/2de63a3f1b9884969972f2543fca2a588143ba7a
2de63a3https://github.com/nodejs/node/pull/38438/commits/2de63a3f1b9884969972f2543fca2a588143ba7a
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Apr 27, 2021https://github.com/nodejs/node/pull/38438#event-4651642594
https://github.com/aduh95
aduh95https://github.com/aduh95
Apr 27, 2021 https://github.com/nodejs/node/pull/38438#pullrequestreview-646204635
View reviewed changes https://github.com/nodejs/node/pull/38438/files/2de63a3f1b9884969972f2543fca2a588143ba7a
https://github.com/jasnell
jasnellhttps://github.com/jasnell
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Apr 27, 2021https://github.com/nodejs/node/pull/38438#event-4652861864
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 27, 2021https://github.com/nodejs/node/pull/38438#issuecomment-827898047
Please reload this pagehttps://github.com/nodejs/node/pull/38438
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Apr 27, 2021 https://github.com/nodejs/node/pull/38438#pullrequestreview-646386783
View reviewed changes https://github.com/nodejs/node/pull/38438/files/2de63a3f1b9884969972f2543fca2a588143ba7a
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 27, 2021https://github.com/nodejs/node/pull/38438#issuecomment-827962675
87aca07https://github.com/nodejs/node/commit/87aca074f94f9c2d9ab18f77fe11ddf3dec661f9
Please reload this pagehttps://github.com/nodejs/node/pull/38438
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 27, 2021https://github.com/nodejs/node/pull/38438#event-4653362255
jasnellhttps://github.com/jasnell
Apr 27, 2021 https://github.com/nodejs/node/pull/38438#ref-commit-87aca07
https://github.com/jasnell
doc: clarify that fs.Dir async iterator closes automaticallyhttps://github.com/nodejs/node/commit/87aca074f94f9c2d9ab18f77fe11ddf3dec661f9
87aca07https://github.com/nodejs/node/commit/87aca074f94f9c2d9ab18f77fe11ddf3dec661f9
#35148https://github.com/nodejs/node/issues/35148
#38438https://github.com/nodejs/node/pull/38438
targoshttps://github.com/targos
Apr 29, 2021 https://github.com/nodejs/node/pull/38438#ref-commit-1eae4af
https://github.com/jasnell
https://github.com/targos
doc: clarify that fs.Dir async iterator closes automaticallyhttps://github.com/nodejs/node/commit/1eae4af6f712a15cc7530edc25dcf652790c8e83
1eae4afhttps://github.com/nodejs/node/commit/1eae4af6f712a15cc7530edc25dcf652790c8e83
#35148https://github.com/nodejs/node/issues/35148
#38438https://github.com/nodejs/node/pull/38438
https://github.com/targos
targoshttps://github.com/targos
May 3, 2021 https://github.com/nodejs/node/pull/38438#ref-pullrequest-874720685
v16.1.0 release proposal #38522 https://github.com/nodejs/node/pull/38522
https://github.com/targos
targoshttps://github.com/targos
backport-blocked-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v14.x
May 30, 2021https://github.com/nodejs/node/pull/38438#event-4816899227
targoshttps://github.com/targos
Sep 4, 2021 https://github.com/nodejs/node/pull/38438#ref-commit-7a92c3c
https://github.com/jasnell
https://github.com/targos
doc: clarify that fs.Dir async iterator closes automaticallyhttps://github.com/nodejs/node/commit/7a92c3cfd4614685426fc6cdff77e54f95895631
7a92c3chttps://github.com/nodejs/node/commit/7a92c3cfd4614685426fc6cdff77e54f95895631
#35148https://github.com/nodejs/node/issues/35148
#38438https://github.com/nodejs/node/pull/38438
https://github.com/targos
targoshttps://github.com/targos
backport-blocked-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v14.x
Sep 4, 2021https://github.com/nodejs/node/pull/38438#event-5256254370
https://github.com/targos
targoshttps://github.com/targos
Sep 4, 2021 https://github.com/nodejs/node/pull/38438#ref-pullrequest-988299806
v14.18.0 release proposal #39990 https://github.com/nodejs/node/pull/39990
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38438
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/38438/files/2de63a3f1b9884969972f2543fca2a588143ba7a
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/38438/files/2de63a3f1b9884969972f2543fca2a588143ba7a
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
doc: undocumented magic: async iterator over fs.Dir will call dir.close() on iteration end https://github.com/nodejs/node/issues/35148
Please reload this pagehttps://github.com/nodejs/node/pull/38438
https://github.com/jasnell
https://github.com/addaleax
https://github.com/aduh95
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.