René's URL Explorer Experiment


Title: src: remove unused guards around node-api reference by legendecas · Pull Request #38334 · nodejs/node · GitHub

Open Graph Title: src: remove unused guards around node-api reference by legendecas · Pull Request #38334 · nodejs/node

X Title: src: remove unused guards around node-api reference by legendecas · Pull Request #38334 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This is roughly a revert on #38250 while we have a formal fix around the use-after-free issue on v8impl::Reference with #38000 landed. As #38250 was alleviating the problem but the root cause is un...

X Description: This is roughly a revert on #38250 while we have a formal fix around the use-after-free issue on v8impl::Reference with #38000 landed. As #38250 was alleviating the problem but the root cause is un...

Opengraph URL: https://github.com/nodejs/node/pull/38334

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a1112d65-0832-f092-90de-c190cd25ac54
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCBD2:2546A0:CF0606:12BAB6B:6A4E4C82
html-safe-nonce69946cc2782c8cb747acbdb2bc6026973b8b7d47669865504700d239d2269b70
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQkQyOjI1NDZBMDpDRjA2MDY6MTJCQUI2Qjo2QTRFNEM4MiIsInZpc2l0b3JfaWQiOiIzMzUxNDk2Njc2NTk0MzA2MTc4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacdc4e68b99e20e9835d7e5866496b169318d21bc350f82a83a658771cfaced4a4
hovercard-subject-tagpull_request:620385067
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/38334/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4cde94fb685c61382a3eb28ed6395f702c457cc23ba84cd33da791df27c57e65/nodejs/node/pull/38334
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4cde94fb685c61382a3eb28ed6395f702c457cc23ba84cd33da791df27c57e65/nodejs/node/pull/38334
og:image:altThis is roughly a revert on #38250 while we have a formal fix around the use-after-free issue on v8impl::Reference with #38000 landed. As #38250 was alleviating the problem but the root cause is un...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelegendecas
hostnamegithub.com
expected-hostnamegithub.com
None030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee8506f6d0538364886e3f0153c154c410965e70d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/38334#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38334
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38334
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/38334
Reloadhttps://github.com/nodejs/node/pull/38334
Reloadhttps://github.com/nodejs/node/pull/38334
Please reload this pagehttps://github.com/nodejs/node/pull/38334
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/38334
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
legendecashttps://github.com/legendecas
nodejs:masterhttps://github.com/nodejs/node/tree/master
legendecas:node-api/referencehttps://github.com/legendecas/node/tree/node-api/reference
Conversationhttps://github.com/nodejs/node/pull/38334
Commits1 (1)https://github.com/nodejs/node/pull/38334/commits
Checkshttps://github.com/nodejs/node/pull/38334/checks
Files changedhttps://github.com/nodejs/node/pull/38334/files
src: remove unused guards around node-api referencehttps://github.com/nodejs/node/pull/38334#top
legendecashttps://github.com/legendecas
nodejs:masterhttps://github.com/nodejs/node/tree/master
legendecas:node-api/referencehttps://github.com/legendecas/node/tree/node-api/reference
https://github.com/legendecas
legendecashttps://github.com/legendecas
Apr 21, 2021https://github.com/nodejs/node/pull/38334#issue-864096391
Please reload this pagehttps://github.com/nodejs/node/pull/38334
#38250https://github.com/nodejs/node/pull/38250
#38000https://github.com/nodejs/node/pull/38000
#38250https://github.com/nodejs/node/pull/38250
Please reload this pagehttps://github.com/nodejs/node/pull/38334
https://github.com/legendecas
legendecashttps://github.com/legendecas
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Apr 21, 2021https://github.com/nodejs/node/pull/38334#event-4626267702
https://github.com/legendecas
legendecashttps://github.com/legendecas
jasnellhttps://github.com/jasnell
April 21, 2021 17:09https://github.com/nodejs/node/pull/38334#event-4626267717
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Apr 21, 2021https://github.com/nodejs/node/pull/38334#event-4626267999
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 21, 2021https://github.com/nodejs/node/pull/38334#issuecomment-824222331
https://ci.nodejs.org/job/node-test-pull-request/37594/https://ci.nodejs.org/job/node-test-pull-request/37594/
Please reload this pagehttps://github.com/nodejs/node/pull/38334
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Apr 22, 2021 https://github.com/nodejs/node/pull/38334#pullrequestreview-642687205
View reviewed changes https://github.com/nodejs/node/pull/38334/files
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/38334#pullrequestreview-642687205
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/38334
https://github.com/aduh95
aduh95https://github.com/aduh95
Apr 22, 2021https://github.com/nodejs/node/pull/38334#issuecomment-825225790
Please reload this pagehttps://github.com/nodejs/node/pull/38334
https://github.com/legendecas
legendecashttps://github.com/legendecas
Apr 25, 2021https://github.com/nodejs/node/pull/38334#issuecomment-826338525
Please reload this pagehttps://github.com/nodejs/node/pull/38334
@aduh95https://github.com/aduh95
Please reload this pagehttps://github.com/nodejs/node/pull/38334
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 25, 2021https://github.com/nodejs/node/pull/38334#issuecomment-826338730
https://ci.nodejs.org/job/node-test-pull-request/37706/https://ci.nodejs.org/job/node-test-pull-request/37706/
Please reload this pagehttps://github.com/nodejs/node/pull/38334
https://github.com/legendecas
src: remove unused guards around node-api referencehttps://github.com/nodejs/node/pull/38334/commits/fa9f44cee004825e236914dc2f45aa831c4ff00a
fa9f44chttps://github.com/nodejs/node/pull/38334/commits/fa9f44cee004825e236914dc2f45aa831c4ff00a
https://github.com/legendecas
legendecashttps://github.com/legendecas
force-pushedhttps://github.com/nodejs/node/compare/e3eb194b679a971165b42a9342ee44a7a50a7ce2..fa9f44cee004825e236914dc2f45aa831c4ff00a
e3eb194https://github.com/nodejs/node/commit/e3eb194b679a971165b42a9342ee44a7a50a7ce2
fa9f44chttps://github.com/nodejs/node/commit/fa9f44cee004825e236914dc2f45aa831c4ff00a
Compare https://github.com/nodejs/node/compare/e3eb194b679a971165b42a9342ee44a7a50a7ce2..fa9f44cee004825e236914dc2f45aa831c4ff00a
July 6, 2021 14:25https://github.com/nodejs/node/pull/38334#event-4983599885
https://github.com/legendecas
legendecashttps://github.com/legendecas
Jul 8, 2021https://github.com/nodejs/node/pull/38334#issuecomment-876029564
#38899https://github.com/nodejs/node/pull/38899
Please reload this pagehttps://github.com/nodejs/node/pull/38334
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38334
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38334
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 13, 2021https://github.com/nodejs/node/pull/38334#issuecomment-878756052
https://ci.nodejs.org/job/node-test-pull-request/39010/https://ci.nodejs.org/job/node-test-pull-request/39010/
Please reload this pagehttps://github.com/nodejs/node/pull/38334
legendecashttps://github.com/legendecas
Jul 14, 2021 https://github.com/nodejs/node/pull/38334#ref-commit-c6a2077
https://github.com/legendecas
src: remove unused guards around node-api referencehttps://github.com/nodejs/node/commit/c6a20778688a361c14611e8d0622fe8956e4633d
c6a2077https://github.com/nodejs/node/commit/c6a20778688a361c14611e8d0622fe8956e4633d
#38334https://github.com/nodejs/node/pull/38334
https://github.com/legendecas
legendecashttps://github.com/legendecas
Jul 14, 2021https://github.com/nodejs/node/pull/38334#issuecomment-880001603
c6a2077https://github.com/nodejs/node/commit/c6a20778688a361c14611e8d0622fe8956e4633d
Please reload this pagehttps://github.com/nodejs/node/pull/38334
https://github.com/legendecas
legendecashttps://github.com/legendecas
Jul 14, 2021https://github.com/nodejs/node/pull/38334#event-5020550666
https://github.com/legendecas
legendecashttps://github.com/legendecas
July 14, 2021 15:42https://github.com/nodejs/node/pull/38334#event-5020551096
targoshttps://github.com/targos
Jul 17, 2021 https://github.com/nodejs/node/pull/38334#ref-commit-0acc403
https://github.com/legendecas
https://github.com/targos
src: remove unused guards around node-api referencehttps://github.com/nodejs/node/commit/0acc403e2a6655f323b92e2090ca78c4842dd39e
0acc403https://github.com/nodejs/node/commit/0acc403e2a6655f323b92e2090ca78c4842dd39e
#38334https://github.com/nodejs/node/pull/38334
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Jul 26, 2021 https://github.com/nodejs/node/pull/38334#ref-pullrequest-953169906
v16.6.0 proposal #39534 https://github.com/nodejs/node/pull/39534
BethGriggshttps://github.com/BethGriggs
Jul 29, 2021 https://github.com/nodejs/node/pull/38334#ref-commit-fc13837
https://github.com/legendecas
https://github.com/BethGriggs
src: remove unused guards around node-api referencehttps://github.com/nodejs/node/commit/fc138376aa0d3701b617a674c16e16b8eae25859
fc13837https://github.com/nodejs/node/commit/fc138376aa0d3701b617a674c16e16b8eae25859
#38334https://github.com/nodejs/node/pull/38334
targoshttps://github.com/targos
Sep 4, 2021 https://github.com/nodejs/node/pull/38334#ref-commit-5c473bd
https://github.com/legendecas
https://github.com/targos
src: remove unused guards around node-api referencehttps://github.com/nodejs/node/commit/5c473bdc12b35546e3b03b47c70ae14fff90536b
5c473bdhttps://github.com/nodejs/node/commit/5c473bdc12b35546e3b03b47c70ae14fff90536b
#38334https://github.com/nodejs/node/pull/38334
https://github.com/targos
targoshttps://github.com/targos
Sep 4, 2021 https://github.com/nodejs/node/pull/38334#ref-pullrequest-988299806
v14.18.0 release proposal #39990 https://github.com/nodejs/node/pull/39990
mwalbeckhttps://github.com/mwalbeck
Oct 6, 2021 https://github.com/nodejs/node/pull/38334#ref-commit-b56d53d
https://github.com/mwalbeck
Update Node.js to v14.18.0 (#52)https://github.com/mwalbeck/docker-jellyfin-livestream/commit/b56d53d9104e89f2e984ef3001e6825d34762598
b56d53dhttps://github.com/mwalbeck/docker-jellyfin-livestream/commit/b56d53d9104e89f2e984ef3001e6825d34762598
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38334
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/38334/files/e3eb194b679a971165b42a9342ee44a7a50a7ce2
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Please reload this pagehttps://github.com/nodejs/node/pull/38334
https://github.com/legendecas
https://github.com/nodejs-github-bot
https://github.com/aduh95
https://github.com/mhdawson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.