René's URL Explorer Experiment


Title: deps: V8: cherry-pick 501482cbc704 by cjihrig · Pull Request #38121 · nodejs/node · GitHub

Open Graph Title: deps: V8: cherry-pick 501482cbc704 by cjihrig · Pull Request #38121 · nodejs/node

X Title: deps: V8: cherry-pick 501482cbc704 by cjihrig · Pull Request #38121 · nodejs/node

Description: Original commit message: Fix ValueDeserializer::ReadDouble() bounds check If end_ is smaller than sizeof(double), the result would wrap around, and lead to an invalid memory access. Refs: https:/...

Open Graph Description: Original commit message: Fix ValueDeserializer::ReadDouble() bounds check If end_ is smaller than sizeof(double), the result would wrap around, and lead to an invalid memory access. Refs: https:/...

X Description: Original commit message: Fix ValueDeserializer::ReadDouble() bounds check If end_ is smaller than sizeof(double), the result would wrap around, and lead to an invalid memory access. Refs: https:/...

Opengraph URL: https://github.com/nodejs/node/pull/38121

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f41c47bf-db09-5222-e120-69ed97fb20e7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9982:1860A8:DF45D7:1364020:696A831A
html-safe-nonce383e424c40f853246b103405899ffcce728e2680c60fc5fbdb0cf2fed6739702
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTgyOjE4NjBBODpERjQ1RDc6MTM2NDAyMDo2OTZBODMxQSIsInZpc2l0b3JfaWQiOiIzNzQwMzM2ODg0OTc4MTg5MDgyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace4ff194f65c86eb9c8170b64f86903d143d9874dc1ad6edfdf841b1f5109059e
hovercard-subject-tagpull_request:610274382
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/38121/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9ea6e037d2f2ac618607e3d5046f28c3ce9e07041948a1c3b1df9920c9e8fa27/nodejs/node/pull/38121
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9ea6e037d2f2ac618607e3d5046f28c3ce9e07041948a1c3b1df9920c9e8fa27/nodejs/node/pull/38121
og:image:altOriginal commit message: Fix ValueDeserializer::ReadDouble() bounds check If end_ is smaller than sizeof(double), the result would wrap around, and lead to an invalid memory access. Refs: https:/...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
None913560fa317c3c5a71e34f9b19253c9f09d02b4b958a86c2a56f4c8541116377
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5998c30593994bf2589055aef7b22d368a499367
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/38121#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38121
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38121
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/38121
Reloadhttps://github.com/nodejs/node/pull/38121
Reloadhttps://github.com/nodejs/node/pull/38121
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/38121
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/38121
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/38121#issue-comment-box
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:cphttps://github.com/cjihrig/node/tree/cp
deps: V8: cherry-pick 501482cbc704 https://github.com/nodejs/node/pull/38121#top
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:cphttps://github.com/cjihrig/node/tree/cp
Conversation 5 https://github.com/nodejs/node/pull/38121
Commits 2 https://github.com/nodejs/node/pull/38121/commits
Checks 0 https://github.com/nodejs/node/pull/38121/checks
Files changed https://github.com/nodejs/node/pull/38121/files
Please reload this pagehttps://github.com/nodejs/node/pull/38121
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Apr 7, 2021https://github.com/nodejs/node/pull/38121#issue-851938171
v8/v8@501482cbc704https://github.com/v8/v8/commit/501482cbc704
#37978https://github.com/nodejs/node/issues/37978
Please reload this pagehttps://github.com/nodejs/node/pull/38121
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
Apr 7, 2021https://github.com/nodejs/node/pull/38121#event-4559818973
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Apr 7, 2021https://github.com/nodejs/node/pull/38121#issuecomment-814647694
Please reload this pagehttps://github.com/nodejs/node/pull/38121
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Apr 7, 2021 https://github.com/nodejs/node/pull/38121#pullrequestreview-630010748
View reviewed changes https://github.com/nodejs/node/pull/38121/files
RaisinTenhttps://github.com/RaisinTen
https://github.com/nodejs/node/pull/38121#pullrequestreview-630010748
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/38121
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 7, 2021 https://github.com/nodejs/node/pull/38121#pullrequestreview-630040614
View reviewed changes https://github.com/nodejs/node/pull/38121/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/50a26f4b8abb788b14a4a3bbfcfc22ced3251374..8ef497ceebcd679f5383bb43789c9f2fd5667e1c
50a26f4https://github.com/nodejs/node/commit/50a26f4b8abb788b14a4a3bbfcfc22ced3251374
8ef497chttps://github.com/nodejs/node/commit/8ef497ceebcd679f5383bb43789c9f2fd5667e1c
Compare https://github.com/nodejs/node/compare/50a26f4b8abb788b14a4a3bbfcfc22ced3251374..8ef497ceebcd679f5383bb43789c9f2fd5667e1c
April 8, 2021 02:14https://github.com/nodejs/node/pull/38121#event-4565951805
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Apr 8, 2021https://github.com/nodejs/node/pull/38121#issuecomment-815395616
Please reload this pagehttps://github.com/nodejs/node/pull/38121
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 8, 2021https://github.com/nodejs/node/pull/38121#issuecomment-815395873
https://ci.nodejs.org/job/node-test-pull-request/37276/https://ci.nodejs.org/job/node-test-pull-request/37276/
Please reload this pagehttps://github.com/nodejs/node/pull/38121
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Apr 8, 2021 https://github.com/nodejs/node/pull/38121#pullrequestreview-630925130
View reviewed changes https://github.com/nodejs/node/pull/38121/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 8, 2021https://github.com/nodejs/node/pull/38121#issuecomment-815776635
https://ci.nodejs.org/job/node-test-pull-request/37295/https://ci.nodejs.org/job/node-test-pull-request/37295/
Please reload this pagehttps://github.com/nodejs/node/pull/38121
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Apr 8, 2021 https://github.com/nodejs/node/pull/38121#pullrequestreview-631438449
View reviewed changes https://github.com/nodejs/node/pull/38121/files
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Apr 8, 2021https://github.com/nodejs/node/pull/38121#event-4568913364
cjihrighttps://github.com/cjihrig
April 8, 2021 22:27https://github.com/nodejs/node/pull/38121#commits-pushed-ca13f7a
https://github.com/cjihrig
deps: V8: cherry-pick 501482cbc704https://github.com/nodejs/node/pull/38121/commits/ca13f7aaf36ee9f88368f15f294acf171c0af859
ca13f7ahttps://github.com/nodejs/node/pull/38121/commits/ca13f7aaf36ee9f88368f15f294acf171c0af859
nodejs#37978https://github.com/nodejs/node/issues/37978
https://chromium-review.googlesource.com/c/v8/v8/+/2801353https://chromium-review.googlesource.com/c/v8/v8/+/2801353
nodejs#38121https://github.com/nodejs/node/pull/38121
nodejs#37978https://github.com/nodejs/node/issues/37978
v8/v8@501482cbc704https://github.com/v8/v8/commit/501482cbc704
https://github.com/cjihrig
test: add regression test for serdes readDouble()https://github.com/nodejs/node/pull/38121/commits/e96773b94bbfdfd0b9d5d449ece90e4e297f9c94
e96773bhttps://github.com/nodejs/node/pull/38121/commits/e96773b94bbfdfd0b9d5d449ece90e4e297f9c94
nodejs#37978https://github.com/nodejs/node/issues/37978
nodejs#38121https://github.com/nodejs/node/pull/38121
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/8ef497ceebcd679f5383bb43789c9f2fd5667e1c..e96773b94bbfdfd0b9d5d449ece90e4e297f9c94
8ef497chttps://github.com/nodejs/node/commit/8ef497ceebcd679f5383bb43789c9f2fd5667e1c
e96773bhttps://github.com/nodejs/node/commit/e96773b94bbfdfd0b9d5d449ece90e4e297f9c94
Compare https://github.com/nodejs/node/compare/8ef497ceebcd679f5383bb43789c9f2fd5667e1c..e96773b94bbfdfd0b9d5d449ece90e4e297f9c94
April 9, 2021 02:27https://github.com/nodejs/node/pull/38121#event-4572027472
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
e96773bhttps://github.com/nodejs/node/commit/e96773b94bbfdfd0b9d5d449ece90e4e297f9c94
Apr 9, 2021https://github.com/nodejs/node/pull/38121#event-4572028781
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
April 9, 2021 02:28https://github.com/nodejs/node/pull/38121#event-4572030135
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Apr 12, 2021 https://github.com/nodejs/node/pull/38121#ref-pullrequest-826369040
2021-04-20, Version 16.0.0 (Current) #37678 https://github.com/nodejs/node/pull/37678
targoshttps://github.com/targos
May 1, 2021 https://github.com/nodejs/node/pull/38121#ref-commit-8951c19
https://github.com/cjihrig
https://github.com/targos
deps: V8: cherry-pick 501482cbc704https://github.com/nodejs/node/commit/8951c19e723272bf6a26cc624e50a2d059a19c05
8951c19https://github.com/nodejs/node/commit/8951c19e723272bf6a26cc624e50a2d059a19c05
#37978https://github.com/nodejs/node/issues/37978
https://chromium-review.googlesource.com/c/v8/v8/+/2801353https://chromium-review.googlesource.com/c/v8/v8/+/2801353
#38121https://github.com/nodejs/node/pull/38121
#37978https://github.com/nodejs/node/issues/37978
v8/v8@501482cbc704https://github.com/v8/v8/commit/501482cbc704
targoshttps://github.com/targos
May 1, 2021 https://github.com/nodejs/node/pull/38121#ref-commit-aa0d814
https://github.com/cjihrig
https://github.com/targos
test: add regression test for serdes readDouble()https://github.com/nodejs/node/commit/aa0d8146e9ab0ed92f13a0748357ab1b9881307e
aa0d814https://github.com/nodejs/node/commit/aa0d8146e9ab0ed92f13a0748357ab1b9881307e
#37978https://github.com/nodejs/node/issues/37978
#38121https://github.com/nodejs/node/pull/38121
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
May 3, 2021 https://github.com/nodejs/node/pull/38121#ref-pullrequest-874193529
v14.17.0 proposal #38507 https://github.com/nodejs/node/pull/38507
danielleadamshttps://github.com/danielleadams
May 8, 2021 https://github.com/nodejs/node/pull/38121#ref-commit-a6dba4d
https://github.com/cjihrig
https://github.com/danielleadams
deps: V8: cherry-pick 501482cbc704https://github.com/nodejs/node/commit/a6dba4de55f7c40211960aa49f08a33701f58309
a6dba4dhttps://github.com/nodejs/node/commit/a6dba4de55f7c40211960aa49f08a33701f58309
#37978https://github.com/nodejs/node/issues/37978
https://chromium-review.googlesource.com/c/v8/v8/+/2801353https://chromium-review.googlesource.com/c/v8/v8/+/2801353
#38121https://github.com/nodejs/node/pull/38121
#37978https://github.com/nodejs/node/issues/37978
v8/v8@501482cbc704https://github.com/v8/v8/commit/501482cbc704
danielleadamshttps://github.com/danielleadams
May 8, 2021 https://github.com/nodejs/node/pull/38121#ref-commit-7162bea
https://github.com/cjihrig
https://github.com/danielleadams
test: add regression test for serdes readDouble()https://github.com/nodejs/node/commit/7162beaa649100b2c772ca2a57cfa9039c3559d5
7162beahttps://github.com/nodejs/node/commit/7162beaa649100b2c772ca2a57cfa9039c3559d5
#37978https://github.com/nodejs/node/issues/37978
#38121https://github.com/nodejs/node/pull/38121
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38121
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/38121/files/50a26f4b8abb788b14a4a3bbfcfc22ced3251374
https://github.com/gengjiawen
gengjiawen https://github.com/gengjiawen
https://github.com/nodejs/node/pull/38121/files/8ef497ceebcd679f5383bb43789c9f2fd5667e1c
https://github.com/RaisinTen
RaisinTen https://github.com/RaisinTen
https://github.com/nodejs/node/pull/38121/files/8ef497ceebcd679f5383bb43789c9f2fd5667e1c
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
"deserializer.readDouble()" results in an abort https://github.com/nodejs/node/issues/37978
Please reload this pagehttps://github.com/nodejs/node/pull/38121
https://github.com/cjihrig
https://github.com/gengjiawen
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/RaisinTen
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.