René's URL Explorer Experiment


Title: http: fixup perf regression by jasnell · Pull Request #38110 · nodejs/node · GitHub

Open Graph Title: http: fixup perf regression by jasnell · Pull Request #38110 · nodejs/node

X Title: http: fixup perf regression by jasnell · Pull Request #38110 · nodejs/node

Description: /cc @mcollina Signed-off-by: James M Snell jasnell@gmail.com

Open Graph Description: /cc @mcollina Signed-off-by: James M Snell jasnell@gmail.com

X Description: /cc @mcollina Signed-off-by: James M Snell jasnell@gmail.com

Mail addresses
jasnell@gmail.com

Opengraph URL: https://github.com/nodejs/node/pull/38110

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:dd07edc4-d9c4-e471-0069-8e3fc9958c62
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAD88:327857:14C2144:1C8F216:696A96BB
html-safe-nonce079555a9d6a0c235d3d23d5f889da2d20693b9b8b40c7f0974200c78dbea0428
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDg4OjMyNzg1NzoxNEMyMTQ0OjFDOEYyMTY6Njk2QTk2QkIiLCJ2aXNpdG9yX2lkIjoiNjE1ODEyMDQ0NzE2NjI4OTU5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca4d304b5b2ce62022d6614ae1c233f7d4ffbdec6f03a7e244abfaec09a5d7ce9
hovercard-subject-tagpull_request:609961331
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/38110/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c51b113dac34082be85b3e46acbf738b2da0601989048d7a5599c9ceff2345a3/nodejs/node/pull/38110
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c51b113dac34082be85b3e46acbf738b2da0601989048d7a5599c9ceff2345a3/nodejs/node/pull/38110
og:image:alt/cc @mcollina Signed-off-by: James M Snell jasnell@gmail.com
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasnell
hostnamegithub.com
expected-hostnamegithub.com
Nonec0d8175e41e0e55b9e984c935b24b808cabab919dd3174aa45dac3ef503ed1af
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release99aab454e5ddc8df30805fb76c114c3008a15842
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/38110#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38110
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38110
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/38110
Reloadhttps://github.com/nodejs/node/pull/38110
Reloadhttps://github.com/nodejs/node/pull/38110
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/38110
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/38110
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/38110#issue-comment-box
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:fixup-perf-regressionhttps://github.com/jasnell/node/tree/fixup-perf-regression
http: fixup perf regression https://github.com/nodejs/node/pull/38110#top
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:fixup-perf-regressionhttps://github.com/jasnell/node/tree/fixup-perf-regression
Conversation 23 https://github.com/nodejs/node/pull/38110
Commits 1 https://github.com/nodejs/node/pull/38110/commits
Checks 0 https://github.com/nodejs/node/pull/38110/checks
Files changed https://github.com/nodejs/node/pull/38110/files
Please reload this pagehttps://github.com/nodejs/node/pull/38110
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 6, 2021https://github.com/nodejs/node/pull/38110#issue-851559576
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/38110
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Apr 6, 2021https://github.com/nodejs/node/pull/38110#event-4557627318
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38110
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Apr 6, 2021 https://github.com/nodejs/node/pull/38110#pullrequestreview-629140871
View reviewed changes https://github.com/nodejs/node/pull/38110/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/38110#pullrequestreview-629140871
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/38110
https://github.com/richardlau
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38110
https://github.com/jasnell
jasnellhttps://github.com/jasnell
force-pushedhttps://github.com/nodejs/node/compare/237a4ce323ba4b40487cffd44eb5a314f61cbc17..978e4fb23a54d888d4cf9cff890f7e427a8842b9
237a4cehttps://github.com/nodejs/node/commit/237a4ce323ba4b40487cffd44eb5a314f61cbc17
978e4fbhttps://github.com/nodejs/node/commit/978e4fb23a54d888d4cf9cff890f7e427a8842b9
Compare https://github.com/nodejs/node/compare/237a4ce323ba4b40487cffd44eb5a314f61cbc17..978e4fb23a54d888d4cf9cff890f7e427a8842b9
April 6, 2021 16:04https://github.com/nodejs/node/pull/38110#event-4557725092
https://github.com/jasnell
jasnellhttps://github.com/jasnell
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Apr 6, 2021https://github.com/nodejs/node/pull/38110#event-4557727311
https://github.com/lpinca
lpincahttps://github.com/lpinca
Apr 6, 2021 https://github.com/nodejs/node/pull/38110#pullrequestreview-629212394
View reviewed changes https://github.com/nodejs/node/pull/38110/files
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Apr 6, 2021 https://github.com/nodejs/node/pull/38110#pullrequestreview-629217376
View reviewed changes https://github.com/nodejs/node/pull/38110/files
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38110
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Apr 6, 2021 https://github.com/nodejs/node/pull/38110#pullrequestreview-629452857
View reviewed changes https://github.com/nodejs/node/pull/38110/files
lib/internal/perf/observe.jshttps://github.com/nodejs/node/pull/38110/files#diff-467bf7d775fb27563f94b6231c74c64d58d68de5168c17670a68929d6b435b79
Please reload this pagehttps://github.com/nodejs/node/pull/38110
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Apr 6, 2021 https://github.com/nodejs/node/pull/38110#pullrequestreview-629457886
View reviewed changes https://github.com/nodejs/node/pull/38110/files
https://github.com/jasnell
jasnellhttps://github.com/jasnell
force-pushedhttps://github.com/nodejs/node/compare/978e4fb23a54d888d4cf9cff890f7e427a8842b9..de05bb68b2132fdcc37fb7b0b44b4951b2c7b7e1
978e4fbhttps://github.com/nodejs/node/commit/978e4fb23a54d888d4cf9cff890f7e427a8842b9
de05bb6https://github.com/nodejs/node/commit/de05bb68b2132fdcc37fb7b0b44b4951b2c7b7e1
Compare https://github.com/nodejs/node/compare/978e4fb23a54d888d4cf9cff890f7e427a8842b9..de05bb68b2132fdcc37fb7b0b44b4951b2c7b7e1
April 6, 2021 22:29https://github.com/nodejs/node/pull/38110#event-4559339472
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Apr 7, 2021 https://github.com/nodejs/node/pull/38110#pullrequestreview-629925653
View reviewed changes https://github.com/nodejs/node/pull/38110/files
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38110
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38110
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38110
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38110
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38110
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38110
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Apr 9, 2021https://github.com/nodejs/node/pull/38110#issuecomment-816597868
Please reload this pagehttps://github.com/nodejs/node/pull/38110
https://github.com/lpinca
lpincahttps://github.com/lpinca
Apr 9, 2021https://github.com/nodejs/node/pull/38110#issuecomment-816606458
#38149https://github.com/nodejs/node/pull/38149
Please reload this pagehttps://github.com/nodejs/node/pull/38110
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38110
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38110
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38110
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38110
https://github.com/jasnell
http: fixup perf regressionhttps://github.com/nodejs/node/pull/38110/commits/1c62829b25882750bba0ce0bb8a6177d6d918720
1c62829https://github.com/nodejs/node/pull/38110/commits/1c62829b25882750bba0ce0bb8a6177d6d918720
nodejs#37937https://github.com/nodejs/node/issues/37937
nodejs#37136https://github.com/nodejs/node/pull/37136
https://github.com/jasnell
jasnellhttps://github.com/jasnell
force-pushedhttps://github.com/nodejs/node/compare/de05bb68b2132fdcc37fb7b0b44b4951b2c7b7e1..1c62829b25882750bba0ce0bb8a6177d6d918720
de05bb6https://github.com/nodejs/node/commit/de05bb68b2132fdcc37fb7b0b44b4951b2c7b7e1
1c62829https://github.com/nodejs/node/commit/1c62829b25882750bba0ce0bb8a6177d6d918720
Compare https://github.com/nodejs/node/compare/de05bb68b2132fdcc37fb7b0b44b4951b2c7b7e1..1c62829b25882750bba0ce0bb8a6177d6d918720
April 9, 2021 22:38https://github.com/nodejs/node/pull/38110#event-4576653413
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 9, 2021https://github.com/nodejs/node/pull/38110#issuecomment-817009583
Please reload this pagehttps://github.com/nodejs/node/pull/38110
https://ci.nodejs.org/job/node-test-pull-request/37349/https://ci.nodejs.org/job/node-test-pull-request/37349/
Please reload this pagehttps://github.com/nodejs/node/pull/38110
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 9, 2021https://github.com/nodejs/node/pull/38110#issuecomment-817033325
Please reload this pagehttps://github.com/nodejs/node/pull/38110
jasnellhttps://github.com/jasnell
Apr 9, 2021 https://github.com/nodejs/node/pull/38110#ref-commit-40ace47
https://github.com/jasnell
http: fixup perf regressionhttps://github.com/nodejs/node/commit/40ace4739646baf19b7f64ca56e6f1659a58393e
40ace47https://github.com/nodejs/node/commit/40ace4739646baf19b7f64ca56e6f1659a58393e
#37937https://github.com/nodejs/node/issues/37937
#37136https://github.com/nodejs/node/pull/37136
#38110https://github.com/nodejs/node/pull/38110
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 9, 2021https://github.com/nodejs/node/pull/38110#issuecomment-817033599
40ace47https://github.com/nodejs/node/commit/40ace4739646baf19b7f64ca56e6f1659a58393e
Please reload this pagehttps://github.com/nodejs/node/pull/38110
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 9, 2021https://github.com/nodejs/node/pull/38110#event-4576804741
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Apr 12, 2021 https://github.com/nodejs/node/pull/38110#ref-pullrequest-826369040
2021-04-20, Version 16.0.0 (Current) #37678 https://github.com/nodejs/node/pull/37678
https://github.com/targos
targoshttps://github.com/targos
backport-blocked-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v14.x
May 30, 2021https://github.com/nodejs/node/pull/38110#event-4816847862
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38110
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/38110/files/237a4ce323ba4b40487cffd44eb5a314f61cbc17
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/38110/files/de05bb68b2132fdcc37fb7b0b44b4951b2c7b7e1
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/38110/files/978e4fb23a54d888d4cf9cff890f7e427a8842b9
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/38110/files/978e4fb23a54d888d4cf9cff890f7e427a8842b9
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/38110/files/978e4fb23a54d888d4cf9cff890f7e427a8842b9
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/38110
https://github.com/jasnell
https://github.com/nodejs-github-bot
https://github.com/richardlau
https://github.com/mcollina
https://github.com/lpinca
https://github.com/benjamingr
https://github.com/BridgeAR
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.