René's URL Explorer Experiment


Title: [v12.x] src: move CHECK in AddIsolateFinishedCallback by indutny · Pull Request #38010 · nodejs/node · GitHub

Open Graph Title: [v12.x] src: move CHECK in AddIsolateFinishedCallback by indutny · Pull Request #38010 · nodejs/node

X Title: [v12.x] src: move CHECK in AddIsolateFinishedCallback by indutny · Pull Request #38010 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: CHECK(it->second) asserts that we have PerIsolatePlatformData in the per_isolate_ map, and not just a key with empty value. When it == per_isolate_.end(), however, it means that we don't hav...

X Description: CHECK(it->second) asserts that we have PerIsolatePlatformData in the per_isolate_ map, and not just a key with empty value. When it == per_isolate_.end(), however, it means that we don&#...

Opengraph URL: https://github.com/nodejs/node/pull/38010

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:955c9779-8541-1952-c27a-b0846d254365
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBAA6:38592C:126DA53:1ADCFAA:6A4E4156
html-safe-nonce7bc33b2115bbdc87246c22327fae29cf688feae8b7f163e5d776d677968fc0ca
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQUE2OjM4NTkyQzoxMjZEQTUzOjFBRENGQUE6NkE0RTQxNTYiLCJ2aXNpdG9yX2lkIjoiMTcyOTAzNjE0ODc1NDIzNTczNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb444e0bf8bb64dbc668981d5569982d8678a80a226dd80ec161a7bc3f4442c42
hovercard-subject-tagpull_request:606313624
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/38010/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4b3038f94bd482ccfa4dd9d848df189ffa26aa10e571e320c253e436b40ce8dc/nodejs/node/pull/38010
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4b3038f94bd482ccfa4dd9d848df189ffa26aa10e571e320c253e436b40ce8dc/nodejs/node/pull/38010
og:image:altCHECK(it->second) asserts that we have PerIsolatePlatformData in the per_isolate_ map, and not just a key with empty value. When it == per_isolate_.end(), however, it means that we don't hav...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameindutny
hostnamegithub.com
expected-hostnamegithub.com
None030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9fabff9b8b127e686a3ec86f91422e818056ca2c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/38010#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38010
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38010
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/38010
Reloadhttps://github.com/nodejs/node/pull/38010
Reloadhttps://github.com/nodejs/node/pull/38010
Please reload this pagehttps://github.com/nodejs/node/pull/38010
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/38010
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
indutnyhttps://github.com/indutny
nodejs:v12.xhttps://github.com/nodejs/node/tree/v12.x
indutny:fix/electron-worker-threads-crashhttps://github.com/indutny/io.js/tree/fix/electron-worker-threads-crash
Conversationhttps://github.com/nodejs/node/pull/38010
Commits1 (1)https://github.com/nodejs/node/pull/38010/commits
Checkshttps://github.com/nodejs/node/pull/38010/checks
Files changedhttps://github.com/nodejs/node/pull/38010/files
[v12.x] src: move CHECK in AddIsolateFinishedCallbackhttps://github.com/nodejs/node/pull/38010#top
indutnyhttps://github.com/indutny
nodejs:v12.xhttps://github.com/nodejs/node/tree/v12.x
indutny:fix/electron-worker-threads-crashhttps://github.com/indutny/io.js/tree/fix/electron-worker-threads-crash
https://github.com/indutny
indutnyhttps://github.com/indutny
Mar 31, 2021https://github.com/nodejs/node/pull/38010#issue-847289454
Please reload this pagehttps://github.com/nodejs/node/pull/38010
Please reload this pagehttps://github.com/nodejs/node/pull/38010
https://github.com/indutny
indutnyhttps://github.com/indutny
addaleaxhttps://github.com/addaleax
March 31, 2021 20:33https://github.com/nodejs/node/pull/38010#event-4537231642
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av12.x
Mar 31, 2021https://github.com/nodejs/node/pull/38010#event-4537231950
https://github.com/indutny
indutnyhttps://github.com/indutny
Mar 31, 2021 https://github.com/nodejs/node/pull/38010#ref-issue-608318744
Using worker_threads that keep running indefinitely fails assertion on SIGTERM electron/electron#23315 https://github.com/electron/electron/issues/23315
https://github.com/indutny
indutnyhttps://github.com/indutny
force-pushedhttps://github.com/nodejs/node/compare/b9644337aa22b8b887bb5a3879c4759ec225a804..d248ed310e0c6df7cc3009c7a34ad6f6feb2865c
b964433https://github.com/nodejs/node/commit/b9644337aa22b8b887bb5a3879c4759ec225a804
d248ed3https://github.com/nodejs/node/commit/d248ed310e0c6df7cc3009c7a34ad6f6feb2865c
Compare https://github.com/nodejs/node/compare/b9644337aa22b8b887bb5a3879c4759ec225a804..d248ed310e0c6df7cc3009c7a34ad6f6feb2865c
March 31, 2021 21:06https://github.com/nodejs/node/pull/38010#event-4537394975
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 31, 2021 https://github.com/nodejs/node/pull/38010#pullrequestreview-625728954
View reviewed changes https://github.com/nodejs/node/pull/38010/files
src/env.cchttps://github.com/nodejs/node/pull/38010/files#diff-c546570c652a65d182b5c452e071328cdc3599e39b4bc390879b5c15dd545d58
Please reload this pagehttps://github.com/nodejs/node/pull/38010
https://github.com/indutny
src: move CHECK in AddIsolateFinishedCallbackhttps://github.com/nodejs/node/pull/38010/commits/ad7f207e43ec2bc2fe1d78cf8118120a84cd9826
ad7f207https://github.com/nodejs/node/pull/38010/commits/ad7f207e43ec2bc2fe1d78cf8118120a84cd9826
https://github.com/indutny
indutnyhttps://github.com/indutny
force-pushedhttps://github.com/nodejs/node/compare/d248ed310e0c6df7cc3009c7a34ad6f6feb2865c..ad7f207e43ec2bc2fe1d78cf8118120a84cd9826
d248ed3https://github.com/nodejs/node/commit/d248ed310e0c6df7cc3009c7a34ad6f6feb2865c
ad7f207https://github.com/nodejs/node/commit/ad7f207e43ec2bc2fe1d78cf8118120a84cd9826
Compare https://github.com/nodejs/node/compare/d248ed310e0c6df7cc3009c7a34ad6f6feb2865c..ad7f207e43ec2bc2fe1d78cf8118120a84cd9826
March 31, 2021 21:57https://github.com/nodejs/node/pull/38010#event-4537630504
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 31, 2021 https://github.com/nodejs/node/pull/38010#pullrequestreview-625752015
View reviewed changes https://github.com/nodejs/node/pull/38010/files/ad7f207e43ec2bc2fe1d78cf8118120a84cd9826
https://github.com/indutny
indutnyhttps://github.com/indutny
Mar 31, 2021https://github.com/nodejs/node/pull/38010#event-4537632394
https://github.com/indutny
indutnyhttps://github.com/indutny
Mar 31, 2021https://github.com/nodejs/node/pull/38010#issuecomment-811494046
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/38010
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Mar 31, 2021 https://github.com/nodejs/node/pull/38010#pullrequestreview-625754266
View reviewed changes https://github.com/nodejs/node/pull/38010/files/ad7f207e43ec2bc2fe1d78cf8118120a84cd9826
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 28, 2021 https://github.com/nodejs/node/pull/38010#pullrequestreview-647565109
View reviewed changes https://github.com/nodejs/node/pull/38010/files/ad7f207e43ec2bc2fe1d78cf8118120a84cd9826
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 28, 2021https://github.com/nodejs/node/pull/38010#issuecomment-828757507
https://ci.nodejs.org/job/node-test-pull-request/37786/https://ci.nodejs.org/job/node-test-pull-request/37786/
Please reload this pagehttps://github.com/nodejs/node/pull/38010
https://github.com/jasnell
jasnellhttps://github.com/jasnell
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Apr 28, 2021https://github.com/nodejs/node/pull/38010#event-4659090631
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 30, 2021https://github.com/nodejs/node/pull/38010#event-4670989045
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 30, 2021https://github.com/nodejs/node/pull/38010#issuecomment-830264019
Please reload this pagehttps://github.com/nodejs/node/pull/38010
richardlauhttps://github.com/richardlau
Jul 23, 2021 https://github.com/nodejs/node/pull/38010#ref-commit-8a9f949
https://github.com/indutny
https://github.com/richardlau
src: move CHECK in AddIsolateFinishedCallbackhttps://github.com/nodejs/node/commit/8a9f9491a0b238245c45e18baa802cef69180446
8a9f949https://github.com/nodejs/node/commit/8a9f9491a0b238245c45e18baa802cef69180446
#38010https://github.com/nodejs/node/pull/38010
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 23, 2021https://github.com/nodejs/node/pull/38010#issuecomment-885568336
8a9f949https://github.com/nodejs/node/commit/8a9f9491a0b238245c45e18baa802cef69180446
Please reload this pagehttps://github.com/nodejs/node/pull/38010
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 23, 2021https://github.com/nodejs/node/pull/38010#event-5060518565
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 23, 2021 https://github.com/nodejs/node/pull/38010#ref-pullrequest-951746328
v12.22.4 proposal #39500 https://github.com/nodejs/node/pull/39500
guybedfordhttps://github.com/guybedford
Jul 26, 2021 https://github.com/nodejs/node/pull/38010#ref-commit-32ff10c
https://github.com/indutny
https://github.com/guybedford
src: move CHECK in AddIsolateFinishedCallbackhttps://github.com/nodejs/node/commit/32ff10cf6bb5a5cea1e364791ab4e699f4a8c31c
32ff10chttps://github.com/nodejs/node/commit/32ff10cf6bb5a5cea1e364791ab4e699f4a8c31c
#38010https://github.com/nodejs/node/pull/38010
richardlauhttps://github.com/richardlau
Jul 26, 2021 https://github.com/nodejs/node/pull/38010#ref-commit-f552c45
https://github.com/indutny
https://github.com/richardlau
src: move CHECK in AddIsolateFinishedCallbackhttps://github.com/nodejs/node/commit/f552c456769b3611cf182f91d6a0f8087bd66f02
f552c45https://github.com/nodejs/node/commit/f552c456769b3611cf182f91d6a0f8087bd66f02
#38010https://github.com/nodejs/node/pull/38010
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F38010
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/38010/files/ad7f207e43ec2bc2fe1d78cf8118120a84cd9826
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/38010/files/ad7f207e43ec2bc2fe1d78cf8118120a84cd9826
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/38010/files/ad7f207e43ec2bc2fe1d78cf8118120a84cd9826
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/38010
https://github.com/indutny
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/richardlau
https://github.com/addaleax
https://github.com/cjihrig
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.