| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d4b47b30-2cfe-e55b-3ed6-8f452cc8f103 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DB72:54966:90D38A:D5F2E3:6A4E1AF7 |
| html-safe-nonce | 53b5f96af8352fdcc29c9e6988bf1018892cb5d47e3e5f79f94a26cfc0efe039 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjcyOjU0OTY2OjkwRDM4QTpENUYyRTM6NkE0RTFBRjciLCJ2aXNpdG9yX2lkIjoiNzYwMzUxNjk3OTY5Mzg4NjE5OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 44e9c5bc897cb128f1f04bd21873d82308765ccd9d4f93bf66d6d77d2931dd26 |
| hovercard-subject-tag | pull_request:603681652 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/37985/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e71b1b2a6a09328c9792fe717206852842c19a0acda4f7eaef9767f3c1cbb6fb/nodejs/node/pull/37985 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e71b1b2a6a09328c9792fe717206852842c19a0acda4f7eaef9767f3c1cbb6fb/nodejs/node/pull/37985 |
| og:image:alt | This backports both #37865 and 8e46568 for v15.x.
//cc @ruyadorno |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | guybedford |
| hostname | github.com |
| expected-hostname | github.com |
| None | 030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5fe497b4815fcce3df76c0e246faa739a82c3124 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/37985#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37985 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37985 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/37985 |
| Reload | https://github.com/nodejs/node/pull/37985 |
| Reload | https://github.com/nodejs/node/pull/37985 |
| Please reload this page | https://github.com/nodejs/node/pull/37985 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/37985 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
964
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| guybedford | https://github.com/guybedford |
| nodejs:v15.x-staging | https://github.com/nodejs/node/tree/v15.x-staging |
| guybedford:v8-cycle-fix-backport-15 | https://github.com/guybedford/node/tree/v8-cycle-fix-backport-15 |
| Conversation | https://github.com/nodejs/node/pull/37985 |
| Commits2 (2) | https://github.com/nodejs/node/pull/37985/commits |
| Checks | https://github.com/nodejs/node/pull/37985/checks |
| Files changed | https://github.com/nodejs/node/pull/37985/files |
| [v15.x] deps: V8 cycle fix & parent ordering backports | https://github.com/nodejs/node/pull/37985#top |
| guybedford | https://github.com/guybedford |
| nodejs:v15.x-staging | https://github.com/nodejs/node/tree/v15.x-staging |
| guybedford:v8-cycle-fix-backport-15 | https://github.com/guybedford/node/tree/v8-cycle-fix-backport-15 |
|
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| Mar 30, 2021 | https://github.com/nodejs/node/pull/37985#issue-844435720 |
| #37865 | https://github.com/nodejs/node/pull/37865 |
| 8e46568 | https://github.com/nodejs/node/commit/8e46568b1e12fe00581b1292bd6c2b01373f17bd |
| @ruyadorno | https://github.com/ruyadorno |
| Please reload this page | https://github.com/nodejs/node/pull/37985 |
|
| https://github.com/guybedford |
| deps: v8 backport 9689b17687b | https://github.com/nodejs/node/pull/37985/commits/abe04be74b36635fceee92062b0b160c2ee2d21d |
| abe04be | https://github.com/nodejs/node/pull/37985/commits/abe04be74b36635fceee92062b0b160c2ee2d21d |
| http://github.com/v8/v8/commit/9689b17687b21c800c3f7400df4255c55b9c6ec0 | http://github.com/v8/v8/commit/9689b17687b21c800c3f7400df4255c55b9c6ec0 |
| nodejs#37865 | https://github.com/nodejs/node/pull/37865 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
v15.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av15.x |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Mar 30, 2021 | https://github.com/nodejs/node/pull/37985#event-4527114080 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
|
Mar 30, 2021
| https://github.com/nodejs/node/pull/37985#ref-pullrequest-837906423 |
|
deps: V8 backport for f19142e6
#37864
| https://github.com/nodejs/node/pull/37864 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37985 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| force-pushed | https://github.com/nodejs/node/compare/b2fb40e44efadc86e1eee1621ee016111b2cfe62..e3e5b8b5d288c9034c2c6d4a9d86478273164fda |
| b2fb40e | https://github.com/nodejs/node/commit/b2fb40e44efadc86e1eee1621ee016111b2cfe62 |
| e3e5b8b | https://github.com/nodejs/node/commit/e3e5b8b5d288c9034c2c6d4a9d86478273164fda |
|
Compare
| https://github.com/nodejs/node/compare/b2fb40e44efadc86e1eee1621ee016111b2cfe62..e3e5b8b5d288c9034c2c6d4a9d86478273164fda |
| March 30, 2021 12:20 | https://github.com/nodejs/node/pull/37985#event-4527214074 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37985 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| force-pushed | https://github.com/nodejs/node/compare/e3e5b8b5d288c9034c2c6d4a9d86478273164fda..1d53fe73266d180c40db3e0a040ea96c33a50d17 |
| e3e5b8b | https://github.com/nodejs/node/commit/e3e5b8b5d288c9034c2c6d4a9d86478273164fda |
| 1d53fe7 | https://github.com/nodejs/node/commit/1d53fe73266d180c40db3e0a040ea96c33a50d17 |
|
Compare
| https://github.com/nodejs/node/compare/e3e5b8b5d288c9034c2c6d4a9d86478273164fda..1d53fe73266d180c40db3e0a040ea96c33a50d17 |
| March 30, 2021 15:35 | https://github.com/nodejs/node/pull/37985#event-4528585812 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37985 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37985 |
|
| https://github.com/guybedford |
| deps: backport v8 f19142e6 | https://github.com/nodejs/node/pull/37985/commits/d68be4a394bc0105576cfbed206d4a69bac18200 |
| d68be4a | https://github.com/nodejs/node/pull/37985/commits/d68be4a394bc0105576cfbed206d4a69bac18200 |
| v8/v8@f19142e | https://github.com/v8/v8/commit/f19142e6139979da3a177cb0b9f382e459f5ccec |
| nodejs#37864 | https://github.com/nodejs/node/pull/37864 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| force-pushed | https://github.com/nodejs/node/compare/1d53fe73266d180c40db3e0a040ea96c33a50d17..d68be4a394bc0105576cfbed206d4a69bac18200 |
| 1d53fe7 | https://github.com/nodejs/node/commit/1d53fe73266d180c40db3e0a040ea96c33a50d17 |
| d68be4a | https://github.com/nodejs/node/commit/d68be4a394bc0105576cfbed206d4a69bac18200 |
|
Compare
| https://github.com/nodejs/node/compare/1d53fe73266d180c40db3e0a040ea96c33a50d17..d68be4a394bc0105576cfbed206d4a69bac18200 |
| March 30, 2021 18:28 | https://github.com/nodejs/node/pull/37985#event-4529583751 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37985 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Mar 30, 2021 | https://github.com/nodejs/node/pull/37985#issuecomment-810628171 |
| https://ci.nodejs.org/job/node-test-pull-request/37067/ | https://ci.nodejs.org/job/node-test-pull-request/37067/ |
| Please reload this page | https://github.com/nodejs/node/pull/37985 |
| https://github.com/ruyadorno |
| ruyadorno | https://github.com/ruyadorno |
|
Mar 31, 2021
| https://github.com/nodejs/node/pull/37985#pullrequestreview-624837032 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/37985/files/d68be4a394bc0105576cfbed206d4a69bac18200 |
| ruyadorno | https://github.com/ruyadorno |
|
Mar 31, 2021
| https://github.com/nodejs/node/pull/37985#ref-commit-2fd97ce |
|
| https://github.com/guybedford |
|
| https://github.com/ruyadorno |
| deps: v8 backport 9689b17687b | https://github.com/nodejs/node/commit/2fd97ce687c7656a9f44daef574c2c47665ebd41 |
| 2fd97ce | https://github.com/nodejs/node/commit/2fd97ce687c7656a9f44daef574c2c47665ebd41 |
| http://github.com/v8/v8/commit/9689b17687b21c800c3f7400df4255c55b9c6ec0 | http://github.com/v8/v8/commit/9689b17687b21c800c3f7400df4255c55b9c6ec0 |
| #37865 | https://github.com/nodejs/node/pull/37865 |
| #37985 | https://github.com/nodejs/node/pull/37985 |
| ruyadorno | https://github.com/ruyadorno |
|
Mar 31, 2021
| https://github.com/nodejs/node/pull/37985#ref-commit-f09c033 |
|
| https://github.com/guybedford |
|
| https://github.com/ruyadorno |
| deps: backport v8 f19142e6 | https://github.com/nodejs/node/commit/f09c033fafe9835814387ed71999b97745388b59 |
| f09c033 | https://github.com/nodejs/node/commit/f09c033fafe9835814387ed71999b97745388b59 |
| v8/v8@f19142e | https://github.com/v8/v8/commit/f19142e6139979da3a177cb0b9f382e459f5ccec |
| #37864 | https://github.com/nodejs/node/pull/37864 |
| #37985 | https://github.com/nodejs/node/pull/37985 |
| https://github.com/ruyadorno |
| ruyadorno | https://github.com/ruyadorno |
| Mar 31, 2021 | https://github.com/nodejs/node/pull/37985#issuecomment-810704361 |
| 2fd97ce | https://github.com/nodejs/node/commit/2fd97ce687c7656a9f44daef574c2c47665ebd41 |
| f09c033 | https://github.com/nodejs/node/commit/f09c033fafe9835814387ed71999b97745388b59 |
| Please reload this page | https://github.com/nodejs/node/pull/37985 |
| https://github.com/ruyadorno |
| ruyadorno | https://github.com/ruyadorno |
| Mar 31, 2021 | https://github.com/nodejs/node/pull/37985#event-4531473574 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37985 |
|
| https://github.com/ruyadorno |
|
ruyadorno
| https://github.com/ruyadorno |
|
| https://github.com/nodejs/node/pull/37985/files/d68be4a394bc0105576cfbed206d4a69bac18200 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Please reload this page | https://github.com/nodejs/node/pull/37985 |
|
| https://github.com/guybedford |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/ruyadorno |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |