René's URL Explorer Experiment


Title: [v14.x] Backport environment teardown Node-API reference double free fixes by gabrielschulhof · Pull Request #37802 · nodejs/node · GitHub

Open Graph Title: [v14.x] Backport environment teardown Node-API reference double free fixes by gabrielschulhof · Pull Request #37802 · nodejs/node

X Title: [v14.x] Backport environment teardown Node-API reference double free fixes by gabrielschulhof · Pull Request #37802 · nodejs/node

Description: These two fixes are necessary in order to prevent an issue on v14.x whereby a gc happens during environment shutdown causing a double free of a Node-API reference.

Open Graph Description: These two fixes are necessary in order to prevent an issue on v14.x whereby a gc happens during environment shutdown causing a double free of a Node-API reference.

X Description: These two fixes are necessary in order to prevent an issue on v14.x whereby a gc happens during environment shutdown causing a double free of a Node-API reference.

Opengraph URL: https://github.com/nodejs/node/pull/37802

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:87600e66-a328-bccc-a25a-451d16d74240
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8264:27420E:357FE0D:4761805:6A655767
html-safe-nonce8f3bb25f3e8939d0aca5cd9bb801ecf5d37bba019040473adfbf79c53b5a2b38
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjY0OjI3NDIwRTozNTdGRTBEOjQ3NjE4MDU6NkE2NTU3NjciLCJ2aXNpdG9yX2lkIjoiMjAxNjU5NzIyMjk3Mzg1NTU5MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc577376e1da3e1ea9e4da30c31a69529bfffd906a6f6122f3773469fed08322d
hovercard-subject-tagpull_request:596176409
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/37802/commits/466d76826dc83874e24901733aa7b8ad842fcca2
twitter:imagehttps://avatars.githubusercontent.com/u/976081?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/976081?s=400&v=4
og:image:altThese two fixes are necessary in order to prevent an issue on v14.x whereby a gc happens during environment shutdown causing a double free of a Node-API reference.
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None52c76df668885aaff23b50bdca1fa1ea44ac9c1553e888ebc70ff1e4daa4625b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release309153364422b3c499922d1a2a6404910a58ed8e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/37802/commits/466d76826dc83874e24901733aa7b8ad842fcca2#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37802%2Fcommits%2F466d76826dc83874e24901733aa7b8ad842fcca2
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37802%2Fcommits%2F466d76826dc83874e24901733aa7b8ad842fcca2
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/37802/commits/466d76826dc83874e24901733aa7b8ad842fcca2
Reloadhttps://github.com/nodejs/node/pull/37802/commits/466d76826dc83874e24901733aa7b8ad842fcca2
Reloadhttps://github.com/nodejs/node/pull/37802/commits/466d76826dc83874e24901733aa7b8ad842fcca2
Please reload this pagehttps://github.com/nodejs/node/pull/37802/commits/466d76826dc83874e24901733aa7b8ad842fcca2
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/37802/commits/466d76826dc83874e24901733aa7b8ad842fcca2
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 1.1k https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
gabrielschulhofhttps://github.com/gabrielschulhof
nodejs:v14.x-staginghttps://github.com/nodejs/node/tree/v14.x-staging
gabrielschulhof:backport-teardown-gc-ref-fix-to-v14.xhttps://github.com/gabrielschulhof/node/tree/backport-teardown-gc-ref-fix-to-v14.x
Conversation 14 https://github.com/nodejs/node/pull/37802
Commits 3 https://github.com/nodejs/node/pull/37802/commits
Checks 0 https://github.com/nodejs/node/pull/37802/checks
Files changed https://github.com/nodejs/node/pull/37802/files
Please reload this pagehttps://github.com/nodejs/node/pull/37802/commits/466d76826dc83874e24901733aa7b8ad842fcca2
[v14.x] Backport environment teardown Node-API reference double free fixes https://github.com/nodejs/node/pull/37802/commits/466d76826dc83874e24901733aa7b8ad842fcca2#top
Show all changes 3 commits https://github.com/nodejs/node/pull/37802/files
82b6116 node-api: force env shutdown deferring behavior Feb 10, 2021 https://github.com/nodejs/node/pull/37802/commits/82b6116e0bedb06444c0cef22fc89a315ab88a49
466d768 node-api: stop ref gc during environment teardown gabrielschulhof Mar 4, 2021 https://github.com/nodejs/node/pull/37802/commits/466d76826dc83874e24901733aa7b8ad842fcca2
180c33d node-api: fix crash in finalization mhdawson Mar 23, 2021 https://github.com/nodejs/node/pull/37802/commits/180c33dbd446dfe251ea475f72b927a0f6802641
Clear filters https://github.com/nodejs/node/pull/37802/commits/466d76826dc83874e24901733aa7b8ad842fcca2
Please reload this pagehttps://github.com/nodejs/node/pull/37802/commits/466d76826dc83874e24901733aa7b8ad842fcca2
Please reload this pagehttps://github.com/nodejs/node/pull/37802/commits/466d76826dc83874e24901733aa7b8ad842fcca2
js_native_api_v8.cc https://github.com/nodejs/node/pull/37802/commits/466d76826dc83874e24901733aa7b8ad842fcca2#diff-4b35cbf831be523a4f3e5aac3729c95490ed220892695d0e4245c15c1f63cfc1
binding.c https://github.com/nodejs/node/pull/37802/commits/466d76826dc83874e24901733aa7b8ad842fcca2#diff-15ec9f8fa92e344ed4296424e63c2cb6ac84339de91bbfb00cd6dc9db6a1ec87
binding.gyp https://github.com/nodejs/node/pull/37802/commits/466d76826dc83874e24901733aa7b8ad842fcca2#diff-6ed637e484ed018d2ac0712bd3f1eebeccde26ccd752c9e4f7cf438237564858
test.js https://github.com/nodejs/node/pull/37802/commits/466d76826dc83874e24901733aa7b8ad842fcca2#diff-71b6b5a953286af4eee09fda3506c51fdd959f56859b35c0c6dfc1966590c7d0
Prev https://github.com/nodejs/node/pull/37802/commits/82b6116e0bedb06444c0cef22fc89a315ab88a49
Next https://github.com/nodejs/node/pull/37802/commits/180c33dbd446dfe251ea475f72b927a0f6802641
#37236https://github.com/nodejs/node/issues/37236
#37616https://github.com/nodejs/node/pull/37616
Please reload this pagehttps://github.com/nodejs/node/pull/37802/commits/466d76826dc83874e24901733aa7b8ad842fcca2
https://github.com/gabrielschulhof
https://github.com/targos
gabrielschulhofhttps://github.com/nodejs/node/commits?author=gabrielschulhof
targoshttps://github.com/nodejs/node/commits?author=targos
src/js_native_api_v8.cchttps://github.com/nodejs/node/pull/37802/commits/466d76826dc83874e24901733aa7b8ad842fcca2#diff-4b35cbf831be523a4f3e5aac3729c95490ed220892695d0e4245c15c1f63cfc1
View file https://github.com/gabrielschulhof/node/blob/466d76826dc83874e24901733aa7b8ad842fcca2/src/js_native_api_v8.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/37802/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/37802/commits/466d76826dc83874e24901733aa7b8ad842fcca2#diff-4b35cbf831be523a4f3e5aac3729c95490ed220892695d0e4245c15c1f63cfc1
https://github.com/nodejs/node/pull/37802/commits/466d76826dc83874e24901733aa7b8ad842fcca2#diff-4b35cbf831be523a4f3e5aac3729c95490ed220892695d0e4245c15c1f63cfc1
https://github.com/nodejs/node/pull/37802/commits/466d76826dc83874e24901733aa7b8ad842fcca2#diff-4b35cbf831be523a4f3e5aac3729c95490ed220892695d0e4245c15c1f63cfc1
https://github.com/nodejs/node/pull/37802/commits/466d76826dc83874e24901733aa7b8ad842fcca2#diff-4b35cbf831be523a4f3e5aac3729c95490ed220892695d0e4245c15c1f63cfc1
https://github.com/nodejs/node/pull/37802/commits/466d76826dc83874e24901733aa7b8ad842fcca2#diff-4b35cbf831be523a4f3e5aac3729c95490ed220892695d0e4245c15c1f63cfc1
test/node-api/test_env_teardown_gc/binding.chttps://github.com/nodejs/node/pull/37802/commits/466d76826dc83874e24901733aa7b8ad842fcca2#diff-15ec9f8fa92e344ed4296424e63c2cb6ac84339de91bbfb00cd6dc9db6a1ec87
View file https://github.com/gabrielschulhof/node/blob/466d76826dc83874e24901733aa7b8ad842fcca2/test/node-api/test_env_teardown_gc/binding.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/37802/commits/{{ revealButtonHref }}
test/node-api/test_env_teardown_gc/binding.gyphttps://github.com/nodejs/node/pull/37802/commits/466d76826dc83874e24901733aa7b8ad842fcca2#diff-6ed637e484ed018d2ac0712bd3f1eebeccde26ccd752c9e4f7cf438237564858
View file https://github.com/gabrielschulhof/node/blob/466d76826dc83874e24901733aa7b8ad842fcca2/test/node-api/test_env_teardown_gc/binding.gyp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/37802/commits/{{ revealButtonHref }}
test/node-api/test_env_teardown_gc/test.jshttps://github.com/nodejs/node/pull/37802/commits/466d76826dc83874e24901733aa7b8ad842fcca2#diff-71b6b5a953286af4eee09fda3506c51fdd959f56859b35c0c6dfc1966590c7d0
View file https://github.com/gabrielschulhof/node/blob/466d76826dc83874e24901733aa7b8ad842fcca2/test/node-api/test_env_teardown_gc/test.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/37802/commits/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.