| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b7c23455-67b9-d2d5-3c18-ba27e0fcf5a9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C86A:21908E:64F6E7:8804F8:6A4DA700 |
| html-safe-nonce | 771ad74af2196ced67cf5a59ce488c11a1d54dc8cdcf79c0d1d21020c8dd97c9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDODZBOjIxOTA4RTo2NEY2RTc6ODgwNEY4OjZBNERBNzAwIiwidmlzaXRvcl9pZCI6Ijc3MjM0OTA5MDM5MjMyMDU4ODgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 4dd7dd08c9ee76ec7aa87585bf74f0dcb5faada6bede6d1ab33777f065713fa7 |
| hovercard-subject-tag | pull_request:596176409 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/37802/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/346a5a32f926ebe5a576c227371fff2d9a2139c51ef6c73132ff45c161e6ec20/nodejs/node/pull/37802 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/346a5a32f926ebe5a576c227371fff2d9a2139c51ef6c73132ff45c161e6ec20/nodejs/node/pull/37802 |
| og:image:alt | These two fixes are necessary in order to prevent an issue on v14.x whereby a gc happens during environment shutdown causing a double free of a Node-API reference. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gabrielschulhof |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 47723578ce6819210724ef064c858fce6d3115a3 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/37802#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37802 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37802 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/37802 |
| Reload | https://github.com/nodejs/node/pull/37802 |
| Reload | https://github.com/nodejs/node/pull/37802 |
| Please reload this page | https://github.com/nodejs/node/pull/37802 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/37802 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
962
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs:v14.x-staging | https://github.com/nodejs/node/tree/v14.x-staging |
| gabrielschulhof:backport-teardown-gc-ref-fix-to-v14.x | https://github.com/gabrielschulhof/node/tree/backport-teardown-gc-ref-fix-to-v14.x |
| Conversation | https://github.com/nodejs/node/pull/37802 |
| Commits3 (3) | https://github.com/nodejs/node/pull/37802/commits |
| Checks | https://github.com/nodejs/node/pull/37802/checks |
| Files changed | https://github.com/nodejs/node/pull/37802/files |
| [v14.x] Backport environment teardown Node-API reference double free fixes | https://github.com/nodejs/node/pull/37802#top |
| gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs:v14.x-staging | https://github.com/nodejs/node/tree/v14.x-staging |
| gabrielschulhof:backport-teardown-gc-ref-fix-to-v14.x | https://github.com/gabrielschulhof/node/tree/backport-teardown-gc-ref-fix-to-v14.x |
|
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Mar 19, 2021 | https://github.com/nodejs/node/pull/37802#issue-835530153 |
| Please reload this page | https://github.com/nodejs/node/pull/37802 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
|
v14.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av14.x |
| Mar 19, 2021 | https://github.com/nodejs/node/pull/37802#event-4479934632 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| legendecas | https://github.com/legendecas |
| mhdawson | https://github.com/mhdawson |
| March 19, 2021 03:56 | https://github.com/nodejs/node/pull/37802#event-4479934638 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Mar 19, 2021 | https://github.com/nodejs/node/pull/37802#event-4479934789 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Mar 19, 2021 | https://github.com/nodejs/node/pull/37802#event-4479935007 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| force-pushed | https://github.com/nodejs/node/compare/90834544f5e8740f6f2eb130b1e59cc43f77da71..e31b2e33f0adf1f1ba3b08411a9eee3c4922cf95 |
| 9083454 | https://github.com/nodejs/node/commit/90834544f5e8740f6f2eb130b1e59cc43f77da71 |
| e31b2e3 | https://github.com/nodejs/node/commit/e31b2e33f0adf1f1ba3b08411a9eee3c4922cf95 |
|
Compare
| https://github.com/nodejs/node/compare/90834544f5e8740f6f2eb130b1e59cc43f77da71..e31b2e33f0adf1f1ba3b08411a9eee3c4922cf95 |
| March 19, 2021 04:26 | https://github.com/nodejs/node/pull/37802#event-4480011859 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
|
Mar 19, 2021
| https://github.com/nodejs/node/pull/37802#pullrequestreview-616063637 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/37802/files |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Mar 19, 2021
| https://github.com/nodejs/node/pull/37802#pullrequestreview-616521422 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/37802/files |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node/pull/37802#pullrequestreview-616521422 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/37802 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Mar 22, 2021
| https://github.com/nodejs/node/pull/37802#pullrequestreview-618033559 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/37802/files |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node/pull/37802#pullrequestreview-618033559 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| nodejs/node-addon-api#906 | https://github.com/nodejs/node-addon-api/issues/906 |
| Please reload this page | https://github.com/nodejs/node/pull/37802 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Mar 22, 2021
| https://github.com/nodejs/node/pull/37802#ref-issue-807567523 |
|
Intermittent failure in ThreadSafe function
nodejs/node-addon-api#906
| https://github.com/nodejs/node-addon-api/issues/906 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Mar 23, 2021 | https://github.com/nodejs/node/pull/37802#issuecomment-804545475 |
| @legendecas | https://github.com/legendecas |
| #37236 | https://github.com/nodejs/node/issues/37236 |
| @mhdawson | https://github.com/mhdawson |
| Please reload this page | https://github.com/nodejs/node/pull/37802 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Mar 25, 2021 | https://github.com/nodejs/node/pull/37802#issuecomment-806764997 |
| Please reload this page | https://github.com/nodejs/node/pull/37802 |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs/node-addon-api#906 | https://github.com/nodejs/node-addon-api/issues/906 |
| #37876 | https://github.com/nodejs/node/pull/37876 |
| Please reload this page | https://github.com/nodejs/node/pull/37802 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Mar 25, 2021
| https://github.com/nodejs/node/pull/37802#pullrequestreview-621228717 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/37802/files |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node/pull/37802#pullrequestreview-621228717 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/37802 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
| Mar 26, 2021 | https://github.com/nodejs/node/pull/37802#issuecomment-808138030 |
| Please reload this page | https://github.com/nodejs/node/pull/37802 |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| @mhdawson | https://github.com/mhdawson |
| Please reload this page | https://github.com/nodejs/node/pull/37802 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Mar 26, 2021 | https://github.com/nodejs/node/pull/37802#issuecomment-808287860 |
| @legendecas | https://github.com/legendecas |
| @mhdawson | https://github.com/mhdawson |
| #37876 | https://github.com/nodejs/node/pull/37876 |
| @legendecas | https://github.com/legendecas |
| @mhdawson | https://github.com/mhdawson |
| Please reload this page | https://github.com/nodejs/node/pull/37802 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
| Mar 29, 2021 | https://github.com/nodejs/node/pull/37802#issuecomment-809146316 |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| https://github.com/nodejs/node/blob/master/deps/v8/src/handles/global-handles.cc#L532 | https://github.com/nodejs/node/blob/master/deps/v8/src/handles/global-handles.cc#L532 |
| https://github.com/nodejs/node/blob/master/deps/v8/src/handles/global-handles.cc#L1387 | https://github.com/nodejs/node/blob/master/deps/v8/src/handles/global-handles.cc#L1387 |
| Please reload this page | https://github.com/nodejs/node/pull/37802 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
|
Mar 31, 2021
| https://github.com/nodejs/node/pull/37802#pullrequestreview-625057863 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/37802/files |
| src/js_native_api_v8.cc | https://github.com/nodejs/node/pull/37802/files#diff-4b35cbf831be523a4f3e5aac3729c95490ed220892695d0e4245c15c1f63cfc1 |
| legendecas | https://github.com/legendecas |
| Mar 31, 2021 | https://github.com/nodejs/node/pull/37802#discussion_r604722450 |
| Please reload this page | https://github.com/nodejs/node/pull/37802 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| _persistent.IsWeak() | https://github.com/nodejs/node/blob/master/deps/v8/include/v8.h#L11122 |
| https://bugs.chromium.org/p/v8/issues/detail?id=11608 | https://bugs.chromium.org/p/v8/issues/detail?id=11608 |
| Please reload this page | https://github.com/nodejs/node/pull/37802 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
|
Mar 31, 2021
| https://github.com/nodejs/node/pull/37802#ref-pullrequest-846460375 |
|
node-api: make reference weak parameter an indirect link to references
#38000
| https://github.com/nodejs/node/pull/38000 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/11505adecef0ed3baed709c6fa1a0872e9ed26a6..6b115d762dfeece2f3951a65b520d3a64213e2cf |
| 11505ad | https://github.com/nodejs/node/commit/11505adecef0ed3baed709c6fa1a0872e9ed26a6 |
| 6b115d7 | https://github.com/nodejs/node/commit/6b115d762dfeece2f3951a65b520d3a64213e2cf |
|
Compare
| https://github.com/nodejs/node/compare/11505adecef0ed3baed709c6fa1a0872e9ed26a6..6b115d762dfeece2f3951a65b520d3a64213e2cf |
| April 6, 2021 19:54 | https://github.com/nodejs/node/pull/37802#event-4558790940 |
| April 24, 2021 14:55 | https://github.com/nodejs/node/pull/37802#commits-pushed-82b6116 |
|
| https://github.com/legendecas |
|
| https://github.com/targos |
| node-api: force env shutdown deferring behavior | https://github.com/nodejs/node/pull/37802/commits/82b6116e0bedb06444c0cef22fc89a315ab88a49 |
| 82b6116 | https://github.com/nodejs/node/pull/37802/commits/82b6116e0bedb06444c0cef22fc89a315ab88a49 |
| nodejs#37236 | https://github.com/nodejs/node/issues/37236 |
| nodejs#37303 | https://github.com/nodejs/node/pull/37303 |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/targos |
| node-api: stop ref gc during environment teardown | https://github.com/nodejs/node/pull/37802/commits/466d76826dc83874e24901733aa7b8ad842fcca2 |
| 466d768 | https://github.com/nodejs/node/pull/37802/commits/466d76826dc83874e24901733aa7b8ad842fcca2 |
| nodejs#37236 | https://github.com/nodejs/node/issues/37236 |
| nodejs#37616 | https://github.com/nodejs/node/pull/37616 |
|
| https://github.com/mhdawson |
|
| https://github.com/targos |
| node-api: fix crash in finalization | https://github.com/nodejs/node/pull/37802/commits/180c33dbd446dfe251ea475f72b927a0f6802641 |
| 180c33d | https://github.com/nodejs/node/pull/37802/commits/180c33dbd446dfe251ea475f72b927a0f6802641 |
| nodejs/node-addon-api#906 | https://github.com/nodejs/node-addon-api/issues/906 |
| nodejs#37616 | https://github.com/nodejs/node/pull/37616 |
| nodejs#37616 | https://github.com/nodejs/node/pull/37616 |
| nodejs#37876 | https://github.com/nodejs/node/pull/37876 |
| https://github.com/targos |
| targos | https://github.com/targos |
| force-pushed | https://github.com/nodejs/node/compare/fecc3f481dd297d9cd6bf0740122a3d9ed87ceda..180c33dbd446dfe251ea475f72b927a0f6802641 |
| fecc3f4 | https://github.com/nodejs/node/commit/fecc3f481dd297d9cd6bf0740122a3d9ed87ceda |
| 180c33d | https://github.com/nodejs/node/commit/180c33dbd446dfe251ea475f72b927a0f6802641 |
|
Compare
| https://github.com/nodejs/node/compare/fecc3f481dd297d9cd6bf0740122a3d9ed87ceda..180c33dbd446dfe251ea475f72b927a0f6802641 |
| April 24, 2021 12:55 | https://github.com/nodejs/node/pull/37802#event-4639923393 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 24, 2021 | https://github.com/nodejs/node/pull/37802#issuecomment-826088971 |
| https://ci.nodejs.org/job/node-test-pull-request/37660/ | https://ci.nodejs.org/job/node-test-pull-request/37660/ |
| Please reload this page | https://github.com/nodejs/node/pull/37802 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 25, 2021 | https://github.com/nodejs/node/pull/37802#issuecomment-826259841 |
| https://ci.nodejs.org/job/node-test-pull-request/37683/ | https://ci.nodejs.org/job/node-test-pull-request/37683/ |
| Please reload this page | https://github.com/nodejs/node/pull/37802 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 26, 2021 | https://github.com/nodejs/node/pull/37802#issuecomment-826427563 |
| https://ci.nodejs.org/job/node-test-pull-request/37720/ | https://ci.nodejs.org/job/node-test-pull-request/37720/ |
| Please reload this page | https://github.com/nodejs/node/pull/37802 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 26, 2021 | https://github.com/nodejs/node/pull/37802#issuecomment-826583581 |
| https://ci.nodejs.org/job/node-test-pull-request/37728/ | https://ci.nodejs.org/job/node-test-pull-request/37728/ |
| Please reload this page | https://github.com/nodejs/node/pull/37802 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Apr 26, 2021 | https://github.com/nodejs/node/pull/37802#issuecomment-826728709 |
| 5a3e12b...8413759 | https://github.com/nodejs/node/compare/5a3e12b1eeeb73981ef90c5ad5302338c600aee8...8413759d84ebc7ceb1828a7d17c8232063e1b812 |
| Please reload this page | https://github.com/nodejs/node/pull/37802 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Apr 26, 2021 | https://github.com/nodejs/node/pull/37802#event-4644027975 |
| targos | https://github.com/targos |
|
Apr 26, 2021
| https://github.com/nodejs/node/pull/37802#ref-commit-b5b1ad3 |
|
| https://github.com/legendecas |
|
| https://github.com/targos |
| node-api: force env shutdown deferring behavior | https://github.com/nodejs/node/commit/b5b1ad39dd33f867585e7b84077f2aadfc4c46bd |
| b5b1ad3 | https://github.com/nodejs/node/commit/b5b1ad39dd33f867585e7b84077f2aadfc4c46bd |
| #37236 | https://github.com/nodejs/node/issues/37236 |
| #37303 | https://github.com/nodejs/node/pull/37303 |
| #37802 | https://github.com/nodejs/node/pull/37802 |
| targos | https://github.com/targos |
|
Apr 26, 2021
| https://github.com/nodejs/node/pull/37802#ref-commit-6e01855 |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/targos |
| node-api: stop ref gc during environment teardown | https://github.com/nodejs/node/commit/6e018559dba7d9d2a872c1d9b81bb0fd90f19e03 |
| 6e01855 | https://github.com/nodejs/node/commit/6e018559dba7d9d2a872c1d9b81bb0fd90f19e03 |
| #37236 | https://github.com/nodejs/node/issues/37236 |
| #37616 | https://github.com/nodejs/node/pull/37616 |
| #37802 | https://github.com/nodejs/node/pull/37802 |
| targos | https://github.com/targos |
|
Apr 26, 2021
| https://github.com/nodejs/node/pull/37802#ref-commit-8413759 |
|
| https://github.com/mhdawson |
|
| https://github.com/targos |
| node-api: fix crash in finalization | https://github.com/nodejs/node/commit/8413759d84ebc7ceb1828a7d17c8232063e1b812 |
| 8413759 | https://github.com/nodejs/node/commit/8413759d84ebc7ceb1828a7d17c8232063e1b812 |
| nodejs/node-addon-api#906 | https://github.com/nodejs/node-addon-api/issues/906 |
| #37616 | https://github.com/nodejs/node/pull/37616 |
| #37616 | https://github.com/nodejs/node/pull/37616 |
| #37876 | https://github.com/nodejs/node/pull/37876 |
| #37802 | https://github.com/nodejs/node/pull/37802 |
| https://github.com/deepak1556 |
| deepak1556 | https://github.com/deepak1556 |
|
Dec 9, 2021
| https://github.com/nodejs/node/pull/37802#ref-issue-1075344636 |
|
Crash on shutdown in v8impl::(anonymous namespace)::RefBase::Finalize
microsoft/vscode#138721
| https://github.com/microsoft/vscode/issues/138721 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
|
Mar 27, 2022
| https://github.com/nodejs/node/pull/37802#ref-issue-1172166519 |
|
Node.js 12.x need to cherry-pick https://github.com/nodejs/node/pull/37616
#42376
| https://github.com/nodejs/node/issues/42376 |
|
[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 4.25.1
Rednickle/node-1#71
| https://github.com/Rednickle/node-1/pull/71 |
|
[Snyk] Security upgrade gatsby-plugin-sharp from 2.6.24 to 4.25.1
baby636/node#89
| https://github.com/baby636/node/pull/89 |
| https://github.com/137717unity |
| 137717unity | https://github.com/137717unity |
|
Apr 18, 2023
| https://github.com/nodejs/node/pull/37802#ref-pullrequest-1673903544 |
|
[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 4.25.1
137717unity/node#94
| https://github.com/137717unity/node/pull/94 |
| https://github.com/wedataintelligence |
| wedataintelligence | https://github.com/wedataintelligence |
|
Apr 18, 2023
| https://github.com/nodejs/node/pull/37802#ref-pullrequest-1673962488 |
|
[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 4.25.1
wedataintelligence/node#76
| https://github.com/wedataintelligence/node/pull/76 |
|
[Snyk] Security upgrade gatsby-plugin-sharp from 2.2.13 to 4.25.1
kissofire/node#97
| https://github.com/kissofire/node/pull/97 |
|
[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 4.25.1
molllyn1/node#77
| https://github.com/molllyn1/node/pull/77 |
| https://github.com/ron-a20 |
| ron-a20 | https://github.com/ron-a20 |
|
Apr 19, 2023
| https://github.com/nodejs/node/pull/37802#ref-pullrequest-1674489001 |
|
[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 4.25.1
ron-a20/node#94
| https://github.com/ron-a20/node/pull/94 |
| https://github.com/snyk-bot |
| snyk-bot | https://github.com/snyk-bot |
|
Apr 19, 2023
| https://github.com/nodejs/node/pull/37802#ref-pullrequest-1675762885 |
|
[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 4.25.1
aliceUnhinged613/node#91
| https://github.com/aliceUnhinged613/node/pull/91 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37802 |
|
| https://github.com/legendecas |
|
legendecas
| https://github.com/legendecas |
|
| https://github.com/nodejs/node/pull/37802/files/fecc3f481dd297d9cd6bf0740122a3d9ed87ceda |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/37802/files/e31b2e33f0adf1f1ba3b08411a9eee3c4922cf95 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Please reload this page | https://github.com/nodejs/node/pull/37802 |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/mhdawson |
|
| https://github.com/legendecas |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/targos |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |