René's URL Explorer Experiment


Title: http2: make res.req a normal property by cjihrig · Pull Request #37706 · nodejs/node · GitHub

Open Graph Title: http2: make res.req a normal property by cjihrig · Pull Request #37706 · nodejs/node

X Title: http2: make res.req a normal property by cjihrig · Pull Request #37706 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: The change in #36505 broke userland code that already wrote to res.req. This commit updates the res.req getter in the http2 compat layer to be a normal property. Fixes: #37705

X Description: The change in #36505 broke userland code that already wrote to res.req. This commit updates the res.req getter in the http2 compat layer to be a normal property. Fixes: #37705

Opengraph URL: https://github.com/nodejs/node/pull/37706

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2d85ba03-195c-210d-8ba3-6366a17e896f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD2D8:378B6C:121FA4B:18A9681:6A5215ED
html-safe-nonce51e1d8227c33bcd9f0c58214fa3b066e37aab8d8386b1fe92a455e5588aaced0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkQ4OjM3OEI2QzoxMjFGQTRCOjE4QTk2ODE6NkE1MjE1RUQiLCJ2aXNpdG9yX2lkIjoiNTc1OTI2MTk4Mjc1MTU5Mzk2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb015c17b0c016d2332032e9cf10773de61c693490fe47cf19960c510e8046115
hovercard-subject-tagpull_request:590385186
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/37706/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/49dfa567057f226a7c31b21b4679ee83d5f899c433feff7588dd902772954d28/nodejs/node/pull/37706
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/49dfa567057f226a7c31b21b4679ee83d5f899c433feff7588dd902772954d28/nodejs/node/pull/37706
og:image:altThe change in #36505 broke userland code that already wrote to res.req. This commit updates the res.req getter in the http2 compat layer to be a normal property. Fixes: #37705
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/37706#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37706
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37706
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/37706
Reloadhttps://github.com/nodejs/node/pull/37706
Reloadhttps://github.com/nodejs/node/pull/37706
Please reload this pagehttps://github.com/nodejs/node/pull/37706
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/37706
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.2k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 983 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:getterhttps://github.com/cjihrig/node/tree/getter
Conversationhttps://github.com/nodejs/node/pull/37706
Commits1 (1)https://github.com/nodejs/node/pull/37706/commits
Checkshttps://github.com/nodejs/node/pull/37706/checks
Files changedhttps://github.com/nodejs/node/pull/37706/files
http2: make res.req a normal propertyhttps://github.com/nodejs/node/pull/37706#top
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:getterhttps://github.com/cjihrig/node/tree/getter
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Mar 11, 2021https://github.com/nodejs/node/pull/37706#issue-828595471
#36505https://github.com/nodejs/node/pull/36505
#37705https://github.com/nodejs/node/issues/37705
Please reload this pagehttps://github.com/nodejs/node/pull/37706
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
mmarchinihttps://github.com/mmarchini
March 11, 2021 02:00https://github.com/nodejs/node/pull/37706#event-4440662709
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Mar 11, 2021https://github.com/nodejs/node/pull/37706#event-4440663065
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 11, 2021 https://github.com/nodejs/node/pull/37706#pullrequestreview-609368604
View reviewed changes https://github.com/nodejs/node/pull/37706/files
https://github.com/lpinca
lpincahttps://github.com/lpinca
Mar 11, 2021 https://github.com/nodejs/node/pull/37706#pullrequestreview-609506819
View reviewed changes https://github.com/nodejs/node/pull/37706/files
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Mar 11, 2021 https://github.com/nodejs/node/pull/37706#pullrequestreview-609765539
View reviewed changes https://github.com/nodejs/node/pull/37706/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 11, 2021https://github.com/nodejs/node/pull/37706#issuecomment-796740619
https://ci.nodejs.org/job/node-test-pull-request/36623/https://ci.nodejs.org/job/node-test-pull-request/36623/
Please reload this pagehttps://github.com/nodejs/node/pull/37706
https://github.com/ronag
ronaghttps://github.com/ronag
Mar 11, 2021 https://github.com/nodejs/node/pull/37706#pullrequestreview-610027194
View reviewed changes https://github.com/nodejs/node/pull/37706/files
https://github.com/mmarchini
mmarchinihttps://github.com/mmarchini
Mar 11, 2021 https://github.com/nodejs/node/pull/37706#pullrequestreview-610085240
View reviewed changes https://github.com/nodejs/node/pull/37706/files
https://github.com/Flarna
Flarnahttps://github.com/Flarna
Mar 11, 2021 https://github.com/nodejs/node/pull/37706#pullrequestreview-610289201
View reviewed changes https://github.com/nodejs/node/pull/37706/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 12, 2021https://github.com/nodejs/node/pull/37706#issuecomment-797142854
https://ci.nodejs.org/job/node-test-pull-request/36643/https://ci.nodejs.org/job/node-test-pull-request/36643/
Please reload this pagehttps://github.com/nodejs/node/pull/37706
https://github.com/targos
targoshttps://github.com/targos
Mar 12, 2021 https://github.com/nodejs/node/pull/37706#pullrequestreview-610518293
View reviewed changes https://github.com/nodejs/node/pull/37706/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 12, 2021https://github.com/nodejs/node/pull/37706#issuecomment-797466020
https://ci.nodejs.org/job/node-test-pull-request/36650/https://ci.nodejs.org/job/node-test-pull-request/36650/
Please reload this pagehttps://github.com/nodejs/node/pull/37706
https://github.com/cjihrig
http2: make res.req a normal propertyhttps://github.com/nodejs/node/pull/37706/commits/9f119a3581ce5d68b0b1c587714d97361490d6fd
9f119a3https://github.com/nodejs/node/pull/37706/commits/9f119a3581ce5d68b0b1c587714d97361490d6fd
nodejs#36505https://github.com/nodejs/node/pull/36505
nodejs#37706https://github.com/nodejs/node/pull/37706
nodejs#37705https://github.com/nodejs/node/issues/37705
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/632dce915cedda75fa99cd73f38956651d730edc..9f119a3581ce5d68b0b1c587714d97361490d6fd
632dce9https://github.com/nodejs/node/commit/632dce915cedda75fa99cd73f38956651d730edc
9f119a3https://github.com/nodejs/node/commit/9f119a3581ce5d68b0b1c587714d97361490d6fd
Compare https://github.com/nodejs/node/compare/632dce915cedda75fa99cd73f38956651d730edc..9f119a3581ce5d68b0b1c587714d97361490d6fd
March 13, 2021 17:45https://github.com/nodejs/node/pull/37706#event-4454069305
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
9f119a3https://github.com/nodejs/node/commit/9f119a3581ce5d68b0b1c587714d97361490d6fd
Mar 13, 2021https://github.com/nodejs/node/pull/37706#event-4454069558
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
March 13, 2021 17:45https://github.com/nodejs/node/pull/37706#event-4454069620
danielleadamshttps://github.com/danielleadams
Mar 16, 2021 https://github.com/nodejs/node/pull/37706#ref-commit-e4667eb
https://github.com/cjihrig
https://github.com/danielleadams
http2: make res.req a normal propertyhttps://github.com/nodejs/node/commit/e4667eb9e52fa3fc35d8df605a8f3c40471d6be9
e4667ebhttps://github.com/nodejs/node/commit/e4667eb9e52fa3fc35d8df605a8f3c40471d6be9
#36505https://github.com/nodejs/node/pull/36505
#37706https://github.com/nodejs/node/pull/37706
#37705https://github.com/nodejs/node/issues/37705
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
Mar 16, 2021 https://github.com/nodejs/node/pull/37706#ref-pullrequest-832880466
v15.12.0 proposal #37766 https://github.com/nodejs/node/pull/37766
danielleadamshttps://github.com/danielleadams
Mar 16, 2021 https://github.com/nodejs/node/pull/37706#ref-commit-c737df6
https://github.com/cjihrig
https://github.com/danielleadams
http2: make res.req a normal propertyhttps://github.com/nodejs/node/commit/c737df64fe0a2d4775be13209ff49d5b390736a1
c737df6https://github.com/nodejs/node/commit/c737df64fe0a2d4775be13209ff49d5b390736a1
#36505https://github.com/nodejs/node/pull/36505
#37706https://github.com/nodejs/node/pull/37706
#37705https://github.com/nodejs/node/issues/37705
https://github.com/targos
targoshttps://github.com/targos
backport-blocked-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v14.x
May 30, 2021https://github.com/nodejs/node/pull/37706#event-4816827681
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37706
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/37706/files/632dce915cedda75fa99cd73f38956651d730edc
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/37706/files/632dce915cedda75fa99cd73f38956651d730edc
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/37706/files/632dce915cedda75fa99cd73f38956651d730edc
https://github.com/ronag
ronag https://github.com/ronag
https://github.com/nodejs/node/pull/37706/files/632dce915cedda75fa99cd73f38956651d730edc
https://github.com/Flarna
Flarna https://github.com/Flarna
https://github.com/nodejs/node/pull/37706/files/632dce915cedda75fa99cd73f38956651d730edc
https://github.com/RaisinTen
RaisinTen https://github.com/RaisinTen
https://github.com/nodejs/node/pull/37706/files/632dce915cedda75fa99cd73f38956651d730edc
https://github.com/mmarchini
mmarchini https://github.com/mmarchini
https://github.com/nodejs/node/pull/37706/files/632dce915cedda75fa99cd73f38956651d730edc
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Accidental breaking change on v15.7.0 https://github.com/nodejs/node/issues/37705
Please reload this pagehttps://github.com/nodejs/node/pull/37706
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/lpinca
https://github.com/targos
https://github.com/ronag
https://github.com/mmarchini
https://github.com/Flarna
https://github.com/RaisinTen
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.