René's URL Explorer Experiment


Title: node-api: stop ref gc during environment teardown by gabrielschulhof · Pull Request #37616 · nodejs/node · GitHub

Open Graph Title: node-api: stop ref gc during environment teardown by gabrielschulhof · Pull Request #37616 · nodejs/node

X Title: node-api: stop ref gc during environment teardown by gabrielschulhof · Pull Request #37616 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: A gc may happen during environment teardown. Thus, during finalization initiated by environment teardown we must remove the V8 finalizer before calling the Node-API finalizer.

X Description: A gc may happen during environment teardown. Thus, during finalization initiated by environment teardown we must remove the V8 finalizer before calling the Node-API finalizer.

Opengraph URL: https://github.com/nodejs/node/pull/37616

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2eecca6f-592a-52c9-40b4-1c8d2925cdd1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA810:35C55B:567889:759A0B:6A4DA85E
html-safe-noncea63bf8e090d5b8546c6271e0c932678502ee798182474a30b585c04b4d37d055
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODEwOjM1QzU1Qjo1Njc4ODk6NzU5QTBCOjZBNERBODVFIiwidmlzaXRvcl9pZCI6IjkwMzUxNjgzNDk4NDM5OTA2MjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac744aef66ce179263a04947be9e401cb1f7e41bbce5b99e6cd1ffabedbcc83576
hovercard-subject-tagpull_request:586006304
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/37616/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1fbaca25380241abb583a00517e426aaf372cf745f86d64e942bb0a04dfa2ab4/nodejs/node/pull/37616
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1fbaca25380241abb583a00517e426aaf372cf745f86d64e942bb0a04dfa2ab4/nodejs/node/pull/37616
og:image:altA gc may happen during environment teardown. Thus, during finalization initiated by environment teardown we must remove the V8 finalizer before calling the Node-API finalizer.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegabrielschulhof
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release47723578ce6819210724ef064c858fce6d3115a3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/37616#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37616
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37616
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/37616
Reloadhttps://github.com/nodejs/node/pull/37616
Reloadhttps://github.com/nodejs/node/pull/37616
Please reload this pagehttps://github.com/nodejs/node/pull/37616
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/37616
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 962 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
gabrielschulhofhttps://github.com/gabrielschulhof
nodejs:masterhttps://github.com/nodejs/node/tree/master
gabrielschulhof:env-teardown-weak-refs-mainhttps://github.com/gabrielschulhof/node/tree/env-teardown-weak-refs-main
Conversationhttps://github.com/nodejs/node/pull/37616
Commits3 (3)https://github.com/nodejs/node/pull/37616/commits
Checkshttps://github.com/nodejs/node/pull/37616/checks
Files changedhttps://github.com/nodejs/node/pull/37616/files
node-api: stop ref gc during environment teardownhttps://github.com/nodejs/node/pull/37616#top
gabrielschulhofhttps://github.com/gabrielschulhof
nodejs:masterhttps://github.com/nodejs/node/tree/master
gabrielschulhof:env-teardown-weak-refs-mainhttps://github.com/gabrielschulhof/node/tree/env-teardown-weak-refs-main
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Mar 6, 2021https://github.com/nodejs/node/pull/37616#issue-823571455
Please reload this pagehttps://github.com/nodejs/node/pull/37616
https://github.com/gabrielschulhof
add testhttps://github.com/nodejs/node/pull/37616/commits/26fed3f64c7b0b833a300db44363bef25b6accf9
26fed3fhttps://github.com/nodejs/node/pull/37616/commits/26fed3f64c7b0b833a300db44363bef25b6accf9
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
legendecashttps://github.com/legendecas
mhdawsonhttps://github.com/mhdawson
March 6, 2021 05:41https://github.com/nodejs/node/pull/37616#event-4416534793
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Mar 6, 2021https://github.com/nodejs/node/pull/37616#event-4416534828
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Mar 6, 2021 https://github.com/nodejs/node/pull/37616#pullrequestreview-605731071
View reviewed changes https://github.com/nodejs/node/pull/37616/files
src/js_native_api_v8.cchttps://github.com/nodejs/node/pull/37616/files#diff-4b35cbf831be523a4f3e5aac3729c95490ed220892695d0e4245c15c1f63cfc1
gabrielschulhofhttps://github.com/gabrielschulhof
Mar 6, 2021https://github.com/nodejs/node/pull/37616#discussion_r588837845
Please reload this pagehttps://github.com/nodejs/node/pull/37616
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@legendecashttps://github.com/legendecas
Please reload this pagehttps://github.com/nodejs/node/pull/37616
https://github.com/gabrielschulhof
node-api: stop ref gc during environment teardownhttps://github.com/nodejs/node/pull/37616/commits/8eb03c4f190d1b85807928a8434840a52cb2792c
8eb03c4https://github.com/nodejs/node/pull/37616/commits/8eb03c4f190d1b85807928a8434840a52cb2792c
nodejs#37236https://github.com/nodejs/node/issues/37236
nodejs#37616https://github.com/nodejs/node/pull/37616
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
force-pushedhttps://github.com/nodejs/node/compare/76b696f63c502ba66449fe4a88737237fb7408ea..8eb03c4f190d1b85807928a8434840a52cb2792c
76b696fhttps://github.com/nodejs/node/commit/76b696f63c502ba66449fe4a88737237fb7408ea
8eb03c4https://github.com/nodejs/node/commit/8eb03c4f190d1b85807928a8434840a52cb2792c
Compare https://github.com/nodejs/node/compare/76b696f63c502ba66449fe4a88737237fb7408ea..8eb03c4f190d1b85807928a8434840a52cb2792c
March 6, 2021 05:49https://github.com/nodejs/node/pull/37616#event-4416539816
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Mar 6, 2021https://github.com/nodejs/node/pull/37616#issuecomment-791879048
Please reload this pagehttps://github.com/nodejs/node/pull/37616
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Mar 6, 2021https://github.com/nodejs/node/pull/37616#event-4416540915
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Mar 7, 2021https://github.com/nodejs/node/pull/37616#issuecomment-792197213
Please reload this pagehttps://github.com/nodejs/node/pull/37616
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Mar 7, 2021https://github.com/nodejs/node/pull/37616#event-4418240487
https://github.com/gabrielschulhof
add requested commenthttps://github.com/nodejs/node/pull/37616/commits/4c2131c4d8a226fb420f1873a00783be415c70ce
4c2131chttps://github.com/nodejs/node/pull/37616/commits/4c2131c4d8a226fb420f1873a00783be415c70ce
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Mar 12, 2021https://github.com/nodejs/node/pull/37616#issuecomment-797660368
@mhdawsonhttps://github.com/mhdawson
Please reload this pagehttps://github.com/nodejs/node/pull/37616
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Mar 12, 2021 https://github.com/nodejs/node/pull/37616#pullrequestreview-611134173
View reviewed changes https://github.com/nodejs/node/pull/37616/files/4c2131c4d8a226fb420f1873a00783be415c70ce
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/37616#pullrequestreview-611134173
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/37616
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 12, 2021https://github.com/nodejs/node/pull/37616#issuecomment-797819814
https://ci.nodejs.org/job/node-test-pull-request/36667/https://ci.nodejs.org/job/node-test-pull-request/36667/
Please reload this pagehttps://github.com/nodejs/node/pull/37616
https://github.com/legendecas
legendecashttps://github.com/legendecas
Mar 14, 2021 https://github.com/nodejs/node/pull/37616#pullrequestreview-611714595
View reviewed changes https://github.com/nodejs/node/pull/37616/files/8eb03c4f190d1b85807928a8434840a52cb2792c
https://github.com/legendecas
legendecashttps://github.com/legendecas
Mar 15, 2021https://github.com/nodejs/node/pull/37616#event-4456248453
Crash on node api add-on finalization #37236 https://github.com/nodejs/node/issues/37236
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 18, 2021https://github.com/nodejs/node/pull/37616#issuecomment-801991963
https://ci.nodejs.org/job/node-test-pull-request/36779/https://ci.nodejs.org/job/node-test-pull-request/36779/
Please reload this pagehttps://github.com/nodejs/node/pull/37616
gabrielschulhofhttps://github.com/gabrielschulhof
Mar 19, 2021 https://github.com/nodejs/node/pull/37616#ref-commit-52f9aaf
https://github.com/gabrielschulhof
node-api: stop ref gc during environment teardownhttps://github.com/nodejs/node/commit/52f9aafeab02390ff78447a390651ec6ed94d166
52f9aafhttps://github.com/nodejs/node/commit/52f9aafeab02390ff78447a390651ec6ed94d166
#37236https://github.com/nodejs/node/issues/37236
#37616https://github.com/nodejs/node/pull/37616
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Mar 19, 2021https://github.com/nodejs/node/pull/37616#issuecomment-802526880
52f9aafhttps://github.com/nodejs/node/commit/52f9aafeab02390ff78447a390651ec6ed94d166
Please reload this pagehttps://github.com/nodejs/node/pull/37616
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Mar 19, 2021https://github.com/nodejs/node/pull/37616#event-4479900409
gabrielschulhofhttps://github.com/gabrielschulhof
Mar 19, 2021 https://github.com/nodejs/node/pull/37616#ref-commit-9083454
https://github.com/gabrielschulhof
node-api: stop ref gc during environment teardownhttps://github.com/gabrielschulhof/node/commit/90834544f5e8740f6f2eb130b1e59cc43f77da71
9083454https://github.com/gabrielschulhof/node/commit/90834544f5e8740f6f2eb130b1e59cc43f77da71
nodejs#37236https://github.com/nodejs/node/issues/37236
nodejs#37616https://github.com/nodejs/node/pull/37616
gabrielschulhofhttps://github.com/gabrielschulhof
Mar 19, 2021 https://github.com/nodejs/node/pull/37616#ref-commit-e31b2e3
https://github.com/gabrielschulhof
node-api: stop ref gc during environment teardownhttps://github.com/gabrielschulhof/node/commit/e31b2e33f0adf1f1ba3b08411a9eee3c4922cf95
e31b2e3https://github.com/gabrielschulhof/node/commit/e31b2e33f0adf1f1ba3b08411a9eee3c4922cf95
nodejs#37236https://github.com/nodejs/node/issues/37236
nodejs#37616https://github.com/nodejs/node/pull/37616
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Mar 22, 2021 https://github.com/nodejs/node/pull/37616#ref-issue-807567523
Intermittent failure in ThreadSafe function nodejs/node-addon-api#906 https://github.com/nodejs/node-addon-api/issues/906
mhdawsonhttps://github.com/mhdawson
Mar 23, 2021 https://github.com/nodejs/node/pull/37616#ref-commit-c897654
https://github.com/mhdawson
node-api: fix crash in finalizationhttps://github.com/mhdawson/io.js/commit/c897654277232286125bd874f770e480b9e9e332
c897654https://github.com/mhdawson/io.js/commit/c897654277232286125bd874f770e480b9e9e332
nodejs/node-addon-api#906https://github.com/nodejs/node-addon-api/issues/906
nodejs#37616https://github.com/nodejs/node/pull/37616
nodejs#37616https://github.com/nodejs/node/pull/37616
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Mar 23, 2021 https://github.com/nodejs/node/pull/37616#ref-pullrequest-838859407
node-api: fix crash in finalization #37876 https://github.com/nodejs/node/pull/37876
ruyadornohttps://github.com/ruyadorno
Mar 24, 2021 https://github.com/nodejs/node/pull/37616#ref-commit-d1a3e0e
https://github.com/gabrielschulhof
https://github.com/ruyadorno
node-api: stop ref gc during environment teardownhttps://github.com/nodejs/node/commit/d1a3e0efb65d4a4fbe15b3d255df535e22048dbf
d1a3e0ehttps://github.com/nodejs/node/commit/d1a3e0efb65d4a4fbe15b3d255df535e22048dbf
#37236https://github.com/nodejs/node/issues/37236
#37616https://github.com/nodejs/node/pull/37616
Trotthttps://github.com/Trott
Mar 24, 2021 https://github.com/nodejs/node/pull/37616#ref-commit-eb9e0fc
https://github.com/mhdawson
https://github.com/Trott
node-api: fix crash in finalizationhttps://github.com/Trott/io.js/commit/eb9e0fc2c1daa8e50a5ad6369be4c8b9f57a7019
eb9e0fchttps://github.com/Trott/io.js/commit/eb9e0fc2c1daa8e50a5ad6369be4c8b9f57a7019
nodejs/node-addon-api#906https://github.com/nodejs/node-addon-api/issues/906
nodejs#37616https://github.com/nodejs/node/pull/37616
nodejs#37616https://github.com/nodejs/node/pull/37616
Trotthttps://github.com/Trott
Mar 24, 2021 https://github.com/nodejs/node/pull/37616#ref-commit-42dc4d1
https://github.com/mhdawson
https://github.com/Trott
node-api: fix crash in finalizationhttps://github.com/mhdawson/io.js/commit/42dc4d14cdea833b807003863d6322723faa1da8
42dc4d1https://github.com/mhdawson/io.js/commit/42dc4d14cdea833b807003863d6322723faa1da8
nodejs/node-addon-api#906https://github.com/nodejs/node-addon-api/issues/906
nodejs#37616https://github.com/nodejs/node/pull/37616
nodejs#37616https://github.com/nodejs/node/pull/37616
nodejs#37876https://github.com/nodejs/node/pull/37876
gabrielschulhofhttps://github.com/gabrielschulhof
Mar 26, 2021 https://github.com/nodejs/node/pull/37616#ref-commit-fecc3f4
https://github.com/mhdawson
https://github.com/gabrielschulhof
node-api: fix crash in finalizationhttps://github.com/gabrielschulhof/node/commit/fecc3f481dd297d9cd6bf0740122a3d9ed87ceda
fecc3f4https://github.com/gabrielschulhof/node/commit/fecc3f481dd297d9cd6bf0740122a3d9ed87ceda
nodejs/node-addon-api#906https://github.com/nodejs/node-addon-api/issues/906
nodejs#37616https://github.com/nodejs/node/pull/37616
nodejs#37616https://github.com/nodejs/node/pull/37616
nodejs#37876https://github.com/nodejs/node/pull/37876
gabrielschulhofhttps://github.com/gabrielschulhof
Mar 26, 2021 https://github.com/nodejs/node/pull/37616#ref-commit-86019bf
https://github.com/gabrielschulhof
node-api: stop ref gc during environment teardownhttps://github.com/gabrielschulhof/node/commit/86019bf8c66c68f3307cef9d0a5e8f4d3a1032d0
86019bfhttps://github.com/gabrielschulhof/node/commit/86019bf8c66c68f3307cef9d0a5e8f4d3a1032d0
nodejs#37236https://github.com/nodejs/node/issues/37236
nodejs#37616https://github.com/nodejs/node/pull/37616
gabrielschulhofhttps://github.com/gabrielschulhof
Mar 26, 2021 https://github.com/nodejs/node/pull/37616#ref-commit-dcc5da6
https://github.com/mhdawson
https://github.com/gabrielschulhof
node-api: fix crash in finalizationhttps://github.com/gabrielschulhof/node/commit/dcc5da679bbfc07fd9cd5718b81513c2c932b19c
dcc5da6https://github.com/gabrielschulhof/node/commit/dcc5da679bbfc07fd9cd5718b81513c2c932b19c
nodejs/node-addon-api#906https://github.com/nodejs/node-addon-api/issues/906
nodejs#37616https://github.com/nodejs/node/pull/37616
nodejs#37616https://github.com/nodejs/node/pull/37616
nodejs#37876https://github.com/nodejs/node/pull/37876
ruyadornohttps://github.com/ruyadorno
Mar 29, 2021 https://github.com/nodejs/node/pull/37616#ref-commit-906eb53
https://github.com/mhdawson
https://github.com/ruyadorno
node-api: fix crash in finalizationhttps://github.com/nodejs/node/commit/906eb53e995f36f96a9d19a6423e1d11d54435e2
906eb53https://github.com/nodejs/node/commit/906eb53e995f36f96a9d19a6423e1d11d54435e2
nodejs/node-addon-api#906https://github.com/nodejs/node-addon-api/issues/906
#37616https://github.com/nodejs/node/pull/37616
#37616https://github.com/nodejs/node/pull/37616
#37876https://github.com/nodejs/node/pull/37876
ruyadornohttps://github.com/ruyadorno
Mar 30, 2021 https://github.com/nodejs/node/pull/37616#ref-commit-3ab223d
https://github.com/mhdawson
https://github.com/ruyadorno
node-api: fix crash in finalizationhttps://github.com/nodejs/node/commit/3ab223dd3221d1c548cbad4859512f716b7223f6
3ab223dhttps://github.com/nodejs/node/commit/3ab223dd3221d1c548cbad4859512f716b7223f6
nodejs/node-addon-api#906https://github.com/nodejs/node-addon-api/issues/906
#37616https://github.com/nodejs/node/pull/37616
#37616https://github.com/nodejs/node/pull/37616
#37876https://github.com/nodejs/node/pull/37876
https://github.com/ruyadorno
ruyadornohttps://github.com/ruyadorno
Mar 30, 2021 https://github.com/nodejs/node/pull/37616#ref-pullrequest-844019653
v15.13.0 proposal #37977 https://github.com/nodejs/node/pull/37977
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Apr 2, 2021 https://github.com/nodejs/node/pull/37616#ref-issue-849192489
local fatal error for test/js-native-api/test_object/test.js #38040 https://github.com/nodejs/node/issues/38040
targoshttps://github.com/targos
Apr 24, 2021 https://github.com/nodejs/node/pull/37616#ref-commit-466d768
https://github.com/gabrielschulhof
https://github.com/targos
node-api: stop ref gc during environment teardownhttps://github.com/gabrielschulhof/node/commit/466d76826dc83874e24901733aa7b8ad842fcca2
466d768https://github.com/gabrielschulhof/node/commit/466d76826dc83874e24901733aa7b8ad842fcca2
nodejs#37236https://github.com/nodejs/node/issues/37236
nodejs#37616https://github.com/nodejs/node/pull/37616
targoshttps://github.com/targos
Apr 24, 2021 https://github.com/nodejs/node/pull/37616#ref-commit-180c33d
https://github.com/mhdawson
https://github.com/targos
node-api: fix crash in finalizationhttps://github.com/gabrielschulhof/node/commit/180c33dbd446dfe251ea475f72b927a0f6802641
180c33dhttps://github.com/gabrielschulhof/node/commit/180c33dbd446dfe251ea475f72b927a0f6802641
nodejs/node-addon-api#906https://github.com/nodejs/node-addon-api/issues/906
nodejs#37616https://github.com/nodejs/node/pull/37616
nodejs#37616https://github.com/nodejs/node/pull/37616
nodejs#37876https://github.com/nodejs/node/pull/37876
https://github.com/targos
targoshttps://github.com/targos
backport-open-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-open-v14.x
backport-open-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-open-v14.x
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Apr 25, 2021https://github.com/nodejs/node/pull/37616#event-4640754574
targoshttps://github.com/targos
Apr 26, 2021 https://github.com/nodejs/node/pull/37616#ref-commit-6e01855
https://github.com/gabrielschulhof
https://github.com/targos
node-api: stop ref gc during environment teardownhttps://github.com/nodejs/node/commit/6e018559dba7d9d2a872c1d9b81bb0fd90f19e03
6e01855https://github.com/nodejs/node/commit/6e018559dba7d9d2a872c1d9b81bb0fd90f19e03
#37236https://github.com/nodejs/node/issues/37236
#37616https://github.com/nodejs/node/pull/37616
#37802https://github.com/nodejs/node/pull/37802
targoshttps://github.com/targos
Apr 26, 2021 https://github.com/nodejs/node/pull/37616#ref-commit-8413759
https://github.com/mhdawson
https://github.com/targos
node-api: fix crash in finalizationhttps://github.com/nodejs/node/commit/8413759d84ebc7ceb1828a7d17c8232063e1b812
8413759https://github.com/nodejs/node/commit/8413759d84ebc7ceb1828a7d17c8232063e1b812
nodejs/node-addon-api#906https://github.com/nodejs/node-addon-api/issues/906
#37616https://github.com/nodejs/node/pull/37616
#37616https://github.com/nodejs/node/pull/37616
#37876https://github.com/nodejs/node/pull/37876
#37802https://github.com/nodejs/node/pull/37802
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
May 3, 2021 https://github.com/nodejs/node/pull/37616#ref-pullrequest-874193529
v14.17.0 proposal #38507 https://github.com/nodejs/node/pull/38507
https://github.com/richardlau
richardlauhttps://github.com/richardlau
lts-watch-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v12.x
Mar 17, 2022https://github.com/nodejs/node/pull/37616#event-6258630839
https://github.com/XhmikosR
XhmikosRhttps://github.com/XhmikosR
Mar 20, 2022 https://github.com/nodejs/node/pull/37616#ref-issue-1172166519
Node.js 12.x need to cherry-pick https://github.com/nodejs/node/pull/37616 #42376 https://github.com/nodejs/node/issues/42376
legendecashttps://github.com/legendecas
Mar 29, 2022 https://github.com/nodejs/node/pull/37616#ref-commit-7b6b7d3
https://github.com/gabrielschulhof
https://github.com/legendecas
node-api: stop ref gc during environment teardownhttps://github.com/legendecas/node/commit/7b6b7d343edb7b4d23a75a2e3992f8284914f1dd
7b6b7d3https://github.com/legendecas/node/commit/7b6b7d343edb7b4d23a75a2e3992f8284914f1dd
nodejs#37236https://github.com/nodejs/node/issues/37236
nodejs#37616https://github.com/nodejs/node/pull/37616
legendecashttps://github.com/legendecas
Mar 29, 2022 https://github.com/nodejs/node/pull/37616#ref-commit-affb8b2
https://github.com/mhdawson
https://github.com/legendecas
node-api: fix crash in finalizationhttps://github.com/legendecas/node/commit/affb8b2515789099e4b510251b500c55b50c8afc
affb8b2https://github.com/legendecas/node/commit/affb8b2515789099e4b510251b500c55b50c8afc
nodejs/node-addon-api#906https://github.com/nodejs/node-addon-api/issues/906
nodejs#37616https://github.com/nodejs/node/pull/37616
nodejs#37616https://github.com/nodejs/node/pull/37616
nodejs#37876https://github.com/nodejs/node/pull/37876
https://github.com/richardlau
richardlauhttps://github.com/richardlau
backport-open-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-open-v12.x
lts-watch-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v12.x
Mar 30, 2022https://github.com/nodejs/node/pull/37616#event-6335564078
richardlauhttps://github.com/richardlau
Mar 30, 2022 https://github.com/nodejs/node/pull/37616#ref-commit-a2f4206
https://github.com/gabrielschulhof
https://github.com/richardlau
node-api: stop ref gc during environment teardownhttps://github.com/nodejs/node/commit/a2f42064159cabfa27e2d46208b58443069eec96
a2f4206https://github.com/nodejs/node/commit/a2f42064159cabfa27e2d46208b58443069eec96
#37236https://github.com/nodejs/node/issues/37236
#37616https://github.com/nodejs/node/pull/37616
#42512https://github.com/nodejs/node/pull/42512
richardlauhttps://github.com/richardlau
Mar 30, 2022 https://github.com/nodejs/node/pull/37616#ref-commit-2aa9ca1
https://github.com/mhdawson
https://github.com/richardlau
node-api: fix crash in finalizationhttps://github.com/nodejs/node/commit/2aa9ca1ea93b9b9b92a303d3c8def777f3a1dfee
2aa9ca1https://github.com/nodejs/node/commit/2aa9ca1ea93b9b9b92a303d3c8def777f3a1dfee
nodejs/node-addon-api#906https://github.com/nodejs/node-addon-api/issues/906
#37616https://github.com/nodejs/node/pull/37616
#37616https://github.com/nodejs/node/pull/37616
#37876https://github.com/nodejs/node/pull/37876
#42512https://github.com/nodejs/node/pull/42512
https://github.com/richardlau
richardlauhttps://github.com/richardlau
backported-to-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v12.x
backport-open-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-open-v12.x
Mar 30, 2022https://github.com/nodejs/node/pull/37616#event-6336260319
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Mar 30, 2022 https://github.com/nodejs/node/pull/37616#ref-pullrequest-1186734465
v12.22.12 proposal #42531 https://github.com/nodejs/node/pull/42531
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
March 17, 2023 19:00https://github.com/nodejs/node/pull/37616#event-8781589963
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37616
https://github.com/legendecas
legendecas https://github.com/legendecas
https://github.com/nodejs/node/pull/37616/files/8eb03c4f190d1b85807928a8434840a52cb2792c
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/37616/files/4c2131c4d8a226fb420f1873a00783be415c70ce
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Crash on node api add-on finalization https://github.com/nodejs/node/issues/37236
Please reload this pagehttps://github.com/nodejs/node/pull/37616
https://github.com/gabrielschulhof
https://github.com/nodejs-github-bot
https://github.com/legendecas
https://github.com/mhdawson
https://github.com/targos
https://github.com/richardlau
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.