René's URL Explorer Experiment


Title: fs: fix readFile will pass undefined to callback but not null by zbinlin · Pull Request #3740 · nodejs/node · GitHub

Open Graph Title: fs: fix readFile will pass undefined to callback but not null by zbinlin · Pull Request #3740 · nodejs/node

X Title: fs: fix readFile will pass undefined to callback but not null by zbinlin · Pull Request #3740 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: In PR-3485, if encoding set, fs.readFile will pass undefined not null to callback.

X Description: In PR-3485, if encoding set, fs.readFile will pass undefined not null to callback.

Opengraph URL: https://github.com/nodejs/node/pull/3740

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fb702d22-2665-3b54-4822-e68375a58324
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC8FA:9FE98:1813C62:216CB5E:6A4EB86A
html-safe-nonce4ce1d04ee9d7cc3b83ad85a5e2c433a57f7e9f68f1b769e041161c07c4926dfb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOEZBOjlGRTk4OjE4MTNDNjI6MjE2Q0I1RTo2QTRFQjg2QSIsInZpc2l0b3JfaWQiOiIyNzkyNTgyNDIwNDczMjMxNDY2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac696ec311e97a550d0433c30f89e5c24de92f4cb94b74e45fca8fdcb8138f49ae
hovercard-subject-tagpull_request:50281216
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/3740/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e55d71c4b4b7703028295cb8b9ba34635410e10c85a9c7ba59d82c1752cd03f4/nodejs/node/pull/3740
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e55d71c4b4b7703028295cb8b9ba34635410e10c85a9c7ba59d82c1752cd03f4/nodejs/node/pull/3740
og:image:altIn PR-3485, if encoding set, fs.readFile will pass undefined not null to callback.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamezbinlin
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/3740#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3740
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3740
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/3740
Reloadhttps://github.com/nodejs/node/pull/3740
Reloadhttps://github.com/nodejs/node/pull/3740
Please reload this pagehttps://github.com/nodejs/node/pull/3740
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/3740
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
zbinlinhttps://github.com/zbinlin
nodejs:masterhttps://github.com/nodejs/node/tree/master
zbinlin:fix-bug-branchhttps://github.com/zbinlin/node/tree/fix-bug-branch
Conversationhttps://github.com/nodejs/node/pull/3740
Commits1 (1)https://github.com/nodejs/node/pull/3740/commits
Checkshttps://github.com/nodejs/node/pull/3740/checks
Files changedhttps://github.com/nodejs/node/pull/3740/files
fs: fix readFile will pass undefined to callback but not nullhttps://github.com/nodejs/node/pull/3740#top
zbinlinhttps://github.com/zbinlin
nodejs:masterhttps://github.com/nodejs/node/tree/master
zbinlin:fix-bug-branchhttps://github.com/zbinlin/node/tree/fix-bug-branch
https://github.com/zbinlin
zbinlinhttps://github.com/zbinlin
Nov 10, 2015https://github.com/nodejs/node/pull/3740#issue-116152488
PR-3485https://github.com/nodejs/node/pull/3485
Please reload this pagehttps://github.com/nodejs/node/pull/3740
https://github.com/zbinlin
fs: fix readFile will pass undefined to callback but not nullhttps://github.com/nodejs/node/pull/3740/commits/6c704b5b1c922e7c0aedd6d1d26511765f81772f
6c704b5https://github.com/nodejs/node/pull/3740/commits/6c704b5b1c922e7c0aedd6d1d26511765f81772f
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 10, 2015https://github.com/nodejs/node/pull/3740#issuecomment-155490520
Please reload this pagehttps://github.com/nodejs/node/pull/3740
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 10, 2015https://github.com/nodejs/node/pull/3740#issuecomment-155491067
Please reload this pagehttps://github.com/nodejs/node/pull/3740
https://github.com/mscdex
mscdexhttps://github.com/mscdex
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Nov 10, 2015https://github.com/nodejs/node/pull/3740#event-460340300
https://github.com/zbinlin
zbinlinhttps://github.com/zbinlin
Nov 10, 2015https://github.com/nodejs/node/pull/3740#issuecomment-155512309
promise-adapterhttps://github.com/zbinlin/promise-adapter
Please reload this pagehttps://github.com/nodejs/node/pull/3740
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Nov 10, 2015https://github.com/nodejs/node/pull/3740#issuecomment-155513170
Please reload this pagehttps://github.com/nodejs/node/pull/3740
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Nov 10, 2015https://github.com/nodejs/node/pull/3740#issuecomment-155514544
https://ci.nodejs.org/job/node-test-pull-request/692/https://ci.nodejs.org/job/node-test-pull-request/692/
Please reload this pagehttps://github.com/nodejs/node/pull/3740
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Nov 10, 2015https://github.com/nodejs/node/pull/3740#issuecomment-155518051
Please reload this pagehttps://github.com/nodejs/node/pull/3740
https://github.com/JungMinu
JungMinuhttps://github.com/JungMinu
Nov 10, 2015https://github.com/nodejs/node/pull/3740#issuecomment-155518859
Please reload this pagehttps://github.com/nodejs/node/pull/3740
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 11, 2015https://github.com/nodejs/node/pull/3740#issuecomment-155856395
https://ci.nodejs.org/job/node-test-pull-request/705/https://ci.nodejs.org/job/node-test-pull-request/705/
Please reload this pagehttps://github.com/nodejs/node/pull/3740
cjihrighttps://github.com/cjihrig
Nov 11, 2015 https://github.com/nodejs/node/pull/3740#ref-commit-1594198
https://github.com/zbinlin
https://github.com/cjihrig
fs: return null error on readFile() successhttps://github.com/nodejs/node/commit/1594198600f5349d4500e4d5c3b5aa0c1192ed4e
1594198https://github.com/nodejs/node/commit/1594198600f5349d4500e4d5c3b5aa0c1192ed4e
#3740https://github.com/nodejs/node/pull/3740
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 11, 2015https://github.com/nodejs/node/pull/3740#issuecomment-155879982
1594198https://github.com/nodejs/node/commit/1594198600f5349d4500e4d5c3b5aa0c1192ed4e
Please reload this pagehttps://github.com/nodejs/node/pull/3740
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 11, 2015https://github.com/nodejs/node/pull/3740#event-461642545
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 11, 2015https://github.com/nodejs/node/pull/3740#issuecomment-155880846
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/3740
https://github.com/jasnell
jasnellhttps://github.com/jasnell
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Nov 11, 2015https://github.com/nodejs/node/pull/3740#event-461648345
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 11, 2015https://github.com/nodejs/node/pull/3740#issuecomment-155881592
Please reload this pagehttps://github.com/nodejs/node/pull/3740
https://github.com/zbinlin
zbinlinhttps://github.com/zbinlin
November 12, 2015 04:37https://github.com/nodejs/node/pull/3740#event-462057480
rvagghttps://github.com/rvagg
Nov 13, 2015 https://github.com/nodejs/node/pull/3740#ref-commit-2aa6a6d
https://github.com/zbinlin
https://github.com/rvagg
fs: return null error on readFile() successhttps://github.com/nodejs/node/commit/2aa6a6d998ed2f13e7a1bc79421f9d4356f5190e
2aa6a6dhttps://github.com/nodejs/node/commit/2aa6a6d998ed2f13e7a1bc79421f9d4356f5190e
#3740https://github.com/nodejs/node/pull/3740
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 17, 2015https://github.com/nodejs/node/pull/3740#issuecomment-157232060
semver-major fixhttps://github.com/nodejs/node/pull/3740#3485
@cjihrighttps://github.com/cjihrig
Please reload this pagehttps://github.com/nodejs/node/pull/3740
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Nov 17, 2015https://github.com/nodejs/node/pull/3740#event-466174880
https://github.com/rvagg
rvagghttps://github.com/rvagg
Dec 17, 2015 https://github.com/nodejs/node/pull/3740#ref-issue-122642707
Release 4.2.4 Planning #4321 https://github.com/nodejs/node/issues/4321
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 14, 2016 https://github.com/nodejs/node/pull/3740#ref-issue-126730245
Audit commits not found on v4.x-staging #4698 https://github.com/nodejs/node/issues/4698
https://github.com/rvagg
rvagghttps://github.com/rvagg
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
Jan 15, 2016https://github.com/nodejs/node/pull/3740#event-515837972
https://github.com/rvagg
rvagghttps://github.com/rvagg
Jan 15, 2016https://github.com/nodejs/node/pull/3740#issuecomment-171879983
@thealphanerdhttps://github.com/thealphanerd
#3485https://github.com/nodejs/node/pull/3485
Please reload this pagehttps://github.com/nodejs/node/pull/3740
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3740
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Please reload this pagehttps://github.com/nodejs/node/pull/3740
https://github.com/zbinlin
https://github.com/cjihrig
https://github.com/evanlucas
https://github.com/thefourtheye
https://github.com/JungMinu
https://github.com/jasnell
https://github.com/MylesBorins
https://github.com/rvagg
https://github.com/mscdex
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.