| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:23692cc2-78d9-6117-ccd3-8c6e8e2616cf |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C76E:2A7019:E57FAE:13D792E:6A4DEDD3 |
| html-safe-nonce | ea770b17dabb4c304890721fefa0afb4e55b6d41ef654092d6ecd535698d4c7a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNzZFOjJBNzAxOTpFNTdGQUU6MTNENzkyRTo2QTRERUREMyIsInZpc2l0b3JfaWQiOiIzMTY2ODMyMzE1NzI5ODMzNDI3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 0f83bdb8b1ee694ca01eb2299ec6830dabe15507ce8a36cf4228c517ff1526ba |
| hovercard-subject-tag | pull_request:570894021 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/37303/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1f7303b298cfdd5ebbd25a8031bb4f494a2ce6a699a016ded32410cd4dfaea32/nodejs/node/pull/37303 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1f7303b298cfdd5ebbd25a8031bb4f494a2ce6a699a016ded32410cd4dfaea32/nodejs/node/pull/37303 |
| og:image:alt | The finalizer normally never gets called while a reference is strong.
However, during environment shutdown all finalizers must get called. In
order to unify the deferring behavior with that of a re... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gabrielschulhof |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/37303#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37303 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37303 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/37303 |
| Reload | https://github.com/nodejs/node/pull/37303 |
| Reload | https://github.com/nodejs/node/pull/37303 |
| Please reload this page | https://github.com/nodejs/node/pull/37303 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/37303 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
963
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gabrielschulhof:node-api-double-free-ref2 | https://github.com/gabrielschulhof/node/tree/node-api-double-free-ref2 |
| Conversation | https://github.com/nodejs/node/pull/37303 |
| Commits5 (5) | https://github.com/nodejs/node/pull/37303/commits |
| Checks | https://github.com/nodejs/node/pull/37303/checks |
| Files changed | https://github.com/nodejs/node/pull/37303/files |
| node-api: force env shutdown deferring behavior | https://github.com/nodejs/node/pull/37303#top |
| gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gabrielschulhof:node-api-double-free-ref2 | https://github.com/gabrielschulhof/node/tree/node-api-double-free-ref2 |
|
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Feb 10, 2021 | https://github.com/nodejs/node/pull/37303#issue-805257237 |
| #37236 | https://github.com/nodejs/node/issues/37236 |
| @legendecas | https://github.com/legendecas |
| Please reload this page | https://github.com/nodejs/node/pull/37303 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Feb 10, 2021 | https://github.com/nodejs/node/pull/37303#event-4313239991 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| legendecas | https://github.com/legendecas |
| mhdawson | https://github.com/mhdawson |
| February 10, 2021 07:28 | https://github.com/nodejs/node/pull/37303#event-4313240002 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Feb 10, 2021 | https://github.com/nodejs/node/pull/37303#event-4313240242 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| force-pushed | https://github.com/nodejs/node/compare/53f6c32aab2d95d49eb99c33882c2c30c9562db2..cd3e2d135c2042c4c2db59fa5369c196275c98c0 |
| 53f6c32 | https://github.com/nodejs/node/commit/53f6c32aab2d95d49eb99c33882c2c30c9562db2 |
| cd3e2d1 | https://github.com/nodejs/node/commit/cd3e2d135c2042c4c2db59fa5369c196275c98c0 |
|
Compare
| https://github.com/nodejs/node/compare/53f6c32aab2d95d49eb99c33882c2c30c9562db2..cd3e2d135c2042c4c2db59fa5369c196275c98c0 |
| February 10, 2021 07:30 | https://github.com/nodejs/node/pull/37303#event-4313246931 |
| https://github.com/RaisinTen |
| RaisinTen | https://github.com/RaisinTen |
| Feb 10, 2021 | https://github.com/nodejs/node/pull/37303#issuecomment-776523938 |
| Please reload this page | https://github.com/nodejs/node/pull/37303 |
| https://github.com/RaisinTen |
| RaisinTen | https://github.com/RaisinTen |
|
Feb 10, 2021
| https://github.com/nodejs/node/pull/37303#ref-issue-782847478 |
|
investigate flaky test/node-api/test_worker_terminate_finalization/test.js
#36868
| https://github.com/nodejs/node/issues/36868 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Feb 10, 2021 | https://github.com/nodejs/node/pull/37303#issuecomment-776838192 |
| @RaisinTen | https://github.com/RaisinTen |
| c822ba7 | https://github.com/nodejs/node/commit/c822ba7121b073c7a59a7bab05ba46d6a19eb966 |
| #36868 | https://github.com/nodejs/node/issues/36868 |
| Please reload this page | https://github.com/nodejs/node/pull/37303 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| RaisinTen | https://github.com/RaisinTen |
| February 10, 2021 16:32 | https://github.com/nodejs/node/pull/37303#event-4315764506 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Feb 10, 2021 | https://github.com/nodejs/node/pull/37303#issuecomment-776866658 |
| @RaisinTen | https://github.com/RaisinTen |
| @mhdawson | https://github.com/mhdawson |
| #36868 | https://github.com/nodejs/node/issues/36868 |
| #36868 | https://github.com/nodejs/node/issues/36868 |
| Please reload this page | https://github.com/nodejs/node/pull/37303 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Feb 10, 2021
| https://github.com/nodejs/node/pull/37303#pullrequestreview-588095841 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/37303/files |
| src/js_native_api_v8.cc | https://github.com/nodejs/node/pull/37303/files#diff-4b35cbf831be523a4f3e5aac3729c95490ed220892695d0e4245c15c1f63cfc1 |
| Please reload this page | https://github.com/nodejs/node/pull/37303 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Feb 11, 2021
| https://github.com/nodejs/node/pull/37303#pullrequestreview-588209948 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/37303/files |
| src/js_native_api_v8.cc | https://github.com/nodejs/node/pull/37303/files#diff-4b35cbf831be523a4f3e5aac3729c95490ed220892695d0e4245c15c1f63cfc1 |
| Please reload this page | https://github.com/nodejs/node/pull/37303 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Feb 11, 2021 | https://github.com/nodejs/node/pull/37303#issuecomment-777192152 |
| https://ci.nodejs.org/job/node-test-pull-request/36055/ | https://ci.nodejs.org/job/node-test-pull-request/36055/ |
| Please reload this page | https://github.com/nodejs/node/pull/37303 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Feb 12, 2021
| https://github.com/nodejs/node/pull/37303#pullrequestreview-589817945 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/37303/files |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node/pull/37303#pullrequestreview-589817945 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/37303 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Feb 12, 2021 | https://github.com/nodejs/node/pull/37303#issuecomment-778447711 |
| https://ci.nodejs.org/job/node-test-pull-request/36082/ | https://ci.nodejs.org/job/node-test-pull-request/36082/ |
| Please reload this page | https://github.com/nodejs/node/pull/37303 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Feb 12, 2021 | https://github.com/nodejs/node/pull/37303#issuecomment-778473158 |
| https://ci.nodejs.org/job/node-test-pull-request/36085/ | https://ci.nodejs.org/job/node-test-pull-request/36085/ |
| Please reload this page | https://github.com/nodejs/node/pull/37303 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Feb 13, 2021 | https://github.com/nodejs/node/pull/37303#issuecomment-778569947 |
| https://ci.nodejs.org/job/node-test-pull-request/36090/ | https://ci.nodejs.org/job/node-test-pull-request/36090/ |
| Please reload this page | https://github.com/nodejs/node/pull/37303 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Feb 13, 2021 | https://github.com/nodejs/node/pull/37303#issuecomment-778580634 |
| Please reload this page | https://github.com/nodejs/node/pull/37303 |
| https://ci.nodejs.org/job/node-test-pull-request/36091/ | https://ci.nodejs.org/job/node-test-pull-request/36091/ |
| Please reload this page | https://github.com/nodejs/node/pull/37303 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Feb 16, 2021 | https://github.com/nodejs/node/pull/37303#issuecomment-780167810 |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| @legendecas | https://github.com/legendecas |
| Please reload this page | https://github.com/nodejs/node/pull/37303 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Feb 17, 2021 | https://github.com/nodejs/node/pull/37303#issuecomment-780264986 |
| @mhdawson | https://github.com/mhdawson |
| Please reload this page | https://github.com/nodejs/node/pull/37303 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
|
Feb 18, 2021
| https://github.com/nodejs/node/pull/37303#ref-issue-801970073 |
|
Crash on node api add-on finalization
#37236
| https://github.com/nodejs/node/issues/37236 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
| Feb 18, 2021 | https://github.com/nodejs/node/pull/37303#issuecomment-781094228 |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| #37236 (comment) | https://github.com/nodejs/node/issues/37236#issuecomment-781093781 |
| Please reload this page | https://github.com/nodejs/node/pull/37303 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Feb 18, 2021 | https://github.com/nodejs/node/pull/37303#issuecomment-781436790 |
| @legendecas | https://github.com/legendecas |
| Please reload this page | https://github.com/nodejs/node/pull/37303 |
| February 18, 2021 07:53 | https://github.com/nodejs/node/pull/37303#commits-pushed-4cf6a26 |
|
| https://github.com/legendecas |
|
| https://github.com/gabrielschulhof |
| node-api: force env shutdown deferring behavior | https://github.com/nodejs/node/pull/37303/commits/4cf6a26e5ecb851080d2321c6647b6c3562c9461 |
| 4cf6a26 | https://github.com/nodejs/node/pull/37303/commits/4cf6a26e5ecb851080d2321c6647b6c3562c9461 |
| nodejs#37236 | https://github.com/nodejs/node/issues/37236 |
|
| https://github.com/gabrielschulhof |
| add test | https://github.com/nodejs/node/pull/37303/commits/167bb7f95aa5c1cfe6bfff14c82ea99f5947ce1d |
| 167bb7f | https://github.com/nodejs/node/pull/37303/commits/167bb7f95aa5c1cfe6bfff14c82ea99f5947ce1d |
|
| https://github.com/gabrielschulhof |
| heed the linter | https://github.com/nodejs/node/pull/37303/commits/9f723be39abe57ef9d6e6e1e0a78252d7132049e |
| 9f723be | https://github.com/nodejs/node/pull/37303/commits/9f723be39abe57ef9d6e6e1e0a78252d7132049e |
|
| https://github.com/gabrielschulhof |
| handle the case where the reference is not deleted in its destructor | https://github.com/nodejs/node/pull/37303/commits/df5463bbb0264ed1bee6fbdab778ec889101afd7 |
| df5463b | https://github.com/nodejs/node/pull/37303/commits/df5463bbb0264ed1bee6fbdab778ec889101afd7 |
|
| https://github.com/gabrielschulhof |
| put the _finalize_ran = true back in the else body | https://github.com/nodejs/node/pull/37303/commits/21e5b1dad3bc8d045a908d137f45e6da3515be18 |
| 21e5b1d | https://github.com/nodejs/node/pull/37303/commits/21e5b1dad3bc8d045a908d137f45e6da3515be18 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| force-pushed | https://github.com/nodejs/node/compare/6415c99d242ea458a14d395ac456ce02d5d03a8e..21e5b1dad3bc8d045a908d137f45e6da3515be18 |
| 6415c99 | https://github.com/nodejs/node/commit/6415c99d242ea458a14d395ac456ce02d5d03a8e |
| 21e5b1d | https://github.com/nodejs/node/commit/21e5b1dad3bc8d045a908d137f45e6da3515be18 |
|
Compare
| https://github.com/nodejs/node/compare/6415c99d242ea458a14d395ac456ce02d5d03a8e..21e5b1dad3bc8d045a908d137f45e6da3515be18 |
| February 18, 2021 15:54 | https://github.com/nodejs/node/pull/37303#event-4347543280 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Feb 18, 2021 | https://github.com/nodejs/node/pull/37303#issuecomment-781443374 |
| Please reload this page | https://github.com/nodejs/node/pull/37303 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Feb 18, 2021 | https://github.com/nodejs/node/pull/37303#issuecomment-781479305 |
| @legendecas | https://github.com/legendecas |
| https://github.com/legendecas/repro-napi-v8impl-refbase-double-free | https://github.com/legendecas/repro-napi-v8impl-refbase-double-free |
| Please reload this page | https://github.com/nodejs/node/pull/37303 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
|
Feb 18, 2021
| https://github.com/nodejs/node/pull/37303#pullrequestreview-593427156 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/37303/files/21e5b1dad3bc8d045a908d137f45e6da3515be18 |
| legendecas | https://github.com/legendecas |
| Please reload this page | https://github.com/nodejs/node/pull/37303 |
| https://github.com/nodejs/node/pull/37303#pullrequestreview-593427156 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| Please reload this page | https://github.com/nodejs/node/pull/37303 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Feb 18, 2021 | https://github.com/nodejs/node/pull/37303#issuecomment-781491318 |
| https://ci.nodejs.org/job/node-test-pull-request/36226/ | https://ci.nodejs.org/job/node-test-pull-request/36226/ |
| Please reload this page | https://github.com/nodejs/node/pull/37303 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Feb 18, 2021 | https://github.com/nodejs/node/pull/37303#issuecomment-781646103 |
| https://ci.nodejs.org/job/node-test-pull-request/36231/ | https://ci.nodejs.org/job/node-test-pull-request/36231/ |
| Please reload this page | https://github.com/nodejs/node/pull/37303 |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Feb 19, 2021
| https://github.com/nodejs/node/pull/37303#ref-commit-03806a0 |
|
| https://github.com/legendecas |
|
| https://github.com/gabrielschulhof |
| node-api: force env shutdown deferring behavior | https://github.com/nodejs/node/commit/03806a0bb2f3336bcbf3a668e156993cc2582c71 |
| 03806a0 | https://github.com/nodejs/node/commit/03806a0bb2f3336bcbf3a668e156993cc2582c71 |
| #37236 | https://github.com/nodejs/node/issues/37236 |
| #37303 | https://github.com/nodejs/node/pull/37303 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Feb 19, 2021 | https://github.com/nodejs/node/pull/37303#event-4350159143 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| February 19, 2021 04:33 | https://github.com/nodejs/node/pull/37303#event-4350159159 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Feb 19, 2021 | https://github.com/nodejs/node/pull/37303#issuecomment-781810831 |
| 03806a0 | https://github.com/nodejs/node/commit/03806a0bb2f3336bcbf3a668e156993cc2582c71 |
| Please reload this page | https://github.com/nodejs/node/pull/37303 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Feb 19, 2021
| https://github.com/nodejs/node/pull/37303#ref-issue-812249903 |
|
Handle the case where one cannot execute JavaScript
#37446
| https://github.com/nodejs/node/issues/37446 |
| targos | https://github.com/targos |
|
Feb 28, 2021
| https://github.com/nodejs/node/pull/37303#ref-commit-27816ea |
|
| https://github.com/legendecas |
|
| https://github.com/targos |
| node-api: force env shutdown deferring behavior | https://github.com/nodejs/node/commit/27816eac61ca9b242fb716ff1fbf444416cbad0e |
| 27816ea | https://github.com/nodejs/node/commit/27816eac61ca9b242fb716ff1fbf444416cbad0e |
| #37236 | https://github.com/nodejs/node/issues/37236 |
| #37303 | https://github.com/nodejs/node/pull/37303 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Mar 2, 2021
| https://github.com/nodejs/node/pull/37303#ref-pullrequest-820016292 |
|
v15.11.0 release proposal
#37569
| https://github.com/nodejs/node/pull/37569 |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Mar 6, 2021
| https://github.com/nodejs/node/pull/37303#ref-commit-db19bf4 |
|
| https://github.com/legendecas |
|
| https://github.com/gabrielschulhof |
| node-api: force env shutdown deferring behavior | https://github.com/gabrielschulhof/node/commit/db19bf4c79af3361d1d22b1684eff5f07e3dd13a |
| db19bf4 | https://github.com/gabrielschulhof/node/commit/db19bf4c79af3361d1d22b1684eff5f07e3dd13a |
| nodejs#37236 | https://github.com/nodejs/node/issues/37236 |
| nodejs#37303 | https://github.com/nodejs/node/pull/37303 |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Mar 19, 2021
| https://github.com/nodejs/node/pull/37303#ref-commit-5c2c405 |
|
| https://github.com/legendecas |
|
| https://github.com/gabrielschulhof |
| node-api: force env shutdown deferring behavior | https://github.com/gabrielschulhof/node/commit/5c2c4051e456a04b38a9ba7ae1ed167557be5617 |
| 5c2c405 | https://github.com/gabrielschulhof/node/commit/5c2c4051e456a04b38a9ba7ae1ed167557be5617 |
| nodejs#37236 | https://github.com/nodejs/node/issues/37236 |
| nodejs#37303 | https://github.com/nodejs/node/pull/37303 |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Mar 19, 2021
| https://github.com/nodejs/node/pull/37303#ref-commit-4dbe146 |
|
| https://github.com/legendecas |
|
| https://github.com/gabrielschulhof |
| node-api: force env shutdown deferring behavior | https://github.com/gabrielschulhof/node/commit/4dbe146d8b2a46f5a8b458879223d6bbc295ffc5 |
| 4dbe146 | https://github.com/gabrielschulhof/node/commit/4dbe146d8b2a46f5a8b458879223d6bbc295ffc5 |
| nodejs#37236 | https://github.com/nodejs/node/issues/37236 |
| nodejs#37303 | https://github.com/nodejs/node/pull/37303 |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Mar 26, 2021
| https://github.com/nodejs/node/pull/37303#ref-commit-b009706 |
|
| https://github.com/legendecas |
|
| https://github.com/gabrielschulhof |
| node-api: force env shutdown deferring behavior | https://github.com/gabrielschulhof/node/commit/b009706436bec2b05d51ce806d24ad9d9decb81c |
| b009706 | https://github.com/gabrielschulhof/node/commit/b009706436bec2b05d51ce806d24ad9d9decb81c |
| nodejs#37236 | https://github.com/nodejs/node/issues/37236 |
| nodejs#37303 | https://github.com/nodejs/node/pull/37303 |
| targos | https://github.com/targos |
|
Apr 24, 2021
| https://github.com/nodejs/node/pull/37303#ref-commit-82b6116 |
|
| https://github.com/legendecas |
|
| https://github.com/targos |
| node-api: force env shutdown deferring behavior | https://github.com/gabrielschulhof/node/commit/82b6116e0bedb06444c0cef22fc89a315ab88a49 |
| 82b6116 | https://github.com/gabrielschulhof/node/commit/82b6116e0bedb06444c0cef22fc89a315ab88a49 |
| nodejs#37236 | https://github.com/nodejs/node/issues/37236 |
| nodejs#37303 | https://github.com/nodejs/node/pull/37303 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
backport-open-v14.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-open-v14.x |
|
backport-open-v14.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-open-v14.x |
| Apr 25, 2021 | https://github.com/nodejs/node/pull/37303#event-4640754732 |
| targos | https://github.com/targos |
|
Apr 26, 2021
| https://github.com/nodejs/node/pull/37303#ref-commit-b5b1ad3 |
|
| https://github.com/legendecas |
|
| https://github.com/targos |
| node-api: force env shutdown deferring behavior | https://github.com/nodejs/node/commit/b5b1ad39dd33f867585e7b84077f2aadfc4c46bd |
| b5b1ad3 | https://github.com/nodejs/node/commit/b5b1ad39dd33f867585e7b84077f2aadfc4c46bd |
| #37236 | https://github.com/nodejs/node/issues/37236 |
| #37303 | https://github.com/nodejs/node/pull/37303 |
| #37802 | https://github.com/nodejs/node/pull/37802 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
May 3, 2021
| https://github.com/nodejs/node/pull/37303#ref-pullrequest-874193529 |
|
v14.17.0 proposal
#38507
| https://github.com/nodejs/node/pull/38507 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
|
Mar 27, 2022
| https://github.com/nodejs/node/pull/37303#ref-issue-1172166519 |
|
Node.js 12.x need to cherry-pick https://github.com/nodejs/node/pull/37616
#42376
| https://github.com/nodejs/node/issues/42376 |
| legendecas | https://github.com/legendecas |
|
Mar 29, 2022
| https://github.com/nodejs/node/pull/37303#ref-commit-dfefe12 |
|
| https://github.com/legendecas |
| node-api: force env shutdown deferring behavior | https://github.com/legendecas/node/commit/dfefe12551bcba5e1423d71fa31277f25ff78617 |
| dfefe12 | https://github.com/legendecas/node/commit/dfefe12551bcba5e1423d71fa31277f25ff78617 |
| nodejs#37236 | https://github.com/nodejs/node/issues/37236 |
| nodejs#37303 | https://github.com/nodejs/node/pull/37303 |
| richardlau | https://github.com/richardlau |
|
Mar 30, 2022
| https://github.com/nodejs/node/pull/37303#ref-commit-171bb66 |
|
| https://github.com/legendecas |
|
| https://github.com/richardlau |
| node-api: force env shutdown deferring behavior | https://github.com/nodejs/node/commit/171bb66ccc34611e8b3a7d67af5280cd6b2c414c |
| 171bb66 | https://github.com/nodejs/node/commit/171bb66ccc34611e8b3a7d67af5280cd6b2c414c |
| #37236 | https://github.com/nodejs/node/issues/37236 |
| #37303 | https://github.com/nodejs/node/pull/37303 |
| #42512 | https://github.com/nodejs/node/pull/42512 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Mar 30, 2022
| https://github.com/nodejs/node/pull/37303#ref-pullrequest-1186734465 |
|
v12.22.12 proposal
#42531
| https://github.com/nodejs/node/pull/42531 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37303 |
|
| https://github.com/legendecas |
|
legendecas
| https://github.com/legendecas |
|
| https://github.com/nodejs/node/pull/37303/files/21e5b1dad3bc8d045a908d137f45e6da3515be18 |
|
| https://github.com/RaisinTen |
|
RaisinTen
| https://github.com/RaisinTen |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/37303/files/6415c99d242ea458a14d395ac456ce02d5d03a8e |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
|
Crash on node api add-on finalization
| https://github.com/nodejs/node/issues/37236 |
| Please reload this page | https://github.com/nodejs/node/pull/37303 |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/RaisinTen |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mhdawson |
|
| https://github.com/legendecas |
|
| https://github.com/targos |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |