| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:23a002b4-9a6f-48d2-8367-dae1b918e026 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E080:25C52D:C82461:102F8B9:696B28B0 |
| html-safe-nonce | 9942d828f58088e627c6e64fc74f457c9acff58962ec78c81b9dad342ab08244 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDgwOjI1QzUyRDpDODI0NjE6MTAyRjhCOTo2OTZCMjhCMCIsInZpc2l0b3JfaWQiOiIyNTU1NTQ0NzU1OTQwMDQyOTI4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 0ba4439758de068d843d9905bd30704faa75e06514797013255e0bd37a52ab61 |
| hovercard-subject-tag | pull_request:50192604 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/3727/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ddbeb88aa801ebb258de7f39d972e2b97678be2b49ceea732d1626e49b2a5f46/nodejs/node/pull/3727 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ddbeb88aa801ebb258de7f39d972e2b97678be2b49ceea732d1626e49b2a5f46/nodejs/node/pull/3727 |
| og:image:alt | 20285ad changed the format of error messages throughout lib. However, the tests were not updated to reflect these changes. This commit makes those changes. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cjihrig |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/3727#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3727 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3727 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/3727 |
| Reload | https://github.com/nodejs/node/pull/3727 |
| Reload | https://github.com/nodejs/node/pull/3727 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/3727 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
691
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/3727 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/3727#issue-comment-box |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:errs | https://github.com/cjihrig/node/tree/errs |
|
test: fix tests that check error messages
| https://github.com/nodejs/node/pull/3727#top |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:errs | https://github.com/cjihrig/node/tree/errs |
|
Conversation
16
| https://github.com/nodejs/node/pull/3727 |
|
Commits
1
| https://github.com/nodejs/node/pull/3727/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/3727/checks |
|
Files changed
| https://github.com/nodejs/node/pull/3727/files |
| Please reload this page | https://github.com/nodejs/node/pull/3727 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Nov 9, 2015 | https://github.com/nodejs/node/pull/3727#issue-115989600 |
| 20285ad | https://github.com/nodejs/node/commit/20285ad17755187ece16b8a5effeaa87f5407da2 |
| Please reload this page | https://github.com/nodejs/node/pull/3727 |
|
| https://github.com/cjihrig |
| test: fix tests that check error messages | https://github.com/nodejs/node/pull/3727/commits/f730782cef49787b687a3456b98c37371c3c3a05 |
| f730782 | https://github.com/nodejs/node/pull/3727/commits/f730782cef49787b687a3456b98c37371c3c3a05 |
| 20285ad | https://github.com/cjihrig/node/commit/20285ad17755187ece16b8a5effeaa87f5407da2 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Nov 9, 2015 | https://github.com/nodejs/node/pull/3727#issuecomment-155230130 |
| @silverwind | https://github.com/silverwind |
| @micnic | https://github.com/micnic |
| Please reload this page | https://github.com/nodejs/node/pull/3727 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Nov 9, 2015 | https://github.com/nodejs/node/pull/3727#issuecomment-155232619 |
| @cjihrig | https://github.com/cjihrig |
| Please reload this page | https://github.com/nodejs/node/pull/3727 |
| silverwind | https://github.com/silverwind |
|
Nov 9, 2015
| https://github.com/nodejs/node/pull/3727#discussion-diff-44350690 |
| View reviewed changes
| https://github.com/nodejs/node/pull/3727/files/f730782cef49787b687a3456b98c37371c3c3a05#diff-092f2be30e312ebf7517f3d5f08b4c8d38a4bea3449ab15eb87f408a8f301dff |
| lib/path.js | https://github.com/nodejs/node/pull/3727/files#diff-092f2be30e312ebf7517f3d5f08b4c8d38a4bea3449ab15eb87f408a8f301dff |
| silverwind | https://github.com/silverwind |
| Nov 9, 2015 | https://github.com/nodejs/node/pull/3727#discussion_r44350690 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/3727 |
| cjihrig | https://github.com/cjihrig |
| Nov 10, 2015 | https://github.com/nodejs/node/pull/3727#discussion_r44356822 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/3727 |
| silverwind | https://github.com/silverwind |
| Nov 12, 2015 | https://github.com/nodejs/node/pull/3727#discussion_r44646951 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @micnic | https://github.com/micnic |
| Please reload this page | https://github.com/nodejs/node/pull/3727 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Nov 9, 2015 | https://github.com/nodejs/node/pull/3727#event-459486097 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| Nov 10, 2015 | https://github.com/nodejs/node/pull/3727#issuecomment-155261898 |
| Please reload this page | https://github.com/nodejs/node/pull/3727 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Nov 10, 2015 | https://github.com/nodejs/node/pull/3727#issuecomment-155262689 |
| Please reload this page | https://github.com/nodejs/node/pull/3727 |
| thefourtheye | https://github.com/thefourtheye |
|
Nov 10, 2015
| https://github.com/nodejs/node/pull/3727#discussion-diff-44367535 |
| View reviewed changes
| https://github.com/nodejs/node/pull/3727/files/f730782cef49787b687a3456b98c37371c3c3a05#diff-9b302d1821563473bc03304aded13441bd1370dca748efe9825b3af0deb07b05 |
| test/parallel/test-buffer.js | https://github.com/nodejs/node/pull/3727/files#diff-9b302d1821563473bc03304aded13441bd1370dca748efe9825b3af0deb07b05 |
| thefourtheye | https://github.com/thefourtheye |
| Nov 10, 2015 | https://github.com/nodejs/node/pull/3727#discussion_r44367535 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/3727 |
| silverwind | https://github.com/silverwind |
| Nov 10, 2015 | https://github.com/nodejs/node/pull/3727#discussion_r44372438 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/3727 |
| thefourtheye | https://github.com/thefourtheye |
| Nov 10, 2015 | https://github.com/nodejs/node/pull/3727#discussion_r44372509 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/3727 |
| silverwind | https://github.com/silverwind |
| Nov 10, 2015 | https://github.com/nodejs/node/pull/3727#discussion_r44380689 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/3727 |
| cjihrig | https://github.com/cjihrig |
| Nov 10, 2015 | https://github.com/nodejs/node/pull/3727#discussion_r44421525 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/3727 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Nov 10, 2015 | https://github.com/nodejs/node/pull/3727#event-459706303 |
| cjihrig | https://github.com/cjihrig |
|
Nov 10, 2015
| https://github.com/nodejs/node/pull/3727#ref-commit-2c33819 |
|
| https://github.com/cjihrig |
|
| https://github.com/silverwind |
| test: fix tests that check error messages | https://github.com/nodejs/node/commit/2c33819370e50cd1c1eae43d2fd88bdc5aca1905 |
| 2c33819 | https://github.com/nodejs/node/commit/2c33819370e50cd1c1eae43d2fd88bdc5aca1905 |
| 20285ad | https://github.com/nodejs/node/commit/20285ad17755187ece16b8a5effeaa87f5407da2 |
| #3727 | https://github.com/nodejs/node/pull/3727 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Nov 10, 2015 | https://github.com/nodejs/node/pull/3727#issuecomment-155358700 |
| 2c33819 | https://github.com/nodejs/node/commit/2c33819370e50cd1c1eae43d2fd88bdc5aca1905 |
| Please reload this page | https://github.com/nodejs/node/pull/3727 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Nov 10, 2015 | https://github.com/nodejs/node/pull/3727#event-459836396 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| November 10, 2015 15:44 | https://github.com/nodejs/node/pull/3727#event-460223825 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Nov 10, 2015 | https://github.com/nodejs/node/pull/3727#issuecomment-155465627 |
| @cjihrig | https://github.com/cjihrig |
| Please reload this page | https://github.com/nodejs/node/pull/3727 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Nov 10, 2015 | https://github.com/nodejs/node/pull/3727#issuecomment-155466541 |
| #3374 | https://github.com/nodejs/node/pull/3374 |
| Please reload this page | https://github.com/nodejs/node/pull/3727 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
| Nov 12, 2015 | https://github.com/nodejs/node/pull/3727#event-462273093 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Nov 12, 2015 | https://github.com/nodejs/node/pull/3727#issuecomment-156058915 |
| #3374 | https://github.com/nodejs/node/pull/3374 |
| Please reload this page | https://github.com/nodejs/node/pull/3727 |
|
Consistent error messages in all modules
#3374
| https://github.com/nodejs/node/pull/3374 |
|
Rediscuss if error message changes are semver-major
#3776
| https://github.com/nodejs/node/issues/3776 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Nov 26, 2015
| https://github.com/nodejs/node/pull/3727#ref-pullrequest-118948704 |
|
deps: upgrade npm to 3.5.0
#4032
| https://github.com/nodejs/node/pull/4032 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Dec 15, 2015
| https://github.com/nodejs/node/pull/3727#ref-pullrequest-122147191 |
|
v5.3.0 Release Proposal (Stable)
#4281
| https://github.com/nodejs/node/pull/4281 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Mar 17, 2016
| https://github.com/nodejs/node/pull/3727#ref-issue-141699407 |
|
Planning for v6
#5766
| https://github.com/nodejs/node/issues/5766 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3727 |
|
| https://github.com/silverwind |
|
silverwind
| https://github.com/silverwind |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/3727 |
|
| https://github.com/cjihrig |
|
| https://github.com/Fishrock123 |
|
| https://github.com/silverwind |
|
| https://github.com/jbergstroem |
|
| https://github.com/jasnell |
|
| https://github.com/thefourtheye |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |