René's URL Explorer Experiment


Title: crypto: deprecate KeyObject.from but support CryptoKeys in create*Key by tniessen · Pull Request #37240 · nodejs/node · GitHub

Open Graph Title: crypto: deprecate KeyObject.from but support CryptoKeys in create*Key by tniessen · Pull Request #37240 · nodejs/node

X Title: crypto: deprecate KeyObject.from but support CryptoKeys in create*Key by tniessen · Pull Request #37240 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This renames KeyObject.from to KeyObject.fromCryptoKey. Currently, it only accepts CryptoKey instances as inputs, and I don't see that changing any time soon. This is mainly for API safety. Key...

X Description: This renames KeyObject.from to KeyObject.fromCryptoKey. Currently, it only accepts CryptoKey instances as inputs, and I don't see that changing any time soon. This is mainly for API safety....

Opengraph URL: https://github.com/nodejs/node/pull/37240

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:63f02cc8-9847-9960-dc78-44186787ee93
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC50C:DCE25:3B0C1F:549E65:6A4CA0F5
html-safe-noncef91bce49dbf061e1ff9b2b1da390fdd82872c1d70f0173a4f08e8a22bdd991d9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTBDOkRDRTI1OjNCMEMxRjo1NDlFNjU6NkE0Q0EwRjUiLCJ2aXNpdG9yX2lkIjoiMjA4MjkzNDUxMzI3NzM3ODgwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1f311719697b3d5b1e18f5515c74eb2eb3fb31e82124d645147330008308ba54
hovercard-subject-tagpull_request:568513665
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/37240/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b7e99bc16d425bfdfaf1b1bee7c18499c5fcf2d22ff8ab2a67f31786d24d0617/nodejs/node/pull/37240
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b7e99bc16d425bfdfaf1b1bee7c18499c5fcf2d22ff8ab2a67f31786d24d0617/nodejs/node/pull/37240
og:image:altThis renames KeyObject.from to KeyObject.fromCryptoKey. Currently, it only accepts CryptoKey instances as inputs, and I don't see that changing any time soon. This is mainly for API safety. Key...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametniessen
hostnamegithub.com
expected-hostnamegithub.com
None3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseae90d426644ca15e89bacceb72e51f4e9dbf85f7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/37240#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37240
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37240
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/37240
Reloadhttps://github.com/nodejs/node/pull/37240
Reloadhttps://github.com/nodejs/node/pull/37240
Please reload this pagehttps://github.com/nodejs/node/pull/37240
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/37240
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
tniessenhttps://github.com/tniessen
nodejs:mainhttps://github.com/nodejs/node/tree/main
tniessen:crypto-rename-keyobject-fromhttps://github.com/tniessen/node/tree/crypto-rename-keyobject-from
Conversationhttps://github.com/nodejs/node/pull/37240
Commits6 (6)https://github.com/nodejs/node/pull/37240/commits
Checkshttps://github.com/nodejs/node/pull/37240/checks
Files changedhttps://github.com/nodejs/node/pull/37240/files
crypto: deprecate KeyObject.from but support CryptoKeys in create*Keyhttps://github.com/nodejs/node/pull/37240#top
tniessenhttps://github.com/tniessen
nodejs:mainhttps://github.com/nodejs/node/tree/main
tniessen:crypto-rename-keyobject-fromhttps://github.com/tniessen/node/tree/crypto-rename-keyobject-from
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Feb 5, 2021https://github.com/nodejs/node/pull/37240#issue-802356786
Please reload this pagehttps://github.com/nodejs/node/pull/37240
#37198https://github.com/nodejs/node/pull/37198
Please reload this pagehttps://github.com/nodejs/node/pull/37240
https://github.com/tniessen
crypto: rename KeyObject.from to fromCryptoKeyhttps://github.com/nodejs/node/pull/37240/commits/b7c31b34dac5f64ab2af66bb8ffaea4f14452566
b7c31b3https://github.com/nodejs/node/pull/37240/commits/b7c31b34dac5f64ab2af66bb8ffaea4f14452566
https://github.com/tniessen
tniessenhttps://github.com/tniessen
jasnellhttps://github.com/jasnell
panvahttps://github.com/panva
February 5, 2021 17:48https://github.com/nodejs/node/pull/37240#event-4297285547
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Feb 5, 2021https://github.com/nodejs/node/pull/37240#event-4297285784
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Feb 5, 2021 https://github.com/nodejs/node/pull/37240#ref-pullrequest-800177209
doc: mark Certificate methods as static, add missing KeyObject.from #37198 https://github.com/nodejs/node/pull/37198
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Feb 5, 2021https://github.com/nodejs/node/pull/37240#issuecomment-774187749
#37198 (comment)https://github.com/nodejs/node/pull/37198#issuecomment-774185507
Please reload this pagehttps://github.com/nodejs/node/pull/37240
https://github.com/panva
panvahttps://github.com/panva
Feb 5, 2021 https://github.com/nodejs/node/pull/37240#pullrequestreview-584586109
View reviewed changes https://github.com/nodejs/node/pull/37240/files/b7c31b34dac5f64ab2af66bb8ffaea4f14452566
panvahttps://github.com/panva
Please reload this pagehttps://github.com/nodejs/node/pull/37240
https://github.com/nodejs/node/pull/37240#pullrequestreview-584586109
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#37198https://github.com/nodejs/node/pull/37198
Please reload this pagehttps://github.com/nodejs/node/pull/37240
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Feb 5, 2021https://github.com/nodejs/node/pull/37240#issuecomment-774214694
#37198https://github.com/nodejs/node/pull/37198
@panvahttps://github.com/panva
#37198https://github.com/nodejs/node/pull/37198
Please reload this pagehttps://github.com/nodejs/node/pull/37240
https://github.com/panva
panvahttps://github.com/panva
Feb 5, 2021 https://github.com/nodejs/node/pull/37240#pullrequestreview-584676678
View reviewed changes https://github.com/nodejs/node/pull/37240/files/b7c31b34dac5f64ab2af66bb8ffaea4f14452566
doc/api/deprecations.mdhttps://github.com/nodejs/node/pull/37240/files/b7c31b34dac5f64ab2af66bb8ffaea4f14452566#diff-b7c42d4dc97df183538f07f68a1f6ee54068ee8860cfa053ab141e64f290af87
Please reload this pagehttps://github.com/nodejs/node/pull/37240
https://github.com/tniessen
https://github.com/panva
Update doc/api/deprecations.mdhttps://github.com/nodejs/node/pull/37240/commits/1d12a20e89af82bb59d9ca2833a2ce99bfd5ab9c
1d12a20https://github.com/nodejs/node/pull/37240/commits/1d12a20e89af82bb59d9ca2833a2ce99bfd5ab9c
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Feb 6, 2021 https://github.com/nodejs/node/pull/37240#pullrequestreview-584896715
View reviewed changes https://github.com/nodejs/node/pull/37240/files/1d12a20e89af82bb59d9ca2833a2ce99bfd5ab9c
jasnellhttps://github.com/jasnell
https://github.com/nodejs/node/pull/37240#pullrequestreview-584896715
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/37240
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Feb 6, 2021https://github.com/nodejs/node/pull/37240#issuecomment-774505909
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/37240
https://github.com/panva
panvahttps://github.com/panva
Feb 6, 2021https://github.com/nodejs/node/pull/37240#issuecomment-774507113
Please reload this pagehttps://github.com/nodejs/node/pull/37240
Please reload this pagehttps://github.com/nodejs/node/pull/37240
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Feb 6, 2021https://github.com/nodejs/node/pull/37240#issuecomment-774507754
#37240 (comment)https://github.com/nodejs/node/pull/37240#issuecomment-774505909
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/37240
https://github.com/panva
panvahttps://github.com/panva
Feb 6, 2021https://github.com/nodejs/node/pull/37240#issuecomment-774509752
Please reload this pagehttps://github.com/nodejs/node/pull/37240
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Feb 6, 2021https://github.com/nodejs/node/pull/37240#issuecomment-774509868
Please reload this pagehttps://github.com/nodejs/node/pull/37240
tniessenhttps://github.com/tniessen
February 6, 2021 18:50https://github.com/nodejs/node/pull/37240#commits-pushed-d632cd6
https://github.com/tniessen
crypto: allow CryptoKeys in create*Keyhttps://github.com/nodejs/node/pull/37240/commits/d632cd6289d363e5b48040cf59c388144faae972
d632cd6https://github.com/nodejs/node/pull/37240/commits/d632cd6289d363e5b48040cf59c388144faae972
https://github.com/tniessen
fixup! crypto: rename KeyObject.from to fromCryptoKeyhttps://github.com/nodejs/node/pull/37240/commits/6a7a614696e1eaf0a36be6777d49d186a7fffa14
6a7a614https://github.com/nodejs/node/pull/37240/commits/6a7a614696e1eaf0a36be6777d49d186a7fffa14
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Feb 6, 2021https://github.com/nodejs/node/pull/37240#event-4299350791
https://github.com/tniessen
fixup! crypto: allow CryptoKeys in create*Keyhttps://github.com/nodejs/node/pull/37240/commits/01555406d61ebec838aa446eac1345c5da934c25
0155540https://github.com/nodejs/node/pull/37240/commits/01555406d61ebec838aa446eac1345c5da934c25
https://github.com/tniessen
tniessenhttps://github.com/tniessen
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Feb 6, 2021https://github.com/nodejs/node/pull/37240#event-4299450699
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Feb 6, 2021https://github.com/nodejs/node/pull/37240#issuecomment-774528986
Please reload this pagehttps://github.com/nodejs/node/pull/37240
https://github.com/tniessen
fixup! crypto: allow CryptoKeys in create*Keyhttps://github.com/nodejs/node/pull/37240/commits/27a268f660bbdf002f8144a46bb4c0562910c426
27a268fhttps://github.com/nodejs/node/pull/37240/commits/27a268f660bbdf002f8144a46bb4c0562910c426
https://github.com/panva
panvahttps://github.com/panva
Feb 6, 2021 https://github.com/nodejs/node/pull/37240#ref-pullrequest-802798993
crypto: support JWK objects in create(Public|Private)Key #37254 https://github.com/nodejs/node/pull/37254
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
force-pushedhttps://github.com/nodejs/node/compare/dc5a5da4f82eba4b2e5e09a1ac827e75eddc6b04..8e46568b1e12fe00581b1292bd6c2b01373f17bd
dc5a5dahttps://github.com/nodejs/node/commit/dc5a5da4f82eba4b2e5e09a1ac827e75eddc6b04
8e46568https://github.com/nodejs/node/commit/8e46568b1e12fe00581b1292bd6c2b01373f17bd
Compare https://github.com/nodejs/node/compare/dc5a5da4f82eba4b2e5e09a1ac827e75eddc6b04..8e46568b1e12fe00581b1292bd6c2b01373f17bd
March 29, 2021 21:33https://github.com/nodejs/node/pull/37240#event-4523995654
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/2d76238f9184c9009bfa395848a120ac3e5b98e5..ca3ed363ffefa4819c1414aff7ffca34b53a7b95
2d76238https://github.com/nodejs/node/commit/2d76238f9184c9009bfa395848a120ac3e5b98e5
ca3ed36https://github.com/nodejs/node/commit/ca3ed363ffefa4819c1414aff7ffca34b53a7b95
Compare https://github.com/nodejs/node/compare/2d76238f9184c9009bfa395848a120ac3e5b98e5..ca3ed363ffefa4819c1414aff7ffca34b53a7b95
November 12, 2022 01:49https://github.com/nodejs/node/pull/37240#event-7795751617
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Apr 18, 2024https://github.com/nodejs/node/pull/37240#event-12523953722
https://github.com/panva
panvahttps://github.com/panva
Oct 6, 2024 https://github.com/nodejs/node/pull/37240#ref-issue-2568649454
Accepting CryptoKey in node:crypto APIs #55293 https://github.com/nodejs/node/issues/55293
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37240
https://github.com/panva
panva https://github.com/panva
https://github.com/nodejs/node/pull/37240/files/b7c31b34dac5f64ab2af66bb8ffaea4f14452566
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/37240/files/1d12a20e89af82bb59d9ca2833a2ce99bfd5ab9c
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Please reload this pagehttps://github.com/nodejs/node/pull/37240
https://github.com/tniessen
https://github.com/panva
https://github.com/jasnell
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.